[GitHub] [tez] ayushtkn commented on a diff in pull request #304: TEZ-4505: Create counters about time intervals spent in certain states in StateMachineTez

2023-09-14 Thread via GitHub
ayushtkn commented on code in PR #304: URL: https://github.com/apache/tez/pull/304#discussion_r1325767649 ## tez-dag/src/main/java/org/apache/tez/state/StateMachineTez.java: ## @@ -34,6 +38,10 @@ public class StateMachineTez, EVENTTYPE extends Enum realStatemachine; +

[GitHub] [tez] abstractdog commented on pull request #307: TEZ-4506: Report the node of a task attempt failure better.

2023-09-01 Thread via GitHub
abstractdog commented on PR #307: URL: https://github.com/apache/tez/pull/307#issuecomment-1702392678 thanks for the patch @ayushtkn, basically, it looks good to me can you paste here how you tested this and what was the diagnostic message like with the patch? -- This is an automated

[GitHub] [tez] ayushtkn commented on pull request #307: TEZ-4506: Report the node of a task attempt failure better.

2023-09-01 Thread via GitHub
ayushtkn commented on PR #307: URL: https://github.com/apache/tez/pull/307#issuecomment-1702422261 @abstractdog I tried the UT's present in the code. The error message looked like ``` Node: ayushsaxena/192.168.29.11 : Error while running task ( failure ) :

[GitHub] [tez] abstractdog merged pull request #307: TEZ-4506: Report the node of a task attempt failure better.

2023-09-01 Thread via GitHub
abstractdog merged PR #307: URL: https://github.com/apache/tez/pull/307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tez] tez-yetus commented on pull request #307: TEZ-4506: Report the node of a task attempt failure better.

2023-08-30 Thread via GitHub
tez-yetus commented on PR #307: URL: https://github.com/apache/tez/pull/307#issuecomment-1699338926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode

[GitHub] [tez] ayushtkn opened a new pull request, #307: TEZ-4506: Report the node of a task attempt failure better.

2023-08-30 Thread via GitHub
ayushtkn opened a new pull request, #307: URL: https://github.com/apache/tez/pull/307 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tez] abstractdog commented on a diff in pull request #304: TEZ-4505: Create counters about time intervals spent in certain states in StateMachineTez

2023-09-14 Thread via GitHub
abstractdog commented on code in PR #304: URL: https://github.com/apache/tez/pull/304#discussion_r1326047748 ## tez-api/src/main/java/org/apache/tez/common/counters/TaskAttemptCounter.java: ## @@ -0,0 +1,22 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [tez] zabetak opened a new pull request, #308: TEZ-4503: Warn about large conf properties in payload

2023-09-14 Thread via GitHub
zabetak opened a new pull request, #308: URL: https://github.com/apache/tez/pull/308 The changes were tested by running `mvn test -Dtest=TestTezUtils` and manually inspecting the output under: `tez-common/target/surefire-reports/org.apache.tez.common.TestTezUtils-output.txt `. ```

[GitHub] [tez] tez-yetus commented on pull request #308: TEZ-4503: Warn about large conf properties in payload

2023-09-14 Thread via GitHub
tez-yetus commented on PR #308: URL: https://github.com/apache/tez/pull/308#issuecomment-1719663835 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s | Docker mode

[GitHub] [tez] tez-yetus commented on pull request #308: TEZ-4503: Warn about large conf properties in payload

2023-09-14 Thread via GitHub
tez-yetus commented on PR #308: URL: https://github.com/apache/tez/pull/308#issuecomment-1719663833 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 22m 56s | Docker mode

Re: [PR] TEZ-4378: tez-dist: org.checkerframework.dataflow is included with GNU GPLv2 license [tez]

2023-10-16 Thread via GitHub
abstractdog closed pull request #178: TEZ-4378: tez-dist: org.checkerframework.dataflow is included with GNU GPLv2 license URL: https://github.com/apache/tez/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] TEZ-4378: tez-dist: org.checkerframework.dataflow is included with GNU GPLv2 license [tez]

2023-10-16 Thread via GitHub
abstractdog commented on PR #178: URL: https://github.com/apache/tez/pull/178#issuecomment-1764575095 > We have upgraded guava: https://issues.apache.org/jira/browse/TEZ-4504 and in the latest guava version post 30+ I believe it is MIT licensed, So, we are sorted.. > > I think we

Re: [PR] TEZ-4503: Warn about large conf properties in payload [tez]

2023-10-17 Thread via GitHub
abstractdog commented on code in PR #308: URL: https://github.com/apache/tez/pull/308#discussion_r1361625385 ## tez-api/src/main/java/org/apache/tez/dag/api/TezConfiguration.java: ## @@ -1580,6 +1580,26 @@ public TezConfiguration(boolean loadDefaults) { TEZ_PREFIX +

Re: [PR] TEZ-4503: Warn about large conf properties in payload [tez]

2023-10-17 Thread via GitHub
abstractdog commented on code in PR #308: URL: https://github.com/apache/tez/pull/308#discussion_r1361640631 ## tez-api/src/main/java/org/apache/tez/common/TezUtils.java: ## @@ -51,6 +57,14 @@ public final class TezUtils { private static final Logger LOG =

Re: [PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-15 Thread via GitHub
ayushtkn commented on PR #313: URL: https://github.com/apache/tez/pull/313#issuecomment-1763397877 Thanx @abstractdog I added some tests. Checkstyle is kind of unavoidable, getting rid of that is overkill in the prod code for testing IMO -- This is an automated message from the

Re: [PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-15 Thread via GitHub
abstractdog commented on PR #313: URL: https://github.com/apache/tez/pull/313#issuecomment-1763370893 thanks for this patch! I can see that MAPREDUCE-7148 has a unit test for the corresponding change, would you consider adopting it to tez also? -- This is an automated message from the

Re: [PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-25 Thread via GitHub
ayushtkn commented on code in PR #314: URL: https://github.com/apache/tez/pull/314#discussion_r1371696551 ## tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TaskReporter.java: ## @@ -262,6 +263,13 @@ private synchronized ResponseWrapper heartbeat(Collection

Re: [PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-27 Thread via GitHub
abstractdog merged PR #314: URL: https://github.com/apache/tez/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TEZ-4503: Warn about large conf properties in payload [tez]

2023-10-27 Thread via GitHub
zabetak commented on code in PR #308: URL: https://github.com/apache/tez/pull/308#discussion_r1374667892 ## tez-api/src/main/java/org/apache/tez/dag/api/TezConfiguration.java: ## @@ -1580,6 +1580,26 @@ public TezConfiguration(boolean loadDefaults) { TEZ_PREFIX +

Re: [PR] TEZ-4503: Warn about large conf properties in payload [tez]

2023-10-27 Thread via GitHub
zabetak commented on code in PR #308: URL: https://github.com/apache/tez/pull/308#discussion_r1374670968 ## tez-api/src/main/java/org/apache/tez/common/TezUtils.java: ## @@ -51,6 +57,14 @@ public final class TezUtils { private static final Logger LOG =

Re: [PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-25 Thread via GitHub
rbalamohan commented on PR #314: URL: https://github.com/apache/tez/pull/314#issuecomment-1780333971 Minor: change TaskLimitException to some other name, which can represent that limit is related to file bytes written. Rest LGTM. + 1. -- This is an automated message from the

Re: [PR] TEZ-4503: Warn about large conf properties in payload [tez]

2023-10-27 Thread via GitHub
tez-yetus commented on PR #308: URL: https://github.com/apache/tez/pull/308#issuecomment-1783278499 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 24m 52s | Docker mode

Re: [PR] TEZ-4501: Fix TestLocalMode timeouts [tez]

2023-11-03 Thread via GitHub
ayushtkn commented on code in PR #300: URL: https://github.com/apache/tez/pull/300#discussion_r1382298623 ## tez-common/src/main/java/org/apache/tez/common/AsyncDispatcher.java: ## @@ -364,10 +369,20 @@ public void handle(Event event) { } try {

Re: [PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-24 Thread via GitHub
rbalamohan commented on code in PR #314: URL: https://github.com/apache/tez/pull/314#discussion_r1370987305 ## tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TaskReporter.java: ## @@ -262,6 +263,13 @@ private synchronized ResponseWrapper heartbeat(Collection

Re: [PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-24 Thread via GitHub
tez-yetus commented on PR #314: URL: https://github.com/apache/tez/pull/314#issuecomment-1778526455 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker mode

Re: [PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-26 Thread via GitHub
tez-yetus commented on PR #314: URL: https://github.com/apache/tez/pull/314#issuecomment-1781774109 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker mode

Re: [PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-26 Thread via GitHub
tez-yetus commented on PR #314: URL: https://github.com/apache/tez/pull/314#issuecomment-1781825283 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker mode

Re: [PR] TEZ-4292: Upgrade to Yetus 0.13 [tez]

2023-10-30 Thread via GitHub
abstractdog commented on PR #113: URL: https://github.com/apache/tez/pull/113#issuecomment-1785652416 > We have `0.14.1` now, maybe we can chase that? yes I think so as far as I remember, precommit picks up the Jenkinsfile from the PR, so we can test this more or less flawlessly

[GitHub] [tez] zabetak commented on pull request #308: TEZ-4503: Warn about large conf properties in payload

2023-09-18 Thread via GitHub
zabetak commented on PR #308: URL: https://github.com/apache/tez/pull/308#issuecomment-1723559067 @abstractdog Can you please have a look in this PR when you get the chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tez] tez-yetus commented on pull request #309: Reduce Some FileSystem Calls.

2023-09-28 Thread via GitHub
tez-yetus commented on PR #309: URL: https://github.com/apache/tez/pull/309#issuecomment-1738821587 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 19m 12s | Docker mode

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-03 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1343574149 ## tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java: ## @@ -741,12 +743,10 @@ public DAGRecoveryData parseRecoveryData() throws IOException {

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-03 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1343574149 ## tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java: ## @@ -741,12 +743,10 @@ public DAGRecoveryData parseRecoveryData() throws IOException {

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-03 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1343574149 ## tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java: ## @@ -741,12 +743,10 @@ public DAGRecoveryData parseRecoveryData() throws IOException {

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342689615 ## tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java: ## @@ -118,34 +121,28 @@ @Private public final class TezClientUtils { - private static Logger

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342724994 ## tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java: ## @@ -336,8 +328,13 @@ public static FileSystem ensureStagingDirExists(Configuration conf,

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342689615 ## tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java: ## @@ -118,34 +121,28 @@ @Private public final class TezClientUtils { - private static Logger

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342728602 ## tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java: ## @@ -741,12 +743,10 @@ public DAGRecoveryData parseRecoveryData() throws IOException {

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342735956 ## tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java: ## @@ -659,11 +661,11 @@ public DAGRecoveryData parseRecoveryData() throws IOException { List

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
abstractdog commented on PR #309: URL: https://github.com/apache/tez/pull/309#issuecomment-1743079601 thanks for the patch @ayushtkn , left some comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342735956 ## tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java: ## @@ -659,11 +661,11 @@ public DAGRecoveryData parseRecoveryData() throws IOException { List

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
abstractdog commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342717112 ## tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java: ## @@ -233,15 +230,11 @@ private static boolean addLocalResources(Configuration conf, }

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-03 Thread via GitHub
tez-yetus commented on PR #309: URL: https://github.com/apache/tez/pull/309#issuecomment-1745172460 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 14m 53s | Docker mode

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-03 Thread via GitHub
abstractdog merged PR #309: URL: https://github.com/apache/tez/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] TEZ-4517: Upgrade commons-collection4 to 4.4. [tez]

2023-10-04 Thread via GitHub
ayushtkn opened a new pull request, #311: URL: https://github.com/apache/tez/pull/311 [Details for Why?](https://devhub.checkmarx.com/cve-details/Cx78f40514-81ff/?utm_source=jetbrains_medium=referral_campaign=idea) -- This is an automated message from the Apache Git Service. To respond

[PR] TEZ-4516: Fix log lines with incorrect placeholders. [tez]

2023-10-04 Thread via GitHub
ayushtkn opened a new pull request, #310: URL: https://github.com/apache/tez/pull/310 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TEZ-4516: Fix log lines with incorrect placeholders. [tez]

2023-10-04 Thread via GitHub
tez-yetus commented on PR #310: URL: https://github.com/apache/tez/pull/310#issuecomment-1746298596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 14m 51s | Docker mode

Re: [PR] TEZ-4516: Fix log lines with incorrect placeholders. [tez]

2023-10-04 Thread via GitHub
tez-yetus commented on PR #310: URL: https://github.com/apache/tez/pull/310#issuecomment-1746329207 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 26m 8s | Docker mode

Re: [PR] TEZ-4517: Upgrade commons-collection4 to 4.4. [tez]

2023-10-04 Thread via GitHub
tez-yetus commented on PR #311: URL: https://github.com/apache/tez/pull/311#issuecomment-1746398848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker mode

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
ayushtkn commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342865982 ## tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java: ## @@ -741,12 +743,10 @@ public DAGRecoveryData parseRecoveryData() throws IOException {

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
ayushtkn commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342874429 ## tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java: ## @@ -336,8 +328,13 @@ public static FileSystem ensureStagingDirExists(Configuration conf,

[GitHub] [tez] tez-yetus commented on pull request #309: TEZ-4514: Reduce Some FileSystem Calls.

2023-09-28 Thread via GitHub
tez-yetus commented on PR #309: URL: https://github.com/apache/tez/pull/309#issuecomment-1738846881 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 23m 40s | Docker mode

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
ayushtkn commented on code in PR #309: URL: https://github.com/apache/tez/pull/309#discussion_r1342880078 ## tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java: ## @@ -233,15 +230,11 @@ private static boolean addLocalResources(Configuration conf, } else {

Re: [PR] TEZ-4514: Reduce Some FileSystem Calls. [tez]

2023-10-02 Thread via GitHub
tez-yetus commented on PR #309: URL: https://github.com/apache/tez/pull/309#issuecomment-1743342776 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker mode

[PR] TEZ-4518: Added capability to limit number of spill files being generated [tez]

2023-10-08 Thread via GitHub
mudit1289 opened a new pull request, #312: URL: https://github.com/apache/tez/pull/312 ASF Jira: https://issues.apache.org/jira/browse/TEZ-4518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] TEZ-4518: Added capability to limit number of spill files being generated [tez]

2023-10-08 Thread via GitHub
tez-yetus commented on PR #312: URL: https://github.com/apache/tez/pull/312#issuecomment-1752130440 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s | Docker mode

Re: [PR] TEZ-4518: Added capability to limit number of spill files being generated [tez]

2023-10-08 Thread via GitHub
tez-yetus commented on PR #312: URL: https://github.com/apache/tez/pull/312#issuecomment-1752102362 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s | Docker mode

Re: [PR] TEZ-4333: Debug artifacts can include DAG plan in json format [tez]

2023-10-06 Thread via GitHub
ayushtkn commented on code in PR #149: URL: https://github.com/apache/tez/pull/149#discussion_r1349285875 ## tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java: ## @@ -1056,6 +1057,21 @@ private void writePBTextFile(DAG dag) { } } + private void

Re: [PR] TEZ-4518: Added capability to limit number of spill files being generated [tez]

2023-10-11 Thread via GitHub
tez-yetus commented on PR #312: URL: https://github.com/apache/tez/pull/312#issuecomment-1757347856 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docker mode

Re: [PR] TEZ-4518: Added capability to limit number of spill files being generated [tez]

2023-10-14 Thread via GitHub
tez-yetus commented on PR #312: URL: https://github.com/apache/tez/pull/312#issuecomment-1762741464 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 28m 28s | Docker mode

Re: [PR] TEZ-4518: Added capability to limit number of spill files being generated [tez]

2023-10-14 Thread via GitHub
tez-yetus commented on PR #312: URL: https://github.com/apache/tez/pull/312#issuecomment-1762782544 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docker mode

Re: [PR] TEZ-4518: Added capability to limit number of spill files being generated [tez]

2023-10-14 Thread via GitHub
mudit1289 commented on PR #312: URL: https://github.com/apache/tez/pull/312#issuecomment-1762702794 @abstractdog @ayushtkn can you please review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-16 Thread via GitHub
abstractdog commented on code in PR #313: URL: https://github.com/apache/tez/pull/313#discussion_r1360241721 ## tez-runtime-internals/src/test/java/org/apache/tez/runtime/task/TestTaskExecution2.java: ## @@ -653,6 +657,40 @@ public void testKilledAfterComplete() throws

Re: [PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-16 Thread via GitHub
abstractdog merged PR #313: URL: https://github.com/apache/tez/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-16 Thread via GitHub
abstractdog commented on PR #313: URL: https://github.com/apache/tez/pull/313#issuecomment-1763905034 LGTM, only a typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-16 Thread via GitHub
tez-yetus commented on PR #313: URL: https://github.com/apache/tez/pull/313#issuecomment-1763950612 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker mode

Re: [PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-15 Thread via GitHub
tez-yetus commented on PR #313: URL: https://github.com/apache/tez/pull/313#issuecomment-1763385075 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker mode

Re: [PR] TEZ-4517: Upgrade commons-collection4 to 4.4. [tez]

2023-10-04 Thread via GitHub
abstractdog merged PR #311: URL: https://github.com/apache/tez/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TEZ-4516: Fix log lines with incorrect placeholders. [tez]

2023-10-04 Thread via GitHub
abstractdog merged PR #310: URL: https://github.com/apache/tez/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-23 Thread via GitHub
tez-yetus commented on PR #314: URL: https://github.com/apache/tez/pull/314#issuecomment-1776474459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 17m 23s | Docker mode

Re: [PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-24 Thread via GitHub
tez-yetus commented on PR #314: URL: https://github.com/apache/tez/pull/314#issuecomment-1776998580 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker mode

[PR] TEZ-3821: Ability to fail fast tasks that write too much to local disk. [tez]

2023-10-23 Thread via GitHub
ayushtkn opened a new pull request, #314: URL: https://github.com/apache/tez/pull/314 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-14 Thread via GitHub
ayushtkn opened a new pull request, #313: URL: https://github.com/apache/tez/pull/313 Tested on Hive. **Without Patch** ``` -- VERTICES MODESTATUS TOTAL COMPLETED

Re: [PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-14 Thread via GitHub
ayushtkn commented on PR #313: URL: https://github.com/apache/tez/pull/313#issuecomment-1763193636 Added the entire log output on the ticket: [With-Patch-Output](https://issues.apache.org/jira/secure/attachment/13063558/With-Patch-Output.rtf)

Re: [PR] TEZ-4110: Make Tez fail fast when DFS quota is exceeded. [tez]

2023-10-14 Thread via GitHub
tez-yetus commented on PR #313: URL: https://github.com/apache/tez/pull/313#issuecomment-1763199689 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 14m 6s | Docker mode

Re: [PR] TEZ-4518: Added capability to limit number of spill files being generated [tez]

2023-10-11 Thread via GitHub
tez-yetus commented on PR #312: URL: https://github.com/apache/tez/pull/312#issuecomment-1757783048 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s | Docker mode

[GitHub] [tez] tez-yetus commented on pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-22 Thread via GitHub
tez-yetus commented on PR #305: URL: https://github.com/apache/tez/pull/305#issuecomment-1688616272 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 25m 23s | Docker mode

[GitHub] [tez] tez-yetus commented on pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-22 Thread via GitHub
tez-yetus commented on PR #305: URL: https://github.com/apache/tez/pull/305#issuecomment-1688618723 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 25m 57s | Docker mode

[GitHub] [tez] tez-yetus commented on pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-22 Thread via GitHub
tez-yetus commented on PR #305: URL: https://github.com/apache/tez/pull/305#issuecomment-1688727330 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode

[GitHub] [tez] tez-yetus commented on pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-22 Thread via GitHub
tez-yetus commented on PR #305: URL: https://github.com/apache/tez/pull/305#issuecomment-1688782772 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode

[GitHub] [tez] tez-yetus commented on pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-22 Thread via GitHub
tez-yetus commented on PR #305: URL: https://github.com/apache/tez/pull/305#issuecomment-1688833000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode

[GitHub] [tez] ayushtkn commented on pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-22 Thread via GitHub
ayushtkn commented on PR #305: URL: https://github.com/apache/tez/pull/305#issuecomment-1689213316 @abstractdog I have addressed the review comments, added a new TezContainer Class & pushed the methods there, let me know if it looks good. One checkstyle is left intentionally, that

[GitHub] [tez] abstractdog commented on a diff in pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-23 Thread via GitHub
abstractdog commented on code in PR #305: URL: https://github.com/apache/tez/pull/305#discussion_r1303019662 ## tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/TezContainer.java: ## @@ -0,0 +1,161 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [tez] abstractdog commented on pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-23 Thread via GitHub
abstractdog commented on PR #305: URL: https://github.com/apache/tez/pull/305#issuecomment-1689964486 > @abstractdog I have addressed the review comments, added a new TezContainer Class & pushed the methods there, let me know if it looks good. > > One checkstyle is left

[GitHub] [tez] tez-yetus commented on pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-23 Thread via GitHub
tez-yetus commented on PR #305: URL: https://github.com/apache/tez/pull/305#issuecomment-1690213259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode

[GitHub] [tez] abstractdog merged pull request #305: TEZ-1037: Replace multiple members in TaskAttemptImpl for container related stuff with a single reference to the container.

2023-08-24 Thread via GitHub
abstractdog merged PR #305: URL: https://github.com/apache/tez/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] TEZ-4520: Enable Parallel Compilation for TEZ [tez]

2023-11-09 Thread via GitHub
JiaLiangC opened a new pull request, #315: URL: https://github.com/apache/tez/pull/315 Tez was unable to utilize Maven's multi-threaded compilation due to dependency issues, resulting in slow compilation. However, this problem was resolved through module dependency resolution. After

Re: [PR] TEZ-4520: Enable Parallel Compilation for TEZ [tez]

2023-11-09 Thread via GitHub
tez-yetus commented on PR #315: URL: https://github.com/apache/tez/pull/315#issuecomment-1805250759 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 23m 24s | Docker mode

[GitHub] [tez] tez-yetus commented on pull request #263: TEZ-4397: Open Tez Input splits asynchronously

2023-01-30 Thread via GitHub
tez-yetus commented on PR #263: URL: https://github.com/apache/tez/pull/263#issuecomment-1409839186 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 36m 17s | Docker mode

[GitHub] [tez] shameersss1 opened a new pull request, #263: TEZ-4397: Open Tez Input splits asynchronously

2023-01-30 Thread via GitHub
shameersss1 opened a new pull request, #263: URL: https://github.com/apache/tez/pull/263 Tez input splits can be opened asynchronously. This will reduce the amount of time spent for s3 to prepare the connection and opening the object. The changes are taken from the original PR:

[GitHub] [tez] shameersss1 commented on pull request #263: TEZ-4397: Open Tez Input splits asynchronously

2023-01-30 Thread via GitHub
shameersss1 commented on PR #263: URL: https://github.com/apache/tez/pull/263#issuecomment-1409783144 @abstractdog Could you please review the same? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tez] tez-yetus commented on pull request #263: TEZ-4397: Open Tez Input splits asynchronously

2023-01-30 Thread via GitHub
tez-yetus commented on PR #263: URL: https://github.com/apache/tez/pull/263#issuecomment-1409868260 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode

[GitHub] [tez] tez-yetus commented on pull request #187: TEZ-4387: use new doclet API in Java 9+

2023-02-01 Thread via GitHub
tez-yetus commented on PR #187: URL: https://github.com/apache/tez/pull/187#issuecomment-1412718191 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 41m 13s | Docker mode

[GitHub] [tez] shameersss1 commented on pull request #274: TEZ-4479: Eagerly Init/Load FileSystem In Tez Task Containers

2023-03-10 Thread via GitHub
shameersss1 commented on PR #274: URL: https://github.com/apache/tez/pull/274#issuecomment-1463677712 @abstractdog Could you please review the changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tez] tez-yetus commented on pull request #259: TEZ-4463: Upgrade jquery-ui to 1.13.2 due to CVE issues

2023-03-14 Thread via GitHub
tez-yetus commented on PR #259: URL: https://github.com/apache/tez/pull/259#issuecomment-1467765245 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 24m 49s | Docker mode

[GitHub] [tez] mlorek commented on pull request #264: TEZ-4470: typo fixes

2023-03-14 Thread via GitHub
mlorek commented on PR #264: URL: https://github.com/apache/tez/pull/264#issuecomment-1467620590 @abstractdog can you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tez] shameersss1 commented on pull request #274: TEZ-4479: Eagerly Init/Load FileSystem In Tez Task Containers

2023-03-15 Thread via GitHub
shameersss1 commented on PR #274: URL: https://github.com/apache/tez/pull/274#issuecomment-1471336369 @abstractdog Could you please review the changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tez] dependabot[bot] opened a new pull request, #275: Bump jettison from 1.5.3 to 1.5.4

2023-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #275: URL: https://github.com/apache/tez/pull/275 Bumps [jettison](https://github.com/jettison-json/jettison) from 1.5.3 to 1.5.4. Release notes Sourced from https://github.com/jettison-json/jettison/releases;>jettison's releases.

[GitHub] [tez] tez-yetus commented on pull request #275: Bump jettison from 1.5.3 to 1.5.4

2023-03-22 Thread via GitHub
tez-yetus commented on PR #275: URL: https://github.com/apache/tez/pull/275#issuecomment-1480396382 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 25m 0s | Docker mode

[GitHub] [tez] abstractdog commented on pull request #264: TEZ-4470: typo fixes

2023-03-25 Thread via GitHub
abstractdog commented on PR #264: URL: https://github.com/apache/tez/pull/264#issuecomment-1483906496 @mlorek : have you had the chance to check the root cause of test failures in some modules? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tez] abstractdog commented on a diff in pull request #274: TEZ-4479: Eagerly Init/Load FileSystem In Tez Task Containers

2023-03-25 Thread via GitHub
abstractdog commented on code in PR #274: URL: https://github.com/apache/tez/pull/274#discussion_r1148421338 ## tez-api/src/main/java/org/apache/tez/dag/api/TezConfiguration.java: ## @@ -1131,6 +1131,14 @@ public TezConfiguration(boolean loadDefaults) { public static final

  1   2   3   4   5   6   7   8   9   >