[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322262=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322262 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 21:02 Start Date: 02/Oct/19 21:02 Worklog Time Spent: 10m Work Description: Traf-Jenkins commented on issue #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#issuecomment-537679358 Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/3266/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322262) Time Spent: 1.5h (was: 1h 20m) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322148=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322148 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:50 Start Date: 02/Oct/19 18:50 Worklog Time Spent: 10m Work Description: DaveBirdsall commented on pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#discussion_r330712806 ## File path: core/sql/sqlcomp/nadefaults.cpp ## @@ -3629,11 +3622,12 @@ void NADefaults::initCurrentDefaultsWithDefaultDefaults() } // End: Temporary workaround for SQL build regressions to pass - // Cache all the default keywords up front, // leaving other non-keyword token to be cached on demand. Review comment: Should this comment line (line 3625 in the new file) be deleted also? It doesn't make sense by itself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322148) Time Spent: 1h 20m (was: 1h 10m) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322147=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322147 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:50 Start Date: 02/Oct/19 18:50 Worklog Time Spent: 10m Work Description: DaveBirdsall commented on pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#discussion_r330710014 ## File path: core/sql/generator/GenRelUpdate.cpp ## @@ -779,6 +779,7 @@ short HbaseDelete::codeGen(Generator * generator) NABoolean isAlignedFormat = getTableDesc()->getNATable()->isAlignedFormat(getIndexDesc()); NABoolean isHbaseMapFormat = getTableDesc()->getNATable()->isHbaseMapTable(); + NABoolean isTrafMDTable = getTableDesc()->getNATable()->isSeabaseMDTable(); Review comment: Not sure why this change is here. We don't seem to use isTrafMDTable anywhere? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322147) Time Spent: 1h 10m (was: 1h) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322146 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:50 Start Date: 02/Oct/19 18:50 Worklog Time Spent: 10m Work Description: DaveBirdsall commented on pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#discussion_r330711433 ## File path: core/sql/generator/GenRelUpdate.cpp ## @@ -2449,6 +2450,7 @@ short HbaseInsert::codeGen(Generator *generator) } const NATable *naTable = getTableDesc()->getNATable(); + NABoolean isTrafMDTable = getTableDesc()->getNATable()->isSeabaseMDTable(); Review comment: Same observation here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322146) Time Spent: 1h 10m (was: 1h) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322134=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322134 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:40 Start Date: 02/Oct/19 18:40 Worklog Time Spent: 10m Work Description: DaveBirdsall commented on issue #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#issuecomment-537625819 jenkins, retest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322134) Time Spent: 40m (was: 0.5h) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=321353=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321353 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 01/Oct/19 16:26 Start Date: 01/Oct/19 16:26 Worklog Time Spent: 10m Work Description: Traf-Jenkins commented on issue #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#issuecomment-537116350 Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/3265/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 321353) Time Spent: 0.5h (was: 20m) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=321283=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321283 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 01/Oct/19 14:09 Start Date: 01/Oct/19 14:09 Worklog Time Spent: 10m Work Description: Traf-Jenkins commented on issue #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#issuecomment-537054094 Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3265/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 321283) Time Spent: 20m (was: 10m) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=321281=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321281 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 01/Oct/19 14:06 Start Date: 01/Oct/19 14:06 Worklog Time Spent: 10m Work Description: selvaganesang commented on pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858 Avoid reading VERSIONS and DEFAULTS table after it is done once in a process. This required following cleanup 1. cqd MODE_SEABASE is removed. 2. Removed the support to read CQD from a file. 3. NADefaults constructor now reads the defaults table once and saves off the relevant information such as currentDefaults, currentTokens, provenances and currentFloats to be reused by the other NADefaults objects. 4. T2 driver doesn't use the defaultContext to compile any query. Hence, it is not possible to use the heap from CmpContext to save off the defaults value. The code has been changed the heap from CliGlobals to save the current defaults. 5. Fixed code to use static literals as it is from the defaultsDefaults to avoid invalid memory in the saved defaults 6. Changes to optimize initialization of currentTokens_ in NADefaults 7. CQD * RESET RESET CQD * RESET Now resets to the defaults when CQD * RESET RESET was issued. 8. Also optimized initCurrentsFromDefaultsTable further. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 321281) Remaining Estimate: 0h Time Spent: 10m > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
