[jira] Commented: (LUCENE-1356) Allow easy extensions of TopDocCollector

2008-08-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622441#action_12622441 ] Shai Erera commented on LUCENE-1356: IMO, TopFieldDocCollector should be changed to us

[jira] Commented: (LUCENE-1343) A replacement for ISOLatin1AccentFilter that does a more thorough job of removing diacritical marks or non-spacing modifiers.

2008-08-13 Thread Ken Krugler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622432#action_12622432 ] Ken Krugler commented on LUCENE-1343: - Hi Robert, FWIW, the issues being discussed he

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622371#action_12622371 ] Michael McCandless commented on LUCENE-1333: bq. This is rather expensive. In

[jira] Commented: (LUCENE-1343) A replacement for ISOLatin1AccentFilter that does a more thorough job of removing diacritical marks or non-spacing modifiers.

2008-08-13 Thread Lance Norskog (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622345#action_12622345 ] Lance Norskog commented on LUCENE-1343: --- Some languages like Cyrillic have a standar

[jira] Issue Comment Edited: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622238#action_12622238 ] dmsmith edited comment on LUCENE-1333 at 8/13/08 12:04 PM: Reg

RE: How to Query for Documents' Anchor Text?

2008-08-13 Thread Steven A Rowe
Hi dealmaker, The java-dev mailing list is devoted to discussion of the *development* of Lucene. In the future, please use the java-user mailing list for questions about *using* Lucene. If by "anchor text" you mean HTML anchor text, then you must make sure that you index this text in its own

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622238#action_12622238 ] DM Smith commented on LUCENE-1333: -- Regarding the implementation of hashCode: You are usi

[jira] Commented: (LUCENE-1356) Allow easy extensions of TopDocCollector

2008-08-13 Thread Doron Cohen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1263#action_1263 ] Doron Cohen commented on LUCENE-1356: - Shai, Thanks for creating this issue and patch!

[jira] Assigned: (LUCENE-1356) Allow easy extensions of TopDocCollector

2008-08-13 Thread Doron Cohen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doron Cohen reassigned LUCENE-1356: --- Assignee: Doron Cohen > Allow easy extensions of TopDocCollector > -

Re: Extending TopDocCollector

2008-08-13 Thread Shai Erera
Thanks. I created issue https://issues.apache.org/jira/browse/LUCENE-1356and submitted a patch. Do you think it can be included in 2.3.3? On Wed, Aug 13, 2008 at 4:44 PM, Doron Cohen <[EMAIL PROTECTED]> wrote: > Sounds logical to me. After all, TopDocCollector already has a subclass >> (TopFieldD

[jira] Updated: (LUCENE-1356) Allow easy extensions of TopDocCollector

2008-08-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-1356: --- Attachment: 1356.patch The very trivial patch > Allow easy extensions of TopDocCollector >

[jira] Created: (LUCENE-1356) Allow easy extensions of TopDocCollector

2008-08-13 Thread Shai Erera (JIRA)
Allow easy extensions of TopDocCollector Key: LUCENE-1356 URL: https://issues.apache.org/jira/browse/LUCENE-1356 Project: Lucene - Java Issue Type: Improvement Components: Index

Re: Extending TopDocCollector

2008-08-13 Thread Doron Cohen
> > Sounds logical to me. After all, TopDocCollector already has a subclass > (TopFieldDocCollector), and it is quite natural that users might want to > add more - to implement different sorting mechanisms (e.g., according > to payloads, database data, or whatever). > > Does anyone disagree? Is the

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622204#action_12622204 ] Grant Ingersoll commented on LUCENE-1333: - I think the main performance issue with

Re: Extending TopDocCollector

2008-08-13 Thread Nadav Har'El
On Thu, Aug 07, 2008, Shai Erera wrote about "Extending TopDocCollector": > Is it possible to change TopDocCollector members to 'protected' instead of > 'package' and 'private'? It will allow to easily extend it. Today, I have a > need to extend it, but since I cannot use its members I have to impl

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread Doron Cohen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622202#action_12622202 ] Doron Cohen commented on LUCENE-1333: - I'm not using sink tokenizer (yet) so not sure

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread DM Smith (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622201#action_12622201 ] DM Smith commented on LUCENE-1333: -- {quote} Cloning Tokens is not cheap, as I recall. In

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622195#action_12622195 ] Grant Ingersoll commented on LUCENE-1333: - Sorry, you guys are right. My bad. Do

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread Doron Cohen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622171#action_12622171 ] Doron Cohen commented on LUCENE-1333: - But how do you cope with reset()? Consider thi

[jira] Commented: (LUCENE-1333) Token implementation needs improvements

2008-08-13 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622168#action_12622168 ] Grant Ingersoll commented on LUCENE-1333: - My point is it is already cloned when i