SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened
---
Key: LUCENE-2397
URL: https://issues.apache.org/jira/browse/LUCENE-2397
Project: Lucene - Java
Issue Type
[
https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857396#action_12857396
]
Shai Erera commented on LUCENE-2396:
Static? Weren't you against that!?
But if we re
[
https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857388#action_12857388
]
Shai Erera commented on LUCENE-2396:
Robert I think this is great! Can we move more an
[
https://issues.apache.org/jira/browse/LUCENE-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856917#action_12856917
]
Shai Erera commented on LUCENE-2159:
bq. There is an excellent section on it in LIA2
[
https://issues.apache.org/jira/browse/LUCENE-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856911#action_12856911
]
Shai Erera commented on LUCENE-2159:
Which is fine - I think this would be a neat task
[
https://issues.apache.org/jira/browse/LUCENE-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856877#action_12856877
]
Shai Erera commented on LUCENE-2159:
bq. I understand having a general performance sui
[
https://issues.apache.org/jira/browse/LUCENE-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856845#action_12856845
]
Shai Erera commented on LUCENE-2159:
This looks like a nice tool. But all it does is c
[
https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-2316.
Lucene Fields: [New, Patch Available] (was: [New])
Assignee: Shai Erera
Resolution
[
https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856531#action_12856531
]
Shai Erera commented on LUCENE-2316:
That's a fairly trivial patch, therefore I plan t
[
https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2316:
---
Attachment: LUCENE-2316.patch
Patch clarifies the contract, fixes the directories to adhere to it an
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-2386.
Resolution: Fixed
Committed revision 933613. (take #2)
> IndexWriter commits unnecessarily on fre
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2386:
---
Attachment: LUCENE-2386.patch
Patch includes the proposed test in TestIndexWriter. I think this is r
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856063#action_12856063
]
Shai Erera commented on LUCENE-2386:
So just call "new IW()", then rollback and ensure
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855924#action_12855924
]
Shai Erera commented on LUCENE-2386:
I don't think that people need to write that "emp
[
https://issues.apache.org/jira/browse/LUCENE-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855913#action_12855913
]
Shai Erera commented on LUCENE-2392:
I'd like to withdraw my request from above. I mis
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855892#action_12855892
]
Shai Erera commented on LUCENE-2386:
bq. what is the proper way (after this fix) to op
[
https://issues.apache.org/jira/browse/LUCENE-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855877#action_12855877
]
Shai Erera commented on LUCENE-2373:
I'd rather not count on file length as well ... s
[
https://issues.apache.org/jira/browse/LUCENE-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855875#action_12855875
]
Shai Erera commented on LUCENE-2392:
Mike - it'll also be great if we can store the le
[
https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855873#action_12855873
]
Shai Erera commented on LUCENE-2316:
Well ... dir.fileLength is also used by SegmentIn
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855870#action_12855870
]
Shai Erera commented on LUCENE-2386:
I'm not sure if we're arguing about the same thin
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2386:
---
Attachment: LUCENE-2386.patch
Patch w/ proposed fixes. All tests pass, including Solr's :).
> Index
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855767#action_12855767
]
Shai Erera commented on LUCENE-2386:
About IndexReader.listCommits ... the javadocs st
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2386:
---
Attachment: LUCENE-2386.patch
Fixes IndexFileDeleter, adds a proper test to TestIndexWriter. Haven't
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855727#action_12855727
]
Shai Erera commented on LUCENE-2386:
Committed revision 932917 for the revert.
> Inde
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera reopened LUCENE-2386:
As I indicated in an email, Solr tests failed (sorry for not running them
before). After some investi
[
https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855713#action_12855713
]
Shai Erera commented on LUCENE-1709:
Committed revision 932878 with the following:
# b
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-2386.
Lucene Fields: [New, Patch Available] (was: [New])
Resolution: Fixed
Committed revision 93
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2386:
---
Attachment: LUCENE-2386.patch
Patch updated to latest rev. + the proposed name change --
IndexNotFo
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855457#action_12855457
]
Shai Erera commented on LUCENE-2386:
Ok sounds good. Is there a preferred package for
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2386:
---
Attachment: LUCENE-2386.patch
Patch fixes all tests as well as changes to IndexWriter, IndexFileDele
[
https://issues.apache.org/jira/browse/LUCENE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855379#action_12855379
]
Shai Erera commented on LUCENE-1879:
I have found such version ... and it fails too :)
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855369#action_12855369
]
Shai Erera commented on LUCENE-2386:
I already did that ... just didn't post back. Cre
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855344#action_12855344
]
Shai Erera commented on LUCENE-2386:
Ok I've added the following to DirReader:
{code}
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855277#action_12855277
]
Shai Erera commented on LUCENE-2386:
Apparently, there are more tests that fail ... lo
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855265#action_12855265
]
Shai Erera commented on LUCENE-2386:
bq. Maybe change testImmediateDiskFull to set max
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2386:
---
Attachment: LUCENE-2386.patch
First stab at this. Patch still missing CHANGES entry, and I haven't r
[
https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-2385.
Resolution: Fixed
Committed revision 932129.
> Move NoDeletionPolicy from benchmark to core
> ---
[
https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855155#action_12855155
]
Shai Erera commented on LUCENE-2385:
Forgot to mention that the only move I made was o
[
https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2385:
---
Attachment: LUCENE-2385.patch
Is it better now?
> Move NoDeletionPolicy from benchmark to core
> --
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855148#action_12855148
]
Shai Erera commented on LUCENE-2386:
Looking at IFD again, I think a boolean ctor arg
[
https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855140#action_12855140
]
Shai Erera commented on LUCENE-2385:
I did that first, but then remembered that when I
[
https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855131#action_12855131
]
Shai Erera commented on LUCENE-2386:
Took a look at IndexFileDeleter, and located to o
[
https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2385:
---
Attachment: LUCENE-2385.patch
Move NoDeletionPolicy to core, adds javadocs + TestNoDeletionPolicy. A
IndexWriter commits unnecessarily on fresh Directory
Key: LUCENE-2386
URL: https://issues.apache.org/jira/browse/LUCENE-2386
Project: Lucene - Java
Issue Type: Bug
Components: In
Move NoDeletionPolicy from benchmark to core
Key: LUCENE-2385
URL: https://issues.apache.org/jira/browse/LUCENE-2385
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/be
[
https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855020#action_12855020
]
Shai Erera commented on LUCENE-1709:
Robert, I will commit the patch, seems good to do
[
https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854920#action_12854920
]
Shai Erera commented on LUCENE-1482:
I still think that calling isDebugEnabled is bett
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854887#action_12854887
]
Shai Erera commented on LUCENE-2074:
bq. I plan to commit this soon!
That's great ne
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854885#action_12854885
]
Shai Erera commented on LUCENE-2074:
Uwe, must this be coupled with that issue? This o
[
https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854588#action_12854588
]
Shai Erera commented on LUCENE-2353:
Actually, we've reopened LUCENE-1709 to track tha
[
https://issues.apache.org/jira/browse/LUCENE-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-2377.
Resolution: Fixed
Committed revision 931502.
> Enable the use of NoMergePolicy and NoMergeSchedul
[
https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-1709:
---
Attachment: LUCENE-1709-2.patch
Since I had the changes on my local env. I thought it's best to gene
[
https://issues.apache.org/jira/browse/LUCENE-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2377:
---
Attachment: LUCENE-2377.patch
Patch includes both fix to CreateIndexTask as well as relevant tests t
Enable the use of NoMergePolicy and NoMergeScheduler by Benchmark
-
Key: LUCENE-2377
URL: https://issues.apache.org/jira/browse/LUCENE-2377
Project: Lucene - Java
Issue Type: Im
[
https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854348#action_12854348
]
Shai Erera commented on LUCENE-1709:
One more thing - change benchmark tests to run se
[
https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-2353.
Resolution: Fixed
Committed revision 929520.
> Config incorrectly handles Windows absolute pathna
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851842#action_12851842
]
Shai Erera commented on LUCENE-2310:
Right Earwin - agreed.
I'd like to summarize a b
[
https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851836#action_12851836
]
Shai Erera commented on LUCENE-2353:
Unless there are objections, I plan to commit thi
[
https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera reassigned LUCENE-2353:
--
Assignee: Shai Erera
> Config incorrectly handles Windows absolute pathnames
> ---
[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851829#action_12851829
]
Shai Erera commented on LUCENE-2310:
+1 for this simplification. Can we just name it I
[
https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2353:
---
Attachment: LUCENE-2353.patch
Updated to also match 'c:/temp' like paths, which are also accepted on
[
https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850644#action_12850644
]
Shai Erera commented on LUCENE-2353:
I don't have an account yet, so I cannot commit t
[
https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2353:
---
Attachment: LUCENE-2353.patch
The fix is only relevant to get(String, String) and not to all other
Config incorrectly handles Windows absolute pathnames
-
Key: LUCENE-2353
URL: https://issues.apache.org/jira/browse/LUCENE-2353
Project: Lucene - Java
Issue Type: Bug
Components:
[
https://issues.apache.org/jira/browse/LUCENE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850336#action_12850336
]
Shai Erera commented on LUCENE-1879:
Hi Grant - I believe what you describe is related
[
https://issues.apache.org/jira/browse/LUCENE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850313#action_12850313
]
Shai Erera commented on LUCENE-1879:
The way I planned to support multi-threaded index
[
https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850094#action_12850094
]
Shai Erera commented on LUCENE-2345:
Earwin, I wholeheartedly agree with what you wrot
[
https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850086#action_12850086
]
Shai Erera commented on LUCENE-2215:
Sure let's wait for the patch and some perf. resu
[
https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850083#action_12850083
]
Shai Erera commented on LUCENE-2345:
Thanks Uwe, I know that ctor is the preferred way
[
https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850075#action_12850075
]
Shai Erera commented on LUCENE-2345:
Earwin, w/o knowing too much about the details of
[
https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850002#action_12850002
]
Shai Erera commented on LUCENE-2215:
bq. since I think it's safe to say most applicati
[
https://issues.apache.org/jira/browse/LUCENE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849728#action_12849728
]
Shai Erera commented on LUCENE-2345:
bq. The IndexWriter now has a getter and setter f
[
https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849435#action_12849435
]
Shai Erera commented on LUCENE-2343:
I've just realized you haven't added a CHANGES en
[
https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849416#action_12849416
]
Shai Erera commented on LUCENE-2343:
Looks good !
> Add support for benchmarking Coll
[
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849404#action_12849404
]
Shai Erera commented on LUCENE-2339:
Do we want to suppress only IOExceptions? What ab
[
https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849403#action_12849403
]
Shai Erera commented on LUCENE-2343:
I wasn't talking about the name of the parameter
[
https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849393#action_12849393
]
Shai Erera commented on LUCENE-2343:
ok I won't argue about == true/false. It's a styl
[
https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849384#action_12849384
]
Shai Erera commented on LUCENE-2343:
In the patch you write: "topDocOrdered - Creates
[
https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849211#action_12849211
]
Shai Erera commented on LUCENE-2215:
Ohh I see. Missed that. So that can be folded int
[
https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849200#action_12849200
]
Shai Erera commented on LUCENE-2215:
So what's the motivation of declaring PagingColle
[
https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848908#action_12848908
]
Shai Erera commented on LUCENE-2215:
I must admit I don't like throwing UOE. I imagine
[
https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848896#action_12848896
]
Shai Erera commented on LUCENE-2215:
I've reviewed PagingCollector.java and the first
[
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848777#action_12848777
]
Shai Erera commented on LUCENE-2339:
Ok that's indeed different :). I guess we can int
[
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848753#action_12848753
]
Shai Erera commented on LUCENE-2339:
bq. But there is still a need to "close everythin
[
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848729#action_12848729
]
Shai Erera commented on LUCENE-2339:
Mike, that's what I wrote above "if someone does
[
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848636#action_12848636
]
Shai Erera commented on LUCENE-2339:
I don't want to block the issue. If LUCENE-1482 w
[
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848606#action_12848606
]
Shai Erera commented on LUCENE-2339:
Sorry ... I was confused w/ the for loop of Java
[
https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848571#action_12848571
]
Shai Erera commented on LUCENE-1482:
Well ... since Mark hasn't closed it yet (thanks
[
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848565#action_12848565
]
Shai Erera commented on LUCENE-2339:
I personally haven't seen problem using NIO on Wi
[
https://issues.apache.org/jira/browse/LUCENE-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848560#action_12848560
]
Shai Erera commented on LUCENE-2342:
Took me a while to spot the typo :). Can you repr
[
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848376#action_12848376
]
Shai Erera commented on LUCENE-2339:
Patch looks good! Few comments:
# is it safe to
[
https://issues.apache.org/jira/browse/LUCENE-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848341#action_12848341
]
Shai Erera commented on LUCENE-2328:
Earwin, can you add a deprecation message to sync
[
https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848192#action_12848192
]
Shai Erera commented on LUCENE-2331:
I think it's correct. The idea is to say that eve
[
https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2331:
---
Attachment: LUCENE-2331.patch
Patch includes NoMergePolicy.NO_COMPOUND_FILES and COMPOUND_FILES sing
[
https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848113#action_12848113
]
Shai Erera commented on LUCENE-2331:
bq. do you think we should allow instantiation of
[
https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2331:
---
Attachment: LUCENE-2331.patch
Sorry - new eclipse and project settings :). Should be ok now.
> Add
[
https://issues.apache.org/jira/browse/LUCENE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847916#action_12847916
]
Shai Erera commented on LUCENE-2337:
Note that -1 is a valid return value in case doc(
[
https://issues.apache.org/jira/browse/LUCENE-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847716#action_12847716
]
Shai Erera commented on LUCENE-2336:
Hi Gary
This has been discussed before (I'm not
[
https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2331:
---
Attachment: LUCENE-2331.patch
Patch includes:
* NoMergePolicy + TestNoMergePolicy
* NoMergeScheduler
[
https://issues.apache.org/jira/browse/LUCENE-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847585#action_12847585
]
Shai Erera commented on LUCENE-2328:
bq. Trying to sync a file that hasn't yet been cl
1 - 100 of 814 matches
Mail list logo
