[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12786246#action_12786246
]
Simon Willnauer commented on LUCENE-2102:
-
I will commit this tomorrow if nobody
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785253#action_12785253
]
Simon Willnauer commented on LUCENE-2102:
-
I plan to commit the latest patch until
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785379#action_12785379
]
Robert Muir commented on LUCENE-2102:
-
Hello Simon, if this issue is resolved (so we
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784743#action_12784743
]
Uwe Schindler commented on LUCENE-2102:
---
We should use version from the beginning of
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784748#action_12784748
]
Simon Willnauer commented on LUCENE-2102:
-
bq. But to be consistent with
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784750#action_12784750
]
Simon Willnauer commented on LUCENE-2102:
-
I think we should have a consistent
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784875#action_12784875
]
Robert Muir commented on LUCENE-2102:
-
bq. If somebody uses Version 3.1 this filter
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784907#action_12784907
]
Simon Willnauer commented on LUCENE-2102:
-
Robert, I see your point. The root
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784926#action_12784926
]
Robert Muir commented on LUCENE-2102:
-
bq. I don't think that new code should try do
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784928#action_12784928
]
Simon Willnauer commented on LUCENE-2102:
-
bq. ok, I will change this. You are
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784944#action_12784944
]
Simon Willnauer commented on LUCENE-2102:
-
Robert, this patch looks good!
Much
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784407#action_12784407
]
Robert Muir commented on LUCENE-2102:
-
Hi Ahmet, this patch is looking very nice,
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784410#action_12784410
]
Uwe Schindler commented on LUCENE-2102:
---
Looks cool, it even uses the new CharUtils
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784414#action_12784414
]
Robert Muir commented on LUCENE-2102:
-
I have one comment, that this will not work
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784418#action_12784418
]
Uwe Schindler commented on LUCENE-2102:
---
As this is a new lowercasefilter, shouldn't
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784421#action_12784421
]
DM Smith commented on LUCENE-2102:
--
bq. but non-NFC text doesn't work correctly
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784424#action_12784424
]
Robert Muir commented on LUCENE-2102:
-
bq. Maybe its just me, but I think it is
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784423#action_12784423
]
DM Smith commented on LUCENE-2102:
--
For new classes, would it be helpful to add @since to
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784428#action_12784428
]
Robert Muir commented on LUCENE-2102:
-
bq. Unless a NFCNormalizingFilter is added to
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784437#action_12784437
]
Simon Willnauer commented on LUCENE-2102:
-
There is no need to use CharacterUtils
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784438#action_12784438
]
Robert Muir commented on LUCENE-2102:
-
Simon, I would rather see this in contrib also.
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784445#action_12784445
]
Simon Willnauer commented on LUCENE-2102:
-
bq. Would there be opposition to making
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784447#action_12784447
]
Robert Muir commented on LUCENE-2102:
-
I don't think its really unrelated, I think its
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784469#action_12784469
]
Ahmet Arslan commented on LUCENE-2102:
--
I kept the old test method and added a new
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784471#action_12784471
]
Robert Muir commented on LUCENE-2102:
-
Ahmet, I think so. they both test the same
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784472#action_12784472
]
Uwe Schindler commented on LUCENE-2102:
---
One othe possibility to resolve the problem
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784476#action_12784476
]
Robert Muir commented on LUCENE-2102:
-
bq. One othe possibility to resolve the problem
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784478#action_12784478
]
Uwe Schindler commented on LUCENE-2102:
---
The patch's TurkishLowerCaseFilter is as
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784479#action_12784479
]
Robert Muir commented on LUCENE-2102:
-
bq. test that does not use
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784480#action_12784480
]
Robert Muir commented on LUCENE-2102:
-
bq. The patch's TurkishLowerCaseFilter is as
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784483#action_12784483
]
Uwe Schindler commented on LUCENE-2102:
---
if I replace this code from Ahmet's test
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784485#action_12784485
]
Robert Muir commented on LUCENE-2102:
-
Uwe I don't think you understand what I am
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784487#action_12784487
]
Uwe Schindler commented on LUCENE-2102:
---
bq. Uwe this is not true. With a
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784489#action_12784489
]
Robert Muir commented on LUCENE-2102:
-
Uwe, I am talking about this patch too. it is
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784496#action_12784496
]
Uwe Schindler commented on LUCENE-2102:
---
Robert: I understand your problem, but it
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784499#action_12784499
]
Robert Muir commented on LUCENE-2102:
-
Uwe, it *is* specific to the turkish case.
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784570#action_12784570
]
Robert Muir commented on LUCENE-2102:
-
Hi Uwe, now are you ok with this being a
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784667#action_12784667
]
Uwe Schindler commented on LUCENE-2102:
---
Robert: Looks crazy but seems to work,
38 matches
Mail list logo
