Re: valid scores for sorting

2009-05-26 Thread Michael McCandless
On Tue, May 26, 2009 at 2:41 PM, Yonik Seeley wrote: > On Tue, May 26, 2009 at 2:22 PM, Michael McCandless > wrote: >> Hmm -- IndexSearcher tries to detect when SortComparatorSource is >> used, and drive the search with the toplevel reader, so that code is >> not supposed to be reached.  Do you r

Re: valid scores for sorting

2009-05-26 Thread Yonik Seeley
On Tue, May 26, 2009 at 2:22 PM, Michael McCandless wrote: > Hmm -- IndexSearcher tries to detect when SortComparatorSource is > used, and drive the search with the toplevel reader, so that code is > not supposed to be reached.  Do you remember what tickled it? Solr's search code is now using the

Re: valid scores for sorting

2009-05-26 Thread Michael McCandless
On Tue, May 26, 2009 at 1:58 PM, Yonik Seeley wrote: What other issues are you hitting? >>> >>> I hit an NPE when using old-style sort comparators. >> >> Do you have the traceback (or remember the gist)? > > I remember it... >    case SortField.CUSTOM: >      assert factory == null && compar

Re: valid scores for sorting

2009-05-26 Thread Yonik Seeley
On Tue, May 26, 2009 at 1:44 PM, Michael McCandless wrote: > On Tue, May 26, 2009 at 12:29 PM, Yonik Seeley > wrote: >> On Tue, May 26, 2009 at 12:16 PM, Michael McCandless >> wrote: >>> What other issues are you hitting? >> >> I hit an NPE when using old-style sort comparators. > > Do you have

Re: valid scores for sorting

2009-05-26 Thread Michael McCandless
OK I'll commit these changes... Mike On Tue, May 26, 2009 at 1:34 PM, Shai Erera wrote: > I also think we should state that for TSDC, those scores are invalid. > > In fact, we also changed TopDocs to return maxScore=NaN if max-score is not > tracked, so I think in a sense we've already said that

Re: valid scores for sorting

2009-05-26 Thread Michael McCandless
On Tue, May 26, 2009 at 12:29 PM, Yonik Seeley wrote: > On Tue, May 26, 2009 at 12:16 PM, Michael McCandless > wrote: >> What other issues are you hitting? > > I hit an NPE when using old-style sort comparators. Do you have the traceback (or remember the gist)? > The main thing is that I didn't

Re: valid scores for sorting

2009-05-26 Thread Shai Erera
I also think we should state that for TSDC, those scores are invalid. In fact, we also changed TopDocs to return maxScore=NaN if max-score is not tracked, so I think in a sense we've already said that NaN is not a valid value. But anyway, given that I don't believe those scores are common, and th

Re: valid scores for sorting

2009-05-26 Thread Yonik Seeley
FYI, the upgrading work is going on in https://issues.apache.org/jira/browse/SOLR- -Yonik http://www.lucidimagination.com On Tue, May 26, 2009 at 12:29 PM, Yonik Seeley wrote: > On Tue, May 26, 2009 at 12:16 PM, Michael McCandless > wrote: >> What other issues are you hitting? > > I hit a

Re: valid scores for sorting

2009-05-26 Thread Yonik Seeley
On Tue, May 26, 2009 at 12:16 PM, Michael McCandless wrote: > What other issues are you hitting? I hit an NPE when using old-style sort comparators. The main thing is that I didn't anticipate having to rewrite all the custom sort comparators Solr has. There are multiple test cases still failing..

Re: valid scores for sorting

2009-05-26 Thread Michael McCandless
On Tue, May 26, 2009 at 9:48 AM, Yonik Seeley wrote: > I'm attempting to switch Solr to use the new Collector framework to > get per-segment sorting and have been hitting some issues. What other issues are you hitting? > The latest is a function query log(val) which produces both NaN and > -Infi

Re: valid scores for sorting

2009-05-26 Thread Yonik Seeley
On Tue, May 26, 2009 at 9:52 AM, Shai Erera wrote: > We've decided in 1575 to pre-populate HitQueue with sentinel values with > score = Float.NEG_INF, as we assumed these scores will not be produced. TSDC > instantiates HitQueue with pre-filling turned on. > > Is NEG_INF a valid score for you? It

Re: valid scores for sorting

2009-05-26 Thread Shai Erera
We've decided in 1575 to pre-populate HitQueue with sentinel values with score = Float.NEG_INF, as we assumed these scores will not be produced. TSDC instantiates HitQueue with pre-filling turned on. Is NEG_INF a valid score for you? On Tue, May 26, 2009 at 4:48 PM, Yonik Seeley wrote: > I'm att