On Tue, Aug 4, 2009 at 11:46 AM, Yonik Seeley wrote:
> On Tue, Aug 4, 2009 at 11:34 AM, Michael
> McCandless wrote:
>> On Tue, Aug 4, 2009 at 11:29 AM, Yonik Seeley
>> wrote:
>>
In fact I think SortField.getComparator should be package private?
>>>
>>> It would be nice to keep - Solr already
On Tue, Aug 4, 2009 at 11:34 AM, Michael
McCandless wrote:
> On Tue, Aug 4, 2009 at 11:29 AM, Yonik Seeley
> wrote:
>
>>> In fact I think SortField.getComparator should be package private?
>>
>> It would be nice to keep - Solr already uses it :-)
>
> Intersting! OK I'll leave it public but put "s
On Tue, Aug 4, 2009 at 11:29 AM, Yonik Seeley wrote:
>> In fact I think SortField.getComparator should be package private?
>
> It would be nice to keep - Solr already uses it :-)
Intersting! OK I'll leave it public but put "subject to suddenly
change" warning on it.
Mike
--
On Tue, Aug 4, 2009 at 11:18 AM, Michael
McCandless wrote:
> On Tue, Aug 4, 2009 at 9:56 AM, Yonik Seeley
> wrote:
>> OK, it sounds like it should always be the same as SortField.getReversed()
>> then?
>> In which case it seems redundant to pass it into
>> SortField.getComparator() since SortFiel
On Tue, Aug 4, 2009 at 9:56 AM, Yonik Seeley wrote:
> OK, it sounds like it should always be the same as SortField.getReversed()
> then?
> In which case it seems redundant to pass it into
> SortField.getComparator() since SortField already keeps track of it?
Duh, right. I'll remove as an arg and
On Tue, Aug 4, 2009 at 5:46 AM, Michael
McCandless wrote:
> On Mon, Aug 3, 2009 at 10:29 PM, Yonik Seeley
> wrote:
>> Why is "reversed" passed into SortField.getComparator(), and what does it
>> mean?
>> Should it always be passed as sortField.getReversed() (and if so, why
>> does the param exist
On Tue, Aug 4, 2009 at 6:47 AM, Koji Sekiguchi wrote:
> I should add them when I attached the patch. Sorry about that, Mike.
> If I have time when finishing work for fast vector highlighter,
> I'd like to contribute...
It's fine! We can iterate :)
And, really I should have asked for more javado
Michael McCandless wrote:
On Mon, Aug 3, 2009 at 10:29 PM, Yonik Seeley wrote:
Why is "reversed" passed into SortField.getComparator(), and what does it mean?
Should it always be passed as sortField.getReversed() (and if so, why
does the param exist at all)?
reversed may be passed on t
On Mon, Aug 3, 2009 at 10:29 PM, Yonik Seeley wrote:
> Why is "reversed" passed into SortField.getComparator(), and what does it
> mean?
> Should it always be passed as sortField.getReversed() (and if so, why
> does the param exist at all)?
reversed may be passed on to some comparators (currently
Why is "reversed" passed into SortField.getComparator(), and what does it mean?
Should it always be passed as sortField.getReversed() (and if so, why
does the param exist at all)?
Also, FieldComparator has no javadoc for most of it's methods. For example:
public void setNextReader(IndexReader
10 matches
Mail list logo
