[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Busch updated LUCENE-1693:
--
Attachment: TestCompatibility.java
I quickly hacked a tool demonstrating my concerns.
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720524#action_12720524
]
Shai Erera commented on LUCENE-1693:
Doesn't this mean that we need to change all our
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720529#action_12720529
]
Michael Busch commented on LUCENE-1693:
---
I don't think we mention subclassing of
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720530#action_12720530
]
Michael Busch commented on LUCENE-1693:
---
But I'll definitely buy Uwe a beer if he
On 6/15/09 10:10 AM, Grant Ingersoll wrote:
But, as Michael M reminded me, it is complex, so please accept my
apologies.
No worries, Grant! I was not really offended, but rather confused...
Thanks for clarifying.
Michael
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720534#action_12720534
]
Uwe Schindler edited comment on LUCENE-1693 at 6/17/09 12:39 AM:
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720534#action_12720534
]
Uwe Schindler commented on LUCENE-1693:
---
Hi Michael,
in principle your test is
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720538#action_12720538
]
Michael Busch commented on LUCENE-1693:
---
OK, what about this sentence in Token.java:
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-1630:
---
Attachment: LUCENE-1630.patch
Fixed most of your comments Mike. I also noticed I did not document
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720550#action_12720550
]
Uwe Schindler commented on LUCENE-1693:
---
OK, I have a solution:
I write a wrapper
I think readahead would be less interesting to Lucene; while we
definitely want a certain amount of readahead (to amortize the
seeking), too much readahead starts means evicting things from the IO
cache. OSs already do a fair job (I think) of some amount of
readahead, though if we do gain
On Tue, Jun 16, 2009 at 6:06 PM, Michael Buschbusch...@gmail.com wrote:
Cool, seems like Mark is volunteering to be the 2.9 release manager ;)
Yay!
Mike
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For
On Tue, Jun 16, 2009 at 7:16 PM, Yonik Seeleyysee...@gmail.com wrote:
On Tue, Jun 16, 2009 at 6:37 PM, Mark Millermarkrmil...@gmail.com wrote:
I've looked at the release todo wiki and I am still having nightmares.
Indeed - it's gotten 5 times longer since the last time I did Lucene or Solr.
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720562#action_12720562
]
Michael Busch commented on LUCENE-1693:
---
For caching:
I guess you would have to
On Wed, Jun 17, 2009 at 10:42 AM, Michael
McCandlessluc...@mikemccandless.com wrote:
I would love to see function queries consolidated between Solr and
Lucene! I think it's a prime example of duplicated and then diverged
sources between Lucene and Solr...
And it's fabulous that you are
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720568#action_12720568
]
Uwe Schindler commented on LUCENE-1693:
---
bq. I think you should try it out and see
[
https://issues.apache.org/jira/browse/LUCENE-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720569#action_12720569
]
Michael McCandless commented on LUCENE-1516:
{quote}
Currently we check the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720571#action_12720571
]
Michael Busch commented on LUCENE-1693:
---
{quote}
I am working on that, I have a
[
https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1505:
---
Fix Version/s: 2.9
Summary: Change contrib/spatial to use trie's
[
https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720572#action_12720572
]
Michael McCandless commented on LUCENE-1505:
LUCENE-1496 is won't fix because
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720574#action_12720574
]
Michael McCandless commented on LUCENE-1673:
Note that LUCENE-1505 is open for
[
https://issues.apache.org/jira/browse/LUCENE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720578#action_12720578
]
Michael McCandless commented on LUCENE-1699:
Patch looks good:
* Can you
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720593#action_12720593
]
Michael McCandless commented on LUCENE-1673:
bq. Want a convenience method for
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720607#action_12720607
]
Michael McCandless commented on LUCENE-1630:
{quote}
bq. Can we make
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720612#action_12720612
]
Shai Erera commented on LUCENE-1630:
Ok I will change acceptsDocsOutOfOrder on
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720619#action_12720619
]
Earwin Burrfoot commented on LUCENE-1630:
-
I wasn't following the issue closely,
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720623#action_12720623
]
Michael McCandless commented on LUCENE-1630:
Still working through the
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720622#action_12720622
]
Shai Erera commented on LUCENE-1630:
It isn't and that's what I expressed in the
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720629#action_12720629
]
Shai Erera commented on LUCENE-1630:
bq. You forgot to fill in the ? in CHANGES
I
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720632#action_12720632
]
Shai Erera commented on LUCENE-1630:
{quote}
You forgot to fill in the ? in
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1693:
--
Attachment: LUCENE-1693.patch
Attached is a new patch, that implements the last idea:
- There
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1693:
--
Attachment: LUCENE-1693.patch
Sorry, small bug in cloning inside next(): the POSToken-test
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1693:
--
Attachment: (was: LUCENE-1693.patch)
AttributeSource/TokenStream API improvements
On Tue, Jun 16, 2009 at 6:06 PM, Michael Buschbusch...@gmail.com wrote:
How soon is soon? Code freeze in 2-3 weeks or so maybe? Then 7-10 days
testing, so 2.9 should be out mid July? Sounds reasonable?
This schedule might be tight for me... I'm on vacation for the week
starting Jun 29.
I tend also to a little bit later; maybe we need more discussions about
NumericField and NumericSortField, especially between the two fractions Mike
vs. Yonik :-)
After finishing the TokenStream simplification and optimization, I will now
again start rewriting of javadocs for trie and hopefully I
On Jun 16, 2009, at 7:16 PM, Yonik Seeley wrote:
On Tue, Jun 16, 2009 at 6:37 PM, Mark Millermarkrmil...@gmail.com
wrote:
There are parts that aren't strictly part of the release process IMO -
things like maven seem optional.
-1. Maven support is not optional.
+1 for more automation.
Uwe Schindler wrote:
Maybe Mark helps me and I can do
it alone the next time, if I have to? :-)
Tag team effort ? It will be my first release to, so that would be great !
--
- Mark
http://www.lucidimagination.com
-
To
On Jun 16, 2009, at 7:16 PM, Yonik Seeley wrote:
On Tue, Jun 16, 2009 at 6:37 PM, Mark Millermarkrmil...@gmail.com
wrote:
There are parts that aren't strictly part of the release process IMO -
things like maven seem optional.
-1. Maven support is not optional.
+1 for more
Uwe Schindler wrote:
Maybe Mark helps me and I can do
it alone the next time, if I have to? :-)
Tag team effort ? It will be my first release to, so that would be great !
Ah ok, I interpreted your mail different yesterday (but it was 1 or 2 am in
Germany...).
Uwe
On Jun 15, 2009, at 2:11 PM, Grant Ingersoll wrote:
More questions:
1. What about Highlighter and MoreLikeThis? They have not been
converted. Also, what are they going to do if the attributes they
need are not available? Caveat emptor?
2. Same for TermVectors. What if the user
I have a special gift in not being clear.
I was just saying be prepared, your turn is coming ;)
But I havn't done a release myself - we don't release that often despite
discussion that we should release more often every year or so.
I did notice though, that Mike did the release right after
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-1630:
---
Attachment: LUCENE-1630.patch
* Collector's acceptDocsOutOfOrder is abstract - this was a really
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720676#action_12720676
]
Uwe Schindler commented on LUCENE-1693:
---
Hi Michael,
I did not do any performance
I agree.
I'm picturing some hopefully-not-that-distant future when we have a
queries module and analysis module that live quite separately from
Lucene Solr's core, and committers from both Solr and Lucene would
work on it.
Mike
On Wed, Jun 17, 2009 at 9:01 AM, Grant
On Wed, Jun 17, 2009 at 8:57 AM, Grant Ingersollgsing...@apache.org wrote:
On Jun 16, 2009, at 7:16 PM, Yonik Seeley wrote:
There are parts that aren't strictly part of the release process IMO -
things like maven seem optional.
-1. Maven support is not optional.
I can't always follow Lucene
On Jun 17, 2009, at 10:11 AM, Yonik Seeley wrote:
On Wed, Jun 17, 2009 at 8:57 AM, Grant
Ingersollgsing...@apache.org wrote:
On Jun 16, 2009, at 7:16 PM, Yonik Seeley wrote:
There are parts that aren't strictly part of the release process
IMO -
things like maven seem optional.
-1.
Let's not forget Nutch... Also, for that matter, Mahout uses Lucene's
Analysis and Core (in fact, I just committed MAHOUT-126 which allows
one to create Vectors from a Lucene index!), although those are just
as consumers, I doubt there is a need for Mahout committers to change
Lucene.
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720692#action_12720692
]
Shai Erera commented on LUCENE-1693:
You can run tokenize.alg which invokes the
[
https://issues.apache.org/jira/browse/LUCENE-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720696#action_12720696
]
Robert Muir commented on LUCENE-1692:
-
michael, ok. I know additional tests here
On 6/17/09 6:23 AM, Mark Miller wrote:
I have a special gift in not being clear.
I was just saying be prepared, your turn is coming ;)
But I havn't done a release myself - we don't release that often
despite discussion that we should release more often every year or so.
I did notice
Michael Busch wrote:
One?!? I did 2.2, 2.3, 2.3.1, 2.3.2!
What can you do ... there was no new guy to relieve you :)
--
- Mark
http://www.lucidimagination.com
-
To unsubscribe, e-mail:
Michael Busch wrote:
wanted to get 2.9 out really really soon.
really, really is probably not totally accurate. I just know how things
can get drawn out. Even still, we have 30 some issues to resolve. If we
don't make a drive though, when will 2.9 come out? Next fall at the
earliest? Later?
We should just not put more items in the 2.9 list anymore (except bug
fixes of course) and then fix the 30 issues and don't rush them too
much. If it takes until end of July I think that's acceptable. A good
quality of the release should be highest priority in my opinion.
Michael
On 6/17/09
That means the release frequency should not exceed the new-committer
frequency. :)
On 6/17/09 10:09 AM, Mark Miller wrote:
Michael Busch wrote:
One?!? I did 2.2, 2.3, 2.3.1, 2.3.2!
What can you do ... there was no new guy to relieve you :)
+1
Michael
On 6/17/09 10:32 AM, Mark Miller wrote:
Michael Busch wrote:
We should just not put more items in the 2.9 list anymore (except bug
fixes of course) and then fix the 30 issues and don't rush them too
much. If it takes until end of July I think that's acceptable. A good
quality of
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720794#action_12720794
]
Michael Busch commented on LUCENE-1693:
---
I'm looking at TokenStream.next():
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720809#action_12720809
]
Uwe Schindler commented on LUCENE-1693:
---
The code is almost identical to before, the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720811#action_12720811
]
Uwe Schindler commented on LUCENE-1693:
---
Ah I understand the problem: As I told, if
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720820#action_12720820
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Ah I understand the problem: As I
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720822#action_12720822
]
Uwe Schindler commented on LUCENE-1693:
---
I could change the calling chain:
[
https://issues.apache.org/jira/browse/LUCENE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Smith updated LUCENE-1625:
--
Attachment: CheckIndex.patch
Attached patch for exposing all collected stats
(created with svn diff
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720846#action_12720846
]
Uwe Schindler commented on LUCENE-1693:
---
I have a solution to build in some
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720849#action_12720849
]
Mark Miller commented on LUCENE-1693:
-
Should I wait to put in the Highlighter update
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720854#action_12720854
]
Uwe Schindler commented on LUCENE-1693:
---
bq. Should I wait to put in the Highlighter
Michael Busch wrote:
Everyone who is unhappy with the release TODO's, go back in your mail
archive to the 2.2 release and check how many tedious little changes
we made to improve the release quality. And besides the maven stuff,
there is not really more to do compared to pre-2.2, it's just
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720887#action_12720887
]
Michael Busch commented on LUCENE-1693:
---
I'm not convinced yet that we will be able
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1693:
--
Attachment: LUCENE-1693.patch
Here my solution: The three default methods are now optimized
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Busch updated LUCENE-1693:
--
Attachment: TestCompatibility.java
Slightly changes tool yields on 2.4 and identically on
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720913#action_12720913
]
Michael Busch commented on LUCENE-1693:
---
You can probably fix CachingTokenFilter and
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720919#action_12720919
]
Michael Busch commented on LUCENE-1693:
---
Btw: SinkTokenizer in my patch has a small
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720926#action_12720926
]
Uwe Schindler commented on LUCENE-1693:
---
Exactly: The problem is in SinkTokenizer.
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720952#action_12720952
]
Uwe Schindler commented on LUCENE-1693:
---
The second test does not work, because it
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1693:
--
Attachment: LUCENE-1693.patch
Small updates, before I go to sleep. This patch removes the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720984#action_12720984
]
Michael Busch commented on LUCENE-1693:
---
Go to bed, I'll review later... in meetings
[
https://issues.apache.org/jira/browse/LUCENE-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Rutherglen updated LUCENE-1313:
-
Attachment: LUCENE-1313.patch
The patch is cleaned up. A static variable
LogMergePolicy.findMergesToExpungeDeletes need to get deletes from the
SegmentReader
Key: LUCENE-1700
URL: https://issues.apache.org/jira/browse/LUCENE-1700
[
https://issues.apache.org/jira/browse/LUCENE-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721024#action_12721024
]
Jason Rutherglen commented on LUCENE-1700:
--
Taking a step back, maybe we can
[
https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1595:
Attachment: LUCENE-1595.patch
Added to changes a bit
Removed modification to core Document class
[
https://issues.apache.org/jira/browse/LUCENE-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1695:
Attachment: LUCENE-1695.patch
Pretty much done, all tests pass. It breaks back compat, but
[
https://issues.apache.org/jira/browse/LUCENE-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721044#action_12721044
]
Mark Miller commented on LUCENE-1628:
-
bq. mark, on the same topic: if possible, at
[
https://issues.apache.org/jira/browse/LUCENE-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721048#action_12721048
]
Mark Miller commented on LUCENE-1628:
-
Looks pretty good. Not sure if we should update
[
https://issues.apache.org/jira/browse/LUCENE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721052#action_12721052
]
Mark Miller commented on LUCENE-1599:
-
Well yuck.
SpanNearQuery does this clone call
[
https://issues.apache.org/jira/browse/LUCENE-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721054#action_12721054
]
Mark Miller commented on LUCENE-1696:
-
Patch looks good! I'll just hold off till the
[
https://issues.apache.org/jira/browse/LUCENE-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721057#action_12721057
]
Robert Muir commented on LUCENE-1628:
-
mark: thanks for the followup on the licenses!
[
https://issues.apache.org/jira/browse/LUCENE-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721061#action_12721061
]
Mark Miller commented on LUCENE-1628:
-
Okay, fair enough. I figured you'd know better
[
https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721078#action_12721078
]
Shai Erera commented on LUCENE-1595:
bq. I still want to run some tests with the
86 matches
Mail list logo
