Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

2018-02-10 Thread Jan Lahoda
* mailto:marti...@google.com>> Date: Sat, Feb 10, 2018 at 7:36 AM Subject: Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal To: Jonathan Gibbons mailto:jonathan.gibb...@oracle.com>> Cc: javadoc-dev mailto:javadoc-dev@openjdk.java.net>> I can confirm that it is this

Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

2018-02-10 Thread Jonathan Gibbons
Martin, Thanks for the investigation and the update.  Sorry for the inconvenience. -- Jon On 2/10/18 8:20 AM, Martin Buchholz wrote: OK, I get it now. jdk tip needs http://hg.openjdk.java.net/jdk/jdk10/rev/107413b070b9 *in the bootstrap* to bootstrap with jdk10, but that is coming out as par

Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

2018-02-10 Thread Martin Buchholz
OK, I get it now. jdk tip needs http://hg.openjdk.java.net/jdk/jdk10/rev/107413b070b9 *in the bootstrap* to bootstrap with jdk10, but that is coming out as part of jdk-10+43, which hasn't been released yet. So this will fix itself over time. I can confirm that jdk tip bootstraps with jdk 10 tip a

Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

2018-02-09 Thread Martin Buchholz
I can confirm that it is this commit: changeset: 48840:5e2d2067da48 tip user:ksrini date:2018-02-09 13:58 -0800 8194651: javadoc: mark the com.sun.javadoc API for removal Reviewed-by: jjg that causes a build failure when rebuilding from scratch. I bisected my configure flags -

Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

2018-02-09 Thread Jonathan Gibbons
Martin, I'm not hearing any CI alarm bells ringing here, and I've just completed a clean build of the latest bits in jdk/jdk repo. There was a related javac fix that went back a few days ago, from Jan Lahoda. Is it possible that either you didn't pick up that fix, or that you have a locally

Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

2018-02-09 Thread Kumar Srinivasan
Martin, Jon, Yes this one: https://bugs.openjdk.java.net/browse/JDK-8194764 When I filed the above bug, I could only reproduce the above only with langtools/make ant script, this issue never showed up while building the jdk, because of this http://hg.openjdk.java.net/jdk/jdk/file/5e2d2067da48

Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

2018-02-09 Thread Martin Buchholz
This seems to break the build * For target buildtools_interim_langtools_modules_jdk.javadoc.interim__the.BUILD_jdk.javadoc.interim_batch: /home/martin/ws/jdk/src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SourcePositionImpl.java:31: warning: [removal] SourcePosition in com.sun.javadoc ha

Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

2018-02-09 Thread Jonathan Gibbons
OK -- Jon On 1/23/18 2:02 PM, Kumar Srinivasan wrote: Hi, Please review fix for 8194651, https://bugs.openjdk.java.net/browse/JDK-8194651 Webrev: http://cr.openjdk.java.net/~ksrini/8194651/webrev.01/ Please note this is blocked by: JDK-8194764 Thanks Kumar

RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

2018-01-23 Thread Kumar Srinivasan
Hi, Please review fix for 8194651, https://bugs.openjdk.java.net/browse/JDK-8194651 Webrev: http://cr.openjdk.java.net/~ksrini/8194651/webrev.01/ Please note this is blocked by: JDK-8194764 Thanks Kumar