On Tue, 31 May 2022 23:43:34 GMT, Jonathan Gibbons wrote:
>> Please review a simple change for `SnippetUtils` to throw a checked
>> exception if a snippet cannot be found.
>
> Jonathan Gibbons has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webr
> Please review a simple change for `SnippetUtils` to throw a checked exception
> if a snippet cannot be found.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase.
On Tue, 31 May 2022 18:27:29 GMT, Jonathan Gibbons wrote:
> Looks good to me. I'm not sure the `requireNonNull` method carries its own
> weight given that one `getSnippetById` method could by implemented by calling
> the other, but that's a minor stylistic concern.
OK, I looked at this again,
On Tue, 31 May 2022 16:02:40 GMT, Hannes Wallnöfer wrote:
> Looks good to me. I'm not sure the `requireNonNull` method carries its own
> weight given that one `getSnippetById` method could by implemented by calling
> the other, but that's a minor stylistic concern.
Note that the `requireNonNul
On Wed, 25 May 2022 19:38:13 GMT, Jonathan Gibbons wrote:
> Please review a simple change for `SnippetUtils` to throw a checked exception
> if a snippet cannot be found.
Looks good to me. I'm not sure the `requireNonNull` method carries its own
weight given that one `getSnippetById` method cou
Please review a simple change for `SnippetUtils` to throw a checked exception
if a snippet cannot be found.
-
Commit messages:
- JDK-8287337: SnippetUtils should throw exceptions if snippets not found
Changes: https://git.openjdk.java.net/jdk/pull/8892/files
Webrev: https://webrev
