> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request with a new ta
On Tue, 21 Sep 2021 01:33:09 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into 826
>> - Improve markup error messages
>>
>> * C
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Mon, 20 Sep 2021 17:01:20 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
On Mon, 20 Sep 2021 17:01:20 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request with a new ta
On Mon, 13 Sep 2021 18:59:48 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/ParseException.java
>> line 50:
>>
>>> 48: * @param position the approximate position
>>> 49: */
>>> 50: public ParseException(String mes
On Mon, 13 Sep 2021 17:42:20 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove trailing whitespace to satisfy jcheck
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommen
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Tue, 14 Sep 2021 09:32:05 GMT, Pavel Rappo wrote:
>> src/jdk.compiler/share/classes/com/sun/source/util/SimpleDocTreeVisitor.java
>> line 460:
>>
>>> 458: * @return the result of {@code defaultAction}
>>> 459: * @since 18
>>> 460: */
>>
>> optional: reformat the latter part
On Mon, 13 Sep 2021 11:59:06 GMT, Hannes Wallnöfer wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove trailing whitespace to satisfy jcheck
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/
On Mon, 13 Sep 2021 17:32:38 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove trailing whitespace to satisfy jcheck
>
> src/jdk.compiler/share/classes/com/sun/source/util/SimpleDocTreeVis
On Mon, 13 Sep 2021 14:23:59 GMT, Hannes Wallnöfer wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove trailing whitespace to satisfy jcheck
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/
On Mon, 13 Sep 2021 18:34:59 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove trailing whitespace to satisfy jcheck
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/
On Thu, 9 Sep 2021 15:27:34 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> branc
On Fri, 20 Aug 2021 18:12:23 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
On Thu, 9 Sep 2021 13:40:20 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> branc
On Thu, 9 Sep 2021 15:27:34 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> branc
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request with a new ta
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request with a new ta
On Wed, 25 Aug 2021 21:50:34 GMT, Jonathan Gibbons wrote:
> So you're just suggesting that I should handle the parts related to
> tagletPath, right? If so, OK.
Yes, I am. I have created a separate bug, where I suggested a patch:
https://bugs.openjdk.java.net/browse/JDK-8273001
-
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Tue, 24 Aug 2021 21:56:05 GMT, Jonathan Gibbons wrote:
>> Generally impressive piece of work.
>
>> @jonathan-gibbons, do we need to mention the semantic change to
>> `com.sun.source.doctree.AttributeTree` in the release notes? Before this PR,
>> `AttributeTree` used to only represent HTML at
On Tue, 24 Aug 2021 21:56:05 GMT, Jonathan Gibbons wrote:
>> Generally impressive piece of work.
>
>> @jonathan-gibbons, do we need to mention the semantic change to
>> `com.sun.source.doctree.AttributeTree` in the release notes? Before this PR,
>> `AttributeTree` used to only represent HTML at
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has refreshed the contents of this pull re
On Wed, 25 Aug 2021 16:00:08 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has refreshed the contents of this pull re
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request with a new ta
On Tue, 24 Aug 2021 21:56:05 GMT, Jonathan Gibbons wrote:
> > @jonathan-gibbons, do we need to mention the semantic change to
> > `com.sun.source.doctree.AttributeTree` in the release notes? Before this
> > PR, `AttributeTree` used to only represent HTML attributes. After this PR
> > has been
On Tue, 24 Aug 2021 17:46:51 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
On Fri, 20 Aug 2021 18:42:53 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
On Fri, 20 Aug 2021 18:50:44 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request with a new ta
On Mon, 26 Jul 2021 14:31:27 GMT, Hannes Wallnöfer wrote:
> I would prefer if variables such as this that are used farther than a few
> lines from their definition had more meaningful names.
It's also confusing that `r` is a `String` but `r1`, `r2` (lines 209-211) are
`StyledText`
---
On Tue, 24 Aug 2021 13:14:57 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
On Fri, 20 Aug 2021 18:50:44 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
On Tue, 24 Aug 2021 11:30:54 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties
>> line 360:
>>
>>> 358:
>>> 359: doclet.tag.attribute.repeated=\
>>> 360: repeated attribute: "{0}"
>>
>> check the resource file for other
On Tue, 24 Aug 2021 10:24:35 GMT, Pavel Rappo wrote:
>> Since we are here, is there any langtools convention for when to collapse a
>> span of single-import declarations into an import-on-demand (.*) declaration?
>
> Fixed in a7cd155.
> Since we are here, is there any langtools convention for w
On Fri, 20 Aug 2021 18:11:05 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Fri, 20 Aug 2021 18:07:30 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
On Mon, 23 Aug 2021 18:03:51 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/SnippetTaglet.java
>> line 39:
>>
>>> 37: import jdk.javadoc.internal.doclets.toolkit.taglets.snippet.Parser;
>>> 38: import jdk.javadoc.internal.doclets.toolkit.ta
On Fri, 20 Aug 2021 18:13:32 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Fri, 20 Aug 2021 18:09:47 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
On Fri, 20 Aug 2021 18:46:43 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
On Mon, 23 Aug 2021 17:36:02 GMT, Jonathan Gibbons wrote:
>>> This discussion does not belong here.
>>
>> I've hoped to specify tag syntax before we push this PR. Until the syntax
>> has been specified, the comment has to be stored somewhere. What would be an
>> appropriate place to store that
On Mon, 23 Aug 2021 16:01:51 GMT, Pavel Rappo wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 923:
>>
>>> 921: * probably be considered on a case-by-case basis, for an
>>> attribute
>>> 922: * value of the {@snippet} tag we do
On Fri, 20 Aug 2021 18:25:02 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
On Fri, 20 Aug 2021 18:03:12 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Fri, 20 Aug 2021 17:54:37 GMT, Jonathan Gibbons wrote:
> This discussion does not belong here.
I've hoped to specify tag syntax before we push this PR. Until the syntax has
been specified, the comment has to be stored somewhere. What would be an
appropriate place to store that comment in?
On Fri, 20 Aug 2021 17:46:38 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Fri, 20 Aug 2021 17:49:03 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
On Fri, 20 Aug 2021 17:45:21 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass through FIXMEs and TODOs
>>
>> Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes
>
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request with a new ta
On Fri, 6 Aug 2021 12:24:06 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> branc
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Wed, 28 Jul 2021 14:40:55 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
On Wed, 28 Jul 2021 14:40:55 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
On Fri, 23 Jul 2021 20:13:56 GMT, Jonathan Gibbons wrote:
> the existing seeTagToContent handles all flavors of @see tag, and {@link}.
All but fake ones. The `seeTagToContent` method uses the path (`DocTreePath`)
of the `see` tag being passed. In the case of snippet markup, there's no such
tag
On Wed, 28 Jul 2021 15:31:11 GMT, liach
wrote:
>> Pavel Rappo has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Change AnnotatedText to StyledText
>>
>>Renames the class, removes its generic parameter, and changes the related
>
On Wed, 28 Jul 2021 14:40:55 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
On Mon, 26 Jul 2021 12:55:17 GMT, Hannes Wallnöfer wrote:
>> Pavel Rappo has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Change AnnotatedText to StyledText
>>
>>Renames the class, removes its generic parameter, and changes the
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Mon, 26 Jul 2021 15:25:03 GMT, Hannes Wallnöfer wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css
>> line 881:
>>
>>> 879: .bold {
>>> 880: font-weight: bold;
>>> 881: }
>>
>> Both the name and definition seem very global. Maybe it wo
On Tue, 27 Jul 2021 15:59:00 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/parser/Parser.java
>> line 275:
>>
>>> 273: throw new ParseException("Unexpected
>>> attributes", t.lineSourceOffset + t.markupLine
On Mon, 26 Jul 2021 17:05:45 GMT, Hannes Wallnöfer wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve comments
>>
>> This commit adds trivial commentary to some of the Java declarations. This
>> commit al
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Tue, 27 Jul 2021 11:06:35 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
Pavel Rappo has updated the pull request incrementally
On Fri, 23 Jul 2021 22:35:38 GMT, Jonathan Gibbons wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>>
On Thu, 15 Jul 2021 14:13:16 GMT, Pavel Rappo wrote:
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
The comments don't need to be of core-libs quality, but at least some of
the problems we have had in the code of late has been discerning the
original intent, so at least some amount of comment/documentation is
useful, even if we don't run it through javadoc or even doclint.
Think of the comme
On Fri, 23 Jul 2021 18:48:27 GMT, Jonathan Gibbons wrote:
> More feedback;
>
> 1. It seems reasonable to introduce the `...taglets.snippets` package. It
> seems excessive to have three sub packages within that, for `actions`,
> `parser` and `text`, especially when the last contains just a sin
On Thu, 15 Jul 2021 14:13:16 GMT, Pavel Rappo wrote:
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
On Thu, 15 Jul 2021 14:13:16 GMT, Pavel Rappo wrote:
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
On Thu, 15 Jul 2021 14:13:16 GMT, Pavel Rappo wrote:
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
On Thu, 15 Jul 2021 14:13:16 GMT, Pavel Rappo wrote:
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
On Thu, 15 Jul 2021 14:13:16 GMT, Pavel Rappo wrote:
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
> branch.
87 matches
Mail list logo
