On Wed, 19 Jun 2024 09:59:26 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
On Wed, 19 Jun 2024 09:59:26 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advance.
Nizar Benalla has updated the pull request with a new ta
On Fri, 14 Jun 2024 02:32:16 GMT, Nizar Benalla wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> whitespace
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line
> 695:
>
>> 693:
On Fri, 14 Jun 2024 19:16:26 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
On Fri, 14 Jun 2024 19:01:56 GMT, Chen Liang wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify method
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line
> 670:
>
>> 668:
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advance.
Nizar Benalla has updated the pull request incrementally
On Fri, 14 Jun 2024 19:00:41 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advance.
Nizar Benalla has updated the pull request incrementally
On Fri, 14 Jun 2024 12:15:45 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
On Tue, 11 Jun 2024 13:03:47 GMT, Pavel Rappo wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits
On Tue, 11 Jun 2024 22:12:42 GMT, Jonathan Gibbons wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> com
On Fri, 14 Jun 2024 12:12:51 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
On Wed, 12 Jun 2024 09:03:38 GMT, Hannes Wallnöfer wrote:
>> Wouldn't the easiest solution be to add a boolean `global`/`isGlobal` field
>> and getter to `Attr`?
>>
>> That would give use some more opportunities to simplify the code: We could
>> get rid of the `GLOBAL_ATTRS` map here *and* avo
On Wed, 12 Jun 2024 09:02:20 GMT, Hannes Wallnöfer wrote:
>> I suggest one of
>>
>> 1. Add a `boolean global;` member to the enum, and provide a second
>> constructor that allows that boolean member to be set true. For example,
>>
>> WIDTH,
>> STYLE(true),
>>
>>
>> 2. Make the `Set` be sta
On Tue, 11 Jun 2024 21:58:46 GMT, Jonathan Gibbons wrote:
>>> If we are ordering the entries, we can use comparable to check that an attr
>>> is greater than the start of the global attr, something like
>>>
>>> ```java
>>> private static boolean isGlobalAttr(Attr value) {
>>> return value.c
On Tue, 11 Jun 2024 13:41:58 GMT, Pavel Rappo wrote:
>> If we are ordering the entries, we can use comparable to check that an attr
>> is greater than the start of the global attr, something like
>>
>> private static boolean isGlobalAttr(Attr value) {
>> return value.compareTo(Attr.ACCESSKE
On Tue, 11 Jun 2024 12:40:23 GMT, Nizar Benalla wrote:
>> Either what Chen has suggested or re-sort the complete list alphabetically
>> as it was prior to this change, well, almost.
>
>> Either what Chen has suggested or re-sort the complete list alphabetically
>> as it was prior to this change
On Wed, 12 Jun 2024 09:26:25 GMT, Pavel Rappo wrote:
>> I admit to being "lazy" when I wrote `startsWith("on")`. In general, I don't
>> think folk should be writing many if any event handlers in doc comments, and
>> it was easier to give forward compatibility with a weak test for `"on"`.
>> Li
On Tue, 11 Jun 2024 23:49:15 GMT, Jonathan Gibbons wrote:
>> As @jonathan-gibbons likes to point out, javadoc is not an HTML validation
>> tool. So I think, it's okay to leave the code simple. Maybe this would be
>> even simpler?
>>
>> data-[a-z][-a-z0-9]*
>
> I admit to being "lazy" when
On Tue, 11 Jun 2024 15:09:03 GMT, Pavel Rappo wrote:
>> I think like being slightly restrictive and safe.
>
> As @jonathan-gibbons likes to point out, javadoc is not an HTML validation
> tool. So I think, it's okay to leave the code simple. Maybe this would be
> even simpler?
>
> data-[a-z
On Tue, 11 Jun 2024 14:42:48 GMT, Nizar Benalla wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line
>> 695:
>>
>>> 693: // custom "data-*" attributes are also accepted
>>> 694: var attrName=name.toString();
>>> 695: if (!att
On Tue, 11 Jun 2024 13:24:48 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
On Tue, 11 Jun 2024 13:26:28 GMT, Pavel Rappo wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits
On Fri, 14 Jun 2024 12:12:51 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advance.
Nizar Benalla has updated the pull request with a new ta
On Tue, 11 Jun 2024 13:35:31 GMT, Chen Liang wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line
>> 556:
>>
>>> 554: }
>>> 555:
>>> 556: private final EnumSet GLOBAL_ATTRS = EnumSet.of(
>>
>> I get it, you cannot make it static because it's used in a
On Tue, 11 Jun 2024 12:45:10 GMT, Pavel Rappo wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove classpath exception
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line
> 556:
>
On Tue, 11 Jun 2024 13:24:48 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advance.
Nizar Benalla has updated the pull request incrementa
On Tue, 11 Jun 2024 11:37:27 GMT, Nizar Benalla wrote:
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advanc
On Tue, 11 Jun 2024 12:37:46 GMT, Pavel Rappo wrote:
> Either what Chen has suggested or re-sort the complete list alphabetically as
> it was prior to this change.
I will go with Chen's suggestions, will fix in a bit.
I might move STYLE down as it's also a global tag
-
PR Review
On Tue, 11 Jun 2024 11:51:05 GMT, Chen Liang wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
On Tue, 11 Jun 2024 11:37:27 GMT, Nizar Benalla wrote:
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advanc
34 matches
Mail list logo
