On Thu, 25 Aug 2022 19:55:47 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
>> If you already are an OpenJDK
>> [Author](https://openjdk.java.net/bylaws#author),
>> [Committer](https://openjdk.java.net/bylaws#committer) or
>> [Reviewe
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
Hello Michael,
> > these changes are mostly fine.
>
> Can you be specific about the exact problems that you noticed that prevented
> you from saying "these chan
On Thu, 27 Oct 2022 11:24:32 GMT, Daniel Fuchs wrote:
>> How about `_unused` or `_unused1`, `_unused2` then in the meantime?
>
> I'd be happy to make the change. Let's wait to see if anybody has a better
> naming suggestion.
Hello Daniel, I think calling it `unused` is fine. I did a quick searc
On Wed, 26 Oct 2022 17:51:31 GMT, Daniel Fuchs wrote:
>> I see your point. It may be more appropriate if URI.toURL was designed as
>> URL.fromURL.
>>
>> I was wondering to have application developers a consistent way to get an
>> URL instance. Now there are two methods in different classes U
On Sun, 27 Nov 2022 17:49:57 GMT, Michael Ernst wrote:
> Could someone who knows the undocumented ins and outs of creating JDK pull
> requests could split this pull request up into multiple PRs? Then it can be
> merged, rather than wasting all the effort that went into it.
I've raised https://
Can I please get a review of this change which fixes some typos in the
`test/langtools` files? This was originally raised by @mernst in
https://github.com/openjdk/jdk/pull/10029, but given that the other PR touches
multiple other areas and files, progress was stalled.
The commit in this PR only
On Mon, 28 Nov 2022 10:06:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes some typos in the
> `test/langtools` files? This was originally raised by @mernst in
> https://github.com/openjdk/jdk/pull/10029, but given that the other PR
> touches mu
On Mon, 28 Nov 2022 10:06:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes some typos in the
> `test/langtools` files? This was originally raised by @mernst in
> https://github.com/openjdk/jdk/pull/10029, but given that the other PR
> touches mu
On Wed, 4 Oct 2023 05:36:54 GMT, KIRIYAMA Takuya wrote:
>> KIRIYAMA Takuya has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> com
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote:
>> I modified the location from which javadoc copies some legal files to the
>> generated documentation. If --legal-notices option is set to default or
>> nothing is specified,, GPLv2 Legal Documents are copied from
>> legal/java.base/
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote:
>> I modified the location from which javadoc copies some legal files to the
>> generated documentation. If --legal-notices option is set to default or
>> nothing is specified,, GPLv2 Legal Documents are copied from
>> legal/java.base/
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote:
>> I modified the location from which javadoc copies some legal files to the
>> generated documentation. If --legal-notices option is set to default or
>> nothing is specified,, GPLv2 Legal Documents are copied from
>> legal/java.base/
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote:
>> I modified the location from which javadoc copies some legal files to the
>> generated documentation. If --legal-notices option is set to default or
>> nothing is specified,, GPLv2 Legal Documents are copied from
>> legal/java.base/
On Tue, 1 Apr 2025 16:25:58 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to clean up
> some issues noticed in the `TestRedirectLinks.java` test?
>
> The `javadoc/doclet/testLinkOption/TestRedirectLinks.java` test has bee
On Wed, 2 Apr 2025 01:41:27 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which proposes to clean
>> up some issues noticed in the `TestRedirectLinks.java` test?
>>
>> The `javadoc/doclet/testLinkOption/TestRedirectLinks.java` t
Can I please get a review of this test-only change which proposes to clean up
some issues noticed in the `TestRedirectLinks.java` test?
The `javadoc/doclet/testLinkOption/TestRedirectLinks.java` test has been
failing intermittently in our CI. The root cause of those failures isn't yet
clear and
ing the `sendResponseHeaders()` method.
>
> The test continues to pass with this change. We will continue investigating
> the intermittent failure if/when it occurs again after this change.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the
On Wed, 16 Apr 2025 04:03:24 GMT, SendaoYan wrote:
> Hi all,
>
> The newly added test jdk/javadoc/doclet/testUnexported/TestUnexported.java
> javac build fails. This PR add depedencies to make javac build success.
> Test-fix only, change has been verified locally, no risk.
Marked as reviewed
On Wed, 16 Apr 2025 04:03:24 GMT, SendaoYan wrote:
> Hi all,
>
> The newly added test jdk/javadoc/doclet/testUnexported/TestUnexported.java
> javac build fails. This PR add depedencies to make javac build success.
> Test-fix only, change has been verified locally, no risk.
Hello @sendaoYan, c
Can I please get a review of this problemlisting change which problem lists the
`tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java`
test? This test has been failing regularly in our CI in tier2.
I have tier2 run in progress and I'll integrate this change once that run
On Tue, 24 Jun 2025 04:29:16 GMT, Jaikiran Pai wrote:
> Can I please get a review of this problemlisting change which problem lists
> the
> `tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java`
> test? This test has been failing regularly in our CI in t
On Fri, 30 May 2025 09:51:23 GMT, Matthias Baesken wrote:
> Make langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java
> intermittent, add the respective keyword.
> The test fails sometimes, see e.g. JDK-8338439 .
Looks OK and trivial to me.
-
Marked as reviewed by jp
On Tue, 17 Jun 2025 15:22:24 GMT, Nizar Benalla wrote:
> Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved,
> JavaBaseCheckSince no longer needs to be problemlisted.
Hello Nizar, if I understand correctly, this problem listing can be removed and
the PR integrated once the merge conf
On Tue, 24 Jun 2025 04:29:16 GMT, Jaikiran Pai wrote:
> Can I please get a review of this problemlisting change which problem lists
> the
> `tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java`
> test? This test has been failing regularly in our CI in t
24 matches
Mail list logo
