Sorry, it was my mistake, I pushed changes without build failure correction.
May I push a fix for this into the same repo?
Thanks,
Andrew
On 3/7/2013 5:20 PM, Seán Coffey wrote:
Yes - you're right. That does look like an issue. Andrew Brygin ran
pre integration tests before pushing the changes
Hello,
please review a fix for the build failure:
http://cr.openjdk.java.net/~bae/8009641/webrev.00/
Thanks,
Andrew
On 3/7/2013 5:55 PM, Seán Coffey wrote:
Even better if you want to push the change ? I haven't heard from
Andrew B. yet.
I've logged 8009641 to track this. You could use tha
Hi Andrew,
thanks for the review. I am pushing the change.
Sorry for the mess.
Thanks,
Andrew
On 3/7/2013 7:12 PM, Andrew Hughes wrote:
- Original Message -
Hello,
please review a fix for the build failure:
http://cr.openjdk.java.net/~bae/8009641/webrev.00/
Looks good to
- Original Message -
> Hi Andrew,
>
> thanks for the review. I am pushing the change.
>
> Sorry for the mess.
>
It's ok. I'm still baffled that javac misses it. I was able to build with
OpenJDK6,
just not with IcedTea's bootstrapping setup, which uses ecj.
Thanks for the quick f
- Original Message -
> Hello,
>
> please review a fix for the build failure:
>
> http://cr.openjdk.java.net/~bae/8009641/webrev.00/
>
Looks good to me and better than what I had as the synchronized blocks were
still outside the try
(so the variables could end up being null).
Ok to
Even better if you want to push the change ? I haven't heard from Andrew
B. yet.
I've logged 8009641 to track this. You could use that ID if you want.
8009641: OpenJDK 6 build broken via 8007675 fix
regards,
Sean.
On 07/03/2013 13:51, Andrew Hughes wrote:
- Original Message -
Yes
- Original Message -
> Yes - you're right. That does look like an issue. Andrew Brygin ran
> pre
> integration tests before pushing the changes internally and they were
> successful. However - I've traced back over the sources and what was
> run
> in his test build and what he pushed to
Yes - you're right. That does look like an issue. Andrew Brygin ran pre
integration tests before pushing the changes internally and they were
successful. However - I've traced back over the sources and what was run
in his test build and what he pushed to internal repo differs. ( in 2
areas) -
- Original Message -
> - Original Message -
> > I'm only the proxy here but I created the webrev from the
> > changesets
> > that I pushed. I don't see any difference.
> >
> > t4 $diff LCMSTransform.java.webrev
> > jdk/src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
> > t4
- Original Message -
> I'm only the proxy here but I created the webrev from the changesets
> that I pushed. I don't see any difference.
>
> t4 $diff LCMSTransform.java.webrev
> jdk/src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
> t4 $
>
Indeed. I'm still seeing the same failu
I'm only the proxy here but I created the webrev from the changesets
that I pushed. I don't see any difference.
t4 $diff LCMSTransform.java.webrev
jdk/src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
t4 $
regards,
Sean.
On 07/03/2013 10:59, Andrew Hughes wrote:
- Original Messag
- Original Message -
> February CPU pushes completed as reviewed in last round of webrevs.
>
> I'd like to push 2 extra fixes now for issues addressed in
> yesterday's
> JDK releases.
>
> webrev : http://cr.openjdk.java.net/~coffeys/webrev.6open.mar5/
>
> Good to push ?
>
> regards,
> S
On 03/05/2013 03:02 PM, Seán Coffey wrote:
> February CPU pushes completed as reviewed in last round of webrevs.
>
> I'd like to push 2 extra fixes now for issues addressed in yesterday's
> JDK releases.
>
> webrev : http://cr.openjdk.java.net/~coffeys/webrev.6open.mar5/
The only difference I se
February CPU pushes completed as reviewed in last round of webrevs.
I'd like to push 2 extra fixes now for issues addressed in yesterday's
JDK releases.
webrev : http://cr.openjdk.java.net/~coffeys/webrev.6open.mar5/
Good to push ?
regards,
Sean.
On 05/03/2013 18:44, Omair Majid wrote:
On
On 03/05/2013 10:52 AM, Edvard Wendelin wrote:
> Hi,
>
> The change in JAXP can be viewed here:
> http://cr.openjdk.java.net/~joehw/jdk8/8001235/webrev/ While it's
> generated against JDK 8, the change in 6 is identical.
The JAXP changes look identical to what was pushed to jdk7u. Looks all
goo
Hi,
The change in JAXP can be viewed here:
http://cr.openjdk.java.net/~joehw/jdk8/8001235/webrev/ While it's
generated against JDK 8, the change in 6 is identical. I plan to push
the changes today.
Cheers,
Edvard
On 02/20/2013 09:39 PM, Omair Majid wrote:
Hi Edvard,
Sorry, I accidentally
Hi Edvard,
Sorry, I accidentally sent this off-list the first time.
On 02/12/2013 03:44 AM, Edvard Wendelin wrote:
> Here is an updated webrev: http://cr.openjdk.java.net/~ewendeli/6ssr.2/
I compared this with what we added to icedtea6 and it looks fine to me.
Is it customary to have the jaxp
Hi,
Here is an updated webrev: http://cr.openjdk.java.net/~ewendeli/6ssr.2/
/Edvard
On Feb 7, 2013, at 1:03 PM, Edvard Wendelin wrote:
> Hi,
>
> Ẃith Oracle Java SE Critical Patch Update live, I'm now requesting approval
> to push the changes into jdk6-open.
>
> webrev: http://cr.openjdk.j
On 02/07/2013 02:08 PM, Edvard Wendelin wrote:
> I'll look into the headers and generate a new webrev.
Hi Edvard,
This has gone very quiet. What's up?
Thanks,
Andrew.
> On 02/07/2013 02:14 PM, Andrew Hughes wrote:
>> I haven't reviewed the whole thing but the following files are missing
>> l
I'll look into the headers and generate a new webrev.
Thanks,
Edvard
On 02/07/2013 02:14 PM, Andrew Hughes wrote:
I haven't reviewed the whole thing but the following files are missing license
headers:
jdk/test/javax/swing/Security/7186948/bug7186948.java
jdk/test/javax/swing/Security/720
- Original Message -
> Hi,
>
> Ẃith Oracle Java SE Critical Patch Update live, I'm now requesting
> approval to push the changes into jdk6-open.
>
> webrev: http://cr.openjdk.java.net/~ewendeli/6ssr/
>
> Please review.
>
> Thanks,
> Edvard
>
I haven't reviewed the whole thing but the
Hi,
Ẃith Oracle Java SE Critical Patch Update live, I'm now requesting
approval to push the changes into jdk6-open.
webrev: http://cr.openjdk.java.net/~ewendeli/6ssr/
Please review.
Thanks,
Edvard
22 matches
Mail list logo
