Re: Java DirectByteBuffer and OOM

2015-08-10 Thread Ivan Gerasimov
Hi Biju! I'll see if I can backport that change to jdk8u. Sincerely yours, Ivan On 10.08.2015 19:57, Biju G.S Nair wrote: Thanks Andrew for the response. Hi JDK8 development team, Could you please back port and merge the patch https://bugs.openjdk.java.net/browse/JDK-6857566 in JDK 8. T

hg: jdk7u/jdk7u-dev/jdk: 8068338: Better message about incompatible zlib in Deflater.init

2014-12-30 Thread ivan . gerasimov
Changeset: bc0ed44ecd01 Author:igerasim Date: 2014-12-30 00:11 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/bc0ed44ecd01 8068338: Better message about incompatible zlib in Deflater.init Reviewed-by: alanb, sherman ! src/share/native/java/util/zip/Deflater.c

[7u-dev] Request for approval to backport: 8068338: Better message about incompatible zlib in Deflater.init

2014-12-29 Thread Ivan Gerasimov
Hi! Would you please approve backporting of this cleanup fix? Unshuffled patch applies cleanly. Jdk8 backport request in in process. Bug: https://bugs.openjdk.java.net/browse/JDK-8068338 Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/be91019db7bd Review: http://mail.openjdk.java.ne

hg: jdk7u/jdk7u-dev/jdk: 8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so

2014-12-29 Thread ivan . gerasimov
Changeset: fd9a9a1bc88f Author:igerasim Date: 2014-12-30 00:27 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/fd9a9a1bc88f 8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so Summary: Define FILES_m to force use of linker script Reviewed-by:

[7u-dev] Request for approval to backport: 8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so

2014-12-29 Thread Ivan Gerasimov
Hi! Would you please approve backporting this fix to jdk7u? The fix applies cleanly. This should help resolve test failures with fastdebug builds of jdk (JDK-8068230). Bug: https://bugs.openjdk.java.net/browse/JDK-8008759 Jdk8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/14e49a7072

hg: jdk7u/jdk7u-dev/jdk: 8064846: Lazy-init thread safety problems in core reflection

2014-12-19 Thread ivan . gerasimov
Changeset: 0750f6a0eaa6 Author:igerasim Date: 2014-12-19 21:54 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0750f6a0eaa6 8064846: Lazy-init thread safety problems in core reflection Summary: Make several fields in core reflection volatile Reviewed-by: jfranck, shade

[7u-dev] Request for Review + Request for Approval to Backport: 8064846: Lazy-init thread safety problems in core reflection

2014-12-19 Thread Ivan Gerasimov
Hello! This is a request to approve the partial backport of the fix JDK-8064846. The backport is very similar to the one for jdk8u. I only had to modify GenericDeclRepository.java a bit due to omitted generics. Tested with JPRT with jdk_lang subset of tests. No failures introduced. jdk7u webr

hg: jdk7u/jdk7u-dev/hotspot: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-04 Thread ivan . gerasimov
Changeset: d386e11a4db3 Author:igerasim Date: 2014-12-04 22:12 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/d386e11a4db3 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs Reviewed-by: mchung ! src/share/vm/runtime/arguments.cpp ! test/r

Re: [7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-03 Thread Ivan Gerasimov
On 04.12.2014 2:44, Mandy Chung wrote: On 12/3/2014 1:00 PM, Ivan Gerasimov wrote: WEBREV: http://cr.openjdk.java.net/~igerasim/8065765/0/webrev/ Another alternative is to use Files.newDirectoryStream(path, "*.jar") and increment the count. What you have is okay too. Yes, th

Re: [7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-03 Thread Ivan Gerasimov
/ Sincerely yours, Ivan On 03.12.2014 23:10, Ivan Gerasimov wrote: Hi! Would you please approve this direct backport from 8 to 7? Bug: https://bugs.openjdk.java.net/browse/JDK-8065765 Jdk8 changeset: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/c03d85ef5e6a Jdk8 Review: http

Re: [7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-03 Thread Ivan Gerasimov
On 03.12.2014 23:10, Ivan Gerasimov wrote: Hi! Would you please approve this direct backport from 8 to 7? Correction! In the test, lambda needs to be replaced with an anonymous class. Bug: https://bugs.openjdk.java.net/browse/JDK-8065765 Jdk8 changeset: http://hg.openjdk.java.net/jdk8u

[7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-03 Thread Ivan Gerasimov
Hi! Would you please approve this direct backport from 8 to 7? Bug: https://bugs.openjdk.java.net/browse/JDK-8065765 Jdk8 changeset: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/c03d85ef5e6a Jdk8 Review: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-December/002618.html Sincer

hg: jdk7u/jdk7u-dev/jdk: 8062771: Core reflection should use final fields whenever possible

2014-11-28 Thread ivan . gerasimov
Changeset: 5c00040ffa9c Author:igerasim Date: 2014-11-28 23:21 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/5c00040ffa9c 8062771: Core reflection should use final fields whenever possible Reviewed-by: martin, jfranck ! src/share/classes/sun/reflect/BootstrapConstru

[7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection

2014-11-28 Thread Ivan Gerasimov
Hello! Would you please approve the backport from jdk 8u to 7u? The patch didn't apply cleanly due to generics in these two files: src/share/classes/sun/reflect/BootstrapConstructorAccessorImpl.java src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java All the other changes are ident

hg: jdk7u/jdk7u-dev/jdk: 8001579: Cleanup warnings in security native code

2014-11-27 Thread ivan . gerasimov
Changeset: b2a3cf632477 Author:igerasim Date: 2014-11-27 20:22 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b2a3cf632477 8001579: Cleanup warnings in security native code Reviewed-by: chegar, alanb, vinnie ! src/share/native/sun/security/jgss/wrapper/GSSLibStub.c !

[7u-dev] Request for Approval: 8001579: Cleanup warnings in security native code

2014-11-27 Thread Ivan Gerasimov
Hello! Would you please give me an approval to backport the fix for JDK-8001579? I have a strong belief this will fix an 'access violation' bug JDK-8049839 that was reported several times for jdk7. The patch applies cleanly. BUG: https://bugs.openjdk.java.net/browse/JDK-8001579 Jdk8 change:

hg: jdk7u/jdk7u-dev/jdk: 8064391: More thread safety problems in core reflection

2014-11-26 Thread ivan . gerasimov
Changeset: 4728d748209d Author:igerasim Date: 2014-11-26 20:47 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/4728d748209d 8064391: More thread safety problems in core reflection Summary: Make fields final or volatile to ensure thread safety Reviewed-by: jfranck ! sr

[7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection

2014-11-26 Thread Ivan Gerasimov
Hello! Would you please approve the (almost) direct backport from jdk 8u to 7u? The difference, comparing to 8u changeset, is due to change in Class.java, (which is already there in 8) and in GenericDeclRepository.java due to genericification. The patch is essentially the same as the one pr

hg: jdk7u/jdk7u-dev/hotspot: 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8

2014-11-24 Thread ivan . gerasimov
Changeset: f49c3e79b676 Author:igerasim Date: 2014-11-24 16:33 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/f49c3e79b676 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 Reviewed-by: coleenp, ccheung ! src/share/vm/runtime/arguments.cpp ! src/share/vm/ru

Re: [7u-dev] Request for Approval: 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8

2014-11-23 Thread Ivan Gerasimov
21:52, Rob McKenna wrote: Approved. -Rob On 22/11/14 22:00, Ivan Gerasimov wrote: Hello! Would you please approve backporting this fix to 7u-dev? The patch applies cleanly. CCC in its final state. Bug: https://bugs.openjdk.java.net/browse/JDK-8064667 Jdk8 change: http://hg.openjdk.jav

[7u-dev] Request for Approval: 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8

2014-11-22 Thread Ivan Gerasimov
Hello! Would you please approve backporting this fix to 7u-dev? The patch applies cleanly. CCC in its final state. Bug: https://bugs.openjdk.java.net/browse/JDK-8064667 Jdk8 change: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/fa6adc194d48 Jdk9 change: N/A (only 7 and 8) Review: http:/

hg: jdk7u/jdk7u-dev/jdk: 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming

2014-11-21 Thread ivan . gerasimov
Changeset: cc7c09cc2393 Author:igerasim Date: 2014-11-21 11:08 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/cc7c09cc2393 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming Reviewed-by: michaelm ! src/share/classes/sun/net/www/ht

[7u-dev] Request for Approval: 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming

2014-11-20 Thread Ivan Gerasimov
Hello! Would you please approve backporting this fix to jdk7u-dev? The change from jdk8 applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8050983 Jdk8 change: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b0e7095469b3 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/48

Re: [7u76] 8051614: smartcardio TCK tests fail due to lack of 'reset' permission

2014-10-28 Thread Ivan Gerasimov
Thanks Seán! Pushed to 7u-dev. Sincerely yours, Ivan On 28.10.2014 13:26, Seán Coffey wrote: jdk7u-dev is gathering fixes for 7u80. Approved. regards, Sean. On 28/10/2014 04:27, Ivan Gerasimov wrote: Hello! I'm looking for an approval to backport the fix into 7u-dev repository. Th

hg: jdk7u/jdk7u-dev/jdk: 8051614: smartcardio TCK tests fail due to lack of 'reset' permission

2014-10-28 Thread ivan . gerasimov
Changeset: acb5d48ed0da Author:coffeys Date: 2014-07-23 20:14 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/acb5d48ed0da 8051614: smartcardio TCK tests fail due to lack of 'reset' permission Reviewed-by: valeriep ! src/share/classes/sun/security/smartcardio/CardImpl

[7u76] 8051614: smartcardio TCK tests fail due to lack of 'reset' permission

2014-10-27 Thread Ivan Gerasimov
Hello! I'm looking for an approval to backport the fix into 7u-dev repository. The fix applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8051614 (marked confidential due to links in the description) Jdk8 changeset: http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/raw-rev/19ace77dfffc Re

hg: jdk7u/jdk7u-dev/jdk: 8057530: (process) Runtime.exec throws garbled message in jp locale; ...

2014-10-24 Thread ivan . gerasimov
Changeset: 6c4164200421 Author:igerasim Date: 2014-10-24 19:38 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6c4164200421 8057530: (process) Runtime.exec throws garbled message in jp locale 8016579: (process) IOException thrown by ProcessBuilder.start() method is in

Re: [7u-dev ONLY] RFR: [8057530] (process) Runtime.exec throws garbled message in jp locale

2014-10-24 Thread Ivan Gerasimov
Thanks Alan! On 24.10.2014 12:33, Alan Bateman wrote: On 24/10/2014 03:52, Ivan Gerasimov wrote: Thanks Dalibor! Could someone with the Reviewer status review this please Skimming through the changes then I don't see any issues, except overly long lines in win32Error which makes it ha

Re: [7u-dev ONLY] RFR: [8057530] (process) Runtime.exec throws garbled message in jp locale

2014-10-23 Thread Ivan Gerasimov
Thanks Dalibor! Could someone with the Reviewer status review this please? Sincerely yours, Ivan On 23.10.2014 18:07, dalibor topic wrote: Approved pending positive review. On 21.10.2014 08:36, Ivan Gerasimov wrote: Hello everybody! This is a request for review of a fix which is

[7u-dev ONLY] RFR: [8057530] (process) Runtime.exec throws garbled message in jp locale

2014-10-20 Thread Ivan Gerasimov
Hello everybody! This is a request for review of a fix which is applicable to 7u only. The issue has already been addressed in 8 and later releases. The fix is a combined backport of https://bugs.openjdk.java.net/browse/JDK-8016579 , which addresses the problem with the encoding in windows cons

hg: jdk7u/jdk7u-dev/jdk: 8059563: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-08 Thread ivan . gerasimov
Changeset: 44ef857dd5e6 Author:igerasim Date: 2014-10-09 10:24 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/44ef857dd5e6 8059563: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories Reviewed-by: mchung ! src/share/classes/sun/

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-08 Thread Ivan Gerasimov
Thank you Mandy! Seems like I managed to skip the mailing lists when sending the 3rd version of the review. Sorry about that. Sincerely yours, Ivan On 09.10.2014 9:56, Mandy Chung wrote: http://cr.openjdk.java.net/~igerasim/8059563/3/webrev/ I reviewed v3 version. Looks good. Mandy

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-08 Thread Ivan Gerasimov
Thanks Mandy! Nit: I suggest to remove the directory "a" at the beginning rather than throwing a RuntimeException so that you can run the test multiple times manually. Yes, makes sense. Here's the updated webrev: http://cr.openjdk.java.net/~igerasim/8059563/2/webrev/ Sincerely yours, Ivan

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-07 Thread Ivan Gerasimov
/2014 4:35 AM, Ivan Gerasimov wrote: Hello! This is a 7u-only fix. Some users complain about the ProxyGenerator not creating the intermediate directories when asked to keep the generated files. It throws an IO exception instead The fix is essentially a part of JDK-8004260. That was a rela

RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

2014-10-06 Thread Ivan Gerasimov
Hello! This is a 7u-only fix. Some users complain about the ProxyGenerator not creating the intermediate directories when asked to keep the generated files. It throws an IO exception instead The fix is essentially a part of JDK-8004260. That was a relatively big update, which required CCC, so

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Ivan Gerasimov
Thank you Daniel and Chris for your review! Sincerely yous, Ivan Please see the updated webrev: http://cr.openjdk.java.net/~igerasim/8059101/1/webrev/ This looks ok to me.

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Ivan Gerasimov
On 25.09.2014 14:18, Daniel Fuchs wrote: Hi Ivan, Should 'usage' also be redirected? This would be inconsistent with other command line utilities. They usually print help/usage to stdout. Sincerely yours, Ivan best regards, -- daniel On 25/09/14 12:12, Ivan Gerasimov wrote:

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Ivan Gerasimov
Thank you Daniel for the comments! On 25.09.2014 13:49, Daniel Fuchs wrote: Hi Ivan, When setting output & input, I wonder if it would be simpler to use an 'if else if' construct in order to avoid the '-a' in the 'if' that follows. We would still need that -a in if, as the user could pass /dev

RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Ivan Gerasimov
Hello! This is a proposal to enhance the unshuffle_patch.sh script so that it will be able to read from stdin and write to stdout. This would let us use the script in a pipe chain. For example, the following line could be used to apply a patch directly from a remote repository: wget -q -O - h

hg: jdk7u/jdk7u-dev/jdk: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM

2014-09-18 Thread ivan . gerasimov
Changeset: 6b53b16c1641 Author:igerasim Date: 2014-09-17 23:52 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6b53b16c1641 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM Summary: Try to resize to "well-known" hotspot max array si

hg: jdk7u/jdk7u-dev/jdk: 7010989: Duplicate closure of file descriptors leads to unexpected and incorrect closure of sockets

2014-09-11 Thread ivan . gerasimov
Changeset: 22b4d5ebccb3 Author:igerasim Date: 2014-09-09 19:02 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/22b4d5ebccb3 7010989: Duplicate closure of file descriptors leads to unexpected and incorrect closure of sockets Reviewed-by: chegar ! src/windows/native/ja

hg: jdk7u/jdk7u-dev/jdk: 7058832: com/sun/net/httpserver/bugs/B6373555.java failing intermittently

2014-08-29 Thread ivan . gerasimov
Changeset: 0032f33fdc47 Author:igerasim Date: 2014-08-29 17:13 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0032f33fdc47 7058832: com/sun/net/httpserver/bugs/B6373555.java failing intermittently Reviewed-by: alanb ! test/com/sun/net/httpserver/bugs/B6373555.java

[7u-dev] Request for Approval: 7058832: com/sun/net/httpserver/bugs/B6373555.java failing intermittently

2014-08-28 Thread Ivan Gerasimov
Hello! Would you please approve unaltered backport of this test fix? The test was reported to still fail with the earlier releases of jdk. Bug: https://bugs.openjdk.java.net/browse/JDK-7058832 Jdk8/9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/raw-rev/7b5a0a141b8b Reviewed-by: alanb, bu

hg: jdk7u/jdk7u-dev/jdk: 8017212: File.createTempFile requires unnecessary "read" permission

2014-08-28 Thread ivan . gerasimov
Changeset: 2df9079cfbd9 Author:igerasim Date: 2014-08-28 18:39 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/2df9079cfbd9 8017212: File.createTempFile requires unnecessary "read" permission Reviewed-by: alanb ! src/share/classes/java/io/File.java + test/java/io/File

hg: jdk7u/jdk7u-dev/jdk: 8055421: (fs) bad error handling in java.base/unix/native/libnio/fs/UnixNativeDispatcher.c

2014-08-26 Thread ivan . gerasimov
Changeset: fd940a08ec2d Author:igerasim Date: 2014-08-26 15:55 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/fd940a08ec2d 8055421: (fs) bad error handling in java.base/unix/native/libnio/fs/UnixNativeDispatcher.c Reviewed-by: martin, alanb ! src/solaris/native/sun/

[7u-dev] Request for Approval: 8055421: (fs) bad error handling in java.base/unix/native/libnio/fs/UnixNativeDispatcher.c

2014-08-26 Thread Ivan Gerasimov
Hello! Would you please approve backport of this recent fix from jdk9. Unshuffled patch from jdk9 applies cleanly. Patch from jdk8u applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8055421 Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/431163ee6141 Jdk8 changeset: htt

hg: jdk7u/jdk7u-dev/jdk: 8055731: sun/security/smartcardio/TestDirect.java throws java.lang.IndexOutOfBoundsException

2014-08-25 Thread ivan . gerasimov
Changeset: 140a7fe18d66 Author:igerasim Date: 2014-08-23 01:05 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/140a7fe18d66 8055731: sun/security/smartcardio/TestDirect.java throws java.lang.IndexOutOfBoundsException Reviewed-by: valeriep ! test/sun/security/smartcar

[7u-dev] Request for approval: 8055731: sun/security/smartcardio/TestDirect.java throws java.lang.IndexOutOfBoundsException

2014-08-22 Thread Ivan Gerasimov
Hello! Would you please approve backport of this unaltered manual test fix? Bug: https://bugs.openjdk.java.net/browse/JDK-8055731 Review: http://mail.openjdk.java.net/pipermail/security-dev/2014-August/011058.html Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/6931bc291000 Sincerely

hg: jdk7u/jdk7u-dev/jdk: 4 new changesets

2014-08-18 Thread ivan . gerasimov
Changeset: 434a2dde9c21 Author:igerasim Date: 2014-08-18 17:14 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/434a2dde9c21 8009258: TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently Reviewed-by: dxu, alanb Contributed-by: yiming.w...@oracle.com ! test

[7u-dev] Request for approval to backport 8009258, 8015628, 4792059, 8028631

2014-08-18 Thread Ivan Gerasimov
Hello! Would you please approve backporting these four test bug fixes? All of them are to stabilize java/io/pathNames/General(Win32|Solaris).java The patches apply cleanly. Bugs: https://bugs.openjdk.java.net/browse/JDK-8009258 https://bugs.openjdk.java.net/browse/JDK-8015628 https://bugs.openj

[7u-dev] Request for Approval and Review: 8017212: File.createTempFile requires unnecessary "read" permission

2014-08-15 Thread Ivan Gerasimov
Hello! I'd like to ask an approval to backport 8017212 into 7u-dev. The patch does not apply cleanly, however the required modifications are quite small. Nevertheless, I will need a peer review for this. The webrev for jdk7: http://cr.openjdk.java.net/~igerasim/8017212/0/webrev/ The differen

hg: jdk7u/jdk7u-dev/jdk: 8054841: (process) ProcessBuilder leaks native memory

2014-08-12 Thread ivan . gerasimov
Changeset: 2590a9c18fdb Author:igerasim Date: 2014-08-12 00:13 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/2590a9c18fdb 8054841: (process) ProcessBuilder leaks native memory Reviewed-by: rriggs, alanb ! src/solaris/native/java/lang/UNIXProcess_md.c

[7u-dev] Request for Approval: 8054841: (process) ProcessBuilder leaks native memory

2014-08-11 Thread Ivan Gerasimov
Hello! May I ask for the approval to back-port a fix for a minor memory leak into jdk7u-dev? The fix applies cleanly. noreg-hard, as this is a native memory leak which can only be observed after a very long loop. Bug: https://bugs.openjdk.java.net/browse/JDK-8054841 Jdk9 change: http://hg.o

hg: jdk7u/jdk7u-dev/jdk: 8046343: (smartcardio) CardTerminal.connect('direct') does not work on MacOSX

2014-08-08 Thread ivan . gerasimov
Changeset: ee4e3f5bd64f Author:igerasim Date: 2014-08-08 15:06 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ee4e3f5bd64f 8046343: (smartcardio) CardTerminal.connect('direct') does not work on MacOSX Reviewed-by: mullan, valeriep ! src/share/classes/sun/security/sma

[7u-dev] Request for approval: 8046343: (smartcardio) CardTerminal.connect('direct') does not work on MacOSX

2014-08-07 Thread Ivan Gerasimov
Hello! May I ask for the approval to backport into 7u-dev repo? The fix is the same as in jdk9/8u modulo lambda, so I'm including the webrev here. Jdk7 webrev: http://cr.openjdk.java.net/~igerasim/8046343/3/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8046343 Jdk9 change: http://hg.o

Re: CFV: New JDK7u Committer: Anton Nashatyrev

2014-08-05 Thread Ivan Gerasimov
Vote: yes On 05.08.2014 18:06, Alexander Potochkin wrote: I hereby nominate Anton Nashatyrev to jdk7u Committer. Anton is a member of the Java SE sustaining team. He has spent most of that time working on the GUI and deployment issues. He has contributed 16 changes to jdk7u so far: http://hg.

Re: CFV: New JDK7u Committer: Mikhail Cherkasov

2014-07-15 Thread Ivan Gerasimov
Vote: Yes

hg: jdk7u/jdk7u-dev/jdk: 8049250: Need a flag to invert the Card.disconnect(reset) argument

2014-07-14 Thread ivan . gerasimov
Changeset: 35aabd00a534 Author:igerasim Date: 2014-07-15 02:26 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/35aabd00a534 8049250: Need a flag to invert the Card.disconnect(reset) argument Reviewed-by: valeriep ! src/share/classes/sun/security/smartcardio/CardImpl.j

hg: jdk7u/jdk7u-dev/jdk: 6545422: [TESTBUG] NativeErrors.java uses wrong path name in exec

2014-07-07 Thread ivan . gerasimov
Changeset: ebb2c60b579c Author:igerasim Date: 2014-07-07 17:54 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ebb2c60b579c 6545422: [TESTBUG] NativeErrors.java uses wrong path name in exec Summary: Uses common testlibrary to find executable. Removed NullPointerExcept

[7u-dev] Request for approval: 6545422: [TESTBUG] NativeErrors.java uses wrong path name in exec

2014-07-07 Thread Ivan Gerasimov
Hello! Can I please have an approval to back port this test fix into 7u-dev? The fix is unaltered, comparing to 8u, and is different in one line, comparing to 9. Bug: https://bugs.openjdk.java.net/browse/JDK-6545422 Change in 8: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/35a00bbf966b R

hg: jdk7u/jdk7u-dev/jdk: 8048080: (smartcardio) javax.smartcardio.Card.openLogicalChannel() dosn't work on MacOSX

2014-06-28 Thread ivan . gerasimov
Changeset: 5f5b1e1b514a Author:igerasim Date: 2014-06-27 08:03 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/5f5b1e1b514a 8048080: (smartcardio) javax.smartcardio.Card.openLogicalChannel() dosn't work on MacOSX Reviewed-by: valeriep ! src/solaris/native/sun/securit

[7u-dev] Request for approval: 8048080: (smartcardio) javax.smartcardio.Card.openLogicalChannel() dosn't work on MacOSX

2014-06-26 Thread Ivan Gerasimov
Hi! Would you please approve this unaltered backport to 7u-dev? Bug: https://bugs.openjdk.java.net/browse/JDK-8048080 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/45592d253efe Review: http://mail.openjdk.java.net/pipermail/security-dev/2014-June/010695.html Sincerely yours, Ivan

hg: jdk7u/jdk7u-dev/jdk: 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f

2014-06-23 Thread ivan . gerasimov
Changeset: 982f4666e2b6 Author:igerasim Date: 2014-06-23 18:27 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/982f4666e2b6 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f Reviewed-by: chegar ! src/share/classes/java/

[7u-dev] Request for approval: 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f

2014-06-23 Thread Ivan Gerasimov
Hello! The fix for 8019834, which was recently ported into 7u causes failures of several tests. In order to fix those, another small fix is required (I overlooked it when first requested an approval for 8019834). Would you please approve backport of this one line fix? It applies cleanly. BUG

hg: jdk7u/jdk7u-dev/jdk: 8019834: InetAddress.getByName hangs for bad IPv6 literals

2014-06-18 Thread ivan . gerasimov
Changeset: 184171631add Author:igerasim Date: 2014-06-18 14:40 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/184171631add 8019834: InetAddress.getByName hangs for bad IPv6 literals Reviewed-by: alanb ! src/share/classes/java/net/InetAddress.java ! test/java/net/ipv6

[7u-dev] Request for approval: 8019834 InetAddress.getByName hangs for bad IPv6 literals

2014-06-18 Thread Ivan Gerasimov
Hello! Would you please approve a straight backport to 7u-dev of the following fix. The bug causes a test to hang. The author of the fix is Okay with backporting. BUG: https://bugs.openjdk.java.net/browse/JDK-8019834 Changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/771c77b49bb6 Review:

hg: jdk7u/jdk7u-dev/jdk: 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh; ...

2014-06-18 Thread ivan . gerasimov
Changeset: 9df69ec6c161 Author:igerasim Date: 2014-06-18 14:11 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9df69ec6c161 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh 7036519: TEST_BUG: add cygwin support to test/demo

[7u-dev] Request for approval: 7036519, 7036518: TEST_BUG: add cygwin support to ...

2014-06-17 Thread Ivan Gerasimov
Hello! Would you please approve backporting of couple of test fixes? Those just failed for me, so it seems we better have them fixed. BUGS: https://bugs.openjdk.java.net/browse/JDK-7036518 TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh https://bugs.openjdk

hg: jdk7u/jdk7u-dev/jdk: 3 new changesets

2014-05-31 Thread ivan . gerasimov
Changeset: 69f00c5cfdf2 Author:igerasim Date: 2014-05-31 01:02 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/69f00c5cfdf2 8030114: [parfait] warnings from b119 for jdk.src.share.native.sun.security.smartcardio: JNI exception pending Summary: Fix pending exception er

hg: jdk7u/jdk7u-dev/jdk: 8033571: [parfait] warning from b128 for security/smartcardio/pcsc_md.c: JNI exception pending

2014-05-31 Thread ivan . gerasimov
Changeset: 2f63db1d2a24 Author:igerasim Date: 2014-06-01 02:43 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/2f63db1d2a24 8033571: [parfait] warning from b128 for security/smartcardio/pcsc_md.c: JNI exception pending Summary: Fix pending exception errors found by pa

[7u-dev] Request for approval: 8033571, 8030114, 8039118: (smartcardio)...

2014-05-29 Thread Ivan Gerasimov
Hello! Could you please approve backporting of three more smart-card related fixes? First two add checks for pending exceptions, and the third eliminates the regression (unresolved external symbol) caused by the second one. These changes not only useful in 8 and 7 by themselves, but will also

hg: jdk7u/jdk7u-dev/jdk: 4 new changesets

2014-05-29 Thread ivan . gerasimov
Changeset: faf013fdf311 Author:igerasim Date: 2014-05-20 10:11 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/faf013fdf311 7195480: javax.smartcardio does not detect cards on Mac OS X Reviewed-by: valeriep ! src/solaris/native/sun/security/smartcardio/MUSCLE/pcsclite

[7u-dev] Request for approval: 7047033, 7195480, 8039319, 8043507, 8043720: (smartcardio)...

2014-05-29 Thread Ivan Gerasimov
Hello! May I please have an approval to backport a few smart-card related fixes into 7u-dev? JDK-7047033: (smartcardio) Card.disconnect(boolean reset) does not reset when reset is true https://bugs.openjdk.java.net/browse/JDK-7047033 http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d96a0380fcee h

Re: CFV: New JDK7u Committer: Sergey Gabdurakhmanov

2014-05-12 Thread Ivan Gerasimov
Vote: Yes On 12.05.2014 21:01, Alexander Potochkin wrote: I hereby nominate Sergey Gabdurakhmanov to jdk7u Committer. Sergey is a member of the Java SE JVM sustaining team. He has spent most of that time working on the hotspot and serviceability issues. He has contributed 11 changes to jdk7u s

Re: CFV: New JDK7u Committer: Vladimir Kempik

2014-05-08 Thread Ivan Gerasimov
Vote: Yes On 30.04.2014 19:08, Alexander Potochkin wrote: I hereby nominate Vladimir Kempik to jdk7u Committer. Vladimir is a member of the Java SE JVM sustaining team. He has spent most of that time working on the hotspot and serviceability issues. He has contributed 10 changes to jdk7u so

hg: jdk7u/jdk7u-dev/jdk: 8038961: kinit, klist and ktab aren't built from jdk7u51 in licensee src bundles

2014-04-29 Thread ivan . gerasimov
Changeset: a938e09de6a4 Author:igerasim Date: 2014-04-30 09:32 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/a938e09de6a4 8038961: kinit, klist and ktab aren't built from jdk7u51 in licensee src bundles Reviewed-by: weijun, erikj ! make/sun/security/krb5/Makefile

hg: jdk7u/jdk7u-dev/langtools: 8040790: [TEST_BUG] tools/javac/innerClassFile/Driver.sh fails to cleanup files after it

2014-04-29 Thread ivan . gerasimov
Changeset: 88f42a42b42d Author:igerasim Date: 2014-04-29 23:14 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/88f42a42b42d 8040790: [TEST_BUG] tools/javac/innerClassFile/Driver.sh fails to cleanup files after it Reviewed-by: lancea ! test/tools/javac/innerClas

Re: RFR: [8040790] TEST_BUG: tools/javac/innerClassFile/Driver.sh fails to cleanup files after it

2014-04-29 Thread Ivan Gerasimov
le.com <mailto:lance.ander...@oracle.com> Sent from my iPad On Apr 29, 2014, at 4:48 AM, Ivan Gerasimov <mailto:ivan.gerasi...@oracle.com>> wrote: Hello! This is a 7u-only test-stabilization one-line fix. The test was reported to not clean after itself, which sometimes causes problem

RFR: [8040790] TEST_BUG: tools/javac/innerClassFile/Driver.sh fails to cleanup files after it

2014-04-29 Thread Ivan Gerasimov
Hello! This is a 7u-only test-stabilization one-line fix. The test was reported to not clean after itself, which sometimes causes problems. Would you please help review the fix? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8040790 WEBREV: http://cr.openjdk.java.net/~igerasim/8040790/0/we

Re: Result: New JDK 7u Committer: Ivan Gerasimov

2014-04-28 Thread Ivan Gerasimov
Thank you guys! On 25.04.2014 14:21, Seán Coffey wrote: Voting for Ivan Gerasimov [1] is now closed. Yes: 12 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Regards, Sean. [1] http://mail.openjdk.java.net/pipermail

Re: RFR: [8038961] kinit, klist and ktab aren't built from jdk7u51 in licensee src bundles

2014-04-28 Thread Ivan Gerasimov
Thanks Erik! On 28.04.2014 17:12, Erik Joelsson wrote: Hello Ivan, The change looks good to me, but I'm not a reviewer for 7u. No problem, I'll wait for one :) Thank you anyway. Sincerely yours, Ivan /Erik On 2014-04-28 14:45, Ivan Gerasimov wrote: Ping. Could someone p

Re: RFR: [8038961] kinit, klist and ktab aren't built from jdk7u51 in licensee src bundles

2014-04-28 Thread Ivan Gerasimov
r the licensee bundle, the kerberoes tools for windows are now created. Any comments/suggestions? Sincerely yours, Ivan On 21.04.2014 22:43, Ivan Gerasimov wrote: Hello! This is a 7u only issue. I was reported that kerberos tools aren't built from the licensee source bundle. The cau

RFR: [8038961] kinit, klist and ktab aren't built from jdk7u51 in licensee src bundles

2014-04-21 Thread Ivan Gerasimov
Hello! This is a 7u only issue. I was reported that kerberos tools aren't built from the licensee source bundle. The cause is that building of the launchers is started from the 'build' target in the Makefile. On Windows, the 'build' target is only defined, if ./common/Library.gmk is included,

[7u-dev] Request for approval: 8039396: NPE when writing a class descriptor object to a custom ObjectOutputStream

2014-04-17 Thread Ivan Gerasimov
Hello! May I please have an approval to backport this unaltered fix to jdk8u? BUG: https://bugs.openjdk.java.net/browse/JDK-8039396 9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/raw-rev/ce1573e7824a Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-April/026461.html Tha

Request for approval: 8026792: [hotspot]: licensee reports a JDK8 build failure after 8005849/8005008 fixes integrated.

2014-03-29 Thread Ivan Gerasimov
May I please have this approved for backporting to 7u-dev? JDK 8 changeset applies cleanly. Bug report: https://bugs.openjdk.java.net/browse/JDK-8026792 JDK 8 Changeset: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/raw-rev/ffb471203842 I couldn't find the review thread. I'm not sure at which m

[7u-dev] Request to backport: 8027348, 8034262

2014-03-25 Thread Ivan Gerasimov
Hi! This is a request to backport two linked changes: 8027348: (process) Enhancement of handling async close of ProcessInputStream Bug: https://bugs.openjdk.java.net/browse/JDK-8027348 Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/62704cc3aaaf Jdk8 changeset: http://hg.openjdk.jav

[7u-dev] Request for approval: 8027212: java/nio/channels/Selector/SelectAfterRead.java fails intermittently

2014-02-19 Thread Ivan Gerasimov
Would you please approve the unmodified backport from 9 of the test bug fix? Master bug: https://bugs.openjdk.java.net/browse/JDK-8027212 Jdk9 Change: http://hg.openjdk.java.net/jdk9/dev/jdk/raw-rev/1f351ad06e95 Review: http://mail.openjdk.java.net/pipermail/nio-dev/2013-December/002435.html T

Re: [7u-dev] Request for approval: 7052170 javadoc -charset option generates wrong meta tag

2014-02-09 Thread Ivan Gerasimov
Hi Rob! Yes, it applies cleanly. I meant to mention it, but missed it somehow. Sincerely yours, Ivan On 09.02.2014 18:53, Rob McKenna wrote: Hi Ivan, Does the patch apply cleanly? (I assume so looking at the code, but we should be explicit) -Rob On 09/02/14 13:28, Ivan Gerasimov

[7u-dev] Request for approval: 7052170 javadoc -charset option generates wrong meta tag

2014-02-09 Thread Ivan Gerasimov
Hello! I'm looking for an approval to backport the fix to jdk7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-7052170 Jdk8 change: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7fb27bc201cc In the duplicate of this issue it is mentioned, that the bug may cause failures of third party t

Re: [7u60] - Request for approval: 8023881, 8030878, 8030698

2014-01-24 Thread Ivan Gerasimov
Thanks Seán! On 24.01.2014 15:30, Seán Coffey wrote: Approved. Apologies for delay in getting to this. regards, Sean. On 22/01/14 23:42, Ivan Gerasimov wrote: Hello! May I kindly ask for the approval to integrate these three fixes into the 7u60 repo? These two 8023881, 8030698 are direct

[7u60] - Request for approval: 8023881, 8030878, 8030698

2014-01-22 Thread Ivan Gerasimov
Hello! May I kindly ask for the approval to integrate these three fixes into the 7u60 repo? These two 8023881, 8030698 are direct backports from the later releases. Both apply cleanly. https://bugs.openjdk.java.net/browse/JDK-8023881 https://bugs.openjdk.java.net/browse/JDK-8030698 This one 8

Re: [7u60] Request for approval: (aio) Assertion in clearPendingIoMap when closing at around time file lock is acquired immediately (win)

2013-12-18 Thread Ivan Gerasimov
Hi Rob! Now, we've got the 'approved' label. Sincerely yours, Ivan On 14.12.2013 7:25, Rob McKenna wrote: Ivan, this is missing the 7u60-critical-approved tag so I'm afraid I can't approve it at the moment. -Rob On 13/12/13 17:21, Ivan Gerasimov wrote: Hello!

[7u60] Request for approval: (aio) Assertion in clearPendingIoMap when closing at around time file lock is acquired immediately (win)

2013-12-13 Thread Ivan Gerasimov
Hello! Would you please approve the backport to 7u60 of the following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8028208 Jdk8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0c414ac10700 The fix applies cleanly except for the ProblemList part, which is not applicable here. Si

[7u-dev] Request to backport: 8024521 (process) Async close issues with Process InputStream

2013-11-10 Thread Ivan Gerasimov
Hello! Would you please approve a backport of a fix that has already been pushed into jdk8? The patch applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8024521 JDK8 Change: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2ec05b2ed94 JDK8 Review Thread: http://mail.openjdk.java.net/pi

[7u-dev] Request for approval: 8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions

2013-10-28 Thread Ivan Gerasimov
Hello! Would you please approve a backport of a simple doc fix into 7u-dev? Bug: https://bugs.openjdk.java.net/browse/JDK-8016018 JDK8 Change: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/92a66af7f834 JDK8 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-August/019879.html Th

[7u-dev] Request for approval: 8022584 Memory leak in NetworkInterface methods

2013-10-23 Thread Ivan Gerasimov
May I have the approval to backport the fix from jkd8 to jdk7u? The patch applies cleanly. However I want to exclude the regtest from the change: First it turned out to be not very reliable, and second the fix itself is trivial. The test has also been removed from the jdk8 with the bugfix 80233

[7u-dev] Request for approval: 8023130 (process) ProcessBuilder#inheritIO does not work on Windows

2013-10-18 Thread Ivan Gerasimov
Hello! May I have the approval to backport the fix from jkd8 to jdk7u? The patch applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8023130 Review threads: 1) http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-August/020194.html 2) http://mail.openjdk.java.net/pipermail/co

Re: [7u-dev] Request for approval for CRs 8007454, 7147084

2013-09-24 Thread Ivan Gerasimov
irst due to the adjustments needed in the backport. Hopefully, you'll be resolving these issues with 2 different changesets. It's been the trend in the past and helps keep changesets more aligned to those in JDK 8. regards, Sean. On 24/09/2013 09:08, Ivan Gerasimov wrote:

[7u-dev] Request for approval for CRs 8007454, 7147084

2013-09-24 Thread Ivan Gerasimov
19604.html 8007454: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014602.html I had set up a JPRT job, which completed successfully. All the .*jdk_lang.* test passed. Sincerely yours, Ivan Gerasimov

Re: [7u-dev] Request for approval to backport 8022584:

2013-08-15 Thread Ivan Gerasimov
Thanks Jeff! On 15.08.2013 21:21, Jeff Dinkins wrote: Hi Ivan, Looks good. Approved for jdk7u-dev. -jeff On Aug 15, 2013, at 8:22 AM, Ivan Gerasimov wrote: Request for approval to backport 8022584 This is a fix of copy/paste error that led to a non necessary allocation in a native code

  1   2   >