[7u-dev] Request for approval : 8052406: SSLv2Hello protocol may be filtered out unexpectedly

Turns out that the new test wasn't being run via JPRT and that it needed adjustment. I've got a new review approved. Re-requesting approval. http://mail.openjdk.java.net/pipermail/security-dev/2014-October/011276.html regards, Sean. On 30/09/2014 19:06, Rob McKenna wrote: Approved. -Rob

Re: [7u80] RFR (backport): 8026303: CMS: JVM intermittently crashes with "FreeList of size 258 violates Conservation Principle" assert

Adding hotspot-gc-dev. On 2014-10-07 15:31, Stefan Johansson wrote: Hi, Please review this backport to 7u-dev for: https://bugs.openjdk.java.net/browse/JDK-8026303 Full webrev: http://cr.openjdk.java.net/~sjohanss/8026303/webrev.00/ Webrev for changes to original fix: http://cr.openjdk.java.n

Re: [7u-dev] Request for approval: 8038966: JAX-WS handles wrongly xsd:any arguments for Web services

Looks fine Aleksej. Approved. regards, Sean. On 08/10/14 09:45, Aleksej Efimov wrote: Hello, Could you, please, approve a backport of 8038966 bug to JDK7u-dev. The source code changes is identical to JDK8. The only one difference is in how test application converts the WS response to String

Re: [7u80] RFR (backport): 8026303: CMS: JVM intermittently crashes with "FreeList of size 258 violates Conservation Principle" assert

Hi Stefan, On Wed, 2014-10-08 at 10:55 +0200, Stefan Johansson wrote: > Adding hotspot-gc-dev. > > On 2014-10-07 15:31, Stefan Johansson wrote: > > Hi, > > > > Please review this backport to 7u-dev for: > > https://bugs.openjdk.java.net/browse/JDK-8026303 > > > > Full webrev: > > http://cr.openjd

[7u-dev] Request for approval : 8004488 wrong permissions checked in krb5

Looking to port this to jdk7u. bug : https://bugs.openjdk.java.net/browse/JDK-8004488 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8004488.7u/webrev/ review thread : http://mail.openjdk.java.net/pipermail/security-dev/2014-October/011314.html regards, Sean.

Re: [7u-dev] Request for approval : 8004488 wrong permissions checked in krb5

approved. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile:+491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 Münc

Re: [7u-dev] Request for approval: 8038966: JAX-WS handles wrongly xsd:any arguments for Web services

Thank you Sean! -Aleksej On 10/08/2014 01:45 PM, Seán Coffey wrote: Looks fine Aleksej. Approved. regards, Sean. On 08/10/14 09:45, Aleksej Efimov wrote: Hello, Could you, please, approve a backport of 8038966 bug to JDK7u-dev. The source code changes is identical to JDK8. The only one diff

hg: jdk7u/jdk7u-dev/jdk: 8038966: JAX-WS handles wrongly xsd:any arguments for Web services

Changeset: 4c1747bcb284 Author:aefimov Date: 2014-10-08 14:24 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/4c1747bcb284 8038966: JAX-WS handles wrongly xsd:any arguments for Web services Reviewed-by: coffeys + test/javax/xml/ws/xsanymixed/CopyingResponse.java + tes

hg: jdk7u/jdk7u-dev/jaxws: 8038966: JAX-WS handles wrongly xsd:any arguments for Web services

Changeset: 3c37fddd70d6 Author:aefimov Date: 2014-10-08 14:22 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws/rev/3c37fddd70d6 8038966: JAX-WS handles wrongly xsd:any arguments for Web services Reviewed-by: coffeys ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2

[7u-dev] Request for approval : 8014254, 7145454, 7156459

Hi folks, looking for approval for these backports. (all of which apply cleanly) 8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive bug: https://bugs.openjdk.java.net/browse/JDK-8043528 changeset: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/86c1e8c799f5 revi

Re: [7u-dev] Request for approval : 8014254, 7145454, 7156459

Approved. regards, Sean. On 08/10/14 13:23, Rob McKenna wrote: Hi folks, looking for approval for these backports. (all of which apply cleanly) 8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive bug: https://bugs.openjdk.java.net/browse/JDK-8043528 changeset: h

Re: [7u80] RFR (backport): 8026303: CMS: JVM intermittently crashes with "FreeList of size 258 violates Conservation Principle" assert

Looks good. /Jesper Stefan Johansson skrev 8/10/14 10:55: Adding hotspot-gc-dev. On 2014-10-07 15:31, Stefan Johansson wrote: Hi, Please review this backport to 7u-dev for: https://bugs.openjdk.java.net/browse/JDK-8026303 Full webrev: http://cr.openjdk.java.net/~sjohanss/8026303/webrev.00/

hg: jdk7u/jdk7u-dev/jdk: 8004488: wrong permissions checked in krb5

Changeset: 014a34d10e44 Author:weijun Date: 2014-10-08 14:10 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/014a34d10e44 8004488: wrong permissions checked in krb5 Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/c

Re: [7u-dev] Request for approval : 8052406: SSLv2Hello protocol may be filtered out unexpectedly

Approved. -Rob On 08/10/14 09:36, Seán Coffey wrote: Turns out that the new test wasn't being run via JPRT and that it needed adjustment. I've got a new review approved. Re-requesting approval. http://mail.openjdk.java.net/pipermail/security-dev/2014-October/011276.html regards, Sean.

hg: jdk7u/jdk7u-dev/jdk: 8052406: SSLv2Hello protocol may be filter out unexpectedly

Changeset: 715d90e998c9 Author:xuelei Date: 2014-10-08 14:25 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/715d90e998c9 8052406: SSLv2Hello protocol may be filter out unexpectedly Reviewed-by: weijun ! src/share/classes/sun/security/ssl/Handshaker.java ! test/Makefi

Re: [7u80] Request for approval 8026303: CMS: JVM intermittently crashes with "FreeList of size 258 violates Conservation Principle" assert

Hi again Rob, Now the fix for 8026303 is backported to 8u and I have gotten two reviews of the code proposed to be backported into 7u. Is it ok to push these changes to jdk7u-dev then? Thanks, Stefan On 2014-10-06 16:06, Rob McKenna wrote: Ah, see what you mean. I was looking at the wrong b

Re: [7u80] Request for approval 8026303: CMS: JVM intermittently crashes with "FreeList of size 258 violates Conservation Principle" assert

Yup, approved. Can you forward a link to the 7 codereview thread? Thanks, -Rob On 08/10/14 15:06, Stefan Johansson wrote: Hi again Rob, Now the fix for 8026303 is backported to 8u and I have gotten two reviews of the code proposed to be backported into 7u. Is it ok to push these changes

Re: [7u80] Request for approval 8026303: CMS: JVM intermittently crashes with "FreeList of size 258 violates Conservation Principle" assert

Thanks, Here is the review mail thread: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2014-October/009816.html Stefan On 2014-10-08 16:09, Rob McKenna wrote: Yup, approved. Can you forward a link to the 7 codereview thread? Thanks, -Rob On 08/10/14 15:06, Stefan Johansson wrote: Hi a

hg: jdk7u/jdk7u-dev/jdk: 3 new changesets

Changeset: 43db70cf8b20 Author:naoto Date: 2012-03-21 10:10 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/43db70cf8b20 7145454: JVM wide monitor lock in Currency.getInstance(String) Reviewed-by: okutsu ! src/share/classes/java/util/Currency.java Changeset: ffd8b8da

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

On 10/7/2014 1:47 AM, Ivan Gerasimov wrote: Thank you Mandy! I've updated the webrev based on your suggestions. The test is moved to test/sun/misc/ProxyGenerator/ directory. Here's the updated webrev: http://cr.openjdk.java.net/~igerasim/8059563/1/webrev/ Thanks for updating the test. Nit:

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

Thanks Mandy! Nit: I suggest to remove the directory "a" at the beginning rather than throwing a RuntimeException so that you can run the test multiple times manually. Yes, makes sense. Here's the updated webrev: http://cr.openjdk.java.net/~igerasim/8059563/2/webrev/ Sincerely yours, Ivan

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

http://cr.openjdk.java.net/~igerasim/8059563/3/webrev/ I reviewed v3 version. Looks good. Mandy

Re: RFR [8059563]: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

Thank you Mandy! Seems like I managed to skip the mailing lists when sending the 3rd version of the review. Sorry about that. Sincerely yours, Ivan On 09.10.2014 9:56, Mandy Chung wrote: http://cr.openjdk.java.net/~igerasim/8059563/3/webrev/ I reviewed v3 version. Looks good. Mandy

hg: jdk7u/jdk7u-dev/jdk: 8059563: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories

Changeset: 44ef857dd5e6 Author:igerasim Date: 2014-10-09 10:24 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/44ef857dd5e6 8059563: (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories Reviewed-by: mchung ! src/share/classes/sun/