Re: RFR: 8022746: List of spelling errors in API doc

On 23/10/2013 16:05, sergey malenkov wrote: Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 The second version of the fix is here: http://cr.openjdk.java.net/~malenkov/8022746.8.1/

Re: Reminder: RFR: 8022746: List of spelling errors in API doc

The fix looks good for me. Thanks, Alexandr. On 10/24/2013 9:17 PM, sergey malenkov wrote: Any objections? SAM On 23.10.2013 19:05, sergey malenkov wrote: Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.j

Re: Reminder: RFR: 8022746: List of spelling errors in API doc

Hi Sergey, Good stuff. I've looked over the RMI and serialization related files and the changes look fine. s'marks On 10/24/13 10:17 AM, sergey malenkov wrote: Any objections? SAM On 23.10.2013 19:05, sergey malenkov wrote: Could you please review the following huge fix: fix:http://cr.o

Reminder: RFR: 8022746: List of spelling errors in API doc

Any objections? SAM On 23.10.2013 19:05, sergey malenkov wrote: Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 The second version of the fix is here: http://cr.openjdk.java.net/~malenk

Re: RFR: 8022746: List of spelling errors in API doc

Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 The second version of the fix is here: http://cr.openjdk.java.net/~malenkov/8022746.8.1/

Re: RFR: 8022746: List of spelling errors in API doc

I understand there are several "alphanumeric" usages in the document, but I'd use "alphanum" there, as it is preceded by "3-8" which is more like ABNF notation. Naoto On 10/22/13 10:55 AM, sergey malenkov wrote: * A well-formed locale key has the form * [0-9a-zA-Z]{2}. A well-formed lo

Re: RFR: 8022746: List of spelling errors in API doc

* A well-formed locale key has the form * [0-9a-zA-Z]{2}. A well-formed locale type has the * form "" | [0-9a-zA-Z]{3,8} ('-' [0-9a-zA-Z]{3,8})* (it - * can be empty, or a series of subtags 3-8 alphanums in length). A + * can be empty, or a series of subtags 3-8 alphanumerics in length). A

Re: RFR: 8022746: List of spelling errors in API doc

Hi Sergey, I looked at the changes wrt i18n, and found one change in Locale class: 221 * can be empty, or a series of subtags 3-8 alphanumerics in length). A where you modified "alphanums" to "alphanumerics". In fact it's not a typo, as "alphanum" is defined in BCP 47 standard. Naoto On 1

Re: RFR: 8022746: List of spelling errors in API doc

Thank you for this information. I'll remove *.1 files from the webrev. Regards, SAM On 22.10.2013 19:46, Jonathan Gibbons wrote: On 10/22/2013 05:22 AM, sergey malenkov wrote: Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:http

Re: RFR: 8022746: List of spelling errors in API doc

Thanks, I fixed both occurrences of ProtoclList in that file. Regards, SAM On 22.10.2013 19:13, Sean Mullan wrote: You have some merge cruft left in jdk/src/share/classes/sun/security/krb5/Realm.java Line 246 of jdk/src/share/classes/sun/security/ssl/SSLContextImpl.java should be: // Get s

Re: RFR: 8022746: List of spelling errors in API doc

Yes, makes sense to fix now that we know about them On Oct 22, 2013, at 12:45 PM, sergey malenkov wrote: > Thanks! > I fixed package.html, but there are similar typos in the following classes: > > javax.sql.rowset.spi.XmlReader: > * SyncProvider implementations that supply XML data reader > * ca

Re: RFR: 8022746: List of spelling errors in API doc

Thanks! I fixed package.html, but there are similar typos in the following classes: javax.sql.rowset.spi.XmlReader: * SyncProvider implementations that supply XML data reader * capabilities such as output XML stream capabilities can implement this * interface to provider standard XmlReader ob

Re: RFR: 8022746: List of spelling errors in API doc

On 10/22/2013 05:22 AM, sergey malenkov wrote: Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 I've replaced all typos with correct words in all documentations and comments. Our t

Re: RFR: 8022746: List of spelling errors in API doc

First, thank you for doing this. I went through all of the JDBC/RowSet diffs. They all look good but I found one other error that the spell checker missed in one of the lines you changed http://cr.openjdk.java.net/~malenkov/8022746.8.0/jdk/src/share/classes/com/sun/rowset/package.html.sdiff.ht

Re: RFR: 8022746: List of spelling errors in API doc

You have some merge cruft left in jdk/src/share/classes/sun/security/krb5/Realm.java Line 246 of jdk/src/share/classes/sun/security/ssl/SSLContextImpl.java should be: // Get supported ProtocolList. Other than that, I reviewed all the security/crypto changes and they look good to me. BTW,

Re: RFR: 8022746: List of spelling errors in API doc

I looked over the networking and concurrency changes, and they look fine to me. I think Doug won't have a problem accepting these trivial typos into his CVS. -Chris. On 22/10/2013 14:05, Alan Bateman wrote: On 22/10/2013 13:22, sergey malenkov wrote: Hello, Could you please review the fol

Re: RFR: 8022746: List of spelling errors in API doc

> Can you say what tools you used for this, was in an IDE > or did you run a spell checker by other means? No, I've used only the words listed in the bug description. To find all places I used a very simple script mentioned in the bug comments. But editing should be handled manually, because of

Re: RFR: 8022746: List of spelling errors in API doc

Hi, Sergey, I quickly looked through the client libs code and it all looks fine. Thanks, Artem On 10/22/2013 4:22 PM, sergey malenkov wrote: Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/J

Re: RFR: 8022746: List of spelling errors in API doc

On 22/10/2013 13:22, sergey malenkov wrote: Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 I've replaced all typos with correct words in all documentations and comments. Our tech

RFR: 8022746: List of spelling errors in API doc

Hello, Could you please review the following huge fix: fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8022746 I've replaced all typos with correct words in all documentations and comments. Our technical writer has already checked it. Thanks