tzaeschke commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1383891081
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -140,37 +141,178 @@ private String getTrimmedPropertyValue(Properties props,
String key) {
return
clr-apache commented on PR #84:
URL: https://github.com/apache/db-jdo/pull/84#issuecomment-1778204772
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tobous merged PR #84:
URL: https://github.com/apache/db-jdo/pull/84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
mboapache opened a new pull request, #85:
URL: https://github.com/apache/db-jdo/pull/85
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1794402762
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #84:
URL: https://github.com/apache/db-jdo/pull/84#issuecomment-1777490176
Kudos, SonarCloud Quality Gate passed! [ throws MojoExecutionException,
MojoFailureException {
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387252360
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -263,231 +396,261 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387168344
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -140,37 +141,178 @@ private String getTrimmedPropertyValue(Properties props,
String key) {
return
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387254461
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -528,13 +693,14 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1804648411
Kudos, SonarCloud Quality Gate passed! [` and `printStackTrace(...)`.
To avoid duplication in the `printStackTrace()`, the nested exceptions are
no longer printed as part of the `toString()`.
tobous commented on PR #75:
URL: https://github.com/apache/db-jdo/pull/75#issuecomment-1516770471
Rejected. Old behavior is preferred. `JDOException` being mutable is too low
of an issue for the larger rework necessary to replicate the old behavior while
keeping the class immutable.
--
tzaeschke merged PR #74:
URL: https://github.com/apache/db-jdo/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tobous closed pull request #75: JDO-823 - Make JDOException immutable
URL: https://github.com/apache/db-jdo/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tobous opened a new pull request, #76:
URL: https://github.com/apache/db-jdo/pull/76
Make all fields in JDOException final. Explicitly excludes
'inPrintStackTrace' as it is needed for some state tracking. Makes it
'transient' instead.
--
This is an automated message from the Apache Git
sonarcloud[bot] commented on PR #76:
URL: https://github.com/apache/db-jdo/pull/76#issuecomment-1516777040
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
tzaeschke merged PR #76:
URL: https://github.com/apache/db-jdo/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #72:
URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490859079
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #72:
URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490850995
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
tzaeschke opened a new pull request, #72:
URL: https://github.com/apache/db-jdo/pull/72
Remove unused local variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on PR #73:
URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1495138879
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #73:
URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1496338683
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
clr-apache merged PR #73:
URL: https://github.com/apache/db-jdo/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #74:
URL: https://github.com/apache/db-jdo/pull/74#issuecomment-1500862018
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
tzaeschke opened a new pull request, #74:
URL: https://github.com/apache/db-jdo/pull/74
Remove claim that @Convert can be put on types. See
https://issues.apache.org/jira/browse/JDO-826.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tzaeschke merged PR #72:
URL: https://github.com/apache/db-jdo/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
clr-apache opened a new pull request, #73:
URL: https://github.com/apache/db-jdo/pull/73
JDO-819 Fix code smells
Use "Arrays.copyOf", "Arrays.asList", "Collections.addAll" or
"System.arraycopy" instead.
--
This is an automated message from the Apache Git Service.
To respond to the
sonarcloud[bot] commented on PR #73:
URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1493455267
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tzaeschke opened a new pull request, #83:
URL: https://github.com/apache/db-jdo/pull/83
As part of https://issues.apache.org/jira/browse/JDO-823, this PR attempt to
clean up code issues in the `Enhancer`.
Specifically:
- [x] Reduce code complexity of `execute()`. Done.
- [ ] ~~Fix
sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1628800957
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tobous opened a new pull request, #78:
URL: https://github.com/apache/db-jdo/pull/78
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
clr-apache commented on PR #48:
URL: https://github.com/apache/db-jdo-site/pull/48#issuecomment-1575823651
I can't say I understand this, but have no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tobous opened a new pull request, #48:
URL: https://github.com/apache/db-jdo-site/pull/48
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tobous opened a new pull request, #79:
URL: https://github.com/apache/db-jdo/pull/79
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #79:
URL: https://github.com/apache/db-jdo/pull/79#issuecomment-1575670686
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1613252562
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tzaeschke merged PR #91:
URL: https://github.com/apache/db-jdo/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tobous commented on PR #49:
URL: https://github.com/apache/db-jdo-site/pull/49#issuecomment-1954948109
Removed the Zip as well by accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tobous merged PR #49:
URL: https://github.com/apache/db-jdo-site/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mboapache merged PR #90:
URL: https://github.com/apache/db-jdo/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tzaeschke opened a new pull request, #88:
URL: https://github.com/apache/db-jdo/pull/88
This PR moves log files instead of copying them, see
https://issues.apache.org/jira/browse/JDO-834.
It also contains some minor cleanup:
- Added `command.add("execute");` in `RunTck` to JUnit
sonarcloud[bot] commented on PR #88:
URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826392651
Kudos, SonarCloud Quality Gate passed! [