Re: Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

Ya, deleting a build would trigger listener and for that RunListener.onDeleted() can be used. But for deleting builds from external workspace manager, few builds will be picked according to the filters. And that builds will be deleted by calling delete() method, if I am not wrong. On Friday,

Re: `stalled-pr` label vs. JIRA status

On Thu, Apr 4, 2019 at 3:26 PM Daniel Beck wrote: > - New status name ("Stalled" probably) STALLED > - one sentence description Some work was done on this issue, but there is no clear plan for it to be completed. > - category IN PROGRESS > - where it sorts into the list of existing statuses

Re: Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

On Thu, Apr 4, 2019 at 2:51 PM Nisarg Shah wrote: > discarding of workspaces when builds are discarded is responsibility of > 'external-workspace-manager'. Yes, I would think so. > And advanced Build Discarder should be notified to do the additional cleanup ? Not quite sure what that means.

Re: Beta availability of github-branch-source plugin

Yes, I'll do my best to take some time on this. On Fri, Apr 5, 2019 at 3:58 AM Vivek Pandey wrote: > Rick, > > Thanks. Hope you get chance to give it a try do let us know if there are > any issues. > > On Wed, Apr 3, 2019 at 6:36 PM Rick wrote: > >> Hi Vivek, >> >> Good to see this. And thanks

Re: Creating a new Gitlab SCM Plugin with Multibranch Pipeline support

Hi Owen and Parichay, Thanks for your time. I'm interested in the GitLab plugin. That's why I created this project proposal. >From my view, there're some similar logic and codes. If I understand correctly, this is also Parichay said Other areas of improvement for GitLab plugin is implementation

Re: Beta availability of github-branch-source plugin

Rick, Thanks. Hope you get chance to give it a try do let us know if there are any issues. On Wed, Apr 3, 2019 at 6:36 PM Rick wrote: > Hi Vivek, > > Good to see this. And thanks for your efforts. > > On Thu, Apr 4, 2019 at 1:44 AM Vivek Pandey > wrote: > >> Hello, >> >> We are emailing you

Re: `stalled-pr` label vs. JIRA status

> On 4. Apr 2019, at 19:24, Jesse Glick wrote: > > We have recently started using a `stalled-pr` label in JIRA to mark > issues which have an associated pull request that has not been merged > and has no immediate prospects of merging—unresolved conflicts, > unaddressed review comments, etc.

Re: Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

So according to you, discarding of workspaces when builds are discarded is responsibility of 'external-workspace-manager'. And advanced Build Discarder should be notified to do the additional cleanup ? And one more thing, deleting of builds should be done advanced build discarder. So how that

Re: Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

On Thu, Apr 4, 2019 at 2:22 PM Nisarg Shah wrote: > Here I want to delete builds,artifacts and workspaces created by External > Workspace Manager. Artifacts are normally deleted alongside a build. (Unless you are using `artifact-manager-s3`, by design.) Unless I am missing something, it is the

Re: Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

Okay. So you are suggesting to implement RunListener.onDeleted in External Workspace Manager, if I am not wrong. But this method is used when any action is to be performed after some deletion operation. Here I want to delete builds,artifacts and workspaces created by External Workspace Manager.

Re: Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

On Thu, Apr 4, 2019 at 12:41 PM Nisarg Shah wrote: > I thought of making a new delete() method for integration with External > Workspace Manager. Not exactly sure where this is going, but perhaps that plugin could simply implement `RunListener.onDeleted`? That would do the right thing when a

Re: Could not find artifact org.jenkins-ci.main:jenkins-war:jar:war-for-test:2.164.1

On Thu, Apr 4, 2019 at 12:21 PM Rafael Ruiz Palacios wrote: > Any idea why this happens? Update to a newer parent POM and specify your `jenkins.version` and `java.level`: https://github.com/jenkinsci/plugin-pom#usage You can delete the `jenkins-test-harness.version` override. You can also

Re: `stalled-pr` label vs. JIRA status

+1 from me. On Thu, Apr 4, 2019 at 11:24 AM Jesse Glick wrote: > We have recently started using a `stalled-pr` label in JIRA to mark > issues which have an associated pull request that has not been merged > and has no immediate prospects of merging—unresolved conflicts, > unaddressed review

Re: Proposal: AWS Secrets Manager Credentials Provider plugin

On Thu, Apr 4, 2019 at 12:10 PM Chris Kilding wrote: > Would we be able to do it all in a single Github repo inside the jenkinsci > org? Yes. > a separate upstream repo in our own Github account, with a fork under > jenkinsci? We explicitly discourage having this fork structure as it makes

`stalled-pr` label vs. JIRA status

We have recently started using a `stalled-pr` label in JIRA to mark issues which have an associated pull request that has not been merged and has no immediate prospects of merging—unresolved conflicts, unaddressed review comments, etc. Perhaps this should be made into a proper *Status* in JIRA so

Re: Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

Actually I thought of making a new delete() method for integration with External Workspace Manager. As in External Workspace Manager the details of workspace and root directory won't be accessible by current methods. For that Fingerprints will be used. So I was just confused that, would this

Could not find artifact org.jenkins-ci.main:jenkins-war:jar:war-for-test:2.164.1

Hi team! Anyone has faced the following exception while building a plugin for Jenkins on https://ci.jenkins.io/ ? org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.jenkins-ci.main:jenkins-war:jar:war-for-test:2.164.1 in

Re: Proposal: AWS Secrets Manager Credentials Provider plugin

Hi, That sounds good - we’re happy to host in jenkinsci and make the plugin available through the built-in Jenkins plugin manager. As Jesse suggested we did indeed base our plugin on the Kubernetes credentials provider. Would we be able to do it all in a single Github repo inside the

Re: Proposal: AWS Secrets Manager Credentials Provider plugin

Can't wait to check this out. Thanks for publishing it! > On 4. Apr 2019, at 16:21, Chris Kilding > wrote: > > We’re initially thinking it should be a Github repo under the ‘jenkinsci’ or > ‘aws’ organisations, with our own engineers added to that repo as external > collaborators. (These

Re: Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

Did not see this mentioned in the doc so replying here. On Thu, Apr 4, 2019 at 9:30 AM Nisarg Shah wrote: > I have a doubt in the integration part, whether the delete() method currently > used in logRotator.java(current Discarder) will work for discarding builds > from Multi-Branch plugin It

Re: Proposal: AWS Secrets Manager Credentials Provider plugin

On Thu, Apr 4, 2019 at 10:26 AM Chris Kilding wrote: > We looked around for a Jenkins Credentials Provider plugin to do this, but we > could not find one, so we’ve written one. Great! This has been missing for a while. > what kind of features you’d like to see it support Without knowing much

Proposal: AWS Secrets Manager Credentials Provider plugin

Hello, My company has a need to load CI secrets (e.g. API tokens and machine user passwords) from AWS Secrets Manager. We used to do this with hacky Shell scripts but wanted something better. We looked around for a Jenkins Credentials Provider plugin to do this, but we could not find one, so

Re: How to get access to configs/credentials on a UnprotectedRootAction class

Perfect. The global-configuration archetype example was super helpful. I got it working. Thank you. Yes, using a secret makes sense more than whole credentials here. On Thursday, April 4, 2019 at 3:47:07 PM UTC+3, Jesse Glick wrote: > > On Thu, Apr 4, 2019 at 6:52 AM Daniel Beck > > wrote: >

Regarding integration of Advanced Build Discarder(GSoC Idea) with Multi-Branch Pipeline Plugin

Hello everyone, I am Nisarg Shah and I have prepared an application on Advanced Build Discarder for GSoC-2019. I have included one feature of integrating Advanced Build Discarder plugin to be

Re: How to get access to configs/credentials on a UnprotectedRootAction class

On Thu, Apr 4, 2019 at 6:52 AM Daniel Beck wrote: > Create a GlobalConfiguration Easiest to start with https://github.com/jenkinsci/archetypes#usage even if you throw away the toy plugin afterwards. I am not sure what kind of “credentials” you are referring to here. To validate a token you

Re: How to get access to configs/credentials on a UnprotectedRootAction class

Create a GlobalConfiguration annotated with @Extension and use ExtensionList.lookupSingleton to access it from your UnprotectedRootAction. > On 4. Apr 2019, at 12:17, Daniel Anechitoaie wrote: > > I have a class that exposes a Webhook and I'd like to check the validity of > the token from the

Re: Creating a new Gitlab SCM Plugin with Multibranch Pipeline support

Hi Owen, I am really glad this thread got your attention. Firstly, I would like to apologise for being critical about the multi-branch pipeline support in Gitlab Plugin. I acknowledge a lot of hard work and time must have been dedicated to develop the Gitlab plugin. I have been spending time with

How to get access to configs/credentials on a UnprotectedRootAction class

I have a class that exposes a Webhook and I'd like to check the validity of the token from the incoming request. On a builder class I was able to retrieve the configs trough the getDescriptor() class. How can I do this on a UnprotectedRootAction class? -- You received this message because you

Re: Creating a new Gitlab SCM Plugin with Multibranch Pipeline support

I maintain the GitLab plugin, but unfortunately in the last few months I have had no time to dedicate to it. I have been hoping that a capable and motivated person would offer to take over maintaining it, but so far that has not happened. I have also lobbied CloudBees a little bit to invest