Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-05 Thread Jesse Glick
On Fri, Aug 5, 2016 at 4:52 PM, Mark Waite wrote: > - change jenkins.MasterToSlaveFileCallable to > FileCallable Vice-versa I guess you mean. > - add checkRoles(RoleChecker) to HudsonTestCase Probably basically the same change: SECURITY-144. > My recollection (when

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-05 Thread Mark Waite
On Fri, Aug 5, 2016 at 2:04 PM Jesse Glick wrote: > On Fri, Aug 5, 2016 at 7:57 AM, Mark Waite > wrote: > > The git client plugin (1.19.7 and > > it predecessors) matches the situation you describe (old Jenkins > baseline, > > not recent release,

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-05 Thread Jesse Glick
On Fri, Aug 5, 2016 at 7:57 AM, Mark Waite wrote: > The git client plugin (1.19.7 and > it predecessors) matches the situation you describe (old Jenkins baseline, > not recent release, does not compile without changes against current core). Why exactly does it not

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-05 Thread Slide
+1 to Mark's comments. On Fri, Aug 5, 2016 at 4:57 AM Mark Waite wrote: > Replies inline > > > On Fri, Aug 5, 2016 at 1:51 AM Manuel Jesús Recena Soto > wrote: > >> Hello Mark, >> >> In advance, thanks for your feedback. >> >> (replies inline) >> >>

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-05 Thread Mark Waite
Replies inline On Fri, Aug 5, 2016 at 1:51 AM Manuel Jesús Recena Soto wrote: > Hello Mark, > > In advance, thanks for your feedback. > > (replies inline) > > 2016-08-04 21:27 GMT+02:00 Mark Waite : > > > > On Thu, Aug 4, 2016 at 12:46 PM Manuel

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-05 Thread Manuel Jesús Recena Soto
Hello Mark, In advance, thanks for your feedback. (replies inline) 2016-08-04 21:27 GMT+02:00 Mark Waite : > > On Thu, Aug 4, 2016 at 12:46 PM Manuel Jesús Recena Soto > wrote: >> >> Hello Oliver, >> >> I like the idea. >> >> General speaking, ATH

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-04 Thread Slide
With releases coming often, it is hard to test against the latest Jenkins when trying to deal with issues and so forth. Most maintainers just don't have the time to test against the latest release, the latest LTS and a few things in between. On Thu, Aug 4, 2016 at 12:23 AM ogondza

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-04 Thread Mark Waite
On Thu, Aug 4, 2016 at 12:46 PM Manuel Jesús Recena Soto wrote: > Hello Oliver, > > I like the idea. > > General speaking, ATH and PCT are very important and we should look after > its healthy. > > IMHO, PCT results are a nice place to figure out bad symptoms on some > plugins.

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-04 Thread Manuel Jesús Recena Soto
Hello Oliver, I like the idea. General speaking, ATH and PCT are very important and we should look after its healthy. IMHO, PCT results are a nice place to figure out bad symptoms on some plugins. Please, find here two issues as result of PCT: JENKINS-36646

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-04 Thread Jesse Glick
On Wed, Aug 3, 2016 at 9:31 AM, Oliver Gondža wrote: > Is somebody working on this? Maybe ask andresrc. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it,

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-04 Thread ogondza
Right, not the best wording. What I had in mind is: "It is something we would like to have confirmed before declaring the release is good to go". Unfortunately, many maintainers do not put that much effort into making sure their plugins work with latests cores, myself including. -- oliver --

Re: Automate recommended plugin unittest run against latest Jenkins core

2016-08-03 Thread Mark Waite
I don't understand why you would make that a GA criteria for releases, or for LTS releases. Can you explain in more detail what you're trying to confirm with that check? I had maintained a separate branch of the git client plugin which depended on the latest LTS release (called

Automate recommended plugin unittest run against latest Jenkins core

2016-08-03 Thread Oliver Gondža
Hi, I created an issue[1] to verify if all recommended plugins has passing unittest when run against latest core. I would like to use that as a GA criteria for releases, LTS ones at least. I see people are still updating plugin-compat-tester so I guess it is not dead, though I did not