Re: Guideline for upgrading plugin to JDK 9+

> On 21. Oct 2019, at 23:39, Damian Szczepanik > wrote: > > I had to upgrade org.jenkins-ci.plugins:plugin what also upgrades property > jenkins.version so I expect that some older Jenkins installations won't be > able to see new version via plugin manager? You can choose an older

Re: Guideline for upgrading plugin to JDK 9+

Title: Re: Guideline for upgrading plugin to JDK 9+ That pom.xml was helpful. I had to upgrade org.jenkins-ci.plugins:plugin what also upgrades property jenkins.version so I expect that some older Jenkins installations won't be able to see new version via plugin manager? Damian Here

Re: Guideline for upgrading plugin to JDK 9+

We had to update the enforcer plugin to work around the bug where it was reading code from META-INF where it's not supposed to. See here for example: https://github.com/jenkinsci/audit-log-plugin/blob/master/pom.xml#L202-L214 On Mon, Oct 21, 2019 at 6:08 AM Oleg Nenashev wrote: > Just to add

Re: Guideline for upgrading plugin to JDK 9+

Just to add some info about using Java 9+ in plugins JEP-211 requires plugins to stay on Java 8. If necessary, they can indeed go to higher version, but Plugin POM does not fully support it. https://github.com/jenkinsci/plugin-pom/pull/133 would need to be finished and integrated. Note that,

Re: Guideline for upgrading plugin to JDK 9+

Here is an example on how to suppress those files: https://github.com/jenkinsci/warnings-ng-plugin/blob/master/pom.xml#L922 > Am 20.10.2019 um 23:37 schrieb Damian Szczepanik > : > > I think that's the second option:

Re: Guideline for upgrading plugin to JDK 9+

> Should I upgrade the plugin to JDK 9+ or it's not mandatory because from SLA perspective Jenkins should be upgraded? I believe jenkins core is still minimum requirement of java 8. According to https://jenkins.io/doc/administration/requirements/java/ 9 and 10 are explicitly not supported. So

Re: Guideline for upgrading plugin to JDK 9+

Title: Re: Guideline for upgrading plugin to JDK 9+ I think that's the second option: [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ cucumber-reports --- [INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-annotations:jar:2.10.0.pr2:compile contains module

Re: Guideline for upgrading plugin to JDK 9+

You should not change to JDK 9 if not absolutely necessary. Did your dependency really change the API to JDK 9? Or did they just compile with JDK 9 and add a module information file which requires the increased class file level? Those files can be ignored in the pom... > Am 20.10.2019 um

Guideline for upgrading plugin to JDK 9+

Hi, After upgrading some plugin dependencies I found that dependency is compiled against JDK 9 while my plugin still uses 8 - compilation has failed. Is there any recommendation, guideline, best practices that guide about: 1. Should I upgrade the plugin to JDK 9+ or it's not mandatory