Re: Prettier for formatting supported languages in Jenkins core

2022-08-13 Thread Tim Jacomb
We have eslint as well to do things like what you said My preference is for opinionated formatters so we don’t have to worry about debating options and it does a really good job by just automatically formatting it, you don’t get red lines in your IDE as you type distracting you like you do with

Re: Prettier for formatting supported languages in Jenkins core

2022-08-12 Thread 'Gavin Mogan' via Jenkins Developers
I know i said I had issues with prettier being opinionated, but my issue wasn't the opinions it had, just that it wasn't very flexible. My personal projects I usually import one of the opinionated rulesets to eslint and have it done, but eslint is infinitely configurable, while my experience, at

Re: Prettier for formatting supported languages in Jenkins core

2022-08-09 Thread Basil Crow
On Tue, Aug 9, 2022 at 2:46 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > > I think it's the key point about the complaints again Prettier, it's a very > opinionated, meaning that it's not about our subjectivity, but reusing the > one from its author. There is no truth about what

Re: Prettier for formatting supported languages in Jenkins core

2022-08-08 Thread 'Gavin Mogan' via Jenkins Developers
I've always found prettier very opinionated and frustrating to use. Personally I prefer eslint --fix, which lets you have very fine control on a lot of things. But no matter what, I'm 100% in favor of automated tools managing code style. On Mon, Aug 8, 2022 at 1:15 PM Basil Crow wrote: > >

Re: Prettier for formatting supported languages in Jenkins core

2022-08-08 Thread Basil Crow
First of all, huge thank you to Tim for working on this effort! +1 from me. I think a consistent and automatically applied set of formatting rules will make it easier to read and edit these files in the future. The most significant objections I have heard so far were that Prettier poorly formats

Prettier for formatting supported languages in Jenkins core

2022-08-08 Thread Tim Jacomb
Hi all Looking for any feedback on the proposal of using prettier for formatting Jenkins core with the supported languages: - JavaScript - CSS - HTML - Markdown - Yaml See: https://github.com/jenkinsci/jenkins/pull/6863 Thanks Tim -- You received this message because you are