Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-06-26 Thread Matt Sicker
Thanks, Oleg! On Tue, Jun 25, 2019 at 5:39 PM Oleg Nenashev wrote: > > UPD: User docs have been integrated and tested: > https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.adoc > I plan to make a blogpost later, but I believe this story can be considered > as completed

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-06-25 Thread Oleg Nenashev
UPD: User docs have been integrated and tested: https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.adoc I plan to make a blogpost later, but I believe this story can be considered as completed for Jenkins plugin maintainers. Whomever is interested, feel free to start using

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-06-19 Thread Oleg Nenashev
Meanwhile now we have more than 20 repositories with Release Drafter enabled. I have created https://github.com/jenkinsci/.github/pull/8 to document usage in the jenkinsci organization (quick hack). Any feedback will be appreciated. On Wednesday, May 29, 2019 at 1:02:47 PM UTC+2, Daniel Beck

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-29 Thread Daniel Beck
> On 28. May 2019, at 22:37, Tim Jacomb wrote: > > Afaik admin role is granted in general now, since the introduction of danger > zone permission protection. This is correct. Obviously, many people have write access specifically, either because they were added while we had implemented the

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-28 Thread Tim Jacomb
Afaik admin role is granted in general now, since the introduction of danger zone permission protection. I’m admin on a plugin that was hosted a couple of months ago, without me asking for it at all... Thanks Tim On Tue, 28 May 2019 at 18:58, Oleg Nenashev wrote: > We usually do not grant

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-28 Thread Oleg Nenashev
We usually do not grant ADMIN role permissions to maintainers, but some plugins indeed use admin. I prefer to focus on a more common case in the guidelines BR, Oleg On Tue, May 28, 2019, 18:40 Tim Jacomb wrote: > I’m pretty sure maintainers can just add the app themselves as it’s > approved

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-28 Thread Tim Jacomb
I’m pretty sure maintainers can just add the app themselves as it’s approved for the org, assuming they have admin permission on the repo I didn’t need an infra ticket when I set it up on the slack plugin... Thanks Tim On Tue, 28 May 2019 at 15:02, Oleg Nenashev wrote: > I agree it makes

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-28 Thread Jesse Glick
On Sat, May 25, 2019 at 7:29 AM Oleg Nenashev wrote: > If you want to try out Release Drafter in your repos, let me know. Certainly in `plugin-pom` and friends. Can we just create a `.github/release-drafter.yml` and have it start working, or is there some other step? A small guide in

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-25 Thread Oleg Nenashev
Since there is a consensus in this thread, I went ahead and implemented this story: - Default configuration: https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.yml - Pull request which merges the configuration for BlueOcean and Configuration-as-Code plugins:

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-25 Thread Daniel Beck
> On 24. May 2019, at 19:23, James Nord wrote: > > If there was a way to release community plugins from our infra then you could > do this with a simple command without the need to grant any permissions to > apps. I know of a proposal supposed to be landing soon related to that :) -- You

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-24 Thread Oleg Nenashev
If we speak about GitHub automation, it is easier to use GitHub Actions + Rekease Drafter. https://github.com/toolmantim/release-drafter#usage . Permission issue still applies, but at least you get more control of what's being invoked W.r.t automating releases from ci.jenkins.io, it is a

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-24 Thread James Nord
If there was a way to release community plugins from our infra then you could do this with a simple command without the need to grant any permissions to apps. "jx step changelog" / https://github.com/github-tools/github-release-notes are some possible commands but others exist too. now we

Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-24 Thread Marky Jackson
+1 from me -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-23 Thread Oleg Nenashev
Security concern is indeed an issue there, same for Dependabot and other things. TL;DR: A malicious GitHUb app maintainer can push code to your repo. AFAIK GitHub is well aware about this concern, and they are introducing more and more fine grain permissions. Even if we put configs on a global

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-23 Thread Gavin Mogan
I don't think the warning about release drafter really affects jenkins. Its all open source and public anyways. +1 to standardising on using github releases. I started letting release drafter work and then copy the release notes to confluence just for backwards compability On Thu, May 23, 2019

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-23 Thread Jesse Glick
+1 from me as well. I guess we would consider it a separate though related effort to actually standardize use of Release Drafter, so that plugins.jenkins.io is able to obtain changelogs from the GitHub release metadata rather than Confluence. -- You received this message because you are

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-23 Thread Matt Sicker
GitHub's terribly coarse security API to the forefront once again! On Thu, May 23, 2019 at 6:09 AM Robert Sandell wrote: > +1 I've been hoping we do something like this for a while now but haven't > come up with anything myself :) > > Though it states on the Release Draft App page >

Re: Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-23 Thread Robert Sandell
+1 I've been hoping we do something like this for a while now but haven't come up with anything myself :) Though it states on the Release Draft App page : "Release Drafter requires full write, because GitHub does not offer a limited scope for only writing

Proposal - Introducing Global Probot configuration for Release Drafter and other tools

2019-05-23 Thread Oleg Nenashev
Hi all, Just another GitHub infrastructure thread is here. There is a number of components which started using Release Drafter to automate management of releases notes. Basically, this tool generates changelog drafts using pull request metadata