Re: (another) docker slaves plugin - review request

2015-12-16 Thread Andrew Bayer
Yeah, it's painful and needs serious revisiting. I'd be up for discussions around that for 2.0 or soon after. I think that'd be valuable. A. On Wed, Dec 16, 2015 at 10:52 AM, Kanstantsin Shautsou < kanstantsin@gmail.com> wrote: > I missed my favorite question :) > > Jenkins Cloud API is not

Re: (another) docker slaves plugin - review request

2015-12-16 Thread Kanstantsin Shautsou
I missed my favorite question :) Jenkins Cloud API is not enough for anything IMHO. It was actual 5 years ago when AWS appeared. Today you may want more levels of provisioning: DC locations/groups/machines/containers in it. All cloud plugins are hacks and copy-pastes. Imho issue is in Jenkins

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Nigel Magnay
I haven't fully grokked how the alternative launch scheme works (I assume it's operating as a launcher higher up the food chain). I don't know if this is giving you options of controlling the build environment before it is launched based on the build it is about to execute. I would imagine you

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Nigel Magnay
> > > > nigelm, > > It uses queue listener to look for a label and add a slave . > > Docker has many, many load balancing tools , docker swarm for example. You > can simply point jenkins to your swarm instance for docker. > > I see no reasons why Jenkins would be doing load balancing with docker >

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Surya Gaddipati
So, do you agree that cloud api is not good enough for docker containers ? On Sunday, December 13, 2015 at 12:53:44 PM UTC-6, Surya Gaddipati wrote: > > This is not a hosting request. I am hoping to get some feedback on the > plugin and see if its worth hosting/merging into other plugins. > >

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Surya Gaddipati
> Do you think that the cloud API *ought* to be good enough for docker containers ? Not quite sure what you mean. But yea cloud api should support single use throwaway slaves that are tied to a single build. On Sunday, December 13, 2015 at 12:53:44 PM UTC-6, Surya Gaddipati wrote: > > This

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Kanstantsin Shautsou
> On Dec 15, 2015, at 19:17, Surya Gaddipati wrote: > > >So what is your problem around Cloud API based provisioning? > > 1. Delay in provisioning -> There is no technical reason user has to deal > with this. This is totally a problem we can solve . > 2. Container

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Kanstantsin Shautsou
Hi, that’s wrong info about docker-plugin. docker-plugin support: - provisioning jenkins slaves - building/publish images (duplicated/duplicates docker-build-publish-plugin) - Docker container controls All functionality is written via docker-java library layer. > On Dec 15, 2015, at 18:59, Surya

Re: (another) docker slaves plugin - review request

2015-12-15 Thread 'Yoann Dubreuil' via Jenkins Developers
Hi Surya, Thanks for your reply, I've a few questions below. On Tue, Dec 15, 2015 at 4:43 PM, Surya Gaddipati wrote: > Hi Yoann, > Thank you for your response. > > > I was wondering what was missing to rewrite a simplified version of it. > > So here are couple of

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Kanstantsin Shautsou
> On Dec 15, 2015, at 18:43, Surya Gaddipati wrote: > > Hi Yoann, > Thank you for your response. > > > I was wondering what was missing to rewrite a simplified version of it. > > So here are couple of things that I found needed to be changed > > 1. changed to use

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Surya Gaddipati
Hi nigelm, The important difference between this and all other docker slaves plugin is that this doesn't use jenkins' cloud api for the reasons listed here On Sunday, December 13, 2015 at

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Surya Gaddipati
Hi Yoann, Thank you for your response. > I was wondering what was missing to rewrite a simplified version of it. So here are couple of things that I found needed to be changed 1. changed to use spotify-docker api client instead of command line, I needed it to talk to docker-swarm to

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Kanstantsin Shautsou
Surya, could you describe your use case because it seems that you want two orthogonal features in one? > On Dec 15, 2015, at 18:47, Surya Gaddipati wrote: > > Hi nigelm, > > The important difference between this and all other docker slaves plugin is > that this

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Surya Gaddipati
Hi Kanstantsin , Use case is exactly this https://wiki.jenkins-ci.org/display/JENKINS/Docker+Plugin "The aim of the docker plugin is to be able to use a docker host to dynamically provision a slave, run a single build, then tear-down that slave." But without going through Jenkins Cloud

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Kanstantsin Shautsou
Yes, i'm working on such thing in my new plugin, will notify when will have something working. On Monday, December 14, 2015 at 6:41:26 PM UTC+3, Surya Gaddipati wrote: > > Hi Oleg, > Thank you for your feedback. > > Looks like DockerPlugin uses Jenkins clound api ( link >

Re: (another) docker slaves plugin - review request

2015-12-15 Thread 'Yoann Dubreuil' via Jenkins Developers
Hi Surya, As one of the author of https://github.com/ndeloof/docker-slaves-plugin , I was wondering what was missing to rewrite a simplified version of it. Maybe we could work together to improve this plugin instead? Yoann. On Tue, Dec 15, 2015 at 2:29 PM, Kanstantsin Shautsou <

Re: (another) docker slaves plugin - review request

2015-12-15 Thread Nigel Magnay
> I agree that independent Docker slave makes sense. > IIRC such functionality is provided by one of existing Docker plugins, but > I'm not sure. There're too many of them :( > > If no, I would vote for integrating the proposal into Docker-plugin if > there is no showstoppers. > > ​docker-plugin

Re: (another) docker slaves plugin - review request

2015-12-14 Thread Surya Gaddipati
Hi Oleg, Thank you for your feedback. Looks like DockerPlugin uses Jenkins clound api ( link ) This plugin uses QueueListener to provision slaves . Can

Re: (another) docker slaves plugin - review request

2015-12-14 Thread Oleg Nenashev
I agree that independent Docker slave makes sense. IIRC such functionality is provided by one of existing Docker plugins, but I'm not sure. There're too many of them :( If no, I would vote for integrating the proposal into Docker-plugin if there is no showstoppers. Best regards, Oleg