Re: Adopting xUnit plugin

Hi Nikolas, Done. You are the default assignee now. BR, Oleg On Fri, May 4, 2018 at 7:31 PM, 'Nikolas Falco' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > Please also make me the default recipient on JIRA for xUnit component > otherwise I'm not advised on new ticket > > --

Re: Adopting xUnit plugin

Please also make me the default recipient on JIRA for xUnit component otherwise I'm not advised on new ticket -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email

Re: Adopting xUnit plugin

I was confused because I always lookup at the wrong repository (dtkit-plugin). Should be better change description of that plugin. Actually it appears like DTKit 2.1.3. In my opinion the plugin label should be something "DTKit API Plugin" and a little description. Il giorno mercoledì 2 maggio

Re: Adopting xUnit plugin

Yes, that's what I meant in "DTKit could be made such API plugin, but I do not exactly understand what it does in Jenkins now." On Wed, May 2, 2018 at 6:08 PM, 'Nikolas Falco' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > ok, there is already a plugin that include the

Re: Adopting xUnit plugin

ok, there is already a plugin that include the libdtkit https://github.com/jenkinsci/dtkit-plugin. Maybe I could move xUnit dependencies from libdtkit to dtkit-plugin Il giorno mercoledì 2 maggio 2018 16:33:50 UTC+2, Jesse Glick ha scritto: > > On Wed, May 2, 2018 at 9:29 AM, 'Nikolas Falco'

Re: Adopting xUnit plugin

On Wed, May 2, 2018 at 9:29 AM, 'Nikolas Falco' via Jenkins Developers wrote: > So you suggest to move code from DTKit into xUnit plugin IIUC the recommendation was simply to take the existing library and repackage it as a plugin (with no user-facing features).

Re: Adopting xUnit plugin

Hi Oleg, I think the DTKit plugin library was done externally to make extension easier. For example a plugin could extends org.jenkinsci.lib.dtkit.type.TestType other few interfaces to be added as tool type on xUnit plugin regardless of the version of xunit and its dependencies. -

Re: Adopting xUnit plugin

Thanks for it Nikolas! Please feel free to ping me or code-reviewers if you need any help with reviews. Best regards, Oleg On Sunday, April 15, 2018 at 9:32:25 AM UTC+2, Nikolas Falco wrote: > > Good news, a pull request has been submitted - >

Re: Adopting xUnit plugin

Good news, a pull request has been submitted - https://github.com/jenkins-infra/repository-permissions-updater/pull/668 Il giorno mercoledì 11 aprile 2018 23:48:35 UTC+2, Andrew Bayer ha scritto: > > That'd be fine by me. > > A. > > On Mon, Apr 9, 2018 at 6:35 AM, 'Nikolas Falco' via Jenkins

Re: Adopting xUnit plugin

That'd be fine by me. A. On Mon, Apr 9, 2018 at 6:35 AM, 'Nikolas Falco' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > I know that the xUnit plugin was already adopted on 15/11/2017 ( > https://groups.google.com/forum/#!searchin/jenkinsci- >

Re: Adopting xUnit plugin

Hi Any plans to release new version of xUnit before PR (https://github.com/jenkinsci/xunit-plugin/pull/49/files) is merged? :) Basically, I'm interested in two PRs: - https://github.com/jenkinsci/xunit-plugin/pull/47 (it's even approved already) -

Re: Adopting xUnit plugin

> On 14. Nov 2017, at 21:44, Andrew Bayer wrote: > > ...but could someone with ownership rights for > github.com/jenkinsci/xunit-plugin update the repo description to > https://plugins.jenkins.io/xunit? Thanks. Done. -- You received this message because you are

Re: Adopting xUnit plugin

...but could someone with ownership rights for github.com/jenkinsci/xunit-plugin update the repo description to https://plugins.jenkins.io/xunit? Thanks. A. On Tue, Nov 14, 2017 at 3:41 PM, Andrew Bayer wrote: > And yes, I've updated the JIRA component owner myself. =)

Re: Adopting xUnit plugin

And yes, I've updated the JIRA component owner myself. =) A. On Tue, Nov 14, 2017 at 3:38 PM, Andrew Bayer wrote: > Done - https://github.com/jenkins-infra/repository-permissions- > updater/pull/503 > > On Tue, Nov 14, 2017 at 2:51 PM, Daniel Beck

Re: Adopting xUnit plugin

Done - https://github.com/jenkins-infra/repository-permissions-updater/pull/503 On Tue, Nov 14, 2017 at 2:51 PM, Daniel Beck wrote: > > > On 14. Nov 2017, at 18:50, Andrew Bayer wrote: > > > > I guess I'll take it? =) GitHub and Jenkins infra usernames

Re: Adopting xUnit plugin

> On 14. Nov 2017, at 18:50, Andrew Bayer wrote: > > I guess I'll take it? =) GitHub and Jenkins infra usernames are both abayer. > Thanks! This is another one of Gregory's plugins, thanks for taking over! File a PR in

Re: Adopting xUnit plugin

+1. Generally you have enough permissions to transfer Ownership on your own ;) вторник, 14 ноября 2017 г., 18:50:43 UTC+1 пользователь Andrew Bayer написал: > > Hey - > > So I want to get some changes into xUnit, and noticed the plugin is up for > adoption. So...I guess I'll take it? =) GitHub