Re: Prettier for formatting supported languages in Jenkins core

2022-08-09 Thread Basil Crow
On Tue, Aug 9, 2022 at 2:46 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > > I think it's the key point about the complaints again Prettier, it's a very > opinionated, meaning that it's not about our subjectivity, but reusing the > one from its author. There is no truth about what

Re: ASM in core

2022-08-17 Thread Basil Crow
Recent weeklies no longer consume ASM. So shall we detach it to a library plugin? -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Next LTS baseline

2022-08-02 Thread Basil Crow
Are we talking about the version of Jetty to be shipped in 2.346.3 or the version of Jetty to be shipped in 2.361.1? 2.361.1 is far enough away that I would be in favor of a backport of Jetty 10.0.11, once it has been in the weekly release for a week or two without serious regressions. This would

Re: Prettier for formatting supported languages in Jenkins core

2022-08-08 Thread Basil Crow
First of all, huge thank you to Tim for working on this effort! +1 from me. I think a consistent and automatically applied set of formatting rules will make it easier to read and edit these files in the future. The most significant objections I have heard so far were that Prettier poorly formats

[Regression] JENKINS-70128 Dismiss button unreadable in old data monitor with dark theme

2023-01-01 Thread Basil Crow
jenkinsci/jenkins#7364 has introduced a regression on the weekly line. JENKINS-70128 contains the steps to reproduce, expected result, and actual result. At the time of this writing,

Re: JDK19 is now available on ci.jenkins.io

2023-01-04 Thread Basil Crow
Many thanks to the infrastructure team for doing this. Fun fact: Java 19 test runs of Jenkins core are (on average) 20-25% faster than Java 11/17 test runs. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group

Re: Request info on Jenkins+JsonWebToken(JWT) re: CVE-2022-23529

2023-01-11 Thread Basil Crow
Based on the output of "yarn info" it does not show up in the dependency tree of Jenkins core. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

[Regression] JENKINS-70112 Pressing "Apply" in a configuration is considered a modification

2023-01-01 Thread Basil Crow
jenkinsci/jenkins#7203 has introduced a regression on the weekly line. JENKINS-70112 contains the steps to reproduce, expected result, and actual result. At the time of this writing,

Re: Next baseline shift

2022-12-07 Thread Basil Crow
On Thu, Dec 1, 2022 at 10:15 AM Basil Crow wrote: > > Next week I will take a look at migrating from Jetty 9 to Jetty 10 in the plugin build toolchain. I released jenkins-test-harness 1912.v0cdf15450b_fb <https://github.com/jenkinsci/jenkins-test-harness/releases/tag/1912.v0cdf

Re: Revert of breadcrumb bar accessibility change

2022-12-09 Thread Basil Crow
On Fri, Dec 9, 2022 at 9:21 AM Tim Jacomb wrote: > Jan has offered a partial reversion instead of a full one > https://github.com/jenkinsci/jenkins/pull/6912#issuecomment-1331319966 It is unclear to me whether the partial revert would address both JENKINS-70169

Revert of breadcrumb bar accessibility change

2022-12-09 Thread Basil Crow
The Jenkins core maintainers aspire to deliver First Customer Ship (FCS) quality all the time on the main branch . The integration of jenkinsci/jenkins#6912

Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread Basil Crow
On Wed, Dec 14, 2022 at 12:37 PM Ullrich Hafner wrote: > > I would suggest to always update the major version of our plugin-pom if we > make breaking changes. This is the second time that we deliver incompatible > changes with the same major version. Perhaps; we do not officially use semantic

Re: Proposal to ensure new plugin hosting requests use Maven instead of Gradle

2022-12-07 Thread Basil Crow
+1 On Wed, Dec 7, 2022 at 2:20 AM Alexander Brandes wrote: > > Hey everyone, > > the Gradle JPI plugin lacks fundamental support of the jenkins.io > infrastructure. > There's no support for automated releases (CD, JEP-229), missing metadata for > the plugin page and a few other limitations,

Re: JDK19 is now available on ci.jenkins.io

2022-12-08 Thread Basil Crow
What Tim said. I am not the biggest fan of an edge label either as this goes against the principle of reproducible builds. The Java 19 agent label can be deprecated in the agent documentation when Java 20 is released (which is minimal effort on the operational side). In general consumers of

Re: Allow up to 2 elected board members from a single company

2022-11-28 Thread Basil Crow
+1 from me as well. Since the time the current rules were established, Kohsuke has begun a new chapter in which he has focused his attention on Launchable and decreased his involvement in the Jenkins community and CloudBees. This proposal

Re: Next baseline shift

2022-11-28 Thread Basil Crow
On Mon, Nov 28, 2022 at 11:38 AM 'Jesse Glick' via Jenkins Developers wrote: > > Independently of that, we can consider switching the default JDK for > ci.jenkins.io `buildPlugin` from 8 to 11. +1 from me regarding the idea. Regarding the implementation, I am not sure to whom you are referring

Re: Problematic releases

2022-11-28 Thread Basil Crow
On Mon, Nov 28, 2022 at 3:54 PM DuMaM wrote: > > How about this release drafter problem? For your Release Drafter problem I would recommend following up in https://github.com/release-drafter/release-drafter/issues/1269 or https://github.com/release-drafter/release-drafter/pull/1255. Release

Next baseline shift

2022-11-28 Thread Basil Crow
Historically we have supported old baselines for a long time in the build toolchain. The current build toolchain supports baselines as far back as 2.249. This provides a high degree of flexibility for plugin maintainers and ultimately end users. Sustaining this level of compatibility across

Re: Next baseline shift

2022-11-28 Thread Basil Crow
On Mon, Nov 28, 2022 at 1:30 PM 'Jesse Glick' via Jenkins Developers wrote: > Not really any of those […] I was soliciting opinions on whether it sounded > desirable and safe enough to try And I was pointing out that it is of more practical value to discuss designs alongside concrete

Re: Servlet container support (was: Nov 28, 2022 Governance Board Agenda)

2022-11-28 Thread Basil Crow
https://github.com/jenkinsci/packaging/pull/350 https://github.com/jenkins-infra/jenkins.io/pull/5747 -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Allow up to 2 elected board members from a single company

2022-11-29 Thread Basil Crow
On Mon, Nov 28, 2022 at 11:57 PM Ullrich Hafner wrote: > Basically, the reasoning for this change is not clear for me. The reasoning is simply that the rate of creation of new governance action items is far higher than their rate of completion; i.e., a lack of bandwidth. Adding a second board

Re: Next baseline shift

2022-11-29 Thread Basil Crow
On Tue, Nov 29, 2022 at 3:19 PM James Nord wrote: > > This bytecode difference trips up spotbugs (causing several new false > positives) that have no option other than to be suppressed, so this change > will likely cause "unrelated" build failures somewhere.

Re: Servlet container support (was: Nov 28, 2022 Governance Board Agenda)

2022-11-29 Thread Basil Crow
Yes I have been surprised at how many users are running Jenkins in Tomcat, or at least how vocal they have been. My gut feeling is that dropping Level 2 support for traditional servlet containers is a non-trivial project: e.g. collecting telemetry to quantify current usage of traditional servlet

Re: Problematic releases

2022-11-27 Thread Basil Crow
https://github.com/dependabot/dependabot-core/blob/c5e5b827af80f60482262ffca0bd9a2bb7a4d73d/maven/lib/dependabot/maven/update_checker/version_finder.rb attempts to filter out prereleases and date-based versions, but in my experience that logic is far from perfect. -- You received this message

Re: Next baseline shift

2022-12-01 Thread Basil Crow
I released the first tranche of PRs in 4.52 . Next week I will take a look at migrating from Jetty 9 to Jetty 10 in the plugin build toolchain. -- You received this message because you are subscribed to the Google Groups "Jenkins

Plugin POM inheritance

2023-01-19 Thread Basil Crow
Should jenkinsci/plugin-pom be made to inherit from jenkinsci/pom? jenkinsci/plugin-pom duplicates a large amount of material from jenkinsci/pom, and inheriting it instead would greatly ease maintenance by allowing the duplicate material to be deleted. There are only a few things in jenkinsci/pom

Re: Plugin POM inheritance

2023-01-20 Thread Basil Crow
Unfortunately the benefits of this idea are severely diminished because Maven does not really support profile inheritance: http://www.dashbay.com/2011/03/maven-profile-inheritance/ https://issues.apache.org/jira/browse/MNG-5127 So while we could deduplicate properties, managed dependencies, and

Re: Removing inactive Core maintainers to reduce risk

2023-01-29 Thread Basil Crow
On Sun, Jan 29, 2023 at 4:52 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > Thanks for the positive feedback! It was positive feedback about the intention, not necessarily the end result. > [To] widen the discussion before the act did not seem necessary. Especially > when such a

Re: Adoption of the GitLab Plugin which has been marked for adoption

2023-01-29 Thread Basil Crow
+1 from me (former maintainer), thanks for helping out! On Sun, Jan 29, 2023 at 6:26 AM Kris Stern wrote: > > Hi everyone, > > I would like to adopt the GitLab Plugin which has been marked for adoption. > > Link of the plugin: https://github.com/jenkinsci/gitlab-plugin > Status of the plugin:

Re: Removing inactive Core maintainers to reduce risk

2023-01-30 Thread Basil Crow
On Mon, Jan 30, 2023 at 3:19 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > A PR merged in a release can be installed. A missing permission is not at > that kind of level of impact. A compromised account with unnecessary commit access could very well have that level of impact if it

Re: Removing inactive Core maintainers to reduce risk

2023-01-27 Thread Basil Crow
On Fri, Jan 27, 2023 at 1:06 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > > For that reason we have decided to remove inactive contributors from the > ‘core’ team. Thanks! Strongly agree that this is a great move. > we decided Was this decision made in concert with other core

Re: Removing inactive Core maintainers to reduce risk

2023-01-31 Thread Basil Crow
On Tue, Jan 31, 2023 at 7:24 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > As it's about reducing the risk and not eliminating it I do not see a reason why we should accept continued exposure. Software supply chain attacks have been increasing in recent years, highlighting the need

Re: requireUpperBoundDeps issue after bom update to 1887.vda_d0ddb_c15c4

2023-03-06 Thread Basil Crow
You can work around the problem as follows: diff --git a/pom.xml b/pom.xml index 67c2f7d..1c6265d 100644 --- a/pom.xml +++ b/pom.xml @@ -51,7 +51,14 @@ io.jenkins.tools.bom bom-2.361.x -1836.vfe602c266c05 +1887.vda_d0ddb_c15c4 +

Re: Jenkins Security Scan now generally available

2023-03-19 Thread Basil Crow
Does the Jenkins Security Scan need to be adapted to use the artifact caching proxy? -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Duties of a plugin maintainer.

2023-03-08 Thread Basil Crow
On Wed, Mar 8, 2023 at 5:13 AM Mark Waite wrote: > I made that mistake with a plugin that I adopted a few months ago. It's last > release had been done many years ago. I adopted it and made the flawed > assumption that the master branch was in good condition, ready to release. I > released a

Re: Proposal to ensure new plugin hosting requests use Maven instead of Gradle

2023-03-22 Thread Basil Crow
Here are the most popular plugins still using Gradle for their build: gradle 232,746 multiple-scms 22,241 allure-jenkins-plugin 17,121 terraform 5,046 checkmarx 4,502 jira-trigger 3,996 blackduck-detect 2,838 npm-yarn-wrapper-steps 2,152 ez-templates 2,145 templating-engine 1,742

Re: Duties of a plugin maintainer.

2023-03-07 Thread Basil Crow
The main duty of a plugin maintainer from my perspective is to not introduce regressions for users of the plugin. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an

Re: *-api-plugin (tests downstream plugins)?

2023-02-21 Thread Basil Crow
Yes, most library plugins do not have sufficient test coverage. They should all have at least one smoke test based on RealJenkinsRule, since JenkinsRule is not a realistic linkage environment. Testing downstream consumers from a PR build is essentially the second half of JENKINS-45047 and would be

Re: Disambiguate and document the merge/close process

2023-03-03 Thread Basil Crow
On Thu, Feb 9, 2023 at 4:54 PM Basil Crow wrote: > > I would like to bring this proposal to a conclusion by March. https://github.com/jenkinsci/jenkins/pull/7516 has been approved; if nobody objects by March 15, I'll assume lazy consensus and merge it. -- You received this message becau

Re: Optional automated source code formatting - prep for JEP

2023-04-12 Thread Basil Crow
On Wed, Apr 12, 2023 at 6:06 AM 'jn...@cloudbees.com' via Jenkins Developers wrote: > Please do not troll [sic] this out until > https://github.com/diffplug/spotless/issues/1559 is fixed I am rejecting this request, as Spotless works fine on Windows in the default configuration. Users of exotic

Re: Jenkins Security Scan now generally available

2023-04-17 Thread Basil Crow
On Sun, Mar 19, 2023 at 7:13 PM Basil Crow wrote: > Does the Jenkins Security Scan need to be adapted to use the artifact > caching proxy? Any answer to this question? -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To

Re: Revise "Bug" template fields on Jira

2023-04-17 Thread Basil Crow
On Mon, Apr 17, 2023 at 2:01 AM Alexander Brandes wrote: > > I would like to propose making the "Environment" and "Description" fields > mandatory for "Bug" type issues on Jira +1 from me -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

Launchable in the Jenkins project

2023-04-17 Thread Basil Crow
I have captured in writing everything I have learned so far about Launchable and how to do model training in a way that is most effective for the Jenkins project: https://docs.google.com/document/d/12LdoAFA566P4LgHhu1L-fuOQuhipxk77tUDXQdNmhss/edit Based on this document, we have three models to

Re: Reimbursement for code signing certificate

2023-04-18 Thread Basil Crow
On Tue, Apr 18, 2023 at 12:03 PM Tim Jacomb wrote: > > +1 +1 from me as well -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Reimbursement for code signing certificate

2023-04-18 Thread Basil Crow
On Tue, Apr 18, 2023 at 12:29 PM 'Gavin Mogan' via Jenkins Developers wrote: > I would argue this discussion should happen before the spending not after. FTR, from JEP-15 (at revision b8bfe17), § 3.3.4 ("Reimbursement process"), lines 193-194: > Expenses should be pre-approved through the

Re: Reimbursement for code signing certificate

2023-04-18 Thread Basil Crow
On Tue, Apr 18, 2023 at 11:23 AM 'Gavin Mogan' via Jenkins Developers wrote: > Shouldn't this be submitted via expensify and approved in the board > mailing list? >From JEP-15 (at revision b8bfe17), § 3.3.2 ("Use of donations"), lines 177-178: > Budget requests should be submitted to the

Re: Jenkins 2.401 as next LTS baseline?

2023-04-21 Thread Basil Crow
+1 for 2.401 as well -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit

Re: Request for adoption of Job DSL and Docker plugins

2023-05-01 Thread Basil Crow
Thank you for your quality contributions to other Jenkins plugins. We appreciate it when a user of a plugin steps up to maintain it, because such maintainers have a good idea of the testing that is required in order to avoid regressions. For plugins with a high user count, we typically want to

Re: Proposal to ensure new plugin hosting requests use Maven instead of Gradle

2023-03-28 Thread Basil Crow
On Mon, Mar 27, 2023 at 7:27 AM 'Herve Le Meur' via Jenkins Developers < jenkinsci-dev@googlegroups.com> wrote: > For those using buildPluginWithGradle() from the shared pipeline library, we could add a note about it in the logs. This was done in jenkins-infra/pipeline-library#629

[Regression] Non-unique IDs

2023-04-07 Thread Basil Crow
jenkinsci/jenkins#5923 introduced a regression concerning non-unique IDs, and jenkinsci/jenkins#7631 fixed the first regression but introduced a second regression, breaking compatibility with multiple

Re: Optional automated source code formatting - prep for JEP

2023-04-08 Thread Basil Crow
https://github.com/jenkinsci/plugin-pom/pull/733 is a non-draft PR that incorporates all previous feedback and reflects practical experience in the Jenkins and Maven projects. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe

Re: Moving ATH tests closer to the code under test

2023-04-10 Thread Basil Crow
On Wed, May 11, 2022 at 7:32 AM Tim Jacomb wrote: > Recently both Jan and myself have hit a number of issues with HtmlUnit not > supporting modern JavaScript. (You implement it and it works fine in the > browser but then the PR test builder blows up and you need to re-implement > it)

Re: Optional automated source code formatting - prep for JEP

2023-04-11 Thread Basil Crow
Thanks to everyone who has adopted the new Spotless configuration. I am trying to get everyone who was already using Spotless migrated over to the new configuration. Once that happens, I might even be able to change the opt-in mechanism from the ugly .mvn_exec_spotless file to a Maven property.

Re: Prototype.js replacing JSON.stringify

2023-04-02 Thread Basil Crow
https://issues.jenkins.io/browse/JENKINS-70906 FTR -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view

Re: Prototype.js replacing JSON.stringify

2023-04-02 Thread Basil Crow
On Sat, Mar 11, 2023 at 3:37 PM Ullrich Hafner wrote: > But this JS code is so deeply nested in Jenkins UI code that I have no clue > on how to fix that... You could open pull requests for one or more of the dozens of currently unassigned subtasks in JENKINS-70906. -- You received this

Disambiguate and document the merge/close process

2023-02-09 Thread Basil Crow
Over the past few months and especially during Hacktoberfest, I have observed several cases where the Jenkins core contribution process did not go as smoothly as it could have gone. After thinking deeply about several examples, I concluded that the existing process contains several ambiguities

Re: Jenkins 2.413 as next LTS baseline?

2023-07-12 Thread Basil Crow
2.414 does have some benefits, like a Prototype fix and an optimization to the End of Life subsystem. The only risky portion is the Safe Restart change, but as Mark mentioned, this could always be patched or backed out if necessary. I audited the Safe Restart change, and it seems safe (no pun

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-07-17 Thread Basil Crow
On Mon, Jul 17, 2023 at 3:58 PM Basil Crow wrote: > > AFAICT it is so that plugins whose required core is 1.577 or earlier > will continue to work if installed on a clean installation. There are > 343 such plugins. Once releases are created whose required core is > 1.578 or later (

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-07-17 Thread Basil Crow
On Mon, Jul 17, 2023 at 1:05 PM Ullrich Hafner wrote: > > Is there a reason that we are still bundling the JUnit plugin in our war? It > has been removed from core quite some years ago... AFAICT it is so that plugins whose required core is 1.577 or earlier will continue to work if installed on

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-07-17 Thread Basil Crow
On Mon, Jun 12, 2023 at 10:39 AM Basil Crow wrote: > > Then https://github.com/jenkinsci/jenkins/blob/c886642632d81091c17d93f16b50c97ffb04d146/war/pom.xml#L406-L412 > needs to be adjusted. JENKINS-71666 <https://issues.jenkins.io/browse/JENKINS-71666> FTR -- You received this

Re: Removing inactive CERT members to reduce risk

2023-07-17 Thread Basil Crow
On Fri, Jul 14, 2023 at 6:55 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > > This email is a continuation of > https://groups.google.com/g/jenkinsci-dev/c/8cy8w7ZqyB8/m/eZfaenQzEAAJ. Is it a continuation if the last post to that thread remains unacknowledged? -- You received

Re: Removing inactive CERT members to reduce risk

2023-07-18 Thread Basil Crow
On Tue, Jul 18, 2023 at 1:05 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > Your proposal about a more extreme approach was discussed and rejected. But not with a valid justification. > that discussion seemed to be sterile from my PoV I fail to see how that discussion is sterile.

Re: Removing inactive CERT members to reduce risk

2023-07-18 Thread Basil Crow
On Tue, Jul 18, 2023 at 10:56 AM 'wfoll...@cloudbees.com' via Jenkins Developers wrote: > > I prefer to have an incremental approach that provides value right now > instead of waiting on a larger effort that will provide value only later in > the future. Why not proceed on both fronts

Re: Prototype.js replacing JSON.stringify

2023-07-18 Thread Basil Crow
Many thanks to everyone who has contributed PRs to remove usages of Prototype. I did a more thorough search for usages of Prototype, this time scanning every .jelly and .js file in the Update Center. I updated the spreadsheet

Re: Jenkins 2.413 as next LTS baseline?

2023-07-17 Thread Basil Crow
There do not appear to be any known user-visible regressions in production code in 2.414, but jenkinsci/jenkins#7872 implies a change in Login Theme (3,757 installations) which has not yet been completed (tracked in JENKINS-71238

Re: Prototype.js replacing JSON.stringify

2023-05-29 Thread Basil Crow
On Mon, May 29, 2023 at 3:40 PM 'Rahul Somasunderam' via Jenkins Developers wrote: > > Will that be a problem? It will be. See https://github.com/jenkinsci/stapler/pull/452. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe

Re: Prototype.js replacing JSON.stringify

2023-05-29 Thread Basil Crow
On Mon, May 29, 2023 at 3:33 PM 'Rahul Somasunderam' via Jenkins Developers wrote: > I tested out uno-choice from the spreadsheet - it doesn't depend on prototype. > I think it's a false positive No. Active Choices calls Prototype's Ajax.Request. It is not a false positive. -- You received

Did Tippy.js add Popper2 to Jenkins core?

2023-05-22 Thread Basil Crow
https://github.com/jenkinsci/bootstrap5-api-plugin/pull/213 (comment) concerns me: > Popper2 is now part of Jenkins core. As far as I can tell the Popper dependency was added when replacing YUI tooltips with Tippy in https://github.com/jenkinsci/jenkins/pull/6408. Has this abstraction now leaked

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Basil Crow
On Tue, May 23, 2023 at 10:18 AM 'Gavin Mogan' via Jenkins Developers wrote: > I tried accessing "Popper.createPopper" on ci.jenkins.io and it doesn't seem > to be defined, so I don't think its exposed? Then why was https://github.com/jenkinsci/bootstrap5-api-plugin/pull/213 needed? -- You

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Basil Crow
It occurs to me that the new Webpack 5 module federation feature could be used to implement dynamic linking with Webpack builds: https://webpack.js.org/concepts/module-federation/ Implementing the tooling for this in the Jenkins ecosystem would likely be an ambitious project of similar scope to

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Basil Crow
I meant that Hafner-style JavaScript library Jenkins plugins could be made to export a federated module instead of (or in addition to) a Stapler adjunct. That would allow those libraries to be consumed from other Jenkins plugins with a Webpack build (e.g., pipeline-graph-view) but without the

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Basil Crow
On Wed, May 24, 2023 at 2:50 PM Ullrich Hafner wrote: > Popper is now part of the Bootstrap plugin. Yes, jenkinsci/bootstrap5-api-plugin@76fd031d8291a9a836264c34b630c8c273102c86 resolves the issue from my perspective. On Wed, May 24, 2023 at 2:46 PM Ullrich Hafner wrote: > I understand that

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-25 Thread Basil Crow
On Thu, May 25, 2023 at 5:24 AM Ullrich Hafner wrote: > Rather than reinventing the wheel we should use more of those rock-solid > component [sic] that are already on the market. Indeed, and I suspect this was the fatal flaw behind Tom Fennelly's effort several years back: his homegrown dynamic

Re: Proposal to ensure new plugin hosting requests use Maven instead of Gradle

2023-05-25 Thread Basil Crow
In addition to what Mark wrote, I would want to see some of our top open-source Gradle-based Jenkins plugins (e.g., Gradle, Terraform, Checkmarx, Jira Trigger, etc.) upgraded to use the latest gradle-jpi-plugin toolchain, a recent LTS release as the Jenkins core baseline, and a recent plugin Bill

Requesting admin access to the jenkinsci GitHub organization

2023-06-05 Thread Basil Crow
I would like to become an organization administrator of the jenkinsci GitHub organization. This would facilitate various efforts I am involved with, such as repository transfers. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-23 Thread Basil Crow
On Tue, May 23, 2023 at 12:28 AM Ullrich Hafner wrote: > In JS and CSS and Jelly we have no concepts of encapsulation and APIs in the > moment. Everything what is available in the browser is public by default. In > JS this is even more complex to hide than in Java. Can Webpack be made to build a

Re: Maven 3.9.2: ready to roll?

2023-05-23 Thread Basil Crow
+1 -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit

Re: Backporting for LTS 2.401.2 has started

2023-06-09 Thread Basil Crow
That makes sense to me, and I think an exception is justified for time-sensitive areas, such as EOL notifications. The feature has been in weeklies without any reports of regression. On Fri, Jun 9, 2023 at 8:34 AM Mark Waite wrote: > I would like to inform users earlier about end of life

Re: Jenkins 2.413 as next LTS baseline?

2023-08-01 Thread Basil Crow
On Mon, Jul 17, 2023 at 8:41 AM Basil Crow wrote: > There do not appear to be any known user-visible regressions in production > code in 2.414, but jenkinsci/jenkins#7872 > <https://github.com/jenkinsci/jenkins/pull/7872> implies a change in > Login Theme (3,757 installations)

Re: JSON license

2023-07-25 Thread Basil Crow
Ought to be made into a library plugin I think. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this

Re: Jenkins 2.413 as next LTS baseline?

2023-07-21 Thread Basil Crow
On Fri, Jul 21, 2023 at 10:42 AM 'jn...@cloudbees.com' via Jenkins Developers wrote: > 2.414 has a regression in the plugin manager. > I would be -1 on this unless that is fixed (currently missing a Jenkins bug > but has been the cause of a lot of ATH failures) >

Re: [ci.jenkins.io] JDK21 availability

2023-08-11 Thread Basil Crow
On Fri, Aug 11, 2023 at 1:11 PM Basil Crow wrote: > Thanks! This was already very helpful as it enabled me to file > JENKINS-71805 <https://issues.jenkins.io/browse/JENKINS-71805>. > I meant JENKINS-71800 <https://issues.jenkins.io/browse/JENKINS-71800>. -- You received

Re: [ci.jenkins.io] JDK21 availability

2023-08-11 Thread Basil Crow
Thanks! This was already very helpful as it enabled me to file JENKINS-71805 . -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from

Re: Drop 2.375.x support from plugin bom

2023-06-26 Thread Basil Crow
No strong feeling one way or another from me. When we began requiring 2.361.x or newer, there was a strong technical reason; namely, it was prohibitively difficult to support Java 11 as a first-class citizen in the toolchain alongside Java 8. There is no similar technical justification in this

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-06-12 Thread Basil Crow
On Wed, May 24, 2023 at 2:50 PM Ullrich Hafner wrote: > > Popper is now part of the Bootstrap plugin. (So somehow in my own Jenkins UI > "core“ to create rich user interfaces without hassle.) Then

Re: Prototype.js replacing JSON.stringify

2023-05-05 Thread Basil Crow
On Mon, Mar 13, 2023 at 3:27 PM 'Gavin Mogan' via Jenkins Developers wrote: > > I think the first steps would be to remove as many of those references from > core before detaching the plugin and making it optional Detaching Prototype to a plugin might work, but it is also likely to create

Re: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:javac: invalid flag: --release

2023-05-11 Thread Basil Crow
On Thu, May 11, 2023 at 8:55 AM 'Gavin Mogan' via Jenkins Developers wrote: > > I think the PR in question is doing exactly that > https://github.com/jenkinsci/bmc-cfa-plugin/pull/42/files#diff-e6ffa5dc854b843b3ee3c3c28f8eae2f436c2df2b1ca299cca1fa5982e390cf8R4-R5 Those lines were not present in

Re: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:javac: invalid flag: --release

2023-05-11 Thread Basil Crow
Please read Jenkins plugin development requires Java 11 or newer . -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it,

Re: Prototype.js replacing JSON.stringify

2023-05-11 Thread Basil Crow
I filed pull requests to remove Prototype.js from about 25 or so plugins. Please review, merge, and release these. Here are some more plugins I identified that are still using Prototype.js. Please file pull requests to remove Prototype.js from these plugins: matrix-auth 264461 blueocean 64506

Re: Prototype.js replacing JSON.stringify

2023-05-18 Thread Basil Crow
2.406 is on track to ship without any usages of Prototype. I have created a tracking spreadsheet to cover Prototype usages in plugins and filed issues for any affected plugin with more than 100

Re: GSoC 2023 Building jenkins.io with alternative tools project feedback solicitation

2023-05-18 Thread Basil Crow
The calculus of this decision seems different when it comes to the documentation portions of the site (e.g., the end user documentation and developer documentation) vs the regular content (e.g., the blog, changelogs, and other static content). I think there may be a sweet spot in using Antora for

Re: GSoC 2023 Building jenkins.io with alternative tools project feedback solicitation

2023-05-19 Thread Basil Crow
On Fri, May 19, 2023 at 10:24 AM 'Gavin Mogan' via Jenkins Developers wrote: > Having been around for a number of the GSOC projects, and a number of the > migration projects. I'm very worried about half finished state that nobody > finishes. And honestly spent a lot of time cleaning up content on

Re: GSoC 2023 Building jenkins.io with alternative tools project feedback solicitation

2023-05-19 Thread Basil Crow
On Fri, May 19, 2023 at 10:24 AM 'Gavin Mogan' via Jenkins Developers wrote: > Having been around for a number of the GSOC projects, and a number of the > migration projects. I'm very worried about half finished state that nobody > finishes. And honestly spent a lot of time cleaning up content on

Re: 2.440.1 Release Lead

2024-01-22 Thread Basil Crow
+1 -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit

Re: Proposal: Stefan Spieker to join the core PR reviewers team

2024-02-18 Thread Basil Crow
+1 On Sun, Feb 18, 2024 at 10:07 PM Mark Waite wrote: > > > On Sunday, February 18, 2024 at 9:30:35 AM UTC-7 Alexander Brandes wrote: > > Hey everyone, > > I would like to propose Stefan Spieker (@StefanSpieker > ) to join the core PR reviewers team. > > Stefan

Re: Banned dependencies error compiling SAML plugin PR

2023-12-18 Thread Basil Crow
Agreed; this is neither recommended nor supported. On Mon, Dec 18, 2023 at 1:09 PM James Nord wrote: > > All the supporting code for providing a warning about this has been removed > from the update center and Jenkins IIRC. > > So you will have no warning when you try and install the plugin -

Re: 2.426.3 Release Lead

2023-12-18 Thread Basil Crow
+1 -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit

Re: JSON license

2023-12-14 Thread Basil Crow
We have also explicitly clarified that public domain dedications and public-domain-equivalent licenses are acceptable in the project governance document. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and

Re: License for library plugins

2023-12-12 Thread Basil Crow
I proposed a (soft) recommendation to the documentation in https://github.com/jenkins-infra/jenkins.io/pull/6936. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an

Re: Banned dependencies error compiling SAML plugin PR

2023-12-12 Thread Basil Crow
As of v6.x, pac4j requires Java 17 or newer. The Jenkins plugin development toolchain will not accept Java 17 bytecode as long as Jenkins core still supports Java 11. You will need to stay on v5.x of pac4j until around fall of next year when Jenkins requires Java 17 or newer. -- You received

<    1   2   3   4   >