Re: commit access

2015-07-30 Thread Jesse Glick
On Thu, Jul 23, 2015 at 8:18 PM, David van Laatum da...@vanlaatum.id.au wrote: The problem we had with the existing jenkins stuff was that it was hard to split up the unit tests using the matrix plugin into equal runtime groups You can use the Parallel Test Executor plugin for this, with a

Re: Best way to figure out the SCM for a com.cloudbees.hudson.plugins.folder.Folder?

2015-08-11 Thread Jesse Glick
On Mon, Aug 10, 2015 at 12:20 PM, Cletus D'Souza cletusdso...@hotmail.com wrote: Could someone nudge in the right direction in terms of figuring out the SCM associated with a com.cloudbees.hudson.plugins.folder.Folder? There is none. A folder is just a collection of items such as projects, some

Re: Office Hour for August 12: Workflow plugin

2015-08-11 Thread Jesse Glick
On Tue, Aug 11, 2015 at 7:32 AM, Vinodhini Vijay vinodhini.vi...@gmail.com wrote: The event time is showing 11:00am PDT in https://wiki.jenkins-ci.org/display/JENKINS/Office+Hours , but pointing to a different time. I tried to change, but it is not reflecting the new time. It was mistakenly

Re: Unable to overwrite JAVA_HOME in Workflow

2015-08-11 Thread Jesse Glick
On Fri, Aug 7, 2015 at 6:37 AM, Rafael Ribeiro Rezende rafaelrez...@gmail.com wrote: if I understood well, the only way to force this Ant installation to use another JAVA_HOME is by resetting the env variable in console before starting my Jenkins instance. Is that right? You could · set

Re: Request for new p4workflow plugin

2015-08-11 Thread Jesse Glick
On Mon, Aug 10, 2015 at 2:54 PM, Daniel Beck m...@beckweb.net wrote: with an explicit dependency to a later jenkins-core (but older parent) you can write plugin code for newer versions, while the plugin will show up as compatible with older releases -- you'll need to take care of properly

Re: Migrating the Jenkins plugin archetype to Workflow

2015-08-11 Thread Jesse Glick
On Fri, Aug 7, 2015 at 12:06 PM, Rafael Ribeiro Rezende rafaelrez...@gmail.com wrote: Yes. The migration is very simple, but might save beginners the trouble of doing so in a later stage, since they are compelled to override the more generic perform(...) which works for both freestyle and

Re: Revisiting bundled plugins

2015-08-06 Thread Jesse Glick
On Wed, Aug 5, 2015 at 1:56 AM, Kohsuke Kawaguchi k...@kohsuke.org wrote: We add the following plugins and their dependencies: git parameterized-trigger workflow -1, no new bundled plugins. Then remove the following plugins: cvs (split from core in 1.340, 929KB) ant (split from core in

Re: Unable to overwrite JAVA_HOME in Workflow

2015-08-06 Thread Jesse Glick
On Thu, Aug 6, 2015 at 8:28 AM, Rafael Ribeiro Rezende rafaelrez...@gmail.com wrote: I need to get my JAVA_HOME environment variable from within my MyPublisher plugin's perform method. So, I do the following: EnvVars env = run.getEnvironment(listener); `Run.getEnvironment` produces

Re: Data loss in the Jenkins CI issue tracker

2015-08-13 Thread Jesse Glick
On Thu, Aug 13, 2015 at 11:04 AM, Daniel Beck m...@beckweb.net wrote: look for messages containing your jenkins-ci.org user name or email address that were posted between July 15 and July 17 Tip: https://groups.google.com/forum/#!searchin/jenkinsci-issues/YOURNAMEHERE%7Csort:date -- You

Re: docker-commons support for DOCKER_CONFIG

2015-08-13 Thread Jesse Glick
On Wed, Aug 12, 2015 at 6:39 PM, nicolas de loof nicolas.del...@gmail.com wrote: Let's say I have slave with 2 executors, and two jobs running docker push to registry, with distinct credentials, running concurrently - job 1 do set .docker/config.json with credentials c1 - job 2 do set

Re: Changes section in a workflow job

2015-08-10 Thread Jesse Glick
On Mon, Aug 10, 2015 at 10:13 AM, Lakshmi Narasimhan Vaikuntam vaikuntam.narasim...@gmail.com wrote: is this an issue with Workflow job type? Seems to be. I filed JENKINS-29881. -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To

Re: Snippet generator for a SCMStep with one argument constructor generates incorrect groovy

2015-08-10 Thread Jesse Glick
On Mon, Aug 10, 2015 at 10:30 AM, Lakshmi Narasimhan Vaikuntam vaikuntam.narasim...@gmail.com wrote: public class A { You must: `extends AbstractDescribableImplA` and create `A/config.jelly`. @DataBoundConstructor public A( String arg1, String arg2) { } You also need public getters

Re: Snippet generator for a SCMStep with one argument constructor generates incorrect groovy

2015-08-10 Thread Jesse Glick
By the way please come to my Office Hour on Wednesday if you can. https://wiki.jenkins-ci.org/display/JENKINS/Office+Hours -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To unsubscribe from this group and stop receiving emails from it,

Re: Querying for build parameters

2015-08-10 Thread Jesse Glick
On Mon, Aug 3, 2015 at 2:49 AM, Lakshmi Narasimhan Vaikuntam vaikuntam.narasim...@gmail.com wrote: For a freestyle job, using these two apis gives the same set of parameters 1) /api/xml?tree=property[parameterDefinitions[name,type]] That is right. You are looking up

Re: revisit ToolInstallation (Default)

2015-07-27 Thread Jesse Glick
+1 on your proposal except On Wed, Jul 1, 2015 at 4:41 PM, nicolas de loof nicolas.del...@gmail.com wrote: ToolInstallation selector only get displayed on UI when there's more than just on[e] installation I would recommend the selector be displayed unconditionally. Principle of least

Re: @reviewbybees pull requests

2015-07-27 Thread Jesse Glick
On Fri, Jul 3, 2015 at 10:48 AM, Ullrich Hafner ullrich.haf...@gmail.com wrote: I don’t see why it is helpful to make intermediate work visible to plug-in authors, it creates a lot of unwanted noise. I think it would be sufficient that you make code reviews within your forked repository. When

Re: Workflow Plugin and Snippet Generator

2015-07-27 Thread Jesse Glick
On Thu, Jul 2, 2015 at 11:40 AM, Gregory Symons gsym...@gsconsulting.biz wrote: I'm currently working on updating the analysis suite plugins to work with the workflow plugin I hope you are coördinating with @amuniz who is also working on this?

Re: revisit ToolInstallation (Default)

2015-07-27 Thread Jesse Glick
On Thu, Jul 2, 2015 at 6:09 PM, Martin Weber fifteenknots...@gmail.com wrote: BuildSteps inside jobs in turn just reference the selected tool installation by its never changing PID (instead of its name as currently, which causes the annoying behavior). I think I would be -1 on this. Like

Re: [workflow] can a Step create child Steps?

2015-07-27 Thread Jesse Glick
On Fri, Jul 24, 2015 at 12:00 PM, James Strachan james.strac...@gmail.com wrote: I wonder has anyone ever tried such a thing; written a Step which creates one or more child steps itself? There is no API which would permit a `StepExecution` to create and run another one. What you *can* do is to

Re: How to force the installation of a plugin using the JenkinsRule?

2015-07-27 Thread Jesse Glick
On Mon, Jul 27, 2015 at 3:30 PM, Victor Martinez victormartinezru...@gmail.com wrote: For some reason the gradle plugin is not installed when I run mvn test Not sure, it works for me. -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To

Re: Trigger a build via API and know for sure, the resulting build number

2015-07-27 Thread Jesse Glick
On Mon, Jul 20, 2015 at 1:14 PM, andrew.p.s...@gmail.com wrote: The best solution I can think of right now is to generate a random string to be used as an ID. Post that ID as a parameter than use the API to find which build has that matching ID. Thoughts? Run.queueId (in newer Jenkins

Re: Improvements to the developer docs

2015-07-27 Thread Jesse Glick
On Thu, Jul 16, 2015 at 8:31 AM, Daniel Beck m...@beckweb.net wrote: What parts do you think are documented insufficiently? The relationship between `Describable` and `Descriptor`, and how you are *supposed* to do form binding (recommended idioms as in `ui-samples-plugin`). -- You received

Re: rfc: Solution for Sonar and Xvnc

2015-07-27 Thread Jesse Glick
On Wed, Jul 8, 2015 at 10:51 AM, croesch christian.roe...@icongmbh.de wrote: Are you suggesting, that actually the way the sonar plugin works should be changed? From what little I know of that plugin, yes. -- You received this message because you are subscribed to the Google Groups Jenkins

Re: Jelly Repeatable Items default values

2015-07-27 Thread Jesse Glick
On Thu, Jul 23, 2015 at 8:39 PM, Christopher Orr ch...@orr.me.uk wrote: repeatableProperty has a default field, which specifies the initial list of values for the repeatable collection, if there isn't yet an instance. Unfortunately `repeatableHeteroProperty` does not. Would be a good PR. --

Re: Jenkins 2.0 proposal

2015-10-23 Thread Jesse Glick
On Fri, Oct 23, 2015 at 4:53 AM, d...@fortysix.ch wrote: > They have some points compared to jerkins: > http://concourse.ci/concourse-vs.html#jenkins > ..specially: > - every configuration must be backed in a version control system > - first class support for pipelines Yes, it

Re: Is ArtifactManager nonstandard?

2015-10-23 Thread Jesse Glick
On Fri, Oct 23, 2015 at 12:53 PM, oliver gondža wrote: > said plugins are not using the ArtifactManager as > they likely predates the extension point introduced in Jenkins 1.532. Right. https://issues.jenkins-ci.org/browse/JENKINS-22637 by the way. -- You received this

Re: 2.0 proposal

2015-10-21 Thread Jesse Glick
On Wed, Oct 21, 2015 at 1:28 PM, Kohsuke Kawaguchi wrote: > That there will be more of these problems down the road. Perhaps. More important is the ongoing burden of not knowing whether what you wrote in `src/main/java/**/*.java`, or what you loaded from `*-sources.jar`, is

Re: Testing module with BuildStepMonitor.BUILD

2015-10-27 Thread Jesse Glick
On Mon, Oct 26, 2015 at 10:10 PM, Gavin wrote: > I'm working on a legacy module that has BuildStepMonitor.BUILD. > > I was reading > http://javadoc.jenkins-ci.org/hudson/tasks/BuildStep.html#getRequiredMonitorService() > and it says if I'm not using getPreviousBuild, then I can

Re: Request review and comments: Copyartifact 2.0

2015-10-28 Thread Jesse Glick
On Tue, Oct 27, 2015 at 6:58 PM, Ikedam wrote: > https://wiki.jenkins-ci.org/display/JENKINS/Preview+for+Copy+Artifact+2.0 Very nice. Some technical comments: > VirtualFile (ArtifactManager) doesn't support listing files with ant file > patttens (like */.java) Does `String[]

Re: [Jelly] Configure rendering in "non-permissive" mode: crash if referencing undefined things?

2015-10-27 Thread Jesse Glick
On Tue, Oct 27, 2015 at 12:24 PM, Baptiste Mathus wrote: > is this expected? (I mean, calling something absent and that being just > ignored) Yes. > is there a way to enable an aggressive mode, at least for example in dev > mode, that would just throw a stack trace in my face?

Re: [DISCUSS] Pull Request merge policy for core

2015-10-28 Thread Jesse Glick
On Wed, Oct 28, 2015 at 12:10 PM, Baptiste Mathus wrote: > Jesse says that it might be preferrable to open a new squashed PR I never said anything of the sort. My preference remains to use plain old Git merge and never destroy history, since simplified views of history can

Re: [proposal] coding style for core (jenkins 2.0?)

2015-10-26 Thread Jesse Glick
-0 I guess. I have never had any problem understanding anyone else’s code because of their formatting choices, weird or not. It is the logic that is the problem. Enforced code style, like discussions about code style, has just been a distraction and waste of time in my experience. If you are

Re: [proposal] coding style for core (jenkins 2.0?)

2015-10-26 Thread Jesse Glick
On Mon, Oct 26, 2015 at 12:44 PM, Kanstantsin Shautsou wrote: >> I have never had any problem understanding anyone else’s code because of >> their formatting choices > > Because you know very well this code base How do you think I got to know (some of) the code base

Re: Is ArtifactManager nonstandard?

2015-10-22 Thread Jesse Glick
On Thu, Oct 22, 2015 at 6:33 AM, Robert Sandell wrote: > If copy Artifacts plugin isn't using the ArtifactManager I would consider > that a bug that should be fixed It is already filed for that plugin and IIRC the maintainer was looking into fixing it, but I do not know

Re: Looking for some help with a baffling plugin bug (ansicolor)

2015-10-22 Thread Jesse Glick
On Wed, Oct 21, 2015 at 1:38 PM, Owen Mehegan wrote: > Turns out this was a failure of the plugin to migrate its global > configuration after some code was refactored. Open to any guidance about > best practices for doing that cleanly during an upgrade.

Re: Update one f:dropdownList when a selection is changed in another

2015-11-10 Thread Jesse Glick
On Tue, Oct 27, 2015 at 11:34 AM, Kirill wrote: > what about case when there are two elements? First of all, you should be using `f:dropdownDescriptorSelector` for data binding, rather than a raw `f:dropdownList`. Probably what you are asking for is not possible without

Re: [proposal] coding style for core (jenkins 2.0?)

2015-11-10 Thread Jesse Glick
On Tue, Nov 10, 2015 at 3:22 PM, Stephen Connolly wrote: > None of those match "Jesse"-style so hopefully we can kill that abomination > off ;-) CheckStyle is a syntactic, not semantic, processor so it cannot distinguish between adjectival annotations,

Re: Upgrading Plugin to use Credentials

2015-11-14 Thread Jesse Glick
`ItemListener.onLoaded` perhaps. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on

Re: [ANN] - Serious regressions in plugins due to the SECURITY-206 fix

2015-11-14 Thread Jesse Glick
Please hold off on any action while the issue is being analyzed. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Update one f:dropdownList when a selection is changed in another

2015-11-12 Thread Jesse Glick
On Thu, Nov 12, 2015 at 9:21 AM, Kirill wrote: > I guess this sample plugin should be updated as well. Pull requests welcome. > Do you have a more interactive community, like an IRC chat? https://wiki.jenkins-ci.org/display/JENKINS/IRC+Channel > I'd like to > invest into

Re: [workflow-plugin] Computer.currentComputer() returns null

2015-11-12 Thread Jesse Glick
On Thu, Nov 12, 2015 at 9:45 AM, Rafael Ribeiro Rezende wrote: > Is it a bug? misconfiguration? or I'm not expected to use this command with > workflow at all? You should not rely on `Computer.currentComputer` inside `SimpleBuildStep.perform`. You can get the

Re: Help needed with Workflow support in gitlab-plugin

2015-11-12 Thread Jesse Glick
On Wed, Nov 11, 2015 at 6:22 PM, Owen B. Mehegan wrote: > I can't figure out how to access the branch parameters that the > plugin is setting. If you look at the 'Using it with a job' section of the > readme, it has you configure Git to expect variables like

Re: How to run multiple Jenkins Unit tests in parallel?

2015-11-12 Thread Jesse Glick
On Thu, Nov 12, 2015 at 10:07 AM, Kirill wrote: > I have like 35 tests, and it takes approximately 9 minutes to execute them. > I want to reduce this time. I use the default Surefire settings, and if I > try to play around with forking options like advised on Surefire page The

Re: workflow groovy odd result

2015-11-02 Thread Jesse Glick
On Mon, Nov 2, 2015 at 5:52 PM, Nigel Magnay wrote: > def a = ["a", "b", "c", 3]; > > def b = a.find() { x -> x instanceof Integer }; The infamous: https://issues.jenkins-ci.org/browse/JENKINS-26481 -- You received this message because you are subscribed to the Google

Re: Jenkins 2.0 proposal

2015-10-14 Thread Jesse Glick
On Wed, Oct 14, 2015 at 7:10 AM, ogondza wrote: > Countless instances will have to use both the DB and the FS as backend > simultaneously for some time. If this will span several upgrades, downgrades > will be a pain for the whole time. Downgrades are already unsafe. In

Re: Upgrading Plugin to use Credentials

2015-10-19 Thread Jesse Glick
On Sat, Oct 17, 2015 at 1:40 PM, Gavin wrote: > I won't turn down any examples on upgrading to credentials though. `ssh-plugin` IIRC. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and

Re: Proposal: Use the same DSL for the job-dsl-plugin and for the workflow-plugin

2015-10-19 Thread Jesse Glick
On Sat, Oct 17, 2015 at 5:43 PM, Stefan Wolf wrote: > the main advantage of the workflow approach is that you > can instantiate plugins and these do not depend on the workflow plugin > itself. The main disadvantage is that the dsl you obtain is not very nice. See

Re: 2.0 - breaking out into multiple tracks

2015-10-08 Thread Jesse Glick
On Thu, Oct 8, 2015 at 3:00 AM, Andrew Bayer wrote: > Pluggable storage/database backend - Scope to be determined, myself as > shepherd, target release date of April 2016. This seems a very optimistic schedule based on my experience of what ought to have been far simpler

Re: jenkins.ci library releases.

2015-10-08 Thread Jesse Glick
On Thu, Oct 8, 2015 at 6:44 AM, James Nord wrote: > "[maven-release-plugin] (jnord) some-funky-library-1.2.3-4" - but this > would be the user on the CI system not the user on github. > > Would that work for you jesse? Sure, better than nothing. -- You received this

Re: How to restore the setting encrypted by credential plugin?

2015-10-08 Thread Jesse Glick
On Thu, Oct 8, 2015 at 3:16 AM, Ryanivanka wrote: > I tried to backup all the jenkins home, and re-deploy to a new machine, all > the credentials seems to fail, is the key have something related to machine > environment? No. Perhaps you missed some files. -- You

Re: 2.0 proposal

2015-10-19 Thread Jesse Glick
On Mon, Oct 19, 2015 at 2:19 PM, Kohsuke Kawaguchi wrote: > Queue.Item.id has known fixed set of subtypes, so we can restrict the rewrite > to a much smaller subset. Not sure I follow that. IIUC the problem is outside references to `id`. The number of subtypes of `Item` (and

Re: Plugin releases Twitter bot source?

2015-10-20 Thread Jesse Glick
FYI, there is also a feed for plugins which appear on the CloudBees update center (which is normally a superset of the regular Jenkins UC, though it is generated by a different system): https://twitter.com/jepluginrelease -- You received this message because you are subscribed to the Google

Re: 2.0 proposal

2015-10-20 Thread Jesse Glick
On Tue, Oct 20, 2015 at 2:38 PM, Kohsuke Kawaguchi wrote: > …this is relatively easily achievable by moving the transformed code into a > separate method so that bytecode index remain the same. I am not going to sleep more soundly tonight. :-) I think the broader issue is that

Re: Proposal: Use the same DSL for the job-dsl-plugin and for the workflow-plugin

2015-10-20 Thread Jesse Glick
On Tue, Oct 20, 2015 at 5:24 PM, Stefan Wolf wrote: >> https://issues.jenkins-ci.org/browse/JENKINS-29922 >> >> Part of this would include adding a common annotation which in the >> future Job DSL (and YAML Project, etc.) could interpret as well. > > I see. This is how we get

Re: Jenkins 2.0 proposal

2015-10-14 Thread Jesse Glick
On Tue, Oct 13, 2015 at 5:59 PM, Kanstantsin Shautsou wrote: > I feel that should be analog of transientProjectFactory for builds. You can use `TransientActionFactory` where appropriate. -- You received this message because you are subscribed to the Google Groups

Re: 2.0 proposal

2015-10-19 Thread Jesse Glick
On Mon, Oct 19, 2015 at 9:13 AM, James Nord wrote: > there shall not be any use of the bytecode-compatibility-transformer and > @AdaptField. I see your point; this looks very scary, and we clearly do not have any JVM experts on hand to design a system that is truly

Re: 2.0 website: tech track

2015-10-12 Thread Jesse Glick
On Fri, Oct 9, 2015 at 6:54 PM, Kohsuke Kawaguchi wrote: > There's a proposal on the table best summarized in this post and then in > this Wiki page. This proposal seems to have a good support LGTM but is unclear on what content would *remain* in the wiki, at least in the

Re: Jenkins CI Plugin run on slave

2015-10-12 Thread Jesse Glick
On Mon, Oct 12, 2015 at 7:35 AM, Christoph M wrote: > On the slave I need logging to the > master, passing parameters from the master and launching processes on the > slave. I see no compelling reason to use a callable here at all. Replace your uses of `File` with `FilePath`

Re: [2.0] Website rebump

2015-10-07 Thread Jesse Glick
On Wed, Oct 7, 2015 at 1:34 PM, Daniel Beck wrote: > Visitors will be able to comment on _everything_. Basically like the wiki > today Wait, we are allowing comments on pages? Sounds like a bad idea. In the current wiki these are often incorrect, digressive, misleading, and/or

Re: jenkins.ci library releases.

2015-10-07 Thread Jesse Glick
On Tue, Oct 6, 2015 at 5:54 AM, James Nord wrote: > you can perform releases directly from Jenkins™ (just as you can with the > plugins). Can we have the committer or author set to the logged-in user? Otherwise we just have no idea who performed a release.

Re: Upgrade jsch to fix "Algorithm negotiation failed"

2015-10-12 Thread Jesse Glick
On Mon, Oct 12, 2015 at 4:53 PM, Arnaud Héritier wrote: > This problem is for all plugins using jsch with recent versions of ubuntu > (and probably more distros). > A quick grep in our repos gives this list of plugins using a version < > 0.1.51 Yikes, probably we should

Re: 2.0 - breaking out into multiple tracks

2015-10-09 Thread Jesse Glick
On Fri, Oct 9, 2015 at 4:41 PM, Arnaud Héritier wrote: > Will it increase the stability and performances of Jenkins. Not under current plans, no. IIUC the benefits would mostly be for new users who would start with small installations anyway. -- You received this message

Re: QUESTION: ssh-agent dependencies

2015-10-09 Thread Jesse Glick
On Fri, Oct 9, 2015 at 4:25 PM, Arnaud Héritier wrote: > you are proposing to rewrite the dependencies resolution mechanism of maven > and friends in bash ? Of course not! First of all I said nothing about Bash. Second, Jenkins dependency semantics are pretty simple:

Re: Jenkins CI Plugin run on slave

2015-10-13 Thread Jesse Glick
On Tue, Oct 13, 2015 at 4:31 AM, Christoph M wrote: > The whole build step should be executed on the slave. Again that does not require use of a `Callable` unless you actually need to make Java API calls *on the slave* which are not supported by existing remoting wrappers such

Re: performance labs

2015-10-13 Thread Jesse Glick
On Tue, Oct 13, 2015 at 7:29 AM, Michael Neale wrote: > Looking at the variation of times people see, I am questioning the utility > of a generic test suite. Things vary so much there may be too many variables > at play to make something like this useful right now. Well

Re: Jenkins 2.0 proposal

2015-10-13 Thread Jesse Glick
On Tue, Oct 13, 2015 at 10:53 AM, oliver gondža wrote: > Can we do whatever PowerMock is doing to hook custom logic into `new File` > and provide custom implementation in case it is one of the files we decide > to store in DB (whole JENKINS_HOME?) and JDK implementation for the

Re: Dependency Injection / Sezpoz / Guice scanning

2015-10-13 Thread Jesse Glick
On Tue, Oct 13, 2015 at 7:57 AM, Baptiste Mathus wrote: > In xyz-jenkins-plugin in a Jenkins/Sezpoz managed class, I put > > public class ... { >@Inject >SomeFacade someFacade; > } Only works if the referring class is itself an `@Extension`. Otherwise who is going to

Re: Jenkins 2.0 proposal

2015-10-13 Thread Jesse Glick
On Tue, Oct 13, 2015 at 1:06 PM, Kanstantsin Shautsou wrote: > better create db-plugin with some hibernate and provide API KK actually already did this part—and then stopped there. :-) > start migrating plugins / unbundling existed core API to use this db-plugin Yes,

Re: Dependency Injection / Sezpoz / Guice scanning

2015-10-13 Thread Jesse Glick
On Tue, Oct 13, 2015 at 3:41 PM, Baptiste Mathus wrote: > The @Extension is on a class which extends an abstract class which is the > one having the @Inject. Well, maybe it will work, but probably not. Are you really getting any value from the half-baked DI system in

Re: QUESTION: ssh-agent dependencies

2015-10-09 Thread Jesse Glick
On Fri, Oct 9, 2015 at 9:54 AM, Daniel Beck wrote: > read the plugin dependencies from the HPI files and recursively (transitive > dependencies) add them to your installation Yes, you can do that. I tend to recommend instead that the tool building the image flag these as

Re: QUESTION: ssh-agent dependencies

2015-10-09 Thread Jesse Glick
On Fri, Oct 9, 2015 at 12:09 PM, Victor Martinez wrote: > since the workflow plugin is an active plugin and being in > development actively, I wonder whether that particular dependency won't > affect it. How so? As of 1.0 there should be no incompatible API

Re: QUESTION: ssh-agent dependencies

2015-10-09 Thread Jesse Glick
On Fri, Oct 9, 2015 at 4:19 AM, Victor Martinez wrote: > In order to support the workflow plugin those dependent modules should be > part of every plugin? Yes. The `workflow-step-api` plugin was expressly designed to be small and devoid of UI so that it would be

Re: Help needed with Workflow support in gitlab-plugin

2015-11-12 Thread Jesse Glick
On Thu, Nov 12, 2015 at 3:01 PM, Owen Mehegan wrote: > that the plugin should move toward the > multibranch project model, rather than one job which takes a parameter of > branch (and whose current "status" is therefore usually meaningless). Exactly. > I suspect it will be

Re: How to run multiple Jenkins Unit tests in parallel?

2015-11-14 Thread Jesse Glick
Parallelization operates at the granularity of suites, not cases. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: EOFException when terminating slaves programatically

2015-08-26 Thread Jesse Glick
On Wed, Aug 26, 2015 at 10:30 AM, Carlos Sanchez car...@apache.org wrote: I'm not sure what am I missing, if I should call something else to close the slave connection Not sure, I also get a reproducible `EOFException` from `mock-slave` tests. Kohsuke agreed something was wrong but the

Re: Revisiting bundled plugins

2015-08-27 Thread Jesse Glick
On Thu, Aug 27, 2015 at 11:37 AM, Gus Reiber grei...@cloudbees.com wrote: detached plugins that are essential to Jenkins but have been implemented as plugins for quicker updates and ease of implementation. Split plugins are just plugins, which by definition are not “essential” to Jenkins. They

Re: Request to on how get workspace location from Run object - for workflow compatibilty

2015-08-28 Thread Jesse Glick
On Fri, Aug 28, 2015 at 6:11 AM, Vinodhini Vijay vinodhini.vi...@gmail.com wrote: CustomBuildWrapper doesn't have any GUI Does not matter, it should still offer a `config.jelly`: ?jelly escape-by-default='true'? j:jelly xmlns:j=jelly:core/ -- You received this message because you are

Re: TransientProjectActionFactory and installation without restart

2015-08-28 Thread Jesse Glick
On Fri, Aug 28, 2015 at 9:49 AM, vojta.jan...@gmail.com wrote: My Jenkins plugin implements an TransientProjectActionFactory in order to provide project-level action. Unfortunately the action doesn't appear until the Jenkins is restarted. Probably the factory is getting used for newly created

Re: Jenkins 1.609.3 LTS RC testing started

2015-08-26 Thread Jesse Glick
On Fri, Aug 21, 2015 at 2:57 AM, oliver gondža ogon...@gmail.com wrote: Release is scheduled for 2015-08-02. I guess mean 2015-09-02? But that is in the middle of JUC West. There is no way KK could be cutting releases that day or the next. Should we assume that it gets pushed out a few days?

Re: How to make a BatchFile Workflow Compatible?

2015-09-04 Thread Jesse Glick
On Wed, Sep 2, 2015 at 10:16 PM, Vinodhini Vijay wrote: > Can I use WindowsBatchScript batch = new WindowsBatchScript("echo hello > windows"); within my code? You probably do not want to do that. What are you trying to accomplish? Start there. Are you writing a

Re: Fill the config into a repeatable list

2015-09-02 Thread Jesse Glick
Do not use raw `f:repeatable`. Define a nested `Describable` with its own `config.jelly` and use `f:repeatableProperty` or `f:repeatableHeteroProperty`. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and

Re: Timestamps on build logs

2015-09-08 Thread Jesse Glick
On Tue, Sep 8, 2015 at 4:51 AM, Antonio Muñiz wrote: > not sure what you mean, what external storage? https://github.com/jenkinsci/timestamper-plugin/blob/409ae9298bf8c4252cabd0147aaea941c9a9a00f/src/main/java/hudson/plugins/timestamper/TimestamperBuildWrapper.java#L99 If

Re: Timestamps on build logs

2015-09-07 Thread Jesse Glick
Or there is a system property you can set to do the obvious thing on _all_ builds. (IMO you should need to select a configuration option to use the more complicated and fragile external storage.) -- You received this message because you are subscribed to the Google Groups "Jenkins Developers"

Re: design integration tests with JenkinsRule in remote env

2015-09-10 Thread Jesse Glick
On Thu, Sep 10, 2015 at 9:55 AM, Kanstantsin Shautsou wrote: > Is there any ways to do such communication? `/script` (or the CLI equivalent) is your best bet. From an ATH test you can simply use `jenkins.runScript("…")`. -- You received this message because you are

Re: Groovy vs. Jelly

2015-09-10 Thread Jesse Glick
I generally use Jelly views by default, but switch to Groovy if the view really needs some complex logic in it: something beyond accessing public properties of Java objects and doing simple if-then tests. Really I would prefer a different view engine altogether, based on `src/main/java/**/*.java`

Re: Using Environment variables in Workflow

2015-09-10 Thread Jesse Glick
On Thu, Sep 10, 2015 at 9:17 AM, Paul Allen wrote: > I added two break points in SCM.buildEnvVars and my own buildEnvVars and > neither get hit during a Workflow build. Of course not; pending JENKINS-24141 the API does not permit an SCM to contribute environment variables

Re: Test case contribution

2015-09-16 Thread Jesse Glick
On Wed, Sep 16, 2015 at 8:04 AM, Ullrich Hafner wrote: > Did someone already manage it to start the Jenkins under Test with coverage > monitoring (emma, cobertura, jacoco, etc.)? I have run JaCoCo during plugin tests. > Seems not so easy due to the Jenkins class

Re: Guidance on how far SECURITY fixes should go

2015-09-16 Thread Jesse Glick
On Wed, Sep 16, 2015 at 7:27 AM, Stephen Connolly wrote: > @UnsecureAlternative(name="getFooUnsafe", until="1.650") > public Foo getFoo(...) { > ... > } Too complicated, too reflective. Let us keep it to basic statically-checked idioms as much as possible.

Re: Jenkins Plugin Wiki Question

2015-09-16 Thread Jesse Glick
On Wed, Sep 16, 2015 at 12:48 AM, Daniel Beck wrote: > You need Maven to do anything anyway, and `mvn -U > org.jenkins-ci.tools:maven-hpi-plugin:create` is trivial to run. Yet we have > some random service that does basically the same thing Agreed, I think the effort would be

Re: Revisiting bundled plugins

2015-09-16 Thread Jesse Glick
On Wed, Sep 16, 2015 at 3:42 AM, Tom Fennelly wrote: > The plugin in WEB-INF/detached-plugins is already already installed in > "this" jenkins instance. > The only effect here will be a possible upgrade of the plugin if the > installed version is less than the bundled

Re: Alternate GUIs for Jenkins

2015-09-15 Thread Jesse Glick
On Tue, Sep 15, 2015 at 1:41 PM, Gus Reiber wrote: > Do any of you all use 3rd party tools to get information out of Jenkins? Do not use it myself but: http://jenkins-ci.mobi/ -- You received this message because you are subscribed to the Google Groups "Jenkins

Re: Good pratices for workflow plugin support

2015-09-15 Thread Jesse Glick
On Tue, Sep 15, 2015 at 9:24 AM, jcsirot wrote: > I am currently working on the support of the workflow plugin for the ansible > plugin and I'm facing some questions. Happy to help! BTW if you have a PR in progress, feel free to CC @jglick on it. Also if there is a JIRA issue

Re: Guidance on how far SECURITY fixes should go

2015-09-15 Thread Jesse Glick
On Tue, Sep 15, 2015 at 12:06 PM, Suckow, Thomas J wrote: > Cons: > * A lot of work for the Core Jenkins team Yeah, it is a nice idea, I just wonder if the developers available to work on security fixes have the time to do that much polish. -- You received this message

Re: Guidance on how far SECURITY fixes should go

2015-09-15 Thread Jesse Glick
On Tue, Sep 15, 2015 at 3:53 PM, Daniel Beck wrote: > we could introduce [system properties] with a predetermined expiration date > to allow users to upgrade and retain their existing functionality, for a time This could be a good solution for cases where we have prepared

Re: Revisiting bundled plugins

2015-09-16 Thread Jesse Glick
On Wed, Sep 16, 2015 at 1:33 PM, Daniel Beck wrote: > The issue that caused me to think we may need to keep pinning around is your > change to External Monitor Job 1.4 where a resource was moved from core into > the plugin. I see. Basically this is what

Re: Revisiting bundled plugins

2015-09-16 Thread Jesse Glick
On Wed, Sep 16, 2015 at 3:49 PM, Daniel Beck wrote: > Worst case is we'll need to backport the critical fix to an older x.y.1 so we > don't include a bunch of unrelated stuff. Exactly. -- You received this message because you are subscribed to the Google Groups "Jenkins

Re: Revisiting bundled plugins

2015-09-17 Thread Jesse Glick
On Thu, Sep 17, 2015 at 11:49 AM, Tom Fennelly wrote: >> Jenkins core cannot depend on a plugin, this makes no sense. > > I still don't get why it's such a no-no. Violates the very notion of what a “plugin” is. By definition, plugins depend on core, and core does not

Re: Revisiting bundled plugins

2015-09-17 Thread Jesse Glick
On Thu, Sep 17, 2015 at 6:16 AM, Daniel Beck wrote: >> we will upgrade if the plugin does not meet the minimum version requirements >> i.e. is less than the bundled version (in /WEB-INF/detached-plugins). > > Yep, it looks like that's what Jesse is arguing for. Yes. So my

Re: Corner case with Acceptance Test Harness

2015-09-14 Thread Jesse Glick
Of course if we kill bundled plugins (as in another thread) this problem goes away. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Guidance on how far SECURITY fixes should go

2015-09-15 Thread Jesse Glick
On Tue, Sep 15, 2015 at 6:39 AM, Stephen Connolly wrote: > In some cases it is possible to use a system property to re-enable the hole Generally I would really push back on introducing alternate behaviors using a system property, especially something important

<    5   6   7   8   9   10   11   12   13   14   >