Re: RFR 8164800: Cross targeting Windows

2016-08-29 Thread Sundararajan Athijegannathan
t; regards, > Rémi > > - Mail original - >> De: "Sundararajan Athijegannathan" >> À: "Alan Bateman" , "jigsaw-dev" >> >> Envoyé: Vendredi 26 Août 2016 18:08:12 >> Objet: Re: RFR 8164800: Cross targeting Windows >>

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Remi Forax
Hi Sundararajan, Also, in createArgs(), instead Collections.unmodifiableList(), you can use List.of(). regards, Rémi - Mail original - > De: "Sundararajan Athijegannathan" > À: "Alan Bateman" , "jigsaw-dev" > > Envoyé: Vendredi 26 Août 201

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Sundararajan Athijegannathan
Hmm.. I saw another RuntimeException in the same file for another issue.. I guess I'll have to deal with this change when doing another fix in that file - I do have one for reading java.version from java.base descriptor. I'll clean it up when doing that fix. -Sundar On 8/26/2016 9:37 PM, Alan B

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Alan Bateman
On 26/08/2016 15:54, Sundararajan Athijegannathan wrote: Hi, Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/ * Field name changed to targetOsName * Throwing RuntimeException if os name can't be determined from java.base This looks okay except for RuntimeException,

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Jim Laskey (Oracle)
+1 > On Aug 26, 2016, at 11:54 AM, Sundararajan Athijegannathan > wrote: > > Hi, > > Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/ > > * Field name changed to targetOsName > > * Throwing RuntimeException if os name can't be determined from java.base > > -Sundar >

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Mandy Chung
> On Aug 26, 2016, at 7:54 AM, Sundararajan Athijegannathan > wrote: > > Hi, > > Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/ Looks fine. Something to consider as a future cleanup - jlink should know the target platform information up front. It may be worth sto

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Sundararajan Athijegannathan
Hi, Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/ * Field name changed to targetOsName * Throwing RuntimeException if os name can't be determined from java.base -Sundar On 8/26/2016 7:30 PM, Alan Bateman wrote: > On 26/08/2016 14:51, Sundararajan Athijegannathan wr

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Jim Laskey (Oracle)
+1 > On Aug 26, 2016, at 10:51 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8164800/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8164800 > > Thanks, > > -Sundar >

Re: RFR 8164800: Cross targeting Windows

2016-08-26 Thread Alan Bateman
On 26/08/2016 14:51, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8164800/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8164800 What would you think about rename osName to targetOsName to make it clearer? Also in releaseProperties then I wond

RFR 8164800: Cross targeting Windows

2016-08-26 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8164800/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8164800 Thanks, -Sundar