Re: RFR(S): 8219142: Make libjimage strncpy uses GCC 8.x friendly

2019-02-18 Thread Alan Bateman
On 15/02/2019 21:24, Mikael Vidstedt wrote: Please review this change which addresses some warnings generated by GCC 8.2 related to the uses of strncpy in libjimage/imageFile.cpp. Bug: https://bugs.openjdk.java.net/browse/JDK-8219142 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8219142/we

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-18 Thread Magnus Ihse Bursie
> 15 feb. 2019 kl. 18:01 skrev Severin Gehwolf : > > Hi Alan, Mandy, > > Here is the next round of this change: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/06/webrev/ Looks good from the build PoV, with one minor nit: In JtregNativeJdk.gmk, please use the new construct: ifeq (

Re: RFR: 8218913: Rename --strip-debug jlink plugin

2019-02-18 Thread Severin Gehwolf
On Fri, 2019-02-15 at 23:27 -0800, Mandy Chung wrote: > On 2/15/19 8:12 AM, Severin Gehwolf wrote: > > Thanks for the review! I've remove the @author tag: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/03/webrev/ > > Looks good. As Alan said, this needs a CSR to document the new plu

Re: RFR: 8218913: Rename --strip-debug jlink plugin

2019-02-18 Thread Alan Bateman
On 18/02/2019 09:50, Severin Gehwolf wrote: : Thanks. CSR has been filed here: https://bugs.openjdk.java.net/browse/JDK-8219207 The interface change is to add --strip-java-debug-attributes so it might be better to change the synopsis and the summary to make this clearer. Also in the specificat

Re: RFR: 8218913: Rename --strip-debug jlink plugin

2019-02-18 Thread Severin Gehwolf
On Mon, 2019-02-18 at 10:10 +, Alan Bateman wrote: > On 18/02/2019 09:50, Severin Gehwolf wrote: > > : > > Thanks. CSR has been filed here: > > https://bugs.openjdk.java.net/browse/JDK-8219207 > > > The interface change is to add --strip-java-debug-attributes so it > might be better to change

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-18 Thread Severin Gehwolf
Hi Magnus, On Mon, 2019-02-18 at 09:32 +0100, Magnus Ihse Bursie wrote: > > 15 feb. 2019 kl. 18:01 skrev Severin Gehwolf : > > > > Hi Alan, Mandy, > > > > Here is the next round of this change: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/06/webrev/ > > Looks good from the build

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-18 Thread Magnus Ihse Bursie
On 2019-02-18 12:02, Severin Gehwolf wrote: Hi Magnus, On Mon, 2019-02-18 at 09:32 +0100, Magnus Ihse Bursie wrote: 15 feb. 2019 kl. 18:01 skrev Severin Gehwolf : Hi Alan, Mandy, Here is the next round of this change: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/06/webrev/ Loo