hg: jigsaw/m2/jdk: 8062069: Replace jimagefs with jrt file system

Changeset: 102fc000f419 Author:sundar Date: 2014-11-13 07:36 +0530 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/102fc000f419 8062069: Replace jimagefs with jrt file system Reviewed-by: alanb ! src/java.base/share/classes/META-INF/services/java.nio.file.spi.FileSystemProvider

hg: jigsaw/m2/jdk: 8064783: Change rmic to use jrt:/ instead of jimagefs

Changeset: 835a66c32fcf Author:sundar Date: 2014-11-19 18:48 +0530 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/835a66c32fcf 8064783: Change rmic to use jrt:/ instead of jimagefs Reviewed-by: alanb ! src/java.base/share/classes/jdk/internal/jrtfs/jrtls.js !

hg: jigsaw/m2/jdk: 8064791: (jrtfs) DirectoryStream entries have incorrect paths

Changeset: fbad71a36d58 Author:sundar Date: 2014-11-21 16:06 +0530 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/fbad71a36d58 8064791: (jrtfs) DirectoryStream entries have incorrect paths Reviewed-by: alanb ! src/java.base/share/classes/jdk/internal/jimage/ImageReader.java -

hg: jigsaw/jake/nashorn: 8140235: Clean up dynamic module creation in jake/nashorn

Changeset: 7aed4ca0e885 Author:sundar Date: 2015-10-21 19:47 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/7aed4ca0e885 8140235: Clean up dynamic module creation in jake/nashorn Reviewed-by: attila, lagergren, alanb !

Re: Jigsaw @ JavaOne 2015

I watched all the 4 talks - audio is fine. -Sundar On 10/29/2015 12:08 PM, Jochen Theodorou wrote: since it seems nobody mentioned it yet... is there sound on the youtube video? Because I seem not to have that. bye blackdrag On 27.10.2015 21:15, mark.reinh...@oracle.com wrote: 2015/10/23

Re: RFR 8141521: jrt file system's DirectoryStream reports child paths with wrong paths for directories under /packages

May I get review(s) on the updated webrev please? http://cr.openjdk.java.net/~sundar/8141521/webrev.01/ Thanks, -Sundar On 11/11/2015 9:16 PM, Sundararajan Athijegannathan wrote: Hi, Please find the updated webrev @ http://cr.openjdk.java.net/~sundar/8141521/webrev.01/ * Removed

hg: jigsaw/jake/jdk: 8141521: jrt file system's DirectoryStream reports child paths with wrong paths for directories under /packages

Changeset: 67c711a267db Author:sundar Date: 2015-11-17 12:56 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/67c711a267db 8141521: jrt file system's DirectoryStream reports child paths with wrong paths for directories under /packages Reviewed-by: alanb !

hg: jigsaw/jake/nashorn: 8142991: Re-examine jdk.scripting.nashorn.shell linked in JRE that drags in jdk.compiler

Changeset: baa4d288d717 Author:sundar Date: 2015-11-17 16:33 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/baa4d288d717 8142991: Re-examine jdk.scripting.nashorn.shell linked in JRE that drags in jdk.compiler Reviewed-by: jlaskey !

Re: Is Caching JrtFileSystem acceptable?

As Alan said, other thing async. closing of the file system, nothing really comes to mind. There is checkResource call in code to check that the resource exists before opening channel on it.. Is it possible to reproduce this on a smaller app? -Sundar On 11/2/2015 4:05 PM, Alan Bateman wrote:

Re: Possible jrt filesystem bug

This appears to be a bug. I'll check with the latest code in jigsaw forest and file a bug if needed. Thanks, -Sundar On 11/3/2015 1:55 PM, Philippe Marschall wrote: Hi I have encountered something with I believe may be a bug in the jrt filesystem. The children/directory entries of

RFR 8141521: jrt file system's DirectoryStream reports child paths with wrong paths for directories under /packages

Please review http://cr.openjdk.java.net/~sundar/8141521/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8141521 Thanks -Sundar

Re: non-API classes displayed by jrt filesystem

Hi, The situation is not different from, say, zip/jar file system - that file system too exposes *all* underlying resources via file system. All .class resources - package private classes, anonymous inner classes etc. are exposed. Language notions like public/package-private/anonymous etc.

hg: jigsaw/jake/nashorn: 8139106: ant build/test fails with jigsaw/jake/nashorn

Changeset: c350ec3155e1 Author:sundar Date: 2015-10-08 14:49 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/c350ec3155e1 8139106: ant build/test fails with jigsaw/jake/nashorn Reviewed-by: lagergren, mhaupt ! make/build.xml ! make/project.properties -

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

+1 Nashorn changes and modules.xml changes look good to me. -Sundar On 9/16/2015 7:35 PM, Attila Szegedi wrote: On Sep 16, 2015, at 2:51 PM, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please

Re: CFV: New Jigsaw Committer: Harold Seigel (Karen Kinnear)

Vote: Yes On 9/15/2015 12:28 AM, Mike Duigou wrote: Vote: YES On 2015-09-11 12:43, jigsaw-dev-requ...@openjdk.java.net wrote: From: Karen Kinnear To: jigsaw-dev Subject: CFV: New Jigsaw Committer: Harold Seigel Message-ID:

Re: CFV: New Committer: Christian Tornqvist

Vote: yes On 9/17/2015 10:48 PM, John Rose wrote: Vote: yes On Sep 16, 2015, at 2:42 PM, Karen Kinnear wrote: I hereby nominate Christian Tornqvist to Jigsaw Committer.

Re: CFV: New Jigsaw Committer: Harold Seigel

Vote: yes On 9/17/2015 10:49 PM, John Rose wrote: Vote: yes On Sep 11, 2015, at 12:31 PM, Karen Kinnear wrote: I hereby nominate Harold Seigel to Jigsaw Committer.

Re: jigsaw EA feedback for apache lucene

The forbidden-apis' Checker.java has these lines: final URL objectClassURL = loader.getResource("java/lang/Object.class"); if (objectClassURL != null && "jrt".equalsIgnoreCase(objectClassURL.getProtocol())) { // this is Java 9 with modules! isSupportedJDK = true;

Re: Is there really a jdk.proxy1 module?

Because jdk.proxy1 is a dynamically created module, you've to programmatically add read using java.lang.reflect.Module (addRead method) API. -Sundar On 12/8/2015 8:11 PM, Stephane Epardaud wrote: Except I can't add reads to it: $HOME/no-backup/src/jdk1.9.0-jigsaw/bin/java

Re: Is there really a jdk.proxy1 module?

addRead -> addReads -Sundar On 12/8/2015 8:20 PM, Sundararajan Athijegannathan wrote: Because jdk.proxy1 is a dynamically created module, you've to programmatically add read using java.lang.reflect.Module (addRead method) API. -Sundar On 12/8/2015 8:11 PM, Stephane Epardaud wrote: Exc

hg: jigsaw/jake/jdk: 8145750: jjs fails to run simple scripts with security manager turned on

Changeset: 8a5f08fb6039 Author:sundar Date: 2015-12-21 09:40 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8a5f08fb6039 8145750: jjs fails to run simple scripts with security manager turned on Reviewed-by: hannesw, alanb ! src/java.base/share/conf/security/java.policy

hg: jigsaw/jake/nashorn: 8145879: ant clean test fails with too many failures

Changeset: 40b41f4e0d4b Author:sundar Date: 2015-12-21 14:06 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/40b41f4e0d4b 8145879: ant clean test fails with too many failures ! buildtools/nasgen/project.properties ! make/build-nasgen.xml ! make/build.xml !

hg: jigsaw/jake/nashorn: 8145880: Two tests involving Dynalink pluggable linker loading via service loader fail

Changeset: 890589990d39 Author:sundar Date: 2015-12-21 16:37 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/890589990d39 8145880: Two tests involving Dynalink pluggable linker loading via service loader fail !

Re: RFR: JDK 9: 8144001 jake/jdk/test/sun/rmi/rmic/newrmic/equivalence/run.sh compilation error

+1 on test changes. PS. I think we still need to test exports again after rmic is fixed for other issues -- as the test still fails to run with this change. -Sundar On 12/23/2015 5:33 PM, Hamlin Li wrote: Hi, Please review a fix for test issue JDK-8144001 related to modularization. Issue:

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

But, in addition to providing service, jdk.scripting.nashorn module also "exports" nashorn specific APIs in jdk.nashorn.api.* packages. -Sundar On 11/23/2015 9:10 PM, Alan Bateman wrote: On 23/11/2015 15:27, Attila Szegedi wrote: Folks, I integrated the changes Mandy suggested; please

hg: jigsaw/jake/nashorn: 8139106: ant build/test fails with jigsaw/jake/nashorn

Changeset: e2e713228703 Author:sundar Date: 2015-11-25 10:21 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/e2e713228703 8139106: ant build/test fails with jigsaw/jake/nashorn !

hg: jigsaw/jake/jdk: 8142959: Remove dependency on sun.boot.class.path property

Changeset: 5098cced084a Author:sundar Date: 2015-11-24 20:14 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5098cced084a 8142959: Remove dependency on sun.boot.class.path property Reviewed-by: alanb ! src/jdk.rmic/share/classes/sun/rmi/rmic/BatchEnvironment.java !

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

+1 on all changes. -Sundar On 11/20/2015 12:15 AM, Attila Szegedi wrote: Please review JDK-8141338 "Move jdk.internal.dynalink package to jdk.dynalink" for . This is basically the implementation step for integrating JEP 276. This changeset

RFR 8068938: javax.script package description should specify use of ServiceLoader

Please review http://cr.openjdk.java.net/~sundar/8068938/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8068938 This is a doc-only change to mention that ScriptEngineFactory instances are loaded using java.util.ServiceLoader API and avoid wording on META-INF/services [ which is just

Re: RFR 8158736: Adapter class loaders can avoid creating named dynamic modules

AM, Sundararajan Athijegannathan wrote: > No, there are still named, dynamic modules in Nashorn. That comment > was specific to adapter module in nashorn. StructureLoader and > ScriptLoaders load generated classes that require encapsulation. And so > these loader classes do create na

Re: RFR 8158736: Adapter class loaders can avoid creating named dynamic modules

, Jochen Theodorou wrote: > On 06.06.2016 11:38, Sundararajan Athijegannathan wrote: > [...] >> There is no need for named dynamic module - as there is nothing to >> encapsulate. Nashorn module can still selectively export packages to >> adapter module [ so that generated

RFR 8157801: spurious > character in the javadoc comment for ModuleEntry.java

Please review http://cr.openjdk.java.net/~sundar/8157801/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8157801 Thanks, -Sundar

Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

Looks good -Sundar On 6/9/2016 1:15 AM, Jim Laskey (Oracle) wrote: > Consistent use of PathPatterns for jlink, jimage and jmod options. > > —optionName=(regex:|glob:|) ?? where => > glob: > > http://cr.openjdk.java.net/~jlaskey/8158402/webrev/index.html >

Re: RFR 8158131: Nashorn should not use jdk.internal.module.Modules API

ATIC, > +"myModule", "Ljava/lang/reflect/Module;", null, null); > +fv.visitEnd(); > +} > > Suggestion: adhere to Java coding style even in generated code and > spell this as MY_MODULE. Will fix that. Tha

RFR 8158131: Nashorn should not use jdk.internal.module.Modules API

Please review http://cr.openjdk.java.net/~sundar/8158131/ for https://bugs.openjdk.java.net/browse/JDK-8158131 This code cleanup is to avoid Nashorn's use of JDK internal class jdk.internal.module.Modules. With this change, nashorn uses java.lang.reflect.Layer public API to create single Module

Re: RFR 8158131: Nashorn should not use jdk.internal.module.Modules API

, javaBaseModule, myModule in generated -Sundar On 5/30/2016 2:50 PM, Sundararajan Athijegannathan wrote: > Hi, > > Inline replies below. > > > On 5/30/2016 2:16 PM, Michael Haupt wrote: >> Hi Sundar, >> >> lower-case thumbs up for both the j

Re: RFR 8158131: Nashorn should not use jdk.internal.module.Modules API

d. Earlier I had used an acc. context with "getClassLoader" and "createClassLoader" permissions. But, Layer.defineModules call requires just "getClassLoader" permission. Reduced acc. context accordingly. -Sundar On 5/30/2016 4:13 PM, Sundararajan Athijegannathan

Re: RFR: 8156209 - Add argument checks to BasicImageReader calls

Looks good -Sundar On 5/27/2016 8:42 PM, Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8156209/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8156209

Re: RFR 8157931, jdk/internal/jrtfs/Basic.java fails with exploded builds

+1 On 5/26/2016 4:28 PM, Felix Yang wrote: > Hi there, > > please review the following change. > > Webrev: http://cr.openjdk.java.net/~xiaofeya/8157931/webrev.00/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8157931 > > > The test "jdk/internal/jrtfs/Basic.java" fails when testing

Re: question on exports to

Similar scenario exists in nashorn world. We use Layers API to create single-dynamic-Module Layers and Module.addExport for qualified exports across Layers. * Nashorn (qualified) exports of it's runtime code to dynamic module with Module.addExport * addExports managed by generated code's static

Re: RFR: JDK-8156995 - jimage: extract specified contents

Looks good -Sundar On 6/1/2016 8:18 PM, Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8156995/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8156995

Re: RFR: JDK-8156994 - jimage --help is not helpful

Looks good -Sundar On 6/1/2016 8:17 PM, Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8156994/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8156994

Re: RFR 8159593: Plugin Set getType() should return a Category

71 || category.equals(Category.METAINFO_ADDER); > 72 } > > Wondering if we can handle this with a field in the enum. > > +1 otherwise. > > >> On Jun 21, 2016, at 7:25 AM, Sundararajan Athijegannathan >> <sundararajan.athijegannat...@oracle.com> w

RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins

Please review http://cr.openjdk.java.net/~sundar/8153238/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8153238 Thanks, -Sundar

hg: jigsaw/jake/jdk: JLinkTest.java failed in Windows because "\n" was used to split

Changeset: f9fdf06dca00 Author:sundar Date: 2016-02-01 22:58 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f9fdf06dca00 JLinkTest.java failed in Windows because "\n" was used to split ! test/jdk/jigsaw/tools/jlink/JLinkTest.java

hg: jigsaw/jake/jdk: JlinkNegativeList tests fails with "expected internal error" on Windows

Changeset: 8c55ca144a1a Author:sundar Date: 2016-02-03 20:45 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8c55ca144a1a JlinkNegativeList tests fails with "expected internal error" on Windows ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JmodArchive.java

hg: jigsaw/jake/jdk: removed --xhelp option for jimage and jlink

Changeset: 4a3ca484df06 Author:sundar Date: 2016-02-04 12:24 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4a3ca484df06 removed --xhelp option for jimage and jlink ! src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java !

hg: jigsaw/jake/jdk: 8148837: JlinkNegativeList tests fails with "The process cannot access the file because it is being used by another process." on Windows

Changeset: 87c35ea3a7fc Author:sundar Date: 2016-02-02 16:15 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/87c35ea3a7fc 8148837: JlinkNegativeList tests fails with "The process cannot access the file because it is being used by another process." on Windows !

hg: jigsaw/jake/jdk: flexible --release-info option for jlink. support for repeated plugin options.

Changeset: b500b9b1b5ed Author:sundar Date: 2016-02-24 18:54 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b500b9b1b5ed flexible --release-info option for jlink. support for repeated plugin options. !

hg: jigsaw/jake: Using jlink's --release-info option to avoid reading 'release' file from java.home.

Changeset: 6fa036f4a7da Author:sundar Date: 2016-02-24 18:55 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/6fa036f4a7da Using jlink's --release-info option to avoid reading 'release' file from java.home. ! make/Images.gmk

hg: jigsaw/jake/jdk: 8148261: release file has incorrect properties when targeting different platform

Changeset: ec23613dac0f Author:sundar Date: 2016-02-23 16:14 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ec23613dac0f 8148261: release file has incorrect properties when targeting different platform ! src/jdk.jlink/share/classes/jdk/tools/jlink/Jlink.java !

hg: jigsaw/jake/nashorn: 8147598: 4 ant tests fail with jake/nashorn

Changeset: 03e02eb6655a Author:sundar Date: 2016-01-20 13:42 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/03e02eb6655a 8147598: 4 ant tests fail with jake/nashorn ! test/script/nosecurity/JDK-8044798.js ! test/script/nosecurity/JDK-8044851.js !

hg: jigsaw/jake/jdk: 8148176: jlink module-info expresses a useless dependency

Changeset: f92e0a2bd206 Author:sundar Date: 2016-01-27 17:25 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f92e0a2bd206 8148176: jlink module-info expresses a useless dependency ! src/jdk.jlink/share/classes/module-info.java

hg: jigsaw/jake/jdk: Adding jlink -o, -c options to use optimizer, compressor builtin plugins.

Changeset: b025d08c1828 Author:sundar Date: 2016-02-16 19:53 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b025d08c1828 Adding jlink -o, -c options to use optimizer, compressor builtin plugins. ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java !

hg: jigsaw/jake/jdk: Removed jlink -o option, added -G option for string debug information

Changeset: 83fb2d1195da Author:sundar Date: 2016-02-17 17:12 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/83fb2d1195da Removed jlink -o option, added -G option for string debug information ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java !

hg: jigsaw/jake/jdk: Made jlink options --post-process-path, --resources-last-sorter hidden. --help prints expanded names for -G and -c options.

Changeset: 4928b5d006f0 Author:sundar Date: 2016-02-18 17:42 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4928b5d006f0 Made jlink options --post-process-path, --resources-last-sorter hidden. --help prints expanded names for -G and -c options. !

hg: jigsaw/jake/jdk: 8148391: JLink needs an option to dump current command line options

Changeset: c75f491603c0 Author:sundar Date: 2016-02-19 18:59 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c75f491603c0 8148391: JLink needs an option to dump current command line options ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java !

hg: jigsaw/jake/jdk: jlink tests StringSharingPluginTest.java and StripDebugPluginTest.java should convert Windows file separator.

Changeset: 41c175ea7e12 Author:sundar Date: 2016-02-01 23:35 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/41c175ea7e12 jlink tests StringSharingPluginTest.java and StripDebugPluginTest.java should convert Windows file separator. !

hg: jigsaw/jake/jdk: 8150195: tools/jimage/JImageTest.java fails with AccessDeniedException

Changeset: f99cbeea7056 Author:sundar Date: 2016-03-16 19:57 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f99cbeea7056 8150195: tools/jimage/JImageTest.java fails with AccessDeniedException Reviewed-by: jlaskey !

Re: Review for the new static ClassLoader.getPlatformClassLoader method

+1 ClassLoader.getBuiltinPlatformClassLoader method could be private -Sundar On 3/12/2016 3:26 AM, Mandy Chung wrote: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/8146373/webrev.00/ > > This adds a new static ClassLoader.getPlatformClassLoader method to return a > class loader via which

hg: jigsaw/jake/jdk: Add @implNote warning that jdk.internal.jimage/jrtfs must maintain backwards-compatibility with JDK 8

Changeset: 905d45f82376 Author:sundar Date: 2016-03-15 19:45 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/905d45f82376 Add @implNote warning that jdk.internal.jimage/jrtfs must maintain backwards-compatibility with JDK 8 Reviewed-by: sundar Contributed-by:

Re: jlink tool review (Re: Initial webrev with changes for JDK 9)

Hi, Thanks for the review. I've filed a bug to track your suggestions: https://bugs.openjdk.java.net/browse/JDK-8151896 Thanks, -Sundar On 3/14/2016 6:26 PM, Michael Haupt wrote: > Hi again, > > some certain list server doesn't like attachments. ;-) > Find it at

hg: jigsaw/jake/jdk: ImageReader should fail with an IOException if image can't be opened in requested ByteOrder

Changeset: 1768da383e24 Author:sundar Date: 2016-03-10 06:58 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1768da383e24 ImageReader should fail with an IOException if image can't be opened in requested ByteOrder Contributed-by: claes.redes...@oracle.com !

Re: Initial webrev with changes for JDK 9 jrtfs

Hi, Thanks for the review. I've filed a bug to track the cleanups suggested: https://bugs.openjdk.java.net/browse/JDK-8151860 Quick comments: 1) jrt fs is read-only file system as you noted. Copying content into jrt fs does not make sense. Eventually read-only file system exception is thrown.

Please review 8148491: Revisit jlink --genbom

Hi, Please review http://cr.openjdk.java.net/~sundar/8148491/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8148491 Thanks, -Sundar

Re: [9] Review request: 8153754: Nashorn needs access to com.sun.javafx.application

+1 On 4/7/2016 10:17 PM, Kevin Rushforth wrote: > Jim L, > > Please review the following simple change to add the needed qualified > exports: > > http://cr.openjdk.java.net/~kcr/8153754/webrev.00/ > > -- Kevin >

Re: RFR: JDK-8075550 - Error "JavaFX runtime not found" in nashorn when load predefines scripts to import JavaFX packages

+1 On 4/11/2016 6:13 PM, Jim Laskey (Oracle) wrote: > Any one else. > >> On Apr 11, 2016, at 9:13 AM, Michael Haupt wrote: >> >> Hi Jim, >> >> lower-case thumbs up! >> >> Best, >> >> Michael >> >>> Am 08.04.2016 um 19:05 schrieb Jim Laskey (Oracle)

hg: jigsaw/jake/jdk: 8152800: Improve jlink plugin error message on invalid arguments or any other exception

Changeset: 70789188976a Author:sundar Date: 2016-04-12 15:38 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/70789188976a 8152800: Improve jlink plugin error message on invalid arguments or any other exception Reviewed-by: alanb, mchung, jlaskey !

hg: jigsaw/jake/nashorn: CodeStoreAndPathTest used to fail with NPE. Fixed and re-enabled the test.

Changeset: 64f3ca334b12 Author:sundar Date: 2016-03-08 22:17 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/64f3ca334b12 CodeStoreAndPathTest used to fail with NPE. Fixed and re-enabled the test. !

hg: jigsaw/jake/nashorn: removed compile time, runtime dependency from nasgen tool to nashorn code. Nashorn .class files are treated as just data files by nasgen tool.

Changeset: a67ceefb5a7b Author:sundar Date: 2016-03-04 07:41 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/a67ceefb5a7b removed compile time, runtime dependency from nasgen tool to nashorn code. Nashorn .class files are treated as just data files by nasgen tool. !

hg: jigsaw/jake/nashorn: removed -Xpatch and -Xbootclasspath options in nasgen tool invocation.

Changeset: 64016e0013ca Author:sundar Date: 2016-03-04 10:36 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/64016e0013ca removed -Xpatch and -Xbootclasspath options in nasgen tool invocation. ! make/BuildNashorn.gmk

hg: jigsaw/jake/nashorn: nasgen class writer getCommonSuperClass should use isScriptClass check to return ScriptObject as type.

Changeset: 4ec6dc731b3a Author:sundar Date: 2016-03-07 20:00 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/4ec6dc731b3a nasgen class writer getCommonSuperClass should use isScriptClass check to return ScriptObject as type. !

hg: jigsaw/jake/jdk: 8148491: Revisit jlink --genbom

Changeset: fdaafc3eeb7c Author:sundar Date: 2016-03-30 15:48 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/fdaafc3eeb7c 8148491: Revisit jlink --genbom Reviewed-by: jlaskey, alanb, mchung ! make/launcher/Launcher-jdk.scripting.nashorn.shell.gmk !

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

+1 -Sundar On 3/30/2016 7:09 PM, Felix Yang wrote: > Hi all, > renamed the test to distinguish with other jrt fs tests and also > fixed some misc issues. > New webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.03/ > > Thanks, > Felix > On 2016/3/3 15:48, Felix Yang wrote: >> Hi

RFR 8136645: jlink tool should create windows os compatible launcher

Please review http://cr.openjdk.java.net/~sundar/8136645/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8136645 Thanks, -Sundar

Re: RFR 8136645: jlink tool should create windows os compatible launcher

Please review updated webrev @ http://cr.openjdk.java.net/~sundar/8136645/webrev.01/ PS. Fixed "/" with "\" in "java" path. The generated batch file worked in either case - but changing for consistency. Thanks, -Sundar On 3/31/2016 11:08 PM, Sundararajan Athijega

Re: RFR 8136645: jlink tool should create windows os compatible launcher

Thanks for your comments. * Removed !Files.exists * Added isWindows check for .bat files Updated webrev: http://cr.openjdk.java.net/~sundar/8136645/webrev.03/ Thanks, -Sundar On 4/1/2016 12:07 PM, Alan Bateman wrote: > > > On 01/04/2016 06:27, Sundararajan Athijegannat

Re: RFR 8136645: jlink tool should create windows os compatible launcher

is misleading. Changing executable bits on? I'll add comment. Thanks, -Sundar > -Dmitry > > On 2016-03-31 20:38, Sundararajan Athijegannathan wrote: >> Please review http://cr.openjdk.java.net/~sundar/8136645/webrev.00/ for >> https://bugs.openjdk.java.net/browse/JDK-8136645 >> >> Thanks, >> -Sundar >> >

hg: jigsaw/jake/jdk: 8136645: jlink tool should create windows os compatible launcher

Changeset: 1525539374b6 Author:sundar Date: 2016-04-01 17:42 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1525539374b6 8136645: jlink tool should create windows os compatible launcher Reviewed-by: dsamersoff, mchung, alanb !

Re: RFR 8136645: jlink tool should create windows os compatible launcher

Mar 31, 2016, at 9:20 PM, Sundararajan Athijegannathan >> <sundararajan.athijegannat...@oracle.com> wrote: >> >> Please review the updated webrev @ >> http://cr.openjdk.java.net/~sundar/8136645/webrev.02/ > > This version still generates .bat for all platform

Re: RFR 8136645: jlink tool should create windows os compatible launcher

Please review the updated webrev @ http://cr.openjdk.java.net/~sundar/8136645/webrev.02/ * Changed "\n" to "\r\n" * Removed POSIX/bits change code Thanks, -Sundar On 4/1/2016 8:22 AM, Sundararajan Athijegannathan wrote: > Hi, > > Comments below.. > > On 4/1/2

Re: RFR: JDK-8151807 - ImageBufferCache should release buffers when all classes are loaded

+1 -Sundar On 4/13/2016 6:45 PM, Alan Bateman wrote: > On 11/04/2016 14:37, Jim Laskey (Oracle) wrote: >> http://cr.openjdk.java.net/~jlaskey/8151807/webrev/index.html >> https://bugs.openjdk.java.net/browse/JDK-8151807 > This looks quite although I'm wondering if there are cases where we > need

Re: RFR: JDK-8069079 - jimage extract / list to organize classes by modules

+1 -Sundar On 4/24/2016 5:20 PM, Jim Laskey (Oracle) wrote: > Thank you, changes incorporated. > >> On Apr 22, 2016, at 2:08 PM, Mandy Chung wrote: >> >> Hi Jim, >> >>> On Apr 22, 2016, at 6:12 AM, Jim Laskey (Oracle) >>> wrote: >>> >>> Listing

Re: RFR: JDK-8132994 - /modules and /packages should not be parsed by the jimage parser

"if(" in second if statement [missing whitespace after keyword] +1 -Sundar On 4/25/2016 8:08 PM, Jim Laskey (Oracle) wrote: > Changed to special case parse /modules/ and /packages/. Will actually reduce > string table size slightly (better common string match.) > >

Re: 8148834: Update module-info reader/writer to 53.0

+1 On 5/19/2016 5:19 PM, Alan Bateman wrote: > javac has been switched to generate v53.0 class files. ASM, pack200 > and several other areas have been updated too. We have two places in > the module-info reader/writing that needs to be updated so I need a > Reviewer to get this into jdk9/dev. >

Re: RFR: JDK-8156781 - change to jlink has result in test failure

Fix looks good. +1 on test renaming. -Sundar On 5/12/2016 12:02 AM, Mandy Chung wrote: >> On May 11, 2016, at 11:00 AM, Jim Laskey (Oracle) >> wrote: >> >> http://cr.openjdk.java.net/~jlaskey/8156781/webrev/index.html >>

RFR 8156914: jlink API minor cleanups

Please review http://cr.openjdk.java.net/~sundar/8156914/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8156914 Thanks, -Sundar

Re: [9] Review request: 8153872: Nashorn no longer needs access to com.sun.javafx.application

+1 On 4/21/2016 10:19 AM, Mandy Chung wrote: >> On Apr 19, 2016, at 8:25 AM, Kevin Rushforth >> wrote: >> >> Jim, >> >> Please review the following fix: >> >> https://bugs.openjdk.java.net/browse/JDK-8153872 >> http://cr.openjdk.java.net/~kcr/8153872/webrev.00/ >>

RFR 8162782: jlink ResourcePool.releaseProperties should be removed

Please review http://cr.openjdk.java.net/~sundar/8162782/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8162782 Thanks, -Sundar

Re: RFR 8162782: jlink ResourcePool.releaseProperties should be removed

15:42, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8162782/webrev.00/ for >> https://bugs.openjdk.java.net/browse/JDK-8162782 >> >> > Sundar - is this this time to address JDK-8159487 too? > > -Alan

Re: RFR 8162782: jlink ResourcePool.releaseProperties should be removed

. Also fixed the comment for ResourcePoolEntry.Type.TOP Please review updated webrev @ http://cr.openjdk.java.net/~sundar/8162782/webrev.01/index.html Thanks, -Sundar On 8/1/2016 5:52 PM, Alan Bateman wrote: > > > On 31/07/2016 20:29, Sundararajan Athijegannathan wrote: >> Hi, &g

RFR 8162538: plugin API should avoid read only pool, have module view separated from resource view and have pool builder to modify

Please review http://cr.openjdk.java.net/~sundar/8162538/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8162538 Thanks, -Sundar

Re: RFR 8146721: FileCopierPlugin should not create fake module

Fixed: http://cr.openjdk.java.net/~sundar/8146721/webrev.01/ Thanks, -Sundar On 8/4/2016 4:22 PM, Jim Laskey (Oracle) wrote: > Fix grammar on FileCopierPluginTest.java: "We didn't add any .class resources > of java.base module!” > > +1 > > > >> On Aug 4

RFR 8160346: JLinkTest.java should compute exact number of plugins from jdk.jlink module [ was Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins]

t 9:54 AM, Sundararajan Athijegannathan >> <sundararajan.athijegannat...@oracle.com> wrote: >> >> Please review http://cr.openjdk.java.net/~sundar/8153238/webrev.00/ for >> https://bugs.openjdk.java.net/browse/JDK-8153238 > 86 if (builtInPlugins.siz

RFR 8161055: Remove plugin ordering by isAfter, isBefore.

Please review http://cr.openjdk.java.net/~sundar/8161055/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8161055 Thanks -Sundar

Re: RFR: JDK-8160829 - Remove ASMPool support from jlink

+1 On 7/5/2016 7:48 PM, Jim Laskey (Oracle) wrote: > Much of the removed code seems unnecessary since the same functionality can > be accomplished with much simpler code. An example is provided with > ClassForNamePlugin.java (temporary.) A shipping byte code optimizer plugin > will be

RFR 8163116: jlink exclude VM plugin does not fully support cross platform image creation

Please review http://cr.openjdk.java.net/~sundar/8163116/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8163116 No cross platform test added. Existing test fixed to use java.base/module-info.class. Also, piggybacking to fix FileCopierPluginTest to avoid catching PluginException.

RFR 8163256: jlink/plugins/ExcludeVMPluginTest.java failed with Selected VM server doesn't exist

Please review http://cr.openjdk.java.net/~sundar/8163256/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8163256 This is a Mac specific issue. ModuleDescriptor read from jrt:/java.base/module-info.class resource returns osName() to be "Darwin" - but, System.getProperty("os.name") still

Re: Review request 8136930: Simplify use of module-system options by custom launchers

Nashorn portion of the changes look fine - except for minor comment: $jdk9-dev/nashorn/buildtools/nasgen/build.properties needs to be fixed as well [uses -XaddExports] -Sundar On 8/8/2016 4:21 PM, Alan Bateman wrote: > On 05/08/2016 21:11, Mandy Chung wrote: > >> This patch renames the

RFR 8160641: PostProcessingPlugin and ExecutableImage should not be part of plugin API

Please review http://cr.openjdk.java.net/~sundar/8160641/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8160641 Thanks, -Sundar

  1   2   3   >