Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-13 Thread Doug Simon
> On 13 Apr 2018, at 07:15, David Holmes wrote: > > Hi Doug, > > Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with this > ??? These are the non-Graal code base changes needed to move the bean out of the jdk.internal.vm.compiler module. The rest of the changes will come

Provides clauses in binary module descriptor but not in source

2018-04-13 Thread Doug Simon
I just noticed that in the jdk.internal.vm.compiler module descriptor source there is a `uses` clause for CompilerConfigurationFactory[1] but no `provides` clause for the CoreCompilerConfigurationFactory provider[2] which is in the same module. However, `java -d jdk.internal.vm.compiler | grep C

Re: Provides clauses in binary module descriptor but not in source

2018-04-13 Thread Alan Bateman
On 13/04/2018 13:16, Doug Simon wrote: I just noticed that in the jdk.internal.vm.compiler module descriptor source there is a `uses` clause for CompilerConfigurationFactory[1] but no `provides` clause for the CoreCompilerConfigurationFactory provider[2] which is in the same module. However, `

Re: Provides clauses in binary module descriptor but not in source

2018-04-13 Thread Doug Simon
> On 13 Apr 2018, at 14:33, Alan Bateman wrote: > > On 13/04/2018 13:16, Doug Simon wrote: >> I just noticed that in the jdk.internal.vm.compiler module descriptor source >> there is a `uses` clause for CompilerConfigurationFactory[1] but no >> `provides` clause for the CoreCompilerConfigurat

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-13 Thread David Holmes
On 13/04/2018 5:12 PM, Doug Simon wrote: On 13 Apr 2018, at 07:15, David Holmes wrote: Hi Doug, Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with this ??? These are the non-Graal code base changes needed to move the bean out of the jdk.internal.vm.compiler module. T

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-13 Thread Doug Simon
> On 13 Apr 2018, at 15:59, David Holmes wrote: > > On 13/04/2018 5:12 PM, Doug Simon wrote: >>> On 13 Apr 2018, at 07:15, David Holmes wrote: >>> >>> Hi Doug, >>> >>> Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with >>> this ??? >> These are the non-Graal code base c

Re: Avoiding sun.misc.Unsafe and embracing modules in Java libraries: missing links

2018-04-13 Thread Rafael Winterhalter
Yes, of course. This was merely a proof of concept to show that it works. 2018-04-13 8:48 GMT+02:00 Peter Levart : > > > On 04/12/18 10:40, Alan Bateman wrote: > > On 11/04/2018 21:07, Rafael Winterhalter wrote: > > I do not think that this is possible. If the module containing the > interface do