micro-resolution

2014-02-05 Thread Jonathan Gibbons
I am beginning to consider how to rewrite (micro)resolution in javac in the light of the recent discussions regarding readability, visibility, etc. I know that we have determined that the JDK module graph is acyclic. I think we decided that all module graphs should be acyclic, right? I

Re: CFV: New Jigsaw Committer: Erik Joelsson

2014-08-05 Thread Jonathan Gibbons
Vote: yes On 08/05/2014 04:13 PM, Mandy Chung wrote: I hereby nominate Erik Joelsson (aka erikj) to Jigsaw Committer. Erik is one of the main contributors to the new build system in JDK 8 and he has reviewer role in jdk8, jdk8u, and jdk9 project. Erik has already contributed many change sets

Re: CFV: New Jigsaw Committer: Mike Duigou

2014-08-05 Thread Jonathan Gibbons
Vote: yes On 08/05/2014 04:14 PM, Mandy Chung wrote: I hereby nominate Mike Duigou (aka mduigou) to Jigsaw Committer. Mike has been a long time contributor to the JDK, making changes and reviewing in jdk8, jdk9, lambda projects. Mike has also been contributing many patches in the build

hg: jigsaw/m2/langtools: javax.tools: cleanup/simplify ToolProvider

2014-09-18 Thread jonathan . gibbons
Changeset: 9df8d61a5765 Author:jjg Date: 2014-09-18 17:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/9df8d61a5765 javax.tools: cleanup/simplify ToolProvider ! src/java.compiler/share/classes/javax/tools/ToolProvider.java

hg: jigsaw/m2/langtools: javap: fix test failure caused by jimage URIs

2014-09-19 Thread jonathan . gibbons
Changeset: 51f459b7ab1c Author:jjg Date: 2014-09-19 17:48 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/51f459b7ab1c javap: fix test failure caused by jimage URIs ! test/tools/javap/WhitespaceTest.java

hg: jigsaw/m2/langtools: 8058153: Remove some tests from langtools ws

2014-10-07 Thread jonathan . gibbons
Changeset: 820f1f9f4166 Author:sogoel Date: 2014-10-07 15:33 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/820f1f9f4166 8058153: Remove some tests from langtools ws - test/tools/apt/Basics/CheckAptIsRemovedTest.java - test/tools/javac/Paths/SameJVM.java -

hg: jigsaw/m2/langtools: Ensure directory stream is closed when searching for .jimage files

2014-10-24 Thread jonathan . gibbons
Changeset: eaf0d6b44ece Author:jjg Date: 2014-10-24 14:48 -0700 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/eaf0d6b44ece Ensure directory stream is closed when searching for .jimage files ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java

hg: jigsaw/m2/langtools: fix test/tools/javac/api/T6430241.java

2014-11-18 Thread jonathan . gibbons
Changeset: 4e6c43a7b394 Author:jjg Date: 2014-11-18 15:43 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/4e6c43a7b394 fix test/tools/javac/api/T6430241.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java !

hg: jigsaw/m2/langtools: fix test/tools/javadoc/api/basic/GetTask_FileManagerTest.java

2014-11-18 Thread jonathan . gibbons
Changeset: ec5d6e9773c2 Author:jjg Date: 2014-11-18 18:20 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/ec5d6e9773c2 fix test/tools/javadoc/api/basic/GetTask_FileManagerTest.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java !

hg: jigsaw/m2/langtools: fix test/tools/javac/api/TestSearchPaths.java

2014-11-18 Thread jonathan . gibbons
Changeset: 1b92d0a7038d Author:jjg Date: 2014-11-18 18:42 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/1b92d0a7038d fix test/tools/javac/api/TestSearchPaths.java ! test/tools/javac/api/TestSearchPaths.java

hg: jigsaw/m2/langtools: fix remaining Windows test failures

2014-11-25 Thread jonathan . gibbons
Changeset: 860057639029 Author:jjg Date: 2014-11-25 15:00 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/860057639029 fix remaining Windows test failures ! src/jdk.compiler/share/classes/com/sun/tools/javap/JavapTask.java ! test/tools/javac/Paths/Diagnostics.sh !

hg: jigsaw/m2/langtools: Don't use JRTImage when jrt: not available

2014-11-25 Thread jonathan . gibbons
Changeset: adfba96aaec6 Author:jjg Date: 2014-11-25 18:33 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/adfba96aaec6 Don't use JRTImage when jrt: not available ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java !

hg: jigsaw/m2/langtools: minor review feedback

2014-12-01 Thread jonathan . gibbons
Changeset: 66b0c80c1c1e Author:jjg Date: 2014-12-01 16:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/66b0c80c1c1e minor review feedback ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java !

Re: module/bootclass troubles with jdk9

2015-02-03 Thread Jonathan Gibbons
On 02/03/2015 12:17 AM, Alan Bateman wrote: For javac then there are other ideas to support compiling for previous releases, Jon might want to say more on this. -Alan javac is currently in interim land. For now, javac still supports the bootclasspath family of options, meaning that if

Re: Status of remaining com.sun.tools - javax.tools?

2015-04-30 Thread Jonathan Gibbons
On 04/30/2015 01:21 PM, Chris Newland wrote: Hi, Is it intended that the remaining private APIs in com.sun.tools will be converted to javax.tools service providers before JDK9 is released? E.g. com.sun.tools.javap.JavapTask as reported in bug https://bugs.openjdk.java.net/browse/JDK-6493691

hg: jigsaw/jake/langtools: move ModuleTestBase for reuse by additional tests

2015-10-23 Thread jonathan . gibbons
Changeset: 5ce41c5e35a8 Author:vromero Date: 2015-10-23 18:02 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5ce41c5e35a8 move ModuleTestBase for reuse by additional tests - test/tools/javac/modules/ModuleTestBase.java + test/tools/lib/ModuleTestBase.java

hg: jigsaw/jake/langtools: Fixing package-info.class and module-info.class genereation when an internal JavacTaskImpl API is used.

2015-10-23 Thread jonathan . gibbons
Changeset: f5aa149f5bd0 Author:jlahoda Date: 2015-10-23 14:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f5aa149f5bd0 Fixing package-info.class and module-info.class genereation when an internal JavacTaskImpl API is used. !

hg: jigsaw/jake/langtools: 8136709: fixing visible package computation for automatic modules which are used as a dependency of a named module.

2015-10-23 Thread jonathan . gibbons
Changeset: df52fb21fa9f Author:jlahoda Date: 2015-10-23 15:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/df52fb21fa9f 8136709: fixing visible package computation for automatic modules which are used as a dependency of a named module. !

hg: jigsaw/jake/langtools: Fixing a few Java model API bugs.

2015-10-23 Thread jonathan . gibbons
Changeset: f34f96b386fc Author:jlahoda Date: 2015-10-23 14:22 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f34f96b386fc Fixing a few Java model API bugs. ! src/java.compiler/share/classes/javax/lang/model/type/TypeKind.java !

Re: Compilation feedback and version question

2015-10-28 Thread Jonathan Gibbons
On 10/28/2015 01:50 PM, Stephen Colebourne wrote: Finally, I had my module-info.java in the wrong folder initially (at the org.joda.convert package level, rather than the root). However, it got picked up and compiled into the root of the output classes folder. I guess this is expected, but I

Re: Unable to compile modules with references to automatic modules - "cannot find module: jdk.management.resource"

2015-11-09 Thread Jonathan Gibbons
On 11/09/2015 12:55 AM, Alan Bateman wrote: On 08/11/2015 17:51, Jan Lahoda wrote: Automatic modules depend on all other named modules, and javac currently uses all modules it knows about, which includes those it found while analyzing other module-infos. I think it could be changed to

hg: jigsaw/jake/langtools: Setting UsesProviderCompleter to ModuleSymbol.usesProvidersCompleter, to avoid running it too soon.

2015-11-11 Thread jonathan . gibbons
Changeset: 7c66438d4d8a Author:jlahoda Date: 2015-11-11 15:27 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7c66438d4d8a Setting UsesProviderCompleter to ModuleSymbol.usesProvidersCompleter, to avoid running it too soon. !

hg: jigsaw/jake/langtools: Fix tests on langtools ProblemList.jake.txt

2015-11-13 Thread jonathan . gibbons
Changeset: 8630a1e8260d Author:jjg Date: 2015-11-13 18:02 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8630a1e8260d Fix tests on langtools ProblemList.jake.txt ! test/ProblemList.jake.txt - test/tools/javac/Object1.java - test/tools/javac/Object1.out -

hg: jigsaw/jake/langtools: fix whitespace and merge error in ProblemList.jake.txt

2015-11-16 Thread jonathan . gibbons
Changeset: 2e97a1c3478f Author:jjg Date: 2015-11-13 16:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2e97a1c3478f fix whitespace and merge error in ProblemList.jake.txt ! test/ProblemList.jake.txt

Re: Proposal to enhance jdeps tool to search split packages/add some kind of general API

2015-11-15 Thread Jonathan Gibbons
On 11/12/2015 06:49 PM, Mandy Chung wrote: On Nov 12, 2015, at 2:39 AM, Patrick Reinhart wrote: Hi there, I like to do some early adoption tests with software using the new module system. Now we got an unknown amount of split packages in our system, the we will need to

hg: jigsaw/jake/langtools: 8140767: adding -XaddReads option to javac

2015-11-10 Thread jonathan . gibbons
Changeset: 2c1838c6e03c Author:jlahoda Date: 2015-11-10 14:19 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2c1838c6e03c 8140767: adding -XaddReads option to javac ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Directive.java !

hg: jigsaw/jake/langtools: 2 new changesets

2015-11-05 Thread jonathan . gibbons
Changeset: 755579d808dc Author:alundblad Date: 2015-11-05 10:49 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/755579d808dc add missing methods in ForwardingFileManager ! src/java.compiler/share/classes/javax/tools/ForwardingJavaFileManager.java Changeset:

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-07 Thread Jonathan Gibbons
Yes, the message says that "JDevJavaCompiler ... cannot access ... com.sun.tools.javac.api.JavacTool" and indeed, com.sun.tools.javac.api is not a supported public API. Here's the standard comment from the head of the file: * This is NOT part of any supported API. * If you write code that

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-07 Thread Jonathan Gibbons
On 10/07/2015 06:01 PM, Keimpe Bronkhorst wrote: The underlying exception I get is: "Class oracle.jdevimpl.javacompiler.JDevJavaCompiler can not access a member of class com.sun.tools.javac.api.JavacTool (module jdk.compiler) with modifiers "public static", module jdk.compiler does not

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Jonathan Gibbons
Keimpe, While your use-case is about accessing alternate versions of javac, the underlying mechanism you are looking for is more general and not specific to javac. The ability that you need, and which you're currently missing, is the ability to load code (modules) from an alternate JDK

Re: javac not enforcing module boundaries?

2015-09-14 Thread Jonathan Gibbons
https://bugs.openjdk.java.net/browse/JDK-8136505 -- Jon On 09/14/2015 01:22 AM, Peter Levart wrote: Hi, I experimented a little with EA build and found javac behaving a little strange. Is this known or expected behaviour? For example, having the following layout of sources:

Re: jigsaw vs. jsr166 CVS

2015-09-14 Thread Jonathan Gibbons
On 09/13/2015 11:54 AM, Martin Buchholz wrote: javadoc does not seem to have any support for -Xmodule, so I don't know how to fix the "docs" target. https://bugs.openjdk.java.net/browse/JDK-8136503 -- Jon

hg: jigsaw/jake/langtools: 2 new changesets

2015-09-15 Thread jonathan . gibbons
Changeset: 5404faadbbe7 Author:jjg Date: 2015-09-15 13:42 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5404faadbbe7 minor test update ! test/tools/javac/api/TestTrees.java Changeset: 948a1770620e Author:jjg Date: 2015-09-15 14:21 -0700 URL:

Re: CFV: New jigsaw Committer: Jean-Francois Denise

2015-09-15 Thread Jonathan Gibbons
Vote: yes On 09/13/2015 07:33 AM, Alan Bateman wrote: I hereby nominate Jean-Francois Denise to jigsaw Committer. Jean-Francois is a jdk9 Committer and has been contributing to the ongoing development of the jimage container format. He has also been focused recently on the link phase and

hg: jigsaw/jake/langtools: remove unnecessary local variables

2015-09-17 Thread jonathan . gibbons
Changeset: b32127130c64 Author:jjg Date: 2015-09-17 14:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b32127130c64 remove unnecessary local variables ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java

hg: jigsaw/jake/langtools: update local build support

2015-09-17 Thread jonathan . gibbons
Changeset: 24e405279ff8 Author:jlahoda Date: 2015-09-17 15:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/24e405279ff8 update local build support ! make/build.xml ! make/launcher.sh-template ! make/netbeans/langtools/build.xml

Re: hg: jigsaw/jake/langtools: 8062324: Remove workaround copy of ServiceLoader from javac

2015-09-25 Thread Jonathan Gibbons
This should have been attributed to jan.lah...@oracle.com. My apologies for not catching this in time. -- Jon On 09/25/2015 04:07 PM, jonathan.gibb...@oracle.com wrote: Changeset: 4dfde5dc00fc Author:jjg Date: 2015-09-25 15:53 -0700 URL:

hg: jigsaw/jake/langtools: fix ElementStructureTest

2015-09-21 Thread jonathan . gibbons
Changeset: 2933a96a69c6 Author:jlahoda Date: 2015-09-21 13:46 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2933a96a69c6 fix ElementStructureTest ! test/tools/javac/sym/ElementStructureTest.java

hg: jigsaw/jake/langtools: add support for javac -Xpatch option with -Xoverride as a temporary alias

2015-09-24 Thread jonathan . gibbons
Changeset: 5684716bd129 Author:jjg Date: 2015-09-24 18:33 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5684716bd129 add support for javac -Xpatch option with -Xoverride as a temporary alias ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java

Re: no error when module exports non-existing package

2015-12-02 Thread Jonathan Gibbons
Adding Victor back into the recipients. -- Jon On 12/02/2015 10:08 AM, Jonathan Gibbons wrote: On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error

Re: no error when module exports non-existing package

2015-12-02 Thread Jonathan Gibbons
On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error, or at least a warning. Today was the third time I saw the code with a typo or just incorrect

CFV: New Jigsaw Committer: Jan Lahoda

2015-12-02 Thread Jonathan Gibbons
, 2015. Only current Jigsaw Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Jonathan Gibbons [1] http://openjdk.java.net/census#jigsaw [2] http://openjdk.java.net/projects

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

2015-12-04 Thread Jonathan Gibbons
On 12/04/2015 06:33 AM, Stephane Epardaud wrote: On 04/12/2015 15:21, David M. Lloyd wrote: IIRC there is *already* within Java 9 an option to compile against previous JDK ABIs (which are bundled with JDK 9), isn't there? Ah that's interesting, I got hit by calls to byteBuffer(int) which

hg: jigsaw/jake/langtools: 8133058: NPE while compiling empty javafile with -modulesourcepath option

2015-12-08 Thread jonathan . gibbons
Changeset: 8e4070f9a7ae Author:vromero Date: 2015-12-08 18:39 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8e4070f9a7ae 8133058: NPE while compiling empty javafile with -modulesourcepath option Reviewed-by: jjg !

hg: jigsaw/jake: Use VERSION_SHORT again, now that jtreg has been updated

2015-12-03 Thread jonathan . gibbons
Changeset: 1c8c3c9e2494 Author:jjg Date: 2015-12-03 14:01 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/1c8c3c9e2494 Use VERSION_SHORT again, now that jtreg has been updated ! make/CreateJmods.gmk

Re: IllegalAccessError even when -XaddExports adds ALL-UNNAMED to the reported module/package

2015-12-03 Thread Jonathan Gibbons
Roel, To understand the problem, you need to understand something of how javac works. javac is a Java program, and as such it is composed of a set of modules that run in a JVM. The primary module is jdk.compiler, and if you follow the dependencies, you'll see it references java.compiler,

Re: modulepath spec

2015-12-07 Thread Jonathan Gibbons
On 12/07/2015 11:46 AM, Alan Bateman wrote: On 07/12/2015 17:18, Stephane Epardaud wrote: Hi, When there is a -modulepath argument, is it a path in the Unix sense? With a list of File.pathSeparator-separated folders? Ceylon produces `.car` files instead of `.jar` files, but they're really

Result: New Jigsaw Committer: Jan Lahoda

2015-12-17 Thread Jonathan Gibbons
Voting for Jan Lahoda [1] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Jonathan Gibbons [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2015-December/005534.html

hg: jigsaw/jake/langtools: 8134514: javac -X should provide updated syntax for -XaddExports

2015-12-15 Thread jonathan . gibbons
Changeset: 088c841e9b42 Author:vromero Date: 2015-12-15 13:34 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/088c841e9b42 8134514: javac -X should provide updated syntax for -XaddExports Reviewed-by: jjg !

hg: jigsaw/jake/langtools: 8145102: new module graph tests

2015-12-15 Thread jonathan . gibbons
Changeset: cf44ed878521 Author:anazarov Date: 2015-12-15 13:50 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/cf44ed878521 8145102: new module graph tests Reviewed-By: jjg + test/tools/javac/modules/GraphsTest.java ! test/tools/javac/modules/ModuleInfoTest.java !

Specifying module paths

2016-01-07 Thread Jonathan Gibbons
This is a follow-up to some of the recent email discussions regarding the use of the module path. The "State of the Module System" [1] defines a _module path_ as follows: A module path is a sequence of directories containing module artifacts which are searched, in order, for the first

hg: jigsaw/jake/langtools: 2 new changesets

2015-12-22 Thread jonathan . gibbons
Changeset: d9ce7a3e1672 Author:jjg Date: 2015-12-22 12:54 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d9ce7a3e1672 unignore test case in UsesTest.java ! test/tools/javac/modules/UsesTest.java Changeset: 8a2b2c2caa15 Author:jjg Date: 2015-12-22 13:03

hg: jigsaw/jake/langtools: 8145012: Javac doesn't report errors on duplicate uses or provides

2015-12-18 Thread jonathan . gibbons
Changeset: f22706341c4d Author:vromero Date: 2015-12-16 17:29 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f22706341c4d 8145012: Javac doesn't report errors on duplicate uses or provides ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Directive.java !

hg: jigsaw/jake/langtools: 8145016: Javac doesn't report errors on service implementation which cannot be initialized

2015-12-18 Thread jonathan . gibbons
Changeset: 4a70ae037273 Author:vromero Date: 2015-12-17 13:41 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4a70ae037273 8145016: Javac doesn't report errors on service implementation which cannot be initialized !

hg: jigsaw/jake/jaxws: 8144342: javac doesn't report errors if module exports non-existent package

2015-12-18 Thread jonathan . gibbons
Changeset: ab43de1d28fd Author:vromero Date: 2015-12-17 14:38 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/ab43de1d28fd 8144342: javac doesn't report errors if module exports non-existent package ! src/jdk.xml.bind/share/classes/module-info.java

hg: jigsaw/jake/langtools: 8145957: langtools tests failing on exploded image

2015-12-21 Thread jonathan . gibbons
Changeset: 37fefa14f3a7 Author:jjg Date: 2015-12-21 19:03 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/37fefa14f3a7 8145957: langtools tests failing on exploded image ! test/tools/javac/6589361/T6589361.java ! test/tools/lib/ToolBox.java

hg: jigsaw/jake/langtools: read target of symbolic links in JRT file system

2015-11-20 Thread jonathan . gibbons
Changeset: 2eea71812f91 Author:jjg Date: 2015-11-20 16:52 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2eea71812f91 read target of symbolic links in JRT file system ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JRTIndex.java

RFR: 8154399, 8159096, export packages containing standard javadoc doclet

2016-06-16 Thread Jonathan Gibbons
Please review this simple fix for two related aspects of the same problem: Export the "standard doclet" used by javadoc, such that it is possible to derive alternative doclets, either by delegation or subtyping. In JDK 9, javadoc has a "new" standard doclet (JEP 221), but the old one remains

Re: Specifying module paths

2016-01-15 Thread Jonathan Gibbons
be placed directly on the module path; they must continue to be placed in a directory on the module path. This will apply to all JDK tools that support options whose value is a module path. -- Jon On 01/07/2016 03:39 PM, Jonathan Gibbons wrote: This is a follow-up to some of the recent email d

Re: Specifying module paths

2016-01-14 Thread Jonathan Gibbons
On 01/14/2016 12:25 PM, e...@zusammenkunft.net wrote: Hello, If I understood it correctly the modules on the MP must be unique and are not merged, thats why the order inside the directory does not matter for the named modules. Bernd Let me refine that for you ... The modules in each

Re: Specifying module paths

2016-01-14 Thread Jonathan Gibbons
On 01/14/2016 12:14 PM, Robert Scholte wrote: Igor Fedorenko says: "This is a very good proposal. My only suggestion is to extend javax.tools CompilationTask API to take modulepath map as in-memory parameter. Not a big deal, but it'll be silly to write properties file to disk for it to be

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-06-27 Thread Jonathan Gibbons
Since you have already admitted to using multiple concatenated lower case words in unexportedinapi, and since "unexported" is not a real word, can I suggest notexportedinapi for the category, and NOT_EXPORTED_IN_API for the Lint category. Or else just simply all the was down to "exports" and

hg: jigsaw/jake/langtools: Start adding bug IDs into ProblemList

2016-02-10 Thread jonathan . gibbons
Changeset: 37f388c03568 Author:jjg Date: 2016-02-10 13:59 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/37f388c03568 Start adding bug IDs into ProblemList ! test/ProblemList.jake.txt

hg: jigsaw/jake: fix merge problems for "make docs"

2016-02-04 Thread jonathan . gibbons
Changeset: ee7c28c82b0d Author:jjg Date: 2016-02-04 13:16 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/ee7c28c82b0d fix merge problems for "make docs" ! make/Javadoc.gmk

hg: jigsaw/jake/langtools: updates for javac -m option

2016-02-07 Thread jonathan . gibbons
Changeset: 18fc1fe05891 Author:vromero Date: 2016-02-07 15:22 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/18fc1fe05891 updates for javac -m option ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java !

Re: [Jigsaw] Getting "Bad service configuration file" error with annotation processor

2016-02-08 Thread Jonathan Gibbons
Gunnar, cross-posting to jigsaw-dev. Can you describe more about the setup of this example? Is the processor in a module with a module declaration with a provides clause for the processor, or is it a "pre-Jigsaw"/"JDK8-style" processor with a service configuration file in a jar file's

Re: hg: jigsaw/jake/langtools: support module files directly on file manager module paths

2016-02-08 Thread Jonathan Gibbons
} Op Mon, 08 Feb 2016 03:58:37 +0100 schreef Jonathan Gibbons <jonathan.gibb...@oracle.com>: Hi Robert, Thanks for the report. This should now have been addressed by http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/719a1da641c7 -- Jon On 02/03/2016 09:38 AM, Robert Scho

hg: jigsaw/jake/langtools: fix and enable indy string concat tests

2016-02-08 Thread jonathan . gibbons
Changeset: 80ac7bd55719 Author:jjg Date: 2016-02-08 12:48 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/80ac7bd55719 fix and enable indy string concat tests ! test/ProblemList.jake.txt ! test/tools/javac/TestIndyStringConcat.java

hg: jigsaw/jake/langtools: 8130868: error msg can be more accurate while compiling file in default package with -modulesourcepath option

2016-02-08 Thread jonathan . gibbons
Changeset: 257fc848711e Author:vromero Date: 2016-02-08 13:15 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/257fc848711e 8130868: error msg can be more accurate while compiling file in default package with -modulesourcepath option !

hg: jigsaw/jake/langtools: fix tests on langtools ProblemList.jake.txt

2016-02-08 Thread jonathan . gibbons
Changeset: 05ea8a0ca1c6 Author:vromero Date: 2016-02-08 11:14 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/05ea8a0ca1c6 fix tests on langtools ProblemList.jake.txt ! test/ProblemList.jake.txt ! test/tools/javac/T6406771.java !

hg: jigsaw/jake/langtools: 12 new changesets

2016-02-04 Thread jonathan . gibbons
Changeset: 4a4f58f3b344 Author:mcimadamore Date: 2016-01-26 12:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4a4f58f3b344 8148128: Regression: array constructor references marked as inexact Summary: Missing check in constructor reference stuckness check

hg: jigsaw/jake: Enable building of new doclet api docs

2016-02-04 Thread jonathan . gibbons
Changeset: ca23aeeb366e Author:ksrini Date: 2016-02-04 14:13 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/ca23aeeb366e Enable building of new doclet api docs ! make/Javadoc.gmk

hg: jigsaw/jake/langtools: javac -m option

2016-02-04 Thread jonathan . gibbons
Changeset: cc8de1bf3af7 Author:vromero Date: 2016-02-04 18:07 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/cc8de1bf3af7 javac -m option ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java !

hg: jigsaw/jake/langtools: fix typo in comment

2016-02-05 Thread jonathan . gibbons
Changeset: ae8f31d8db90 Author:jjg Date: 2016-02-05 14:47 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ae8f31d8db90 fix typo in comment ! src/java.compiler/share/classes/javax/lang/model/element/ModuleElement.java !

hg: jigsaw/jake/langtools: undo bad commit

2016-02-05 Thread jonathan . gibbons
Changeset: f4f66c2744ec Author:jjg Date: 2016-02-05 14:51 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f4f66c2744ec undo bad commit ! src/java.compiler/share/classes/javax/lang/model/element/ModuleElement.java !

hg: jigsaw/jake/langtools: fix typo in comment

2016-02-05 Thread jonathan . gibbons
Changeset: 5e7e9d89d7ea Author:jjg Date: 2016-02-05 15:21 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5e7e9d89d7ea fix typo in comment ! src/java.compiler/share/classes/javax/lang/model/element/ModuleElement.java

hg: jigsaw/jake/langtools: basic support for modules in javah

2016-02-09 Thread jonathan . gibbons
Changeset: bfa8469c0ff2 Author:jjg Date: 2016-02-09 17:41 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/bfa8469c0ff2 basic support for modules in javah ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTool.java !

hg: jigsaw/jake/langtools: fix test on problem list

2016-02-09 Thread jonathan . gibbons
Changeset: faf4f70ddd6a Author:jjg Date: 2016-02-09 18:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/faf4f70ddd6a fix test on problem list ! test/ProblemList.jake.txt - test/tools/javac/synthesize/Boolean.java - test/tools/javac/synthesize/Byte.java -

hg: jigsaw/jake/langtools: minor update for test

2016-02-09 Thread jonathan . gibbons
Changeset: dd9f148a231c Author:jjg Date: 2016-02-09 18:46 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/dd9f148a231c minor update for test ! test/tools/javac/T8003967/DetectMutableStaticFields.java

hg: jigsaw/jake/langtools: delete obsolete tests and remove from problem list

2016-02-09 Thread jonathan . gibbons
Changeset: 7cce0e7f4fb5 Author:jjg Date: 2016-02-09 17:52 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7cce0e7f4fb5 delete obsolete tests and remove from problem list ! test/ProblemList.jake.txt - test/com/sun/javadoc/testProfiles/TestProfiles.java -

hg: jigsaw/jake/langtools: minor update to test

2016-02-09 Thread jonathan . gibbons
Changeset: 0d994d57bf64 Author:jjg Date: 2016-02-09 19:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/0d994d57bf64 minor update to test ! test/tools/javac/processing/model/testgetallmembers/Main.java

hg: jigsaw/jake/langtools: fixing tests on the ProblemList

2016-02-11 Thread jonathan . gibbons
Changeset: a2e310fa72c6 Author:jjg Date: 2016-02-11 19:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a2e310fa72c6 fixing tests on the ProblemList ! src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java !

Re: hg: jigsaw/jake/langtools: support module files directly on file manager module paths

2016-02-07 Thread Jonathan Gibbons
Hi Robert, Thanks for the report. This should now have been addressed by http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/719a1da641c7 -- Jon On 02/03/2016 09:38 AM, Robert Scholte wrote: Hi Jonathan, it seems like this change is not enough, see:

hg: jigsaw/jake/langtools: update javadoc to support -addmods -limitmods

2016-02-08 Thread jonathan . gibbons
Changeset: afbf27e227d7 Author:jjg Date: 2016-02-08 15:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/afbf27e227d7 update javadoc to support -addmods -limitmods ! src/jdk.javadoc/share/classes/com/sun/tools/javadoc/JavadocTool.java !

hg: jigsaw/jake/langtools: 8148648: javac, neither a service definition or its implementation can be inner classes

2016-02-08 Thread jonathan . gibbons
Changeset: 46c903152cfe Author:vromero Date: 2016-02-08 15:55 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/46c903152cfe 8148648: javac, neither a service definition or its implementation can be inner classes !

hg: jigsaw/jake/langtools: 8145839: javac report error if service doesn't have a no-args constructor

2016-01-28 Thread jonathan . gibbons
Changeset: 650b3ea0c0c6 Author:vromero Date: 2016-01-28 16:31 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/650b3ea0c0c6 8145839: javac report error if service doesn't have a no-args constructor Reviewed-by: jjg !

hg: jigsaw/jake/langtools: 2 new changesets

2016-01-29 Thread jonathan . gibbons
Changeset: f7df0e138394 Author:vromero Date: 2016-01-29 16:24 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f7df0e138394 8145013: Javac doesn't report warnings/errors if module provides unexported service and doesn't use it itself Reviewed-by: jjg !

hg: jigsaw/jake/langtools: 8147801: java.nio.file.ClosedFileSystemException when using Javadoc API's in JDK9

2016-02-01 Thread jonathan . gibbons
Changeset: 74b0706bf77e Author:jjg Date: 2016-02-01 19:34 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/74b0706bf77e 8147801: java.nio.file.ClosedFileSystemException when using Javadoc API's in JDK9 !

Re: hg: jigsaw/jake/langtools: support module files directly on file manager module paths

2016-02-03 Thread Jonathan Gibbons
Robert, Noted. Thanks for the report. That should be easy enough to fix. -- Jon On 02/03/2016 09:38 AM, Robert Scholte wrote: Hi Jonathan, it seems like this change is not enough, see: Locations.ModulePathLocationHandler::setPaths 910 @Override 911 void

Re: modulepath and classpath mixture

2016-02-23 Thread Jonathan Gibbons
On 02/23/2016 01:22 PM, Robert Scholte wrote: On Tue, 23 Feb 2016 22:14:32 +0100, Jonathan Gibbons <jonathan.gibb...@oracle.com> wrote: On 02/23/2016 01:06 PM, Jonathan Gibbons wrote: On 02/23/2016 12:48 PM, Robert Scholte wrote: On Tue, 23 Feb 2016 01:52:50 +0100, Jonathan G

Re: modulepath and classpath mixture

2016-02-23 Thread Jonathan Gibbons
On 02/23/2016 12:48 PM, Robert Scholte wrote: On Tue, 23 Feb 2016 01:52:50 +0100, Jonathan Gibbons <jonathan.gibb...@oracle.com> wrote: On 02/22/2016 12:44 PM, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very pleased with the new -mp options, these matches

Re: modulepath and classpath mixture

2016-02-23 Thread Jonathan Gibbons
On 02/23/2016 01:06 PM, Jonathan Gibbons wrote: On 02/23/2016 12:48 PM, Robert Scholte wrote: On Tue, 23 Feb 2016 01:52:50 +0100, Jonathan Gibbons <jonathan.gibb...@oracle.com> wrote: On 02/22/2016 12:44 PM, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very p

Re: modulepath and classpath mixture

2016-02-23 Thread Jonathan Gibbons
On 02/23/2016 01:10 PM, Robert Scholte wrote: And maybe this is the key question: if src/main/java is a module, should we handle src/test/java as a module too or leave it as a classpath based project? thanks, Robert You list 2 choices, but there's 3 possible answers here. If you're

Re: modulepath and classpath mixture

2016-02-27 Thread Jonathan Gibbons
to compile with. thanks, Robert [1] http://openjdk.java.net/jeps/261 On Tue, 23 Feb 2016 01:52:50 +0100, Jonathan Gibbons <jonathan.gibb...@oracle.com> wrote: On 02/22/2016 12:44 PM, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very pleased with the new -mp o

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-23 Thread Jonathan Gibbons
On 02/23/2016 06:40 AM, Alan Bateman wrote: This fails if JDK8_HOME is not defined and I'm sure will be annoyance for those that run jtreg directly. Should we get the test to just pass if not set? I realize that is not ideal. -Alan. It is relatively common practice for tests that require

Re: modulepath and classpath mixture

2016-02-22 Thread Jonathan Gibbons
On 02/22/2016 12:44 PM, Robert Scholte wrote: Hi, first of all I'd like to say that I'm very pleased with the new -mp options, these matches better with the way Apache Maven would like to work with jars and class-folders. Here's my use case: I noticed that if I add a module-info to

hg: jigsaw/jake/langtools: allow unset/0 entries in TargetPlatform attribute

2016-02-22 Thread jonathan . gibbons
Changeset: 4dbbaf7a0699 Author:jjg Date: 2016-02-22 18:00 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4dbbaf7a0699 allow unset/0 entries in TargetPlatform attribute ! src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java

hg: jigsaw/jake/langtools: add support for new-style -XaddExports -XaddReads in javac

2016-02-22 Thread jonathan . gibbons
Changeset: fc4c2f3a8b21 Author:jjg Date: 2016-02-22 17:42 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/fc4c2f3a8b21 add support for new-style -XaddExports -XaddReads in javac ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java !

hg: jigsaw/jake/langtools: fix javadoc comments, enough to keep doclint happy

2016-02-25 Thread jonathan . gibbons
Changeset: 7671cfbb5f28 Author:jjg Date: 2016-02-25 18:09 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7671cfbb5f28 fix javadoc comments, enough to keep doclint happy ! src/java.compiler/share/classes/javax/lang/model/element/ModuleElement.java !

hg: jigsaw/jake: fix doclint TODO for java.compiler and jdk.compiler

2016-02-25 Thread jonathan . gibbons
Changeset: 42d97944e649 Author:jjg Date: 2016-02-25 18:12 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/42d97944e649 fix doclint TODO for java.compiler and jdk.compiler ! make/CompileJavaModules.gmk

  1   2   3   >