[GitHub] [kafka] jiameixie commented on pull request #8446: KAFKA-9804:Extract consumer configs out of PerfConfig

2020-05-27 Thread GitBox
jiameixie commented on pull request #8446: URL: https://github.com/apache/kafka/pull/8446#issuecomment-635122648 Call for review @huxihx This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r431587702 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +619,81 @@ public void

[GitHub] [kafka] guozhangwang commented on pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-27 Thread GitBox
guozhangwang commented on pull request #8248: URL: https://github.com/apache/kafka/pull/8248#issuecomment-635118880 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma commented on a change in pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8705: URL: https://github.com/apache/kafka/pull/8705#discussion_r431583127 ## File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java ## @@ -804,7 +804,33 @@ private void maybeCloseOldestConnection(long

[GitHub] [kafka] ijuma commented on a change in pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8705: URL: https://github.com/apache/kafka/pull/8705#discussion_r431581763 ## File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala ## @@ -1807,6 +1817,7 @@ class SocketServerTest { currentPollValues

[GitHub] [kafka] ijuma commented on a change in pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8705: URL: https://github.com/apache/kafka/pull/8705#discussion_r431581508 ## File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala ## @@ -1875,6 +1889,14 @@ class SocketServerTest {

[GitHub] [kafka] ijuma commented on pull request #7956: KAFKA-9392; Clarify deleteAcls javadoc and add test for create/delete timing

2020-05-27 Thread GitBox
ijuma commented on pull request #7956: URL: https://github.com/apache/kafka/pull/7956#issuecomment-635095707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r431576336 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java ## @@ -22,7 +22,8 @@ DEFAULT("default"),

[GitHub] [kafka] ijuma commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r431576336 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java ## @@ -22,7 +22,8 @@ DEFAULT("default"),

[GitHub] [kafka] ijuma commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r431576017 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java ## @@ -108,10 +108,11 @@ public static ChannelBuilder

[GitHub] [kafka] ijuma commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r431576164 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java ## @@ -22,7 +22,8 @@ DEFAULT("default"),

[GitHub] [kafka] ijuma commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r431574455 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java ## @@ -108,10 +108,11 @@ public static ChannelBuilder

[GitHub] [kafka] ijuma commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r431574455 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java ## @@ -108,10 +108,11 @@ public static ChannelBuilder

[GitHub] [kafka] ableegoldman commented on a change in pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r431571947 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -551,6 +551,7 @@ void runLoop() {

[GitHub] [kafka] ijuma commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r431571756 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java ## @@ -22,7 +22,8 @@ DEFAULT("default"),

[GitHub] [kafka] kkonstantine merged pull request #8735: KAFKA-10052: Harden assertion of topic settings in Connect integration tests

2020-05-27 Thread GitBox
kkonstantine merged pull request #8735: URL: https://github.com/apache/kafka/pull/8735 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on a change in pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r431571493 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java ## @@ -90,24 +96,21 @@ public static String

[GitHub] [kafka] ableegoldman opened a new pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-27 Thread GitBox
ableegoldman opened a new pull request #8738: URL: https://github.com/apache/kafka/pull/8738 Fixes the admin client timeout supplied to `future.get(timeout)` to always time out based on the configured `default.api.timeout.ms`

[GitHub] [kafka] ableegoldman commented on a change in pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8738: URL: https://github.com/apache/kafka/pull/8738#discussion_r431571250 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -44,12 +45,6 @@ private final

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-635086497 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-635085234 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-635085420 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #8735: KAFKA-10052: Harden assertion of topic settings in Connect integration tests

2020-05-27 Thread GitBox
rhauch commented on pull request #8735: URL: https://github.com/apache/kafka/pull/8735#issuecomment-635085072 The test failures appear to be unrelated to Connect and are known to be flaky. This is an automated message from

[GitHub] [kafka] ijuma merged pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work

2020-05-27 Thread GitBox
ijuma merged pull request #8728: URL: https://github.com/apache/kafka/pull/8728 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work

2020-05-27 Thread GitBox
ijuma commented on pull request #8728: URL: https://github.com/apache/kafka/pull/8728#issuecomment-635083240 Unrelated flaky failures: > org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] >

[jira] [Resolved] (KAFKA-9802) Fix flaky system test `TransactionsTest.test_transactions`

2020-05-27 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9802. Fix Version/s: 2.5.1 Resolution: Fixed > Fix flaky system test

[GitHub] [kafka] ijuma commented on pull request #8732: KAFKA-10017: disable flaky EosBetaUpgradeIntegrationTest to stabilize build

2020-05-27 Thread GitBox
ijuma commented on pull request #8732: URL: https://github.com/apache/kafka/pull/8732#issuecomment-635081822 Thanks for doing this. This test has been incredibly unstable. This is an automated message from the Apache Git

[GitHub] [kafka] hachikuji merged pull request #8736: KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness

2020-05-27 Thread GitBox
hachikuji merged pull request #8736: URL: https://github.com/apache/kafka/pull/8736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rhauch commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-635081325 Jenkins jobs were never associated with this PR (see [INFRA-20344](https://issues.apache.org/jira/browse/INFRA-20344)), but here are the jobs for the latest commit: *

[GitHub] [kafka] ijuma merged pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

2020-05-27 Thread GitBox
ijuma merged pull request #8731: URL: https://github.com/apache/kafka/pull/8731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r431564671 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/WorkerErrantRecordReporter.java ## @@ -0,0 +1,172 @@ +/* + *

[GitHub] [kafka] rhauch commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-635077545 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-8011) Flaky Test RegexSourceIntegrationTest#testRegexMatchesTopicsAWhenCreated

2020-05-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118262#comment-17118262 ] Matthias J. Sax commented on KAFKA-8011: We can also create a new ticket. I don't care. > Flaky

[GitHub] [kafka] rhauch edited a comment on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch edited a comment on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-635072158 Builds were all aborted: `Aborted by user anonymous` * https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2554/ *

[GitHub] [kafka] rhauch commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-635072158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-05-27 Thread GitBox
showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-635071774 Thanks, @ableegoldman . Take your time. :) This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-635071561 Three green builds of commit `126b04`: * https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2552/ * https://builds.apache.org/job/kafka-pr-jdk14-scala2.13/710/ *

[GitHub] [kafka] kkonstantine commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
kkonstantine commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r431557717 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/InternalSinkRecord.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the

[GitHub] [kafka] ableegoldman commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-05-27 Thread GitBox
ableegoldman commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-635065576 Hey @showuon, thanks for the PR! I'm pretty busy at the moment, especially with the 2.6 deadline, but it's on my todo list to review.

[jira] [Updated] (KAFKA-8011) Flaky Test RegexSourceIntegrationTest#testRegexMatchesTopicsAWhenCreated

2020-05-27 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-8011: --- Attachment: org.apache.kafka.streams.integration.RegexSourceIntegrationTest.html >

[jira] [Commented] (KAFKA-8011) Flaky Test RegexSourceIntegrationTest#testRegexMatchesTopicsAWhenCreated

2020-05-27 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118245#comment-17118245 ] Sophie Blee-Goldman commented on KAFKA-8011: Attaching the output from local testing: 

[GitHub] [kafka] rhauch commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r431544842 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/InternalSinkRecord.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r431542322 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -183,12 +180,15 @@ public void

[GitHub] [kafka] kkonstantine commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
kkonstantine commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r431542321 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginUtilsTest.java ## @@ -128,6 +131,10 @@ public void

[GitHub] [kafka] dbtucker commented on pull request #2880: New transform: ExtractFields

2020-05-27 Thread GitBox
dbtucker commented on pull request #2880: URL: https://github.com/apache/kafka/pull/2880#issuecomment-635049359 At the time I wrote this, the combination of Extract Field and Flatten was too limiting for some filtering tasks. Happy to have it land in ExtractField if that is the quicker

[GitHub] [kafka] kkonstantine commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
kkonstantine commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r431512019 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/InternalSinkRecord.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the

[jira] [Commented] (KAFKA-8011) Flaky Test RegexSourceIntegrationTest#testRegexMatchesTopicsAWhenCreated

2020-05-27 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118222#comment-17118222 ] Sophie Blee-Goldman commented on KAFKA-8011: [~mjsax] should we create a separate ticket for

[jira] [Updated] (KAFKA-8011) Flaky Test RegexSourceIntegrationTest#testRegexMatchesTopicsAWhenCreated

2020-05-27 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-8011: --- Priority: Blocker (was: Critical) > Flaky Test

[jira] [Updated] (KAFKA-8011) Flaky Test RegexSourceIntegrationTest#testRegexMatchesTopicsAWhenCreated

2020-05-27 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-8011: --- Fix Version/s: 2.6.0 > Flaky Test

[GitHub] [kafka] abbccdda commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-27 Thread GitBox
abbccdda commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-635042381 ``` 15:01:33 [ant:checkstyle] [ERROR]

[GitHub] [kafka] abbccdda commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
abbccdda commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-635041609 Great work, @feyman2016 @mjsax ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-635041171 Thanks for the KIP and PR @feyman2016! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax merged pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax merged pull request #8589: URL: https://github.com/apache/kafka/pull/8589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] rhauch commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-635034899 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hachikuji commented on a change in pull request #8736: KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness

2020-05-27 Thread GitBox
hachikuji commented on a change in pull request #8736: URL: https://github.com/apache/kafka/pull/8736#discussion_r431530519 ## File path: tests/kafkatest/tests/core/transactions_test.py ## @@ -47,7 +47,7 @@ def __init__(self, test_context): self.num_output_partitions

[jira] [Resolved] (KAFKA-9960) Metrics Reporter should support additional context tags

2020-05-27 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9960. -- Resolution: Fixed Merged the PR to the `trunk` branch for inclusion in the AK 2.6.0 release.

[GitHub] [kafka] rhauch merged pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-27 Thread GitBox
rhauch merged pull request #8691: URL: https://github.com/apache/kafka/pull/8691 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-8930) MM2 documentation

2020-05-27 Thread Rodrigo Alejandro Loza Lucero (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118200#comment-17118200 ] Rodrigo Alejandro Loza Lucero commented on KAFKA-8930: -- Sorry for the question, but

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-635025385 Finally, jenkins cooperated :) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vinothchandar opened a new pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-27 Thread GitBox
vinothchandar opened a new pull request #8737: URL: https://github.com/apache/kafka/pull/8737 - Fixed command line arg checking - Added unit test cases - Local testing with a multi node Kafka cluster ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-635013768 Not sure what's happening, but here are some finally-running builds from previous commit (0e40): * https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2548/ *

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r431513482 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -811,17 +812,41 @@ private void

[GitHub] [kafka] bob-barrett commented on a change in pull request #8736: KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness

2020-05-27 Thread GitBox
bob-barrett commented on a change in pull request #8736: URL: https://github.com/apache/kafka/pull/8736#discussion_r431512735 ## File path: tests/kafkatest/tests/core/transactions_test.py ## @@ -47,7 +47,7 @@ def __init__(self, test_context):

[GitHub] [kafka] hachikuji commented on pull request #8736: KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness

2020-05-27 Thread GitBox
hachikuji commented on pull request #8736: URL: https://github.com/apache/kafka/pull/8736#issuecomment-635012334 Thanks, it was just a copy/paste bug I think. I tweaked the output a little. This is an automated message from

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r431513230 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -811,17 +812,41 @@ private void

[GitHub] [kafka] rhauch commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-635007497 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-635007361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] rhauch commented on pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-27 Thread GitBox
rhauch commented on pull request #8691: URL: https://github.com/apache/kafka/pull/8691#issuecomment-635006306 One seemingly unrelated failure on JDK11 with a known [flaky test](https://issues.apache.org/jira/browse/KAFKA-9516): ```

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-27 Thread GitBox
vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r431505723 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -811,17 +812,41 @@ private void

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-05-27 Thread GitBox
showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-635002983 Hi @abbccdda @ableegoldman , please help review this PR. Thanks This is an automated message from the Apache Git

[GitHub] [kafka] hachikuji opened a new pull request #8736: KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness

2020-05-27 Thread GitBox
hachikuji opened a new pull request #8736: URL: https://github.com/apache/kafka/pull/8736 We have been seeing increased flakiness in transaction system tests. I believe the cause might be due to KIP-537, which increased the default zk session timeout from 6s to 18s and the default replica

[jira] [Updated] (KAFKA-9298) Reuse of a mapped stream causes an Invalid Topology

2020-05-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9298: --- Fix Version/s: 2.5.1 > Reuse of a mapped stream causes an Invalid Topology >

[jira] [Commented] (KAFKA-9298) Reuse of a mapped stream causes an Invalid Topology

2020-05-27 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118162#comment-17118162 ] Bill Bejeck commented on KAFKA-9298: cherry-picked to 2.5 > Reuse of a mapped stream causes an

[GitHub] [kafka] bbejeck commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-27 Thread GitBox
bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-634997680 cherry-picked to 2.5 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-6145) Warm up new KS instances before migrating tasks - potentially a two phase rebalance

2020-05-27 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-6145. Fix Version/s: 2.6.0 Resolution: Fixed > Warm up new KS instances before

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r431484939 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -189,38 +190,52 @@ private void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r431482714 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -272,6 +274,30 @@ public void

[jira] [Commented] (KAFKA-9376) Plugin class loader not found using MM2

2020-05-27 Thread Rodrigo Alejandro Loza Lucero (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118154#comment-17118154 ] Rodrigo Alejandro Loza Lucero commented on KAFKA-9376: -- I had the same problem in

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r431481812 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -811,17 +812,41 @@ private void

[jira] [Updated] (KAFKA-9937) Unable to start Kafka broker using python script

2020-05-27 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-9937: - Component/s: (was: KafkaConnect) > Unable to start Kafka broker using python script >

[GitHub] [kafka] rhauch commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r431474116 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/InternalSinkRecord.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache

[jira] [Created] (KAFKA-10055) Add shared internal utility class

2020-05-27 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-10055: --- Summary: Add shared internal utility class Key: KAFKA-10055 URL: https://issues.apache.org/jira/browse/KAFKA-10055 Project: Kafka Issue Type:

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-634970649 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-634970551 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] kkonstantine commented on pull request #8735: KAFKA-10052: Harden assertion of topic settings in Connect integration tests

2020-05-27 Thread GitBox
kkonstantine commented on pull request #8735: URL: https://github.com/apache/kafka/pull/8735#issuecomment-634968253 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] kkonstantine opened a new pull request #8735: KAFKA-10052: Harden assertion of topic settings in Connect integration tests

2020-05-27 Thread GitBox
kkonstantine opened a new pull request #8735: URL: https://github.com/apache/kafka/pull/8735 A recently added assertion in Connect integration tests uses `consumer#partitionsFor` to verify that a topic was created with the expected number of partitions and replicas. However, probably

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-27 Thread GitBox
vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r431251657 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -189,38 +190,52 @@ private void

[jira] [Resolved] (KAFKA-9952) Reconsider immediate propagation of hw when replica selector is used

2020-05-27 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9952. Fix Version/s: 2.6.0 Resolution: Fixed > Reconsider immediate propagation of hw

[jira] [Assigned] (KAFKA-10052) Flaky Test InternalTopicsIntegrationTest.testCreateInternalTopicsWithFewerReplicasThanBrokers

2020-05-27 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis reassigned KAFKA-10052: -- Assignee: Konstantine Karantasis > Flaky Test >

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-634957589 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hachikuji merged pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-27 Thread GitBox
hachikuji merged pull request #8709: URL: https://github.com/apache/kafka/pull/8709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-634957054 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-634956576 Closing to try to fix builds; will reopen shortly. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] rhauch closed pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch closed pull request #8720: URL: https://github.com/apache/kafka/pull/8720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-9501) Promote Standby tasks to active tasks without closing them

2020-05-27 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-9501: Affects Version/s: 2.6.0 > Promote Standby tasks to active tasks without closing them >

[GitHub] [kafka] vvcephei commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-27 Thread GitBox
vvcephei commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-634956149 Yes, thanks so much for this contribution, and your indefatigable patience, @pgwhalen ! This is an automated

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-634955248 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-27 Thread GitBox
mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-634954533 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-634954721 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-27 Thread GitBox
mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-634954462 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   3   4   >