[GitHub] [kafka] abbccdda commented on a change in pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

2020-08-12 Thread GitBox
abbccdda commented on a change in pull request #9174: URL: https://github.com/apache/kafka/pull/9174#discussion_r469713175 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -805,10 +805,10 @@ public void

[GitHub] [kafka] albert02lowis commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-12 Thread GitBox
albert02lowis commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469707761 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public

[GitHub] [kafka] albert02lowis commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-12 Thread GitBox
albert02lowis commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469704319 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public

[GitHub] [kafka] albert02lowis commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-12 Thread GitBox
albert02lowis commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469704319 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public

[GitHub] [kafka] RamanVerma commented on a change in pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

2020-08-12 Thread GitBox
RamanVerma commented on a change in pull request #9112: URL: https://github.com/apache/kafka/pull/9112#discussion_r469698016 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -187,49 +191,24 @@ class MetadataCacheTest { new

[jira] [Resolved] (KAFKA-10391) Streams should overwrite checkpoint excluding corrupted partitions

2020-08-12 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10391. --- Fix Version/s: 2.7.0 Resolution: Fixed > Streams should overwrite checkpoint

[GitHub] [kafka] guozhangwang merged pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

2020-08-12 Thread GitBox
guozhangwang merged pull request #9170: URL: https://github.com/apache/kafka/pull/9170 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469680702 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-12 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-673212958 ```org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest > shouldUpgradeFromEosAlphaToEosBeta[true]``` failed. I test it on my local and it pass. retest this please

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469650293 ## File path: core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala ## @@ -0,0 +1,127 @@ +/** + * Licensed to the Apache

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469646777 ## File path: core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala ## @@ -0,0 +1,127 @@ +/** + * Licensed to the Apache

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469646777 ## File path: core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala ## @@ -0,0 +1,127 @@ +/** + * Licensed to the Apache

[GitHub] [kafka] ableegoldman commented on pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

2020-08-12 Thread GitBox
ableegoldman commented on pull request #9174: URL: https://github.com/apache/kafka/pull/9174#issuecomment-673189749 @cadonna @guozhangwang This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] hachikuji commented on pull request #9163: KAFKA-10386; Fix flexible version support for `records` type

2020-08-12 Thread GitBox
hachikuji commented on pull request #9163: URL: https://github.com/apache/kafka/pull/9163#issuecomment-673189746 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman opened a new pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

2020-08-12 Thread GitBox
ableegoldman opened a new pull request #9174: URL: https://github.com/apache/kafka/pull/9174 I went through all 5 stages of grief in thinking about what to do here and decided the best thing was to just relax the check after all. Hopefully users who find their output topic unexpectedly

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469637266 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialUpsertion.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the

[jira] [Assigned] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10395: --- Assignee: Sophie Blee-Goldman > TopologyTestDriver does not work with

[jira] [Commented] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176675#comment-17176675 ] Sophie Blee-Goldman commented on KAFKA-10395: - The only really holistic solution I can think

[jira] [Resolved] (KAFKA-10042) Make INVALID_PRODUCER_EPOCH abortable from Produce response

2020-08-12 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-10042. - Resolution: Fixed > Make INVALID_PRODUCER_EPOCH abortable from Produce response >

[jira] [Assigned] (KAFKA-10042) Make INVALID_PRODUCER_EPOCH abortable from Produce response

2020-08-12 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-10042: --- Assignee: Boyang Chen > Make INVALID_PRODUCER_EPOCH abortable from Produce response >

[jira] [Updated] (KAFKA-10042) Make INVALID_PRODUCER_EPOCH abortable from Produce response

2020-08-12 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10042: Fix Version/s: 2.7.0 > Make INVALID_PRODUCER_EPOCH abortable from Produce response >

[jira] [Comment Edited] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176665#comment-17176665 ] Sophie Blee-Goldman edited comment on KAFKA-10395 at 8/13/20, 12:41 AM:

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469627624 ## File path: core/src/test/scala/unit/kafka/server/DescribeUserScramCredentialsRequestTest.scala ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[jira] [Updated] (KAFKA-9803) Allow producers to recover gracefully from transaction timeouts

2020-08-12 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9803: --- Fix Version/s: 2.7.0 > Allow producers to recover gracefully from transaction timeouts >

[jira] [Comment Edited] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176665#comment-17176665 ] Sophie Blee-Goldman edited comment on KAFKA-10395 at 8/13/20, 12:36 AM:

[jira] [Updated] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10395: Labels: test-framework (was: needs-kip test-framework) > TopologyTestDriver does

[GitHub] [kafka] showuon commented on pull request #9104: KAFKA-10266: Update the connector config header.converter

2020-08-12 Thread GitBox
showuon commented on pull request #9104: URL: https://github.com/apache/kafka/pull/9104#issuecomment-673173805 @kkonstantine , could you review this PR? Thanks. This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176665#comment-17176665 ] Sophie Blee-Goldman commented on KAFKA-10395: - I think we could just modify the

[jira] [Updated] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10395: Labels: needs-kip test-framework (was: test-framework) > TopologyTestDriver does

[jira] [Updated] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10395: Labels: test-framework (was: ) > TopologyTestDriver does not work with dynamic

[jira] [Created] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-12 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10395: --- Summary: TopologyTestDriver does not work with dynamic topic routing Key: KAFKA-10395 URL: https://issues.apache.org/jira/browse/KAFKA-10395 Project:

[GitHub] [kafka] badaiaqrandista commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-12 Thread GitBox
badaiaqrandista commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-673156754 @dajac Can you please re-review the changes I've made? This is an automated message from the Apache Git

[jira] [Assigned] (KAFKA-9910) Implement new transaction timed out error

2020-08-12 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao reassigned KAFKA-9910: -- Assignee: HaiyuanZhao > Implement new transaction timed out error >

[GitHub] [kafka] bbejeck commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-12 Thread GitBox
bbejeck commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469593164 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public static void

[GitHub] [kafka] bbejeck commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-12 Thread GitBox
bbejeck commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469593164 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public static void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8834: MINOR: Do not disable heartbeat during Rebalance

2020-08-12 Thread GitBox
ableegoldman commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r469593402 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1069,6 +1069,13 @@ private

[jira] [Updated] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10284: Priority: Critical (was: Major) > Group membership update due to static member

[jira] [Assigned] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-08-12 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-10284: --- Assignee: Boyang Chen > Group membership update due to static member rejoin should be

[jira] [Comment Edited] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-08-12 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176639#comment-17176639 ] Boyang Chen edited comment on KAFKA-10284 at 8/12/20, 10:48 PM: I would

[jira] [Updated] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10284: Fix Version/s: (was: 2.6.1) > Group membership update due to static member

[jira] [Commented] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-08-12 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176639#comment-17176639 ] Boyang Chen commented on KAFKA-10284: - I would say for all. > Group membership update due to static

[jira] [Commented] (KAFKA-9066) Kafka Connect JMX : source & sink task metrics missing for tasks in failed state

2020-08-12 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176636#comment-17176636 ] Randall Hauch commented on KAFKA-9066: -- Merged https://github.com/apache/kafka/pull/8854 to the 2.5

[GitHub] [kafka] ableegoldman commented on a change in pull request #8834: MINOR: Do not disable heartbeat during Rebalance

2020-08-12 Thread GitBox
ableegoldman commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r469587219 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -528,7 +528,6 @@ public void

[GitHub] [kafka] rhauch merged pull request #8854: KAFKA-10146, KAFKA-9066: Retain metrics for failed tasks (backport to 2.5)

2020-08-12 Thread GitBox
rhauch merged pull request #8854: URL: https://github.com/apache/kafka/pull/8854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-9066) Kafka Connect JMX : source & sink task metrics missing for tasks in failed state

2020-08-12 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9066: - Fix Version/s: 2.5.2 > Kafka Connect JMX : source & sink task metrics missing for tasks in

[GitHub] [kafka] svudutala commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2020-08-12 Thread GitBox
svudutala commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-673145549 @dongjinleekr What is timeline for merging this PR and making this upgrade available? This is an automated

[GitHub] [kafka] rhauch commented on a change in pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox
rhauch commented on a change in pull request #9172: URL: https://github.com/apache/kafka/pull/9172#discussion_r469586764 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/TransformationIntegrationTest.java ## @@ -318,4 +323,61 @@ public void

[GitHub] [kafka] rajinisivaram merged pull request #9168: MINOR: Ensure same version of scala library is used for compile and at runtime

2020-08-12 Thread GitBox
rajinisivaram merged pull request #9168: URL: https://github.com/apache/kafka/pull/9168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] rajinisivaram commented on pull request #9168: MINOR: Ensure same version of scala library is used for compile and at runtime

2020-08-12 Thread GitBox
rajinisivaram commented on pull request #9168: URL: https://github.com/apache/kafka/pull/9168#issuecomment-673144455 @ijuma Thanks for the review, streams test failures not related. Merging to trunk, 2.6, 2,5 and 2.4. This

[GitHub] [kafka] ableegoldman commented on pull request #9173: KAFKA-10122: Consumer should allow heartbeat during rebalance

2020-08-12 Thread GitBox
ableegoldman commented on pull request #9173: URL: https://github.com/apache/kafka/pull/9173#issuecomment-673143739 Closing this since I didn't see the existing PR for this bugfix: https://github.com/apache/kafka/pull/8834

[GitHub] [kafka] ableegoldman closed pull request #9173: KAFKA-10122: Consumer should allow heartbeat during rebalance

2020-08-12 Thread GitBox
ableegoldman closed pull request #9173: URL: https://github.com/apache/kafka/pull/9173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

2020-08-12 Thread GitBox
ableegoldman commented on a change in pull request #9094: URL: https://github.com/apache/kafka/pull/9094#discussion_r469582284 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetrics.java ## @@ -289,6 +294,25 @@ public

[GitHub] [kafka] ableegoldman commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

2020-08-12 Thread GitBox
ableegoldman commented on a change in pull request #9094: URL: https://github.com/apache/kafka/pull/9094#discussion_r469582284 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetrics.java ## @@ -289,6 +294,25 @@ public

[GitHub] [kafka] kkonstantine commented on a change in pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox
kkonstantine commented on a change in pull request #9172: URL: https://github.com/apache/kafka/pull/9172#discussion_r469578195 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/TransformationIntegrationTest.java ## @@ -318,4 +323,61 @@ public

[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox
kkonstantine commented on pull request #9172: URL: https://github.com/apache/kafka/pull/9172#issuecomment-673136551 According to https://status.apache.org the jenkins queue has grown too much and the infra team is investigating how to resolve the issues. Thus, the tests haven't run yet.

[GitHub] [kafka] rhauch commented on a change in pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox
rhauch commented on a change in pull request #9172: URL: https://github.com/apache/kafka/pull/9172#discussion_r469574130 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/TransformationIntegrationTest.java ## @@ -318,4 +323,61 @@ public void

[jira] [Updated] (KAFKA-10387) Cannot include SMT configs with source connector that uses topic.creation.* properties

2020-08-12 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10387: -- Priority: Critical (was: Major) > Cannot include SMT configs with source connector that uses

[GitHub] [kafka] d8tltanc commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-12 Thread GitBox
d8tltanc commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-673114249 @abbccdda Thanks for the review offers! I'll rebase this PR. This is an automated message from the Apache Git

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-12 Thread GitBox
d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r468736687 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -721,6 +730,11 @@ protected Node curNode() {

[GitHub] [kafka] vvcephei removed a comment on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-12 Thread GitBox
vvcephei removed a comment on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673100824 @cadonna : ``` > Task :streams:checkstyleMain [ant:checkstyle] [ERROR]

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-12 Thread GitBox
vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673100824 @cadonna : ``` > Task :streams:checkstyleMain [ant:checkstyle] [ERROR]

[GitHub] [kafka] guozhangwang commented on a change in pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

2020-08-12 Thread GitBox
guozhangwang commented on a change in pull request #9170: URL: https://github.com/apache/kafka/pull/9170#discussion_r469518409 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -58,6 +58,9 @@ static boolean

[GitHub] [kafka] guozhangwang commented on a change in pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

2020-08-12 Thread GitBox
guozhangwang commented on a change in pull request #9170: URL: https://github.com/apache/kafka/pull/9170#discussion_r469517595 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,13 +193,17 @@ private void

[GitHub] [kafka] guozhangwang commented on pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

2020-08-12 Thread GitBox
guozhangwang commented on pull request #9170: URL: https://github.com/apache/kafka/pull/9170#issuecomment-673090664 > Do you have any theories as to why this was causing `StreamsUpgradeTest.test_app_upgrade` to be flaky? Do we really get that many TaskCorruptedExceptions in this system

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-12 Thread GitBox
vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673090192 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2020-08-12 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176582#comment-17176582 ] Guozhang Wang commented on KAFKA-10357: --- I've thought about relaying on the committed offsets, but

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-12 Thread GitBox
vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673090128 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-12 Thread GitBox
vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673090023 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-12 Thread GitBox
abbccdda commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-673088220 @d8tltanc Thanks for the great work! I could resume reviewing this PR sometime next week, do you mind rebasing it?

[GitHub] [kafka] abbccdda commented on a change in pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

2020-08-12 Thread GitBox
abbccdda commented on a change in pull request #9170: URL: https://github.com/apache/kafka/pull/9170#discussion_r469509680 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,13 +193,17 @@ private void

[GitHub] [kafka] ableegoldman opened a new pull request #9173: KAFKA-10122: Consumer should allow heartbeat during rebalance

2020-08-12 Thread GitBox
ableegoldman opened a new pull request #9173: URL: https://github.com/apache/kafka/pull/9173 We launched a Streams application reading from a single 3000-partition topic and saw continuous rebalancing. Digging into the logs, every time the leader sent a SyncGroup request it would discover

[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox
kkonstantine commented on pull request #9172: URL: https://github.com/apache/kafka/pull/9172#issuecomment-673067506 cc @rhauch @wicknicks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox
kkonstantine commented on pull request #9172: URL: https://github.com/apache/kafka/pull/9172#issuecomment-673065882 I'll be adding a few more tests. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] kkonstantine opened a new pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox
kkonstantine opened a new pull request #9172: URL: https://github.com/apache/kafka/pull/9172 Addition of configs for custom topic creation with KIP-158 created a regression when transformation configs are also included in the configuration of a source connector. To experience the

[jira] [Updated] (KAFKA-10393) Message for fetch snapshot and fetch

2020-08-12 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-10393: --- Summary: Message for fetch snapshot and fetch (was: KIP-630:

[jira] [Created] (KAFKA-10394) Internal API for generating snapshots

2020-08-12 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-10394: -- Summary: Internal API for generating snapshots Key: KAFKA-10394 URL: https://issues.apache.org/jira/browse/KAFKA-10394 Project: Kafka

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469476195 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4081,168 @@ void handleFailure(Throwable

[jira] [Updated] (KAFKA-10393) KIP-630: message for fetch snapshot and fetch

2020-08-12 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-10393: --- Summary: KIP-630: message for fetch snapshot and fetch (was:

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-12 Thread GitBox
d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r468736687 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -721,6 +730,11 @@ protected Node curNode() {

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-12 Thread GitBox
d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r468736687 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -721,6 +730,11 @@ protected Node curNode() {

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-12 Thread GitBox
d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r469473196 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -74,22 +76,28 @@ private final ClusterResourceListeners

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-12 Thread GitBox
d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r469472239 ## File path: clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-12 Thread GitBox
d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r469471723 ## File path: clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] serjchebotarev commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-08-12 Thread GitBox
serjchebotarev commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-673049249 @ableegoldman alright, thanks. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-12 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r469467881 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1210,28 +1218,20 @@ class Partition(val topicPartition: TopicPartition, } }

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2020-08-12 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176535#comment-17176535 ] Sophie Blee-Goldman commented on KAFKA-10357: - I think the elegant way to shutdown the whole

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-12 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r469460462 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469457068 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4081,168 @@ void handleFailure(Throwable

[GitHub] [kafka] ableegoldman commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

2020-08-12 Thread GitBox
ableegoldman commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-673036155 @serjchebotarev he's out of office this week, just fyi. This is an automated message from the Apache Git

[GitHub] [kafka] ableegoldman commented on a change in pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

2020-08-12 Thread GitBox
ableegoldman commented on a change in pull request #9170: URL: https://github.com/apache/kafka/pull/9170#discussion_r469450345 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java ## @@ -1609,12 +1609,11 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-12 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r469388095 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -748,7 +755,7 @@ class Partition(val topicPartition: TopicPartition,

[jira] [Created] (KAFKA-10393) KIP-630: messafe for fetch snapshot and fetch

2020-08-12 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-10393: -- Summary: KIP-630: messafe for fetch snapshot and fetch Key: KAFKA-10393 URL: https://issues.apache.org/jira/browse/KAFKA-10393 Project:

[GitHub] [kafka] guozhangwang merged pull request #9171: MINOR: add ableegoldman and cadonna to whitelist

2020-08-12 Thread GitBox
guozhangwang merged pull request #9171: URL: https://github.com/apache/kafka/pull/9171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #9171: MINOR: add ableegoldman and cadonna to whitelist

2020-08-12 Thread GitBox
ableegoldman commented on pull request #9171: URL: https://github.com/apache/kafka/pull/9171#issuecomment-673010059 cc @vvcephei @guozhangwang This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ableegoldman opened a new pull request #9171: MINOR: add ableegoldman and cadonna to whitelist

2020-08-12 Thread GitBox
ableegoldman opened a new pull request #9171: URL: https://github.com/apache/kafka/pull/9171 So we don't have to bug the committers to kick off tests  This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] cadonna commented on a change in pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-08-12 Thread GitBox
cadonna commented on a change in pull request #9098: URL: https://github.com/apache/kafka/pull/9098#discussion_r469422110 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -181,26 +181,42 @@ void openDB(final ProcessorContext

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469421523 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4081,168 @@ void handleFailure(Throwable

[GitHub] [kafka] guozhangwang commented on pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

2020-08-12 Thread GitBox
guozhangwang commented on pull request #9170: URL: https://github.com/apache/kafka/pull/9170#issuecomment-67281 cc @ableegoldman @abbccdda for reviews This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-12 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469410480 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4081,168 @@ void handleFailure(Throwable

[jira] [Commented] (KAFKA-10307) Topology cycles in KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2020-08-12 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176482#comment-17176482 ] John Roesler commented on KAFKA-10307: -- Hey [~feyman] , thanks for the reply! IIRC, the number of

  1   2   >