[jira] [Comment Edited] (KAFKA-10876) Duplicate connector/task create requests lead to incorrect FAILED status

2020-12-22 Thread Goltseva Taisiia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253924#comment-17253924 ] Goltseva Taisiia edited comment on KAFKA-10876 at 12/23/20, 7:15 AM: -

[jira] [Commented] (KAFKA-10876) Duplicate connector/task create requests lead to incorrect FAILED status

2020-12-22 Thread Goltseva Taisiia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253924#comment-17253924 ] Goltseva Taisiia commented on KAFKA-10876: -- Hi! It could be seems it's the same issue:

[GitHub] [kafka] showuon edited a comment on pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

2020-12-22 Thread GitBox
showuon edited a comment on pull request #9733: URL: https://github.com/apache/kafka/pull/9733#issuecomment-749913992 @mjsax , thanks for your comments. Let me answer your questions below. > You originally observed a test failure based on missing retries when trying to get the state

[GitHub] [kafka] showuon edited a comment on pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

2020-12-22 Thread GitBox
showuon edited a comment on pull request #9733: URL: https://github.com/apache/kafka/pull/9733#issuecomment-749913992 @mjsax , thanks for your comments. Let me answer your questions below. > You originally observed a test failure based on missing retries when trying to get the state

[GitHub] [kafka] showuon edited a comment on pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

2020-12-22 Thread GitBox
showuon edited a comment on pull request #9733: URL: https://github.com/apache/kafka/pull/9733#issuecomment-749913992 @mjsax , thanks for your comments. Let me answer your questions below. > You originally observed a test failure based on missing retries when trying to get the state

[GitHub] [kafka] showuon edited a comment on pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

2020-12-22 Thread GitBox
showuon edited a comment on pull request #9733: URL: https://github.com/apache/kafka/pull/9733#issuecomment-749913992 @mjsax , thanks for your comments. Let me answer your questions below. > You originally observed a test failure based on missing retries when trying to get the state

[GitHub] [kafka] showuon edited a comment on pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

2020-12-22 Thread GitBox
showuon edited a comment on pull request #9733: URL: https://github.com/apache/kafka/pull/9733#issuecomment-749913992 @mjsax , thanks for your comments. Let me answer your questions below. > You originally observed a test failure based on missing retries when trying to get the state

[GitHub] [kafka] g1geordie edited a comment on pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

2020-12-22 Thread GitBox
g1geordie edited a comment on pull request #9778: URL: https://github.com/apache/kafka/pull/9778#issuecomment-749958296 @chia7712 thank for you comment . please help me take a look again . This is an automated message from

[jira] [Assigned] (KAFKA-10885) Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases

2020-12-22 Thread GeordieMai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GeordieMai reassigned KAFKA-10885: -- Assignee: GeordieMai > Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of

[GitHub] [kafka] g1geordie commented on pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

2020-12-22 Thread GitBox
g1geordie commented on pull request #9778: URL: https://github.com/apache/kafka/pull/9778#issuecomment-749958296 @chia7712 thank for you comment . help me take a look again . This is an automated message from the Apache

[jira] [Commented] (KAFKA-10885) Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases

2020-12-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253906#comment-17253906 ] Chia-Ping Tsai commented on KAFKA-10885: [~Geordie] feel free to take over this issue :) >

[jira] [Commented] (KAFKA-10885) Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases

2020-12-22 Thread GeordieMai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253905#comment-17253905 ] GeordieMai commented on KAFKA-10885: [~chia7712] can I assign this to myself? > Refactor

[jira] [Created] (KAFKA-10885) Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases

2020-12-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10885: -- Summary: Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases Key: KAFKA-10885 URL:

[jira] [Updated] (KAFKA-10885) Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases

2020-12-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10885: --- Labels: newbie (was: ) > Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a

[GitHub] [kafka] showuon commented on pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

2020-12-22 Thread GitBox
showuon commented on pull request #9733: URL: https://github.com/apache/kafka/pull/9733#issuecomment-749913992 @mjsax , thanks for your comments. Let me answer your questions below. > You originally observed a test failure based on missing retries when trying to get the state store.

[GitHub] [kafka] showuon commented on a change in pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

2020-12-22 Thread GitBox
showuon commented on a change in pull request #9733: URL: https://github.com/apache/kafka/pull/9733#discussion_r547617998 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -147,9 +154,16 @@ private final

[jira] [Updated] (KAFKA-10879) ReplicaFetcherThread crash when cluster doing reassign

2020-12-22 Thread zhifeng.peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhifeng.peng updated KAFKA-10879: - Description: [2020-12-21 12:01:28,110] ERROR [ReplicaFetcher replicaId=3, leaderId=6,

[jira] [Updated] (KAFKA-10815) EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified

2020-12-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10815: --- Fix Version/s: 2.7.1 2.6.1 > EosTestDriver#verifyAllTransactionFinished

[GitHub] [kafka] chia7712 commented on a change in pull request #9781: MINOR: Use top-level error in `UpdateFeaturesRequest.getErrorResponse`

2020-12-22 Thread GitBox
chia7712 commented on a change in pull request #9781: URL: https://github.com/apache/kafka/pull/9781#discussion_r547605207 ## File path: clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesRequest.java ## @@ -56,19 +54,11 @@ public

[jira] [Updated] (KAFKA-10815) EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified

2020-12-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10815: --- Fix Version/s: 2.8.0 > EosTestDriver#verifyAllTransactionFinished should break loop if all

[GitHub] [kafka] chia7712 opened a new pull request #9783: KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break l…

2020-12-22 Thread GitBox
chia7712 opened a new pull request #9783: URL: https://github.com/apache/kafka/pull/9783 cherry-pick from #9706 to branch 2.6 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

[GitHub] [kafka] chia7712 opened a new pull request #9782: KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break l…

2020-12-22 Thread GitBox
chia7712 opened a new pull request #9782: URL: https://github.com/apache/kafka/pull/9782 cherry-pick from #9706 to branch 2.7 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

[GitHub] [kafka] chia7712 merged pull request #9706: KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified

2020-12-22 Thread GitBox
chia7712 merged pull request #9706: URL: https://github.com/apache/kafka/pull/9706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-10815) EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified

2020-12-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10815: --- Summary: EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are

[jira] [Updated] (KAFKA-10815) KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified

2020-12-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10815: --- Summary: KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all

[GitHub] [kafka] dongxuwang edited a comment on pull request #9763: MINOR: Use ApiUtils' methods static imported consistently.

2020-12-22 Thread GitBox
dongxuwang edited a comment on pull request #9763: URL: https://github.com/apache/kafka/pull/9763#issuecomment-749878096 @chia7712 Hi Ping, can you help take a look, thanks. This is an automated message from the Apache Git

[GitHub] [kafka] dongxuwang commented on pull request #9763: MINOR: Use ApiUtils' methods static imported consistently.

2020-12-22 Thread GitBox
dongxuwang commented on pull request #9763: URL: https://github.com/apache/kafka/pull/9763#issuecomment-749878096 @chia7712 Hi Ping, can you help review, thanks. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547591383 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1055,14 +1055,14 @@ private boolean handleFetchResponse(

[GitHub] [kafka] mjsax commented on pull request #7068: KAFKA-8651: Add predicate map to #branch

2020-12-22 Thread GitBox
mjsax commented on pull request #7068: URL: https://github.com/apache/kafka/pull/7068#issuecomment-749862519 Closing this PR in favor of https://github.com/apache/kafka/pull/9107 (that is backed by KIP-418). This is an

[jira] [Resolved] (KAFKA-8651) Add a #branch overload that takes a Map of predicate names to predicates

2020-12-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-8651. Resolution: Duplicate Closing this ticket in favor of KAFKA-5488 that is backed by KIP-418

[GitHub] [kafka] mjsax closed pull request #7068: KAFKA-8651: Add predicate map to #branch

2020-12-22 Thread GitBox
mjsax closed pull request #7068: URL: https://github.com/apache/kafka/pull/7068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9722: MINOR: add missing quickstart.html file

2020-12-22 Thread GitBox
mjsax commented on pull request #9722: URL: https://github.com/apache/kafka/pull/9722#issuecomment-749855030 Based on the other PR, we actually did not want to restore the old `quickstart.html` content, but `quickstart-zookeeper.html`. Updated the PR and merged to `trunk`. Also

[GitHub] [kafka] mjsax merged pull request #9722: MINOR: add missing quickstart.html file

2020-12-22 Thread GitBox
mjsax merged pull request #9722: URL: https://github.com/apache/kafka/pull/9722 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] hachikuji commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
hachikuji commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547574619 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1055,14 +1055,14 @@ private boolean handleFetchResponse(

[GitHub] [kafka] mjsax commented on pull request #9721: MINOR: remove dangling quickstart-*.html

2020-12-22 Thread GitBox
mjsax commented on pull request #9721: URL: https://github.com/apache/kafka/pull/9721#issuecomment-749852549 Merged to `trunk` and cherry-picked to `2.7` and `2.6` branches. This is an automated message from the Apache Git

[GitHub] [kafka] mjsax merged pull request #9721: MINOR: remove dangling quickstart-*.html

2020-12-22 Thread GitBox
mjsax merged pull request #9721: URL: https://github.com/apache/kafka/pull/9721 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547568019 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/SuppressionIntegrationTest.java ## @@ -526,6 +526,6 @@ private static void

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547567518 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java ## @@ -128,8 +128,8 @@ public

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547567210 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java ## @@ -174,8 +177,8 @@ private KafkaStreams

[GitHub] [kafka] rhauch commented on pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

2020-12-22 Thread GitBox
rhauch commented on pull request #9780: URL: https://github.com/apache/kafka/pull/9780#issuecomment-749845098 Rebased on `trunk`, and then had to correct tests based on recent changes in Admin API related classes. This is

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r54753 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -737,7 +729,7 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547566599 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -611,12 +604,11 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547566495 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -526,12 +521,10 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547565615 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -521,12 +516,10 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547565615 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -521,12 +516,10 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547564862 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -113,14 +114,7 @@ private static

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547564580 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -388,7 +382,8 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547564223 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java ## @@ -99,7 +99,6 @@ public static void

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547563917 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -557,12 +490,12 @@ public void testStateGlobalThreadClose() throws

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547563654 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -524,9 +460,6 @@ public void testStateThreadClose() throws Exception

[GitHub] [kafka] kowshik commented on a change in pull request #9781: MINOR: Use top-level error in `UpdateFeaturesRequest.getErrorResponse`

2020-12-22 Thread GitBox
kowshik commented on a change in pull request #9781: URL: https://github.com/apache/kafka/pull/9781#discussion_r547557452 ## File path: clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesRequest.java ## @@ -57,18 +55,11 @@ public

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547556738 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1037,6 +1047,35 @@ private boolean handleFetchResponse(

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547556180 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1165,11 +1151,21 @@ private Thread shutdownHelper(final boolean error)

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547554416 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1101,6 +1140,174 @@ private DescribeQuorumResponseData

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547548275 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -226,7 +226,8 @@ RUNNING(1, 2, 3, 5),// 2

[jira] [Commented] (KAFKA-9689) Automatic broker version detection to initialize stream client

2020-12-22 Thread feyman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253798#comment-17253798 ] feyman commented on KAFKA-9689: --- Checked with [~bchen225242] offline, I will pick up this task~ >

[jira] [Assigned] (KAFKA-9689) Automatic broker version detection to initialize stream client

2020-12-22 Thread feyman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] feyman reassigned KAFKA-9689: - Assignee: feyman (was: HaiyuanZhao) > Automatic broker version detection to initialize stream client >

[GitHub] [kafka] hachikuji commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
hachikuji commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547548831 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1037,6 +1047,35 @@ private boolean handleFetchResponse(

[GitHub] [kafka] mjsax commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r547548275 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -226,7 +226,8 @@ RUNNING(1, 2, 3, 5),// 2

[GitHub] [kafka] hachikuji opened a new pull request #9781: MINOR: Use top-level error in `UpdateFeaturesRequest.getErrorResponse`

2020-12-22 Thread GitBox
hachikuji opened a new pull request #9781: URL: https://github.com/apache/kafka/pull/9781 The current `getErrorResponse` sets all of the feature errors, but does not set a top-level error. It seems like the whole point of having the top-level error is so that it could be used in cases

[GitHub] [kafka] mjsax commented on a change in pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

2020-12-22 Thread GitBox
mjsax commented on a change in pull request #9733: URL: https://github.com/apache/kafka/pull/9733#discussion_r547542884 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -135,8 +137,13 @@ private final

[GitHub] [kafka] mjsax merged pull request #9773: MINOR: Kafka Streams updates for 2.7.0 release

2020-12-22 Thread GitBox
mjsax merged pull request #9773: URL: https://github.com/apache/kafka/pull/9773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547485023 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -0,0 +1,765 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547483452 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -287,4 +287,7 @@ public String name() { return "Leader"; } +

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547481788 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1629,16 +1872,29 @@ private long pollFollowerAsVoter(FollowerState

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547481211 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1101,6 +1140,174 @@ private DescribeQuorumResponseData

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547475978 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1037,6 +1047,35 @@ private boolean handleFetchResponse(

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547472266 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -941,6 +949,8 @@ private FetchResponseData tryCompleteFetchRequest(

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547470779 ## File path: clients/src/main/resources/common/message/FetchSnapshotResponse.json ## @@ -0,0 +1,59 @@ +// Licensed to the Apache Software Foundation (ASF)

[jira] [Assigned] (KAFKA-10021) When reading to the end of the config log, check if fetch.max.wait.ms is greater than worker.sync.timeout.ms

2020-12-22 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reassigned KAFKA-10021: - Assignee: Randall Hauch > When reading to the end of the config log, check if

[GitHub] [kafka] rhauch opened a new pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

2020-12-22 Thread GitBox
rhauch opened a new pull request #9780: URL: https://github.com/apache/kafka/pull/9780 The existing `Kafka*BackingStore` classes used by Connect all use `KafkaBasedLog`, which needs to frequently get the end offsets for the internal topic to know whether they are caught up.

[jira] [Updated] (KAFKA-10021) When reading to the end of the config log, check if fetch.max.wait.ms is greater than worker.sync.timeout.ms

2020-12-22 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10021: -- Affects Version/s: 2.3.0 2.4.0 2.5.0

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547446688 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1101,6 +1140,174 @@ private DescribeQuorumResponseData

[jira] [Created] (KAFKA-10884) Limit the size of Fetch and FetchSnapshot response based on broker configuration

2020-12-22 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-10884: -- Summary: Limit the size of Fetch and FetchSnapshot response based on broker configuration Key: KAFKA-10884 URL:

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547437816 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1101,6 +1140,174 @@ private DescribeQuorumResponseData

[jira] [Commented] (KAFKA-10847) Avoid spurious left/outer join results in stream-stream join

2020-12-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253668#comment-17253668 ] Matthias J. Sax commented on KAFKA-10847: - Yeah. Should have assigned it directly... But even

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547424374 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1101,6 +1140,174 @@ private DescribeQuorumResponseData

[jira] [Resolved] (KAFKA-10828) Consider using "acknowledged" over "endorsing" for voters which have recognized the current leader

2020-12-22 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10828. - Resolution: Fixed > Consider using "acknowledged" over "endorsing" for voters which

[GitHub] [kafka] hachikuji merged pull request #9737: KAFKA-10828: Replacing endorsing with acknowledging for voters

2020-12-22 Thread GitBox
hachikuji merged pull request #9737: URL: https://github.com/apache/kafka/pull/9737 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] g1geordie commented on a change in pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

2020-12-22 Thread GitBox
g1geordie commented on a change in pull request #9778: URL: https://github.com/apache/kafka/pull/9778#discussion_r547421729 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -200,7 +202,7 @@ class ClientQuotasRequestTest extends

[GitHub] [kafka] chia7712 commented on a change in pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

2020-12-22 Thread GitBox
chia7712 commented on a change in pull request #9778: URL: https://github.com/apache/kafka/pull/9778#discussion_r547415122 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -200,7 +202,7 @@ class ClientQuotasRequestTest extends

[GitHub] [kafka] g1geordie commented on pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

2020-12-22 Thread GitBox
g1geordie commented on pull request #9778: URL: https://github.com/apache/kafka/pull/9778#issuecomment-749685636 @chia7712 can you help my take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] g1geordie commented on pull request #9776: KAFKA-10878 Check failed message in ProtocolSerializationTest

2020-12-22 Thread GitBox
g1geordie commented on pull request #9776: URL: https://github.com/apache/kafka/pull/9776#issuecomment-749685362 @chia7712 can you help my take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] jsancio commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
jsancio commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547412746 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1101,6 +1140,174 @@ private DescribeQuorumResponseData

[GitHub] [kafka] hachikuji commented on a change in pull request #9553: KAFKA-10427: Fetch snapshot

2020-12-22 Thread GitBox
hachikuji commented on a change in pull request #9553: URL: https://github.com/apache/kafka/pull/9553#discussion_r547391686 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -287,4 +287,7 @@ public String name() { return "Leader"; }

[GitHub] [kafka] vamossagar12 opened a new pull request #9779: KAFKA-10767: Adding test cases for all, reverseAll and reverseRange for ThreadCache

2020-12-22 Thread GitBox
vamossagar12 opened a new pull request #9779: URL: https://github.com/apache/kafka/pull/9779 The test cases for ThreaCache didn't have the corresponding unit tests for all, reverseAll and reverseRange methods. This PR aims to add the same.

[jira] [Updated] (KAFKA-10883) Lien hypertext incorrect

2020-12-22 Thread Jimmy PANNIER (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy PANNIER updated KAFKA-10883: -- Description: En tant que visiteur du site web de présentation kafka,

[jira] [Created] (KAFKA-10883) Lien hypertext incorrect

2020-12-22 Thread Jimmy PANNIER (Jira)
Jimmy PANNIER created KAFKA-10883: - Summary: Lien hypertext incorrect Key: KAFKA-10883 URL: https://issues.apache.org/jira/browse/KAFKA-10883 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-10882) When sending a response to the client,a null pointer exception has occurred in the error code set

2020-12-22 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenbing Shen updated KAFKA-10882: - Attachment: 0880c08b0110fb95d40a.png > When sending a response to the client,a null pointer

[jira] [Created] (KAFKA-10882) When sending a response to the client,a null pointer exception has occurred in the error code set

2020-12-22 Thread Wenbing Shen (Jira)
Wenbing Shen created KAFKA-10882: Summary: When sending a response to the client,a null pointer exception has occurred in the error code set Key: KAFKA-10882 URL: https://issues.apache.org/jira/browse/KAFKA-10882

[jira] [Commented] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2020-12-22 Thread Yifei Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253423#comment-17253423 ] Yifei Gong commented on KAFKA-10875: No worries at all [~tombentley]! I actually hope that's the

[jira] [Comment Edited] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2020-12-22 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253410#comment-17253410 ] Tom Bentley edited comment on KAFKA-10875 at 12/22/20, 11:10 AM: -

[jira] [Commented] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2020-12-22 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253410#comment-17253410 ] Tom Bentley commented on KAFKA-10875: - [~gongyifei] sorry, you're quite right. Not enough coffee

[jira] [Commented] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2020-12-22 Thread Yifei Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253405#comment-17253405 ] Yifei Gong commented on KAFKA-10875: [~tombentley] do you mean {{offsetsForTimes()}} will not search

[GitHub] [kafka] g1geordie opened a new pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

2020-12-22 Thread GitBox
g1geordie opened a new pull request #9778: URL: https://github.com/apache/kafka/pull/9778 The error occcur when dynamic ip config update after borker's config get . solve this by waiting dynamic ip config update.

[jira] [Created] (KAFKA-10881) Fetch offset 2587113 is out of range for partition $TOPIC_NAME-0, resetting offset

2020-12-22 Thread Rupesh (Jira)
Rupesh created KAFKA-10881: -- Summary: Fetch offset 2587113 is out of range for partition $TOPIC_NAME-0, resetting offset Key: KAFKA-10881 URL: https://issues.apache.org/jira/browse/KAFKA-10881 Project:

[jira] [Created] (KAFKA-10880) Fetch offset 2587113 is out of range for partition $TOPIC_NAME-0, resetting offset

2020-12-22 Thread Rupesh (Jira)
Rupesh created KAFKA-10880: -- Summary: Fetch offset 2587113 is out of range for partition $TOPIC_NAME-0, resetting offset Key: KAFKA-10880 URL: https://issues.apache.org/jira/browse/KAFKA-10880 Project:

[jira] [Commented] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2020-12-22 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253344#comment-17253344 ] Tom Bentley commented on KAFKA-10875: - Because the log cleaning removed the older data (in those

[jira] [Commented] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2020-12-22 Thread Yifei Gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253340#comment-17253340 ] Yifei Gong commented on KAFKA-10875: Hi [~tombentley], that's why I tried twice. The 2nd time I

[jira] [Comment Edited] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2020-12-22 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253338#comment-17253338 ] Tom Bentley edited comment on KAFKA-10875 at 12/22/20, 8:45 AM: Are you

  1   2   >