[jira] [Updated] (KAFKA-10586) Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

2021-01-25 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-10586: - Description: KIP-382 introduced MirrorMaker 2.0. Because of scoping issues, the dedicated

[jira] [Updated] (KAFKA-10586) Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

2021-01-25 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-10586: - Summary: Full support for distributed mode in dedicated MirrorMaker 2.0 clusters (was:

[jira] [Commented] (KAFKA-9914) Mirror Maker 2 creates heartbeats kafka topics recursively

2021-01-25 Thread Ravishankar S R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271930#comment-17271930 ] Ravishankar S R commented on KAFKA-9914: Hi [~qq619618919], Thanks for your reply. I did try by

[GitHub] [kafka] liusheng commented on pull request #9872: KAFKA-10759: ARM support for Kafka

2021-01-25 Thread GitBox
liusheng commented on pull request #9872: URL: https://github.com/apache/kafka/pull/9872#issuecomment-767347463 Thanks for bringing this up, hope more and more Big-data projects can run on ARM platform :) This is an

[GitHub] [kafka] wilkinsona commented on pull request #9968: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
wilkinsona commented on pull request #9968: URL: https://github.com/apache/kafka/pull/9968#issuecomment-767337053 Thanks again. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] chia7712 commented on a change in pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol

2021-01-25 Thread GitBox
chia7712 commented on a change in pull request #9641: URL: https://github.com/apache/kafka/pull/9641#discussion_r564260770 ## File path: connect/runtime/src/main/resources/common/message/ConnectAssignment.json ## @@ -0,0 +1,36 @@ +// Licensed to the Apache Software Foundation

[GitHub] [kafka] dengziming commented on a change in pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol

2021-01-25 Thread GitBox
dengziming commented on a change in pull request #9641: URL: https://github.com/apache/kafka/pull/9641#discussion_r564255280 ## File path: connect/runtime/src/main/resources/common/message/ConnectAssignment.json ## @@ -0,0 +1,36 @@ +// Licensed to the Apache Software

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r564251634 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2216,7 +2316,7 @@ public void complete() { // These fields are

[GitHub] [kafka] chia7712 commented on pull request #9971: MINOR: Cache segments map only when required in Log.fetchOffsetByTimestamp

2021-01-25 Thread GitBox
chia7712 commented on pull request #9971: URL: https://github.com/apache/kafka/pull/9971#issuecomment-767317353 ```logSegments``` is thread-safe so is the copy necessary in this case? This is an automated message from the

[jira] [Created] (KAFKA-12238) Implement DescribeProducers API

2021-01-25 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12238: --- Summary: Implement DescribeProducers API Key: KAFKA-12238 URL: https://issues.apache.org/jira/browse/KAFKA-12238 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r564245683 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -43,7 +44,59 @@ final public class

[GitHub] [kafka] hachikuji commented on pull request #9268: KAFKA-10442; Add transaction admin APIs for KIP-664

2021-01-25 Thread GitBox
hachikuji commented on pull request #9268: URL: https://github.com/apache/kafka/pull/9268#issuecomment-767316273 Closing this since clearly no one wants to review  . I will split it up into a set of smaller PRs. This is an

[GitHub] [kafka] hachikuji closed pull request #9268: KAFKA-10442; Add transaction admin APIs for KIP-664

2021-01-25 Thread GitBox
hachikuji closed pull request #9268: URL: https://github.com/apache/kafka/pull/9268 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r564244777 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java ## @@ -106,6 +120,14 @@ */ void updateHighWatermark(LogOffsetMetadata

[GitHub] [kafka] chia7712 merged pull request #9966: MINOR: Fix visibility of Log.{unflushedMessages, addSegment} methods

2021-01-25 Thread GitBox
chia7712 merged pull request #9966: URL: https://github.com/apache/kafka/pull/9966 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r564243924 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -69,23 +82,55 @@ class KafkaMetadataLog( val appendInfo =

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r564243709 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -69,23 +82,55 @@ class KafkaMetadataLog( val appendInfo =

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r564243248 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -370,7 +375,9 @@ class Log(@volatile private var _dir: File, throw new

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r564242549 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -16,28 +16,41 @@ */ package kafka.raft +import java.nio.file.Files import

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r564242245 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -69,23 +82,55 @@ class KafkaMetadataLog( val appendInfo =

[GitHub] [kafka] chia7712 commented on pull request #9970: Kafka-12233: `FileRecords.writeTo` set length incorrectly

2021-01-25 Thread GitBox
chia7712 commented on pull request #9970: URL: https://github.com/apache/kafka/pull/9970#issuecomment-767313055 @dengziming Thanks for your patch. Does this patch want to adjust "count" to make sure it is NOT out of bound of file size? If so, it may be redundant as the "count" is

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-25 Thread GitBox
dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r564224916 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1223,7 +1247,7 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] chia7712 commented on a change in pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol

2021-01-25 Thread GitBox
chia7712 commented on a change in pull request #9641: URL: https://github.com/apache/kafka/pull/9641#discussion_r564213503 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/ConnectProtocol.java ## @@ -43,96 +27,9 @@ * joining the group

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-25 Thread GitBox
dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r564222778 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,125 @@ +/** + * Licensed to the

[jira] [Commented] (KAFKA-8930) MM2 documentation

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271863#comment-17271863 ] ASF GitHub Bot commented on KAFKA-8930: --- miguno commented on a change in pull request #324: URL:

[GitHub] [kafka] ableegoldman commented on pull request #9968: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
ableegoldman commented on pull request #9968: URL: https://github.com/apache/kafka/pull/9968#issuecomment-767284407 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r564212153 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -963,49 +979,111 @@ private FetchResponseData tryCompleteFetchRequest(

[GitHub] [kafka] ableegoldman merged pull request #9968: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
ableegoldman merged pull request #9968: URL: https://github.com/apache/kafka/pull/9968 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
ableegoldman commented on pull request #9947: URL: https://github.com/apache/kafka/pull/9947#issuecomment-767286649 @garyrussell I just merged the 2.6 PR so we'll be ready to go if/when the 2.6.2 release is started. To be honest I'm not sure how likely it is for a 2.6.2 release to be

[GitHub] [kafka] ijuma commented on pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

2021-01-25 Thread GitBox
ijuma commented on pull request #9960: URL: https://github.com/apache/kafka/pull/9960#issuecomment-766742269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] bbejeck commented on pull request #9738: KAFKA-8744: Update Scala API to give names to processors

2021-01-25 Thread GitBox
bbejeck commented on pull request #9738: URL: https://github.com/apache/kafka/pull/9738#issuecomment-766907703 ping @mdespriee feature freeze for 2.8 is approaching it would be great to get this in. This is an automated

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-25 Thread GitBox
jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563861257 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -313,42 +313,57 @@ object TopicCommand extends Logging { } override def

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-01-25 Thread GitBox
tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-766880511 Rebased for conflict. @guozhangwang @cadonna @hachikuji please could one of you take a look? This is

[GitHub] [kafka] showuon commented on a change in pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
showuon commented on a change in pull request #9947: URL: https://github.com/apache/kafka/pull/9947#discussion_r563527151 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -109,16 +109,27 @@ public StateDirectory(final

[GitHub] [kafka] kowshik commented on pull request #9966: MINOR: Fix visibility of Log.{unflushedMessages, addSegment} methods

2021-01-25 Thread GitBox
kowshik commented on pull request #9966: URL: https://github.com/apache/kafka/pull/9966#issuecomment-767042371 cc @junrao for review This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman merged pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
ableegoldman merged pull request #9947: URL: https://github.com/apache/kafka/pull/9947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] kkonstantine commented on a change in pull request #9942: KAFKA-12229: reset to original class loader after connector stop

2021-01-25 Thread GitBox
kkonstantine commented on a change in pull request #9942: URL: https://github.com/apache/kafka/pull/9942#discussion_r564046001 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java ## @@ -157,6 +160,7 @@ public void

[GitHub] [kafka] JimGalasyn commented on a change in pull request #9969: updated upgrade and architecture

2021-01-25 Thread GitBox
JimGalasyn commented on a change in pull request #9969: URL: https://github.com/apache/kafka/pull/9969#discussion_r564106498 ## File path: docs/streams/architecture.html ## @@ -110,6 +110,11 @@

[GitHub] [kafka] garyrussell commented on pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
garyrussell commented on pull request #9947: URL: https://github.com/apache/kafka/pull/9947#issuecomment-767150460 As I [commented on the JIRA

[GitHub] [kafka] kkonstantine commented on pull request #9942: KAFKA-12229: reset to original class loader after connector stop

2021-01-25 Thread GitBox
kkonstantine commented on pull request #9942: URL: https://github.com/apache/kafka/pull/9942#issuecomment-767272618 Indeed @showuon jdk8 and 15 are green. Thanks for the non-obvious fix. LGTM This is an automated

[GitHub] [kafka] chia7712 commented on pull request #9943: MINOR: Fix typo in Utils#toPositive

2021-01-25 Thread GitBox
chia7712 commented on pull request #9943: URL: https://github.com/apache/kafka/pull/9943#issuecomment-766622703 @hongshaoyang Thanks for your patch! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] kowshik commented on pull request #9971: MINOR: Cache segments map only when required in Log.fetchOffsetByTimestamp

2021-01-25 Thread GitBox
kowshik commented on pull request #9971: URL: https://github.com/apache/kafka/pull/9971#issuecomment-767252255 cc @junrao for review This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] hachikuji commented on a change in pull request #9739: KAFKA-10636 Bypass log validation for writes to raft log

2021-01-25 Thread GitBox
hachikuji commented on a change in pull request #9739: URL: https://github.com/apache/kafka/pull/9739#discussion_r563941848 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1057,7 +1057,8 @@ class Log(@volatile private var _dir: File,

[GitHub] [kafka] guozhangwang commented on pull request #9840: KAFKA-10867: Improved task idling

2021-01-25 Thread GitBox
guozhangwang commented on pull request #9840: URL: https://github.com/apache/kafka/pull/9840#issuecomment-767024409 I've just kicked another test. Please feel free to merge afterwards. This is an automated message from the

[GitHub] [kafka] g1geordie commented on a change in pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-01-25 Thread GitBox
g1geordie commented on a change in pull request #9906: URL: https://github.com/apache/kafka/pull/9906#discussion_r563480062 ## File path: clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java ## @@ -455,20 +460,19 @@ public void

[GitHub] [kafka] ijuma commented on a change in pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

2021-01-25 Thread GitBox
ijuma commented on a change in pull request #9960: URL: https://github.com/apache/kafka/pull/9960#discussion_r563524752 ## File path: clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalBuilder.java ## @@ -188,9 +185,7 @@ public

[GitHub] [kafka] urbandan commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-01-25 Thread GitBox
urbandan commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-766923270 @dajac Thank you for your review. Managed to work on this, and addressed your points. This is an automated

[GitHub] [kafka] jolshan edited a comment on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-25 Thread GitBox
jolshan edited a comment on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-766972011 Thanks for the updates and all the hard work! I added a few comments. Mostly just questions for clarification.

[GitHub] [kafka] hachikuji commented on pull request #9958: MINOR: Clean up group instance id handling in `GroupCoordinator`

2021-01-25 Thread GitBox
hachikuji commented on pull request #9958: URL: https://github.com/apache/kafka/pull/9958#issuecomment-766599612 cc @dajac No hurry, but if you have time, please take a look. This is an automated message from the Apache Git

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2021-01-25 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-766978261 Hi @ryannedolan @hachikuji I'd like a definitive direction from you on this subject. Once again, I reiterate on my personal preference as expressed previously by

[GitHub] [kafka] wilkinsona commented on pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
wilkinsona commented on pull request #9947: URL: https://github.com/apache/kafka/pull/9947#issuecomment-766751169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] jsancio commented on a change in pull request #9819: KAFKA-10694: Implement zero copy for FetchSnapshot

2021-01-25 Thread GitBox
jsancio commented on a change in pull request #9819: URL: https://github.com/apache/kafka/pull/9819#discussion_r564124971 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -1098,6 +1099,29 @@ public static void writeFully(FileChannel channel,

[GitHub] [kafka] ijuma merged pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

2021-01-25 Thread GitBox
ijuma merged pull request #9960: URL: https://github.com/apache/kafka/pull/9960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 commented on pull request #9931: MINOR: MessageUtil: remove some deadcode

2021-01-25 Thread GitBox
chia7712 commented on pull request #9931: URL: https://github.com/apache/kafka/pull/9931#issuecomment-766615980 ``` org.apache.kafka.streams.integration.AdjustStreamThreadCountTest.shouldAddAndRemoveStreamThreadsWhileKeepingNamesCorrect ``` ``` Build / JDK 11 /

[GitHub] [kafka] wilkinsona commented on a change in pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
wilkinsona commented on a change in pull request #9947: URL: https://github.com/apache/kafka/pull/9947#discussion_r563652131 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -109,16 +109,27 @@ public

[GitHub] [kafka] chia7712 merged pull request #9931: MINOR: MessageUtil: remove some deadcode

2021-01-25 Thread GitBox
chia7712 merged pull request #9931: URL: https://github.com/apache/kafka/pull/9931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] wcarlson5 commented on pull request #9720: KAFKA-10555: Improve client state machine

2021-01-25 Thread GitBox
wcarlson5 commented on pull request #9720: URL: https://github.com/apache/kafka/pull/9720#issuecomment-767090922 @mjsax it looks like there is one unrelated failure `java.lang.RuntimeException: java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.TopicExistsException:

[GitHub] [kafka] showuon edited a comment on pull request #9942: KAFKA-12229: reset to original class loader after connector stop

2021-01-25 Thread GitBox
showuon edited a comment on pull request #9942: URL: https://github.com/apache/kafka/pull/9942#issuecomment-766574155 @kkonstantine , thanks for the comments. Answer your questions below: 1. Have you noticed how often that happens (every time or occasionally)? --> I'd say, it happens

[GitHub] [kafka] ableegoldman commented on pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
ableegoldman commented on pull request #9947: URL: https://github.com/apache/kafka/pull/9947#issuecomment-767051785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] hachikuji commented on a change in pull request #9819: KAFKA-10694: Implement zero copy for FetchSnapshot

2021-01-25 Thread GitBox
hachikuji commented on a change in pull request #9819: URL: https://github.com/apache/kafka/pull/9819#discussion_r563488709 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -134,6 +134,16 @@ public void readInto(ByteBuffer buffer, int

[GitHub] [kafka] chia7712 commented on a change in pull request #9961: MINOR: remove unused code from MessageTest

2021-01-25 Thread GitBox
chia7712 commented on a change in pull request #9961: URL: https://github.com/apache/kafka/pull/9961#discussion_r563535369 ## File path: clients/src/test/java/org/apache/kafka/common/message/MessageTest.java ## @@ -1006,12 +977,6 @@ private void verifyWriteSucceeds(short

[GitHub] [kafka] g1geordie commented on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-01-25 Thread GitBox
g1geordie commented on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-766586309 @sknop hello , It seems like there are some style error . You can use `./gradlew checkstyleMain checkstyleTest` to cehck .

[GitHub] [kafka] chia7712 commented on a change in pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

2021-01-25 Thread GitBox
chia7712 commented on a change in pull request #9960: URL: https://github.com/apache/kafka/pull/9960#discussion_r563481973 ## File path: clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalBuilder.java ## @@ -188,9 +185,7 @@ public

[GitHub] [kafka] ijuma commented on a change in pull request #9961: MINOR: remove unused code from MessageTest

2021-01-25 Thread GitBox
ijuma commented on a change in pull request #9961: URL: https://github.com/apache/kafka/pull/9961#discussion_r563528446 ## File path: clients/src/test/java/org/apache/kafka/common/message/MessageTest.java ## @@ -1006,12 +977,6 @@ private void verifyWriteSucceeds(short

[GitHub] [kafka] chia7712 commented on a change in pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-01-25 Thread GitBox
chia7712 commented on a change in pull request #9906: URL: https://github.com/apache/kafka/pull/9906#discussion_r563469378 ## File path: clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java ## @@ -455,20 +460,19 @@ public void

[GitHub] [kafka] dengziming commented on pull request #9970: Kafka 12233: `FileRecords.writeTo` set length incorrectly

2021-01-25 Thread GitBox
dengziming commented on pull request #9970: URL: https://github.com/apache/kafka/pull/9970#issuecomment-767242636 Hi, @junrao , PTAL. This is changed in #2140 , also ping @chia7712 @hachikuji to check it. This is an

[GitHub] [kafka] chia7712 merged pull request #9943: MINOR: Fix typo in Utils#toPositive

2021-01-25 Thread GitBox
chia7712 merged pull request #9943: URL: https://github.com/apache/kafka/pull/9943 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] sknop commented on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-01-25 Thread GitBox
sknop commented on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-766939861 > @sknop hello , It seems like there are some style error . > You can use `./gradlew checkstyleMain checkstyleTest` to cehck . Thank you for your feedback. I have adjusted

[GitHub] [kafka] C0urante commented on a change in pull request #9805: MINOR: Remove outdated comment in Connect's WorkerCoordinator

2021-01-25 Thread GitBox
C0urante commented on a change in pull request #9805: URL: https://github.com/apache/kafka/pull/9805#discussion_r563760581 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java ## @@ -50,7 +50,6 @@ * to workers. */

[GitHub] [kafka] wilkinsona edited a comment on pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
wilkinsona edited a comment on pull request #9947: URL: https://github.com/apache/kafka/pull/9947#issuecomment-766751169 I think all the review comments have now been addressed. Please let me know if you'd like the commits to be squashed into one.

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-25 Thread GitBox
rajinisivaram commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563620794 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,117 @@ +/** + * Licensed to

[GitHub] [kafka] ableegoldman commented on pull request #9671: KAFKA-10793: move handling of FindCoordinatorFuture to fix race condition

2021-01-25 Thread GitBox
ableegoldman commented on pull request #9671: URL: https://github.com/apache/kafka/pull/9671#issuecomment-767278329 Ok I think I've gotten to the bottom of this hanging test, and pushed a fix. Tests seem to be passing reliably for me locally. Aiming to get this merged in the next day or

[GitHub] [kafka] ableegoldman commented on a change in pull request #9863: MINOR: Restore interrupt status when closing

2021-01-25 Thread GitBox
ableegoldman commented on a change in pull request #9863: URL: https://github.com/apache/kafka/pull/9863#discussion_r563978428 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -612,11 +612,22 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-01-25 Thread GitBox
ableegoldman commented on a change in pull request #9947: URL: https://github.com/apache/kafka/pull/9947#discussion_r563979615 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -109,16 +109,27 @@ public

[GitHub] [kafka] dengziming edited a comment on pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

2021-01-25 Thread GitBox
dengziming edited a comment on pull request #9960: URL: https://github.com/apache/kafka/pull/9960#issuecomment-766745732 Yes, #9766 is trying to replace Struct in`StickyAssignor`. I am not sure about removing Struct class, I will try to check it, but we can remove

[GitHub] [kafka] dengziming commented on a change in pull request #2140: KAFKA-4390: Replace MessageSet usage with client-side alternatives

2021-01-25 Thread GitBox
dengziming commented on a change in pull request #2140: URL: https://github.com/apache/kafka/pull/2140#discussion_r563471404 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -44,83 +53,435 @@ public FileRecords(File file,

[GitHub] [kafka] dengziming commented on pull request #9965: MINOR: Fix always-passing assertNull validation

2021-01-25 Thread GitBox
dengziming commented on pull request #9965: URL: https://github.com/apache/kafka/pull/9965#issuecomment-766857476 @guozhangwang , hello, PTAL. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-25 Thread GitBox
dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r563708864 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,117 @@ +/** + * Licensed to the

[GitHub] [kafka] junrao commented on a change in pull request #2140: KAFKA-4390: Replace MessageSet usage with client-side alternatives

2021-01-25 Thread GitBox
junrao commented on a change in pull request #2140: URL: https://github.com/apache/kafka/pull/2140#discussion_r563909128 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -44,83 +53,435 @@ public FileRecords(File file,

[GitHub] [kafka] kkonstantine commented on a change in pull request #9805: MINOR: Remove outdated comment in Connect's WorkerCoordinator

2021-01-25 Thread GitBox
kkonstantine commented on a change in pull request #9805: URL: https://github.com/apache/kafka/pull/9805#discussion_r563487426 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java ## @@ -50,7 +50,6 @@ * to workers.

[GitHub] [kafka] dengziming commented on pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

2021-01-25 Thread GitBox
dengziming commented on pull request #9960: URL: https://github.com/apache/kafka/pull/9960#issuecomment-766736615 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] dengziming commented on a change in pull request #9819: KAFKA-10694: Implement zero copy for FetchSnapshot

2021-01-25 Thread GitBox
dengziming commented on a change in pull request #9819: URL: https://github.com/apache/kafka/pull/9819#discussion_r563617104 ## File path: clients/src/main/resources/common/message/FetchSnapshotResponse.json ## @@ -51,8 +51,8 @@ "about": "The total size of the

[GitHub] [kafka] ijuma commented on pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol

2021-01-25 Thread GitBox
ijuma commented on pull request #9641: URL: https://github.com/apache/kafka/pull/9641#issuecomment-766740318 cc @kkonstantine This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] urbandan commented on a change in pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-01-25 Thread GitBox
urbandan commented on a change in pull request #9430: URL: https://github.com/apache/kafka/pull/9430#discussion_r563667979 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -33,15 +35,26 @@ object GetOffsetShell { def main(args: Array[String]): Unit

[GitHub] [kafka] kkonstantine merged pull request #9942: KAFKA-12229: reset to original class loader after connector stop

2021-01-25 Thread GitBox
kkonstantine merged pull request #9942: URL: https://github.com/apache/kafka/pull/9942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] wcarlson5 commented on pull request #9969: updated upgrade and architecture

2021-01-25 Thread GitBox
wcarlson5 commented on pull request #9969: URL: https://github.com/apache/kafka/pull/9969#issuecomment-767148249 @mjsax @JimGalasyn I took a stab at updating the docs for a couple of kips. Let me know if there is anywhere I missed

[GitHub] [kafka] chia7712 commented on pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-01-25 Thread GitBox
chia7712 commented on pull request #9906: URL: https://github.com/apache/kafka/pull/9906#issuecomment-766549241 @g1geordie Could you merge trunk to include the recent bug fixes? This is an automated message from the Apache

[GitHub] [kafka] guozhangwang commented on a change in pull request #9840: KAFKA-10867: Improved task idling

2021-01-25 Thread GitBox
guozhangwang commented on a change in pull request #9840: URL: https://github.com/apache/kafka/pull/9840#discussion_r563952224 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java ## @@ -123,9 +123,9 @@ public boolean

[GitHub] [kafka] jolshan commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-25 Thread GitBox
jolshan commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-766972011 I added a few comments. Mostly just questions for clarification. This is an automated message from the Apache Git

[GitHub] [kafka] dajac commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-01-25 Thread GitBox
dajac commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-766990569 @urbandan Thanks for the update. I will make another pass on it this week. It seems that there are compilation error. Could you take a look please?

[GitHub] [kafka] ijuma commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-25 Thread GitBox
ijuma commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r563455980 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -371,9 +372,44 @@ class RequestChannel(val queueSize: Int,

[GitHub] [kafka] showuon commented on pull request #9942: KAFKA-12229: reset to original class loader after connector stop

2021-01-25 Thread GitBox
showuon commented on pull request #9942: URL: https://github.com/apache/kafka/pull/9942#issuecomment-766495717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] luben commented on pull request #9957: MINOR: Update zstd-jni to 1.4.8-2

2021-01-25 Thread GitBox
luben commented on pull request #9957: URL: https://github.com/apache/kafka/pull/9957#issuecomment-766429641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma merged pull request #9957: MINOR: Update zstd-jni to 1.4.8-2

2021-01-25 Thread GitBox
ijuma merged pull request #9957: URL: https://github.com/apache/kafka/pull/9957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] luben edited a comment on pull request #9957: MINOR: Update zstd-jni to 1.4.8-2

2021-01-25 Thread GitBox
luben edited a comment on pull request #9957: URL: https://github.com/apache/kafka/pull/9957#issuecomment-766508115 > BTW, are you going to implement zstd buffer pool by our buffer supplier (even though #9229 is not merged)? I think it would be good next step. I looked at Kafka's

[GitHub] [kafka] ijuma commented on pull request #9957: MINOR: Update zstd-jni to 1.4.8-2

2021-01-25 Thread GitBox
ijuma commented on pull request #9957: URL: https://github.com/apache/kafka/pull/9957#issuecomment-766439012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-01-25 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-766499389 @abbccdda @guozhangwang , please help review this PR. I believe it impacts some users. Thanks. This is an

[GitHub] [kafka] rgo edited a comment on pull request #9937: KAFKA-4759 Add support for IPv4 and IPv6 ranges in AclAuthorizer

2021-01-25 Thread GitBox
rgo edited a comment on pull request #9937: URL: https://github.com/apache/kafka/pull/9937#issuecomment-763768428 @jeqo I've closed the old PR https://github.com/apache/kafka/pull/9387 because it was a mess with all the merge commits, rebased commits and conflicts with latest changes.

[GitHub] [kafka] g1geordie commented on a change in pull request #9954: MINOR: apply FilterByKeyIterator and FlattenedIterator to code base

2021-01-25 Thread GitBox
g1geordie commented on a change in pull request #9954: URL: https://github.com/apache/kafka/pull/9954#discussion_r563435977 ## File path: clients/src/main/java/org/apache/kafka/common/utils/FilterByKeyIterator.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kkonstantine merged pull request #9942: KAFKA-12229: reset to original class loader after connector stop

2021-01-25 Thread GitBox
kkonstantine merged pull request #9942: URL: https://github.com/apache/kafka/pull/9942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   3   >