[jira] [Commented] (KAFKA-12638) Remove default implementation of ConsumerRebalanceListener#onPartitionsLost

2021-04-08 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317670#comment-17317670 ] dengziming commented on KAFKA-12638: [~ben.c] Feel free to take as many issues as you can as long as

[jira] [Commented] (KAFKA-12492) Formatting of example RocksDBConfigSetter is messed up

2021-04-08 Thread Ben Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317658#comment-17317658 ] Ben Chen commented on KAFKA-12492: -- Sounds good to me. I will do a follow-up PR. > Formatting of

[jira] [Commented] (KAFKA-12638) Remove default implementation of ConsumerRebalanceListener#onPartitionsLost

2021-04-08 Thread Ben Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317654#comment-17317654 ] Ben Chen commented on KAFKA-12638: -- Really appreciate it! > Remove default implementation of

[jira] [Assigned] (KAFKA-12638) Remove default implementation of ConsumerRebalanceListener#onPartitionsLost

2021-04-08 Thread Ben Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Chen reassigned KAFKA-12638: Assignee: Ben Chen > Remove default implementation of ConsumerRebalanceListener#onPartitionsLost

[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-04-08 Thread Patrick O'Keeffe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317651#comment-17317651 ] Patrick O'Keeffe commented on KAFKA-12453: -- Thanks [~mjsax], I'm happy to raise a PR to update

[GitHub] [kafka] C0urante closed pull request #10315: KAFKA-12463: Update default sink task partition assignor to cooperative sticky assignor

2021-04-08 Thread GitBox
C0urante closed pull request #10315: URL: https://github.com/apache/kafka/pull/10315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] C0urante commented on pull request #10315: KAFKA-12463: Update default sink task partition assignor to cooperative sticky assignor

2021-04-08 Thread GitBox
C0urante commented on pull request #10315: URL: https://github.com/apache/kafka/pull/10315#issuecomment-816388437 Closing as this will likely be accomplished by KIP-726; can reopen if necessary. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-12638) Remove default implementation of ConsumerRebalanceListener#onPartitionsLost

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317638#comment-17317638 ] A. Sophie Blee-Goldman commented on KAFKA-12638: If you're interested in this ticket, we

[jira] [Commented] (KAFKA-12638) Remove default implementation of ConsumerRebalanceListener#onPartitionsLost

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317635#comment-17317635 ] A. Sophie Blee-Goldman commented on KAFKA-12638: Nope, no such things as credits in

[jira] [Commented] (KAFKA-12492) Formatting of example RocksDBConfigSetter is messed up

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317629#comment-17317629 ] A. Sophie Blee-Goldman commented on KAFKA-12492: Merged, thanks for the PR!

[GitHub] [kafka] C0urante commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

2021-04-08 Thread GitBox
C0urante commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610330282 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,12 @@ private void doRun() throws

[jira] [Commented] (KAFKA-12634) Should checkpoint after restore finished

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317632#comment-17317632 ] A. Sophie Blee-Goldman commented on KAFKA-12634: I don't think bulk loading should

[jira] [Updated] (KAFKA-12492) Formatting of example RocksDBConfigSetter is messed up

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12492: --- Fix Version/s: 3.0.0 > Formatting of example RocksDBConfigSetter is messed

[GitHub] [kafka] ableegoldman merged pull request #10486: KAFKA-12492: Fix the formatting of example RocksDBConfigSetter

2021-04-08 Thread GitBox
ableegoldman merged pull request #10486: URL: https://github.com/apache/kafka/pull/10486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-08 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r610326449 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java ## @@ -215,8 +215,8 @@ public void

[GitHub] [kafka] ableegoldman commented on pull request #10486: KAFKA-12492: Fix the formatting of example RocksDBConfigSetter

2021-04-08 Thread GitBox
ableegoldman commented on pull request #10486: URL: https://github.com/apache/kafka/pull/10486#issuecomment-816382826 Just some unrelated test failures in `kafka.server.RaftClusterTest` -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-08 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r610325987 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -163,117 +160,95 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-08 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r610325577 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -163,117 +160,95 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-08 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r610324204 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -163,117 +160,95 @@ private boolean

[GitHub] [kafka] showuon commented on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-08 Thread GitBox
showuon commented on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-816379867 @ableegoldman , please help review this PR. The testLargeAssignmentAndGroupWithUniformSubscription test time down from 28xx ms, to 18xx ms. Improved 33% of performance. Yeah~

[jira] [Commented] (KAFKA-12464) Enhance constrained sticky Assign algorithm

2021-04-08 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317615#comment-17317615 ] Luke Chen commented on KAFKA-12464: --- [~ableegoldman], good news, after my enhancement, the

[GitHub] [kafka] showuon opened a new pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-08 Thread GitBox
showuon opened a new pull request #10509: URL: https://github.com/apache/kafka/pull/10509 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

2021-04-08 Thread GitBox
kpatelatwork commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610322098 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,12 @@ private void doRun() throws

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

2021-04-08 Thread GitBox
kpatelatwork commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610322098 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,12 @@ private void doRun() throws

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

2021-04-08 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317613#comment-17317613 ] Sagar Rao commented on KAFKA-8295: -- Thanks Sophie for the background. I do plan to run some benchmarks

[GitHub] [kafka] C0urante commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

2021-04-08 Thread GitBox
C0urante commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610316462 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,12 @@ private void doRun() throws

[jira] [Commented] (KAFKA-12638) Remove default implementation of ConsumerRebalanceListener#onPartitionsLost

2021-04-08 Thread Ben Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317601#comment-17317601 ] Ben Chen commented on KAFKA-12638: -- Just curious. For such issue tagged with Majority, who can work on

[GitHub] [kafka] dengziming commented on pull request #10488: MINOR: Remove some unnecessary cyclomatic complexity suppressions

2021-04-08 Thread GitBox
dengziming commented on pull request #10488: URL: https://github.com/apache/kafka/pull/10488#issuecomment-816368204 @chia7712 , Hello, PTAL, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (KAFKA-12638) Remove default implementation of ConsumerRebalanceListener#onPartitionsLost

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12638: -- Summary: Remove default implementation of ConsumerRebalanceListener#onPartitionsLost Key: KAFKA-12638 URL: https://issues.apache.org/jira/browse/KAFKA-12638

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610305248 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,309 @@ +/* + *

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610305248 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,309 @@ +/* + *

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r610293058 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java ## @@ -0,0 +1,172 @@ +/* + *

[jira] [Updated] (KAFKA-12637) Remove deprecated PartitionAssignor interface

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12637: --- Description: In KIP-429, we deprecated the existing PartitionAssignor

[jira] [Updated] (KAFKA-12637) Remove deprecated PartitionAssignor interface

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12637: --- Labels: newbie newbie++ (was: ) > Remove deprecated PartitionAssignor

[jira] [Created] (KAFKA-12637) Remove deprecated PartitionAssignor interface

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12637: -- Summary: Remove deprecated PartitionAssignor interface Key: KAFKA-12637 URL: https://issues.apache.org/jira/browse/KAFKA-12637 Project: Kafka

[jira] [Updated] (KAFKA-12464) Enhance constrained sticky Assign algorithm

2021-04-08 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-12464: -- Description: In KAFKA-9987, we did a great improvement for the case when all consumers were

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-08 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610281681 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-08 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610281681 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-08 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610281681 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-08 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610280789 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-08 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610269446 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-08 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610269446 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10343: KAFKA-12471: Implement createPartitions in KIP-500 mode

2021-04-08 Thread GitBox
hachikuji commented on a change in pull request #10343: URL: https://github.com/apache/kafka/pull/10343#discussion_r610263157 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1007,6 +999,128 @@ int bestLeader(int[]

[GitHub] [kafka] hachikuji commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-08 Thread GitBox
hachikuji commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610235224 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[GitHub] [kafka] guozhangwang opened a new pull request #10508: KAFKA-12633: Remove deprecated APIs in TopologyTestDriver

2021-04-08 Thread GitBox
guozhangwang opened a new pull request #10508: URL: https://github.com/apache/kafka/pull/10508 As well as related test classes. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

[GitHub] [kafka] guozhangwang commented on pull request #10508: KAFKA-12633: Remove deprecated APIs in TopologyTestDriver

2021-04-08 Thread GitBox
guozhangwang commented on pull request #10508: URL: https://github.com/apache/kafka/pull/10508#issuecomment-816328916 ping @vvcephei for reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] guozhangwang commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
guozhangwang commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610209134 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +48,36 @@ private final

[jira] [Assigned] (KAFKA-12502) Quorum controller should return topic configs in CreateTopic response

2021-04-08 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn reassigned KAFKA-12502: - Assignee: Ryan Dielhenn > Quorum controller should return topic configs in CreateTopic

[jira] [Created] (KAFKA-12636) Ensure retention still enforced for compacted topics if cleaning is not enabled

2021-04-08 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12636: --- Summary: Ensure retention still enforced for compacted topics if cleaning is not enabled Key: KAFKA-12636 URL: https://issues.apache.org/jira/browse/KAFKA-12636

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610185971 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File, } // okay we are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610185677 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File, } // okay we are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610182898 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File, } // okay we are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610179797 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File, } // okay we are

[GitHub] [kafka] jeqo opened a new pull request #10507: KAFKA-8410: Migrating KStream/KTable aggregations and joins to new Processor API

2021-04-08 Thread GitBox
jeqo opened a new pull request #10507: URL: https://github.com/apache/kafka/pull/10507 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610170573 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File, // must fall within the

[jira] [Commented] (KAFKA-8613) Set default grace period to 0

2021-04-08 Thread Israel Ekpo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317532#comment-17317532 ] Israel Ekpo commented on KAFKA-8613: Fantastic! I will share my updates soon. > Set default grace

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610168018 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File, } // okay we

[jira] [Commented] (KAFKA-12634) Should checkpoint after restore finished

2021-04-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317529#comment-17317529 ] Matthias J. Sax commented on KAFKA-12634: - {quote}By the way, shouldn't we also checkpoint 

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610167018 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File, // must fall within the

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610167018 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File, // must fall within the

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610153469 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File, // must fall within the

[jira] [Assigned] (KAFKA-10231) Broken Kafka Connect node to node communication if invalid hostname is in place

2021-04-08 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel reassigned KAFKA-10231: - Assignee: Kalpesh Patel > Broken Kafka Connect node to node communication if invalid

[jira] [Commented] (KAFKA-8613) Set default grace period to 0

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317519#comment-17317519 ] A. Sophie Blee-Goldman commented on KAFKA-8613: --- Just replied on the KIP thread -- will go

[jira] [Assigned] (KAFKA-8613) Set default grace period to 0

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-8613: - Assignee: Israel Ekpo (was: A. Sophie Blee-Goldman) > Set default

[jira] [Commented] (KAFKA-8613) Set default grace period to 0

2021-04-08 Thread Israel Ekpo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317518#comment-17317518 ] Israel Ekpo commented on KAFKA-8613: Hello [~ableegoldman], I have reviewed the KIP. The motivation

[jira] [Commented] (KAFKA-12634) Should checkpoint after restore finished

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317516#comment-17317516 ] A. Sophie Blee-Goldman commented on KAFKA-12634: Oh. :/ By the way, shouldn't we also

[jira] [Commented] (KAFKA-12634) Should checkpoint after restore finished

2021-04-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317504#comment-17317504 ] Matthias J. Sax commented on KAFKA-12634: - I actually did look into `trunk` and it seems not to

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610113314 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +48,36 @@ private final String

[GitHub] [kafka] mjsax opened a new pull request #10506: MINOR: Improve description of `max.poll.records` config

2021-04-08 Thread GitBox
mjsax opened a new pull request #10506: URL: https://github.com/apache/kafka/pull/10506 Users often think that changing `max.poll.records` would impact network traffic with regard to fetching behavior. Seems worth to clarify that it does not. Call for review: @guozhangwang

[jira] [Commented] (KAFKA-12506) Expand AdjustStreamThreadCountTest

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317487#comment-17317487 ] A. Sophie Blee-Goldman commented on KAFKA-12506: It looks like the build might be broken

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610101130 ## File path: core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala ## @@ -116,6 +116,18 @@ abstract class AbstractConsumerTest extends

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610100370 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -601,6 +601,9 @@ private[log] object LogCleanerManager extends Logging {

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610096118 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File, } // okay we are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610094667 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File, } // okay we are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610094667 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2393,6 +2407,10 @@ class Log(@volatile private var _dir: File, } // okay we are

[jira] [Updated] (KAFKA-12634) Should checkpoint after restore finished

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12634: --- Affects Version/s: 2.5.0 > Should checkpoint after restore finished >

[jira] [Commented] (KAFKA-12634) Should checkpoint after restore finished

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317484#comment-17317484 ] A. Sophie Blee-Goldman commented on KAFKA-12634: Well we had that big refactor of task

[jira] [Commented] (KAFKA-7748) Add wall clock TimeDefinition for suppression of intermediate events

2021-04-08 Thread Chris Osborn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317483#comment-17317483 ] Chris Osborn commented on KAFKA-7748: - This feature would be helpful for nightly batch processing

[jira] [Commented] (KAFKA-9831) Failing test: EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]

2021-04-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317477#comment-17317477 ] Matthias J. Sax commented on KAFKA-9831: That is weird... the stacktrace does not match the code:

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r610089215 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File, // must fall within the

[jira] [Comment Edited] (KAFKA-9831) Failing test: EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]

2021-04-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317364#comment-17317364 ] Matthias J. Sax edited comment on KAFKA-9831 at 4/8/21, 8:41 PM: - I saw

[jira] [Comment Edited] (KAFKA-9831) Failing test: EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]

2021-04-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317364#comment-17317364 ] Matthias J. Sax edited comment on KAFKA-9831 at 4/8/21, 8:40 PM: - I saw

[jira] [Commented] (KAFKA-12634) Should checkpoint after restore finished

2021-04-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317469#comment-17317469 ] Matthias J. Sax commented on KAFKA-12634: - Confirmed for 2.5 (so should also affect all newer

[jira] [Commented] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317460#comment-17317460 ] A. Sophie Blee-Goldman commented on KAFKA-12559: Sure thing -- I recommend checking out

[jira] [Commented] (KAFKA-12506) Expand AdjustStreamThreadCountTest

2021-04-08 Thread Aviral Srivastava (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317457#comment-17317457 ] Aviral Srivastava commented on KAFKA-12506: --- Hey [~ableegoldman], actually I always rebase and

[jira] [Commented] (KAFKA-12506) Expand AdjustStreamThreadCountTest

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317455#comment-17317455 ] A. Sophie Blee-Goldman commented on KAFKA-12506: Hey [~kebab-mai-haddi], if I understand

[GitHub] [kafka] ableegoldman commented on pull request #10482: KAFKA-12499: add transaction timeout verification

2021-04-08 Thread GitBox
ableegoldman commented on pull request #10482: URL: https://github.com/apache/kafka/pull/10482#issuecomment-816145780 Build failed with `Execution failed for task ':streams:checkstyleMain` -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

2021-04-08 Thread GitBox
kpatelatwork commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r610062836 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,15 @@ private void doRun() throws

[GitHub] [kafka] guozhangwang commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
guozhangwang commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610054139 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +48,36 @@ private final

[jira] [Created] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

2021-04-08 Thread Frank Yi (Jira)
Frank Yi created KAFKA-12635: Summary: Mirrormaker 2 offset sync is incorrect if the target partition is empty Key: KAFKA-12635 URL: https://issues.apache.org/jira/browse/KAFKA-12635 Project: Kafka

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610044912 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +48,36 @@ private final String

[GitHub] [kafka] cmccabe opened a new pull request #10505: MINOR: fix some bugs in ControllerApis.scala

2021-04-08 Thread GitBox
cmccabe opened a new pull request #10505: URL: https://github.com/apache/kafka/pull/10505 Fix some cases where ControllerApis was blocking on the controller thread. This should not be necessary, since the controller thread can just interface directly with the network threads.

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r609983533 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-08 Thread GitBox
hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r609139321 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -760,6 +768,12 @@ class Log(@volatile private var _dir: File, // must fall within the

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609998576 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,305 @@ +/* + * Licensed

[GitHub] [kafka] guozhangwang commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
guozhangwang commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r609989025 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -133,34 +141,37 @@ public void

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317410#comment-17317410 ] A. Sophie Blee-Goldman commented on KAFKA-8295: --- Thanks Sagar -- I think the custom

[jira] [Commented] (KAFKA-12634) Should checkpoint after restore finished

2021-04-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317393#comment-17317393 ] A. Sophie Blee-Goldman commented on KAFKA-12634: Nice catch. Do you know which versions

[jira] [Resolved] (KAFKA-12619) Ensure LeaderChange message is committed before initializing high watermark

2021-04-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12619. - Fix Version/s: 2.8.1 3.0.0 Resolution: Fixed > Ensure

[jira] [Commented] (KAFKA-12555) Log reason for rolling a segment

2021-04-08 Thread Alexander Daskalov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317389#comment-17317389 ] Alexander Daskalov commented on KAFKA-12555: yeah I got the list from the conditions in

  1   2   >