kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613804832
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -0,0 +1,526 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613799479
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -0,0 +1,526 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613804832
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -0,0 +1,526 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613799479
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -0,0 +1,526 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
[
https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-12566:
-
Assignee: Luke Chen
> Flaky Test MirrorConnectorsIntegrationSSLTest#testReplication
> -
[
https://issues.apache.org/jira/browse/KAFKA-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-9013:
Assignee: Luke Chen
> Flaky Test MirrorConnectorsIntegrationTest#testReplication
> ---
[
https://issues.apache.org/jira/browse/KAFKA-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-12284:
-
Assignee: Luke Chen
> Flaky Test
> MirrorConnectorsIntegrationSSLTest#testOneWayReplicationWit
kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613795734
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -255,19 +261,21 @@ case object SnapshotGenerated extends
LogStartOffsetIncrementReason {
@th
kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613788936
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -222,25 +222,31 @@ case object SnapshotGenerated extends
LogStartOffsetIncrementReason {
*
kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613787269
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -0,0 +1,526 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613787194
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -0,0 +1,526 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
chia7712 commented on a change in pull request #10498:
URL: https://github.com/apache/kafka/pull/10498#discussion_r613782042
##
File path: clients/src/main/java/org/apache/kafka/common/record/Record.java
##
@@ -132,4 +121,16 @@
* @return the array of headers
*/
[
https://issues.apache.org/jira/browse/KAFKA-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321923#comment-17321923
]
Dongjin Lee commented on KAFKA-12669:
-
[~guozhang] You mean, like this one?
https:/
ijuma commented on a change in pull request #10498:
URL: https://github.com/apache/kafka/pull/10498#discussion_r61359
##
File path: clients/src/main/java/org/apache/kafka/common/record/Record.java
##
@@ -132,4 +121,16 @@
* @return the array of headers
*/
He
chia7712 commented on a change in pull request #10498:
URL: https://github.com/apache/kafka/pull/10498#discussion_r613773275
##
File path: clients/src/main/java/org/apache/kafka/common/record/Record.java
##
@@ -132,4 +121,16 @@
* @return the array of headers
*/
ijuma commented on a change in pull request #10498:
URL: https://github.com/apache/kafka/pull/10498#discussion_r613768029
##
File path: clients/src/main/java/org/apache/kafka/common/record/Record.java
##
@@ -132,4 +121,16 @@
* @return the array of headers
*/
He
chia7712 commented on a change in pull request #10498:
URL: https://github.com/apache/kafka/pull/10498#discussion_r613761674
##
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##
@@ -270,7 +270,11 @@ object DumpLogSegments {
var prefix = s"${Reco
chia7712 commented on a change in pull request #10498:
URL: https://github.com/apache/kafka/pull/10498#discussion_r613753836
##
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##
@@ -280,7 +284,7 @@ object DumpLogSegments {
if (batch.magic >= Rec
ijuma commented on a change in pull request #10498:
URL: https://github.com/apache/kafka/pull/10498#discussion_r613743249
##
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##
@@ -280,7 +284,7 @@ object DumpLogSegments {
if (batch.magic >= Record
ijuma commented on a change in pull request #10498:
URL: https://github.com/apache/kafka/pull/10498#discussion_r613742636
##
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##
@@ -270,7 +270,11 @@ object DumpLogSegments {
var prefix = s"${RecordI
[
https://issues.apache.org/jira/browse/KAFKA-12477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12477:
---
Description:
Users who want to upgrade their applications and enable the COO
kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613679576
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2586,11 +1999,15 @@ object Log {
logDirFailureChannel: LogDirFailureChannel,
junrao commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613486870
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -0,0 +1,526 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
dosvath commented on pull request #10375:
URL: https://github.com/apache/kafka/pull/10375#issuecomment-819924623
@kkonstantine @dongjinleekr how should we proceed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ableegoldman commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r613642681
##
File path: checkstyle/import-control.xml
##
@@ -179,6 +179,7 @@
+
Review comment:
Just wondering, what is the reason for
cmccabe commented on a change in pull request #10463:
URL: https://github.com/apache/kafka/pull/10463#discussion_r613659239
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ElectionStrategizer.java
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Fo
cmccabe commented on pull request #10463:
URL: https://github.com/apache/kafka/pull/10463#issuecomment-819922989
@junrao : I filed https://issues.apache.org/jira/browse/KAFKA-12670 for this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Colin McCabe created KAFKA-12670:
Summary: KRaft support for unclean.leader.election.enable
Key: KAFKA-12670
URL: https://issues.apache.org/jira/browse/KAFKA-12670
Project: Kafka
Issue Type:
highluck commented on pull request #9861:
URL: https://github.com/apache/kafka/pull/9861#issuecomment-819917311
Ping
@chia7712
May I ask for a review of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
highluck removed a comment on pull request #9861:
URL: https://github.com/apache/kafka/pull/9861#issuecomment-813823981
@chia7712
May I ask for a review of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jolshan opened a new pull request #10540:
URL: https://github.com/apache/kafka/pull/10540
When using DeleteTopicsRequest with topic IDs, the topic name field should
be null. Before, the code was programmatically assigning null, but it will be
easier and less error prone to simply set that
cmccabe commented on a change in pull request #10463:
URL: https://github.com/apache/kafka/pull/10463#discussion_r613646109
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ElectionStrategizer.java
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Fo
cmccabe commented on pull request #10505:
URL: https://github.com/apache/kafka/pull/10505#issuecomment-819907811
> @cmccabe thanks for this nice patch. It seems this patch includes some
different targets. Could you update description to include them (for example,
this patch adds new APIs t
mjsax commented on pull request #10532:
URL: https://github.com/apache/kafka/pull/10532#issuecomment-819895175
I started a quick KIP for this change -- will wait until the KIP is accepted
before merging.
--
This is an automated message from the Apache Git Service.
To respond to the messa
cmccabe commented on pull request #10539:
URL: https://github.com/apache/kafka/pull/10539#issuecomment-819890717
Looks good overall! Can you remove the jersey dependency from tools? Now
that trogdor is in a separate subproject it should not be needed any more.
Same with "activation" and
[
https://issues.apache.org/jira/browse/KAFKA-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-8531:
---
Description:
With KAFKA-8305, AdminClient allows to create topics based on the broker
defaul
shayelkin opened a new pull request #10539:
URL: https://github.com/apache/kafka/pull/10539
This moves Trogdor out of tools/ and into its own project. This would
allow Trogdor to be linked against other libraries (for example, you
could build a worker that links against k8s to trigger
[
https://issues.apache.org/jira/browse/KAFKA-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-9559:
---
Labels: needs-kip (was: )
> Change the default "default serde" from ByteArraySerde to null
>
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-8613:
---
Description:
Currently, the grace period is set to retention time if the grace period is not
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-8613:
---
Labels: kip (was: )
> Set default grace period to 0
> -
>
>
ijuma commented on a change in pull request #10538:
URL: https://github.com/apache/kafka/pull/10538#discussion_r613610409
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -453,6 +451,8 @@ class BrokerServer(
if (logManager != null)
CoreU
ijuma merged pull request #10470:
URL: https://github.com/apache/kafka/pull/10470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
ijuma commented on pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#issuecomment-819865445
3 jobs passed, one (Build / JDK 15 and Scala 2.13) failed with unrelated
flakes:
>org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplica
ableegoldman commented on a change in pull request #10532:
URL: https://github.com/apache/kafka/pull/10532#discussion_r613602328
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -439,13 +440,34 @@ private String g
mjsax commented on a change in pull request #10532:
URL: https://github.com/apache/kafka/pull/10532#discussion_r613600421
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -439,13 +440,34 @@ private String getBroke
ableegoldman commented on a change in pull request #10532:
URL: https://github.com/apache/kafka/pull/10532#discussion_r613592763
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -439,13 +440,34 @@ private String g
mjsax edited a comment on pull request #10532:
URL: https://github.com/apache/kafka/pull/10532#issuecomment-819834156
Updated the PR.
The log now show:
```
[2021-04-14 14:10:02,176] ERROR stream-thread [main] Unexpected error during
topic creation for
streams-wordcount-KSTREAM
mjsax commented on pull request #10532:
URL: https://github.com/apache/kafka/pull/10532#issuecomment-819834156
Updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
rondagostino opened a new pull request #10538:
URL: https://github.com/apache/kafka/pull/10538
Both the ZooKeeper-based and KRaft brokers invoke
`KafkaScheduler.shutdown()` too early -- before `LogManager.shutdown()` is
invoked. So it is possible for `LogManager` to try to use the schedul
[
https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marco Lotz updated KAFKA-10383:
---
Issue Type: New Feature (was: Improvement)
> KTable Join on Foreign key is opinionated
> -
[
https://issues.apache.org/jira/browse/KAFKA-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12669:
---
Issue Type: Improvement (was: Bug)
> Add deleteRange to WindowStore / KeyVa
[
https://issues.apache.org/jira/browse/KAFKA-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-12667.
Resolution: Fixed
> Incorrect error log on StateDirectory close
>
[
https://issues.apache.org/jira/browse/KAFKA-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12667:
---
Fix Version/s: 2.6.3
> Incorrect error log on StateDirectory close
> ---
ableegoldman commented on pull request #10536:
URL: https://github.com/apache/kafka/pull/10536#issuecomment-819801207
Merged to 2.8, cherrypicked to 2.7 & 2.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ableegoldman merged pull request #10536:
URL: https://github.com/apache/kafka/pull/10536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
cmccabe commented on a change in pull request #10505:
URL: https://github.com/apache/kafka/pull/10505#discussion_r613551585
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1023,6 +1027,22 @@ private QuorumController(LogContext logC
cmccabe commented on a change in pull request #10505:
URL: https://github.com/apache/kafka/pull/10505#discussion_r613551280
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -347,21 +370,22 @@ class ControllerApis(val requestChannel: RequestChannel,
spena commented on a change in pull request #10537:
URL: https://github.com/apache/kafka/pull/10537#discussion_r613544412
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java
##
@@ -196,6 +196,15 @@ public void re
spena opened a new pull request #10537:
URL: https://github.com/apache/kafka/pull/10537
This PR changes the `TimeOrderedKeySchema` composite key from `time-seq-key`
-> `time-key-seq` to allow deletion of duplicated time-key records using the
RocksDB `deleteRange` API. It also removes all
mjsax merged pull request #10529:
URL: https://github.com/apache/kafka/pull/10529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
Guozhang Wang created KAFKA-12669:
-
Summary: Add deleteRange to WindowStore / KeyValueStore interfaces
Key: KAFKA-12669
URL: https://issues.apache.org/jira/browse/KAFKA-12669
Project: Kafka
I
[
https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10383:
Description:
*Status Quo:*
The current implementation of [KIP-213
|[https://cwiki.apache
[
https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10383:
Labels: kip (was: needs-kip)
> KTable Join on Foreign key is opinionated
> -
[
https://issues.apache.org/jira/browse/KAFKA-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321230#comment-17321230
]
Guozhang Wang commented on KAFKA-12370:
---
Another idea to add: maybe we can also ad
[
https://issues.apache.org/jira/browse/KAFKA-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryanne Dolan reassigned KAFKA-12558:
Assignee: Ryanne Dolan
> MM2 may not sync partition offsets correctly
> -
ableegoldman opened a new pull request #10536:
URL: https://github.com/apache/kafka/pull/10536
This condition was fixed on the side in a PR against trunk, but
unfortunately missed the ongoing 2.8.0, 2.7.1, and 2.6.2 releases. This is a
quick hotfix we should merge once those releases are f
cmccabe commented on a change in pull request #10505:
URL: https://github.com/apache/kafka/pull/10505#discussion_r613455861
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -505,9 +529,8 @@ class ControllerApis(val requestChannel: RequestChannel,
}
cmccabe commented on a change in pull request #10505:
URL: https://github.com/apache/kafka/pull/10505#discussion_r613455255
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -242,87 +253,99 @@ class ControllerApis(val requestChannel: RequestChannel,
junrao commented on a change in pull request #10463:
URL: https://github.com/apache/kafka/pull/10463#discussion_r613366570
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ElectionStrategizer.java
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Fou
[
https://issues.apache.org/jira/browse/KAFKA-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12667:
---
Affects Version/s: 2.8.0
> Incorrect error log on StateDirectory close
> ---
[
https://issues.apache.org/jira/browse/KAFKA-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321201#comment-17321201
]
A. Sophie Blee-Goldman commented on KAFKA-12667:
Thanks [~antrenta]. As
[
https://issues.apache.org/jira/browse/KAFKA-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-12667:
--
Assignee: A. Sophie Blee-Goldman
> Incorrect error log on StateDirect
[
https://issues.apache.org/jira/browse/KAFKA-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12667:
---
Fix Version/s: (was: 2.6.3)
2.8.1
3
[
https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321170#comment-17321170
]
Ning Zhang commented on KAFKA-12635:
[~akaltsikis] probably try to manually create a
[
https://issues.apache.org/jira/browse/KAFKA-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-12668:
---
Labels: newbie (was: )
> MockScheduler is not safe to use in concur
[
https://issues.apache.org/jira/browse/KAFKA-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-12668:
---
Description:
The current implementation of {{MockScheduler}} execute
Jose Armando Garcia Sancio created KAFKA-12668:
--
Summary: MockScheduler is not safe to use in concurrent code.
Key: KAFKA-12668
URL: https://issues.apache.org/jira/browse/KAFKA-12668
Proje
chia7712 commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r613418374
##
File path:
clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java
##
@@ -398,7 +398,7 @@ private int writeLegacyCompressedWra
kpatelatwork commented on pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#issuecomment-819667966
@kkonstantine and @rhauch Could one of you please review and merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kpatelatwork commented on a change in pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#discussion_r613415919
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestServerTest.java
##
@@ -185,6 +188,36 @@ public void testAdvert
C0urante commented on a change in pull request #10528:
URL: https://github.com/apache/kafka/pull/10528#discussion_r613402757
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -370,8 +372,9 @@ private boolean sendRecords()
[
https://issues.apache.org/jira/browse/KAFKA-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321110#comment-17321110
]
Angelos Kaltsikis commented on KAFKA-12558:
---
Just one clarification:
The numb
[
https://issues.apache.org/jira/browse/KAFKA-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321110#comment-17321110
]
Angelos Kaltsikis edited comment on KAFKA-12558 at 4/14/21, 3:57 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321106#comment-17321106
]
Angelos Kaltsikis commented on KAFKA-12635:
---
[~yangguo1220] [~fyi] is there an
[
https://issues.apache.org/jira/browse/KAFKA-12664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban resolved KAFKA-12664.
--
Resolution: Not A Bug
> Mirrormaker 2.0 infinite rebalance loop when dealing with more than 2
[
https://issues.apache.org/jira/browse/KAFKA-12664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban reassigned KAFKA-12664:
Assignee: Daniel Urban
> Mirrormaker 2.0 infinite rebalance loop when dealing with more t
dongjinleekr commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-819606373
Hi @cadonna,
Thanks again for your detailed review. Here is the update.
Following your suggestions, I tried some other configurations. First of all,
there is n
C0urante commented on a change in pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#discussion_r613339599
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
##
@@ -369,9 +370,31 @@ else if (serverConnector != nu
[
https://issues.apache.org/jira/browse/KAFKA-12664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321076#comment-17321076
]
Edward Vaisman commented on KAFKA-12664:
Thanks Daniel. Makes sense to me!
> Mi
[
https://issues.apache.org/jira/browse/KAFKA-12664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321057#comment-17321057
]
Daniel Urban commented on KAFKA-12664:
--
Issue is that in your setup, there are 2 co
[
https://issues.apache.org/jira/browse/KAFKA-12664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321048#comment-17321048
]
Edward Vaisman commented on KAFKA-12664:
Woah awesome. Got it to start working a
[
https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320979#comment-17320979
]
Jordan Moore commented on KAFKA-12534:
--
The config warnings should be fixed with KA
[
https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320966#comment-17320966
]
kaushik srinivas edited comment on KAFKA-12534 at 4/14/21, 12:42 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320966#comment-17320966
]
kaushik srinivas commented on KAFKA-12534:
--
Hi [~cricket007] ,
We tried to cha
[
https://issues.apache.org/jira/browse/KAFKA-12664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320917#comment-17320917
]
Daniel Urban commented on KAFKA-12664:
--
In short, just remove those group.id config
ncliang commented on pull request #10475:
URL: https://github.com/apache/kafka/pull/10475#issuecomment-819353968
Ping @mageshn @gharris1727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/KAFKA-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-12313:
--
Comment: was deleted
(was: hey [~ableegoldman], i have started working on the KIP
[https://cwiki.apac
chia7712 commented on a change in pull request #10505:
URL: https://github.com/apache/kafka/pull/10505#discussion_r612981625
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -242,87 +253,99 @@ class ControllerApis(val requestChannel: RequestChannel,
[
https://issues.apache.org/jira/browse/KAFKA-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320768#comment-17320768
]
Bruno Cadonna commented on KAFKA-12667:
---
[~antrenta] Thank you for the ticket! Thi
[
https://issues.apache.org/jira/browse/KAFKA-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-12667:
--
Priority: Major (was: Trivial)
> Incorrect error log on StateDirectory close
> --
1 - 100 of 105 matches
Mail list logo