[GitHub] [kafka] showuon commented on pull request #10871: KAFKA-8940: decrease session timeout to make test faster and reliable

showuon commented on pull request #10871: URL: https://github.com/apache/kafka/pull/10871#issuecomment-861147367 @ableegoldman , thanks for good reminder. I totally agree with you. I've updated the PR description and in the JIRA ticket comment. Thank you. -- This is an automated message

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363356#comment-17363356 ] A. Sophie Blee-Goldman commented on KAFKA-8295: --- Yes, any of the count DSL operators. It

[jira] [Commented] (KAFKA-12844) KIP-740 follow up: clean up TaskId

[ https://issues.apache.org/jira/browse/KAFKA-12844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363355#comment-17363355 ] A. Sophie Blee-Goldman commented on KAFKA-12844: As mentioned elsewhere, this ticket is

[jira] [Commented] (KAFKA-12843) KIP-740 follow up: clean up TaskMetadata

[ https://issues.apache.org/jira/browse/KAFKA-12843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363354#comment-17363354 ] A. Sophie Blee-Goldman commented on KAFKA-12843: This was pointed out on the PR, but

[GitHub] [kafka] ableegoldman commented on pull request #10871: KAFKA-8940: decrease session timeout to make test faster and reliable

ableegoldman commented on pull request #10871: URL: https://github.com/apache/kafka/pull/10871#issuecomment-861138874 Thanks @showuon. Can you add a comment or update the description with the specific error message in the failure mode that this fix is intended to address? As you point

[jira] [Commented] (KAFKA-12690) Remove deprecated Producer#sendOffsetsToTransaction

[ https://issues.apache.org/jira/browse/KAFKA-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363343#comment-17363343 ] A. Sophie Blee-Goldman commented on KAFKA-12690: Hey [~loboxu], as pointed out elsewhere

[jira] [Commented] (KAFKA-12689) Remove deprecated EOS configs

[ https://issues.apache.org/jira/browse/KAFKA-12689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363342#comment-17363342 ] A. Sophie Blee-Goldman commented on KAFKA-12689: Hey [~loboxu], this ticket is marked

[GitHub] [kafka] ableegoldman commented on a change in pull request #10878: KAFKA-12898; Owned partitions in the subscription must be sorted

ableegoldman commented on a change in pull request #10878: URL: https://github.com/apache/kafka/pull/10878#discussion_r651411365 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerProtocol.java ## @@ -70,16 +71,24 @@ public static

[GitHub] [kafka] ijuma commented on pull request #10883: KAFKA-12949: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

ijuma commented on pull request #10883: URL: https://github.com/apache/kafka/pull/10883#issuecomment-861129160 @hachikuji @jsancio do we want to keep this class? It's the second time it breaks so we either need to improve test coverage or we should remove it. -- This is an automated

[GitHub] [kafka] ableegoldman commented on pull request #10876: KAFKA-12843: KIP-740 follow up: clean up TaskMetadata

ableegoldman commented on pull request #10876: URL: https://github.com/apache/kafka/pull/10876#issuecomment-861126045 Thanks for the PR, but @jlprat is correct. Unfortunately this ticket will need to wait for the 4.0 release, which as of this time has not yet even been announced. You can

[GitHub] [kafka] showuon edited a comment on pull request #10367: KAFKA-12495: allow consecutive revoke in incremental cooperative assignor in connector

showuon edited a comment on pull request #10367: URL: https://github.com/apache/kafka/pull/10367#issuecomment-861125710 @kkonstantine , could you check this PR? Or I should find another guy to review this PR since it's been 3 months? Thanks. -- This is an automated message from the

[GitHub] [kafka] showuon commented on pull request #10367: KAFKA-12495: allow consecutive revoke in incremental cooperative assignor in connector

showuon commented on pull request #10367: URL: https://github.com/apache/kafka/pull/10367#issuecomment-861125710 @kkonstantine , could you check this PR? Or I should find another guy to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Comment Edited] (KAFKA-7360) Code example in "Accessing Processor Context" misses a closing parenthesis

[ https://issues.apache.org/jira/browse/KAFKA-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17362470#comment-17362470 ] Vijay edited comment on KAFKA-7360 at 6/15/21, 2:39 AM: Can this be assigned to

[jira] [Comment Edited] (KAFKA-7302) Remove Java7 examples from Streams Docs

[ https://issues.apache.org/jira/browse/KAFKA-7302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17362471#comment-17362471 ] Vijay edited comment on KAFKA-7302 at 6/15/21, 2:38 AM: Can this be assigned to

[GitHub] [kafka] iamgd67 commented on pull request #10818: KAFKA-12889: log clean relative index range check of group consider empty log segment to avoid too many empty log segment left

iamgd67 commented on pull request #10818: URL: https://github.com/apache/kafka/pull/10818#issuecomment-861117484 @guozhangwang could you please review this, thanks in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] jsancio commented on a change in pull request #10786: KAFKA-12787: Integrate controller snapshoting with raft client

jsancio commented on a change in pull request #10786: URL: https://github.com/apache/kafka/pull/10786#discussion_r651390233 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2285,7 +2287,11 @@ QuorumState quorum() { } public

[GitHub] [kafka] jsancio commented on a change in pull request #10786: KAFKA-12787: Integrate controller snapshoting with raft client

jsancio commented on a change in pull request #10786: URL: https://github.com/apache/kafka/pull/10786#discussion_r651387879 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java ## @@ -230,12 +230,18 @@ default long truncateToEndOffset(OffsetAndEpoch

[GitHub] [kafka] jsancio commented on a change in pull request #10786: KAFKA-12787: Integrate controller snapshoting with raft client

jsancio commented on a change in pull request #10786: URL: https://github.com/apache/kafka/pull/10786#discussion_r651387678 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -85,6 +85,20 @@ public OffsetAndEpoch snapshotId() { return

[GitHub] [kafka] jsancio commented on a change in pull request #10786: KAFKA-12787: Integrate controller snapshoting with raft client

jsancio commented on a change in pull request #10786: URL: https://github.com/apache/kafka/pull/10786#discussion_r651387182 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLogTest.java ## @@ -437,14 +437,89 @@ public void testCreateSnapshot() throws IOException {

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10883: KAFKA-12949: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

IgnacioAcunaF commented on pull request #10883: URL: https://github.com/apache/kafka/pull/10883#issuecomment-861104058 PING @ijuma (as I saw you on a PR related to test-kraft-server-start.sh [KAFKA-12672]) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] hachikuji commented on a change in pull request #10786: KAFKA-12787: Integrate controller snapshoting with raft client

hachikuji commented on a change in pull request #10786: URL: https://github.com/apache/kafka/pull/10786#discussion_r651378054 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -85,6 +85,20 @@ public OffsetAndEpoch snapshotId() {

[GitHub] [kafka] jsancio commented on a change in pull request #10786: KAFKA-12787: Integrate controller snapshoting with raft client

jsancio commented on a change in pull request #10786: URL: https://github.com/apache/kafka/pull/10786#discussion_r651374491 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -85,6 +85,20 @@ public OffsetAndEpoch snapshotId() { return

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10883: KAFKA-12949: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

IgnacioAcunaF commented on pull request #10883: URL: https://github.com/apache/kafka/pull/10883#issuecomment-861084792 With no change:  With the change:

[GitHub] [kafka] mjsax commented on pull request #10861: KAFKA-12909: disable spurious left/outer stream-stream join fix for old JoinWindows API

mjsax commented on pull request #10861: URL: https://github.com/apache/kafka/pull/10861#issuecomment-861081018 Replied to comments and rebased to resolve merge conflicts. \cc @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mjsax commented on a change in pull request #10861: KAFKA-12909: disable spurious left/outer stream-stream join fix for old JoinWindows API

mjsax commented on a change in pull request #10861: URL: https://github.com/apache/kafka/pull/10861#discussion_r651363243 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -82,20 +87,23 @@ private class

[GitHub] [kafka] mjsax commented on a change in pull request #10861: KAFKA-12909: disable spurious left/outer stream-stream join fix for old JoinWindows API

mjsax commented on a change in pull request #10861: URL: https://github.com/apache/kafka/pull/10861#discussion_r651362625 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java ## @@ -76,18 +76,37 @@ private final long graceMs; +

[GitHub] [kafka] IgnacioAcunaF opened a new pull request #10883: KAFKA-12949: Add catch case to avoid scala.MatchError null

IgnacioAcunaF opened a new pull request #10883: URL: https://github.com/apache/kafka/pull/10883 Encounter the following exception when trying to run the TestRaftServer: `bin/test-kraft-server-start.sh --config config/kraft.properties` ``` [2021-06-14 17:15:43,232] ERROR

[GitHub] [kafka] YiDing-Duke commented on pull request #10843: MINOR: Log formatting for exceptions during configuration related operations

YiDing-Duke commented on pull request #10843: URL: https://github.com/apache/kafka/pull/10843#issuecomment-861078081 @dajac we are good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #10843: MINOR: Log formatting for exceptions during configuration related operations

YiDing-Duke commented on a change in pull request #10843: URL: https://github.com/apache/kafka/pull/10843#discussion_r651361653 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java ## @@ -174,11 +174,15 @@ public int hashCode() { return

[jira] [Updated] (KAFKA-12949) TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

[ https://issues.apache.org/jira/browse/KAFKA-12949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Acuna updated KAFKA-12949: -- Attachment: TestRaftServer.log > TestRaftServer's scala.MatchError: null on

[jira] [Created] (KAFKA-12949) TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

Ignacio Acuna created KAFKA-12949: - Summary: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh Key: KAFKA-12949 URL: https://issues.apache.org/jira/browse/KAFKA-12949 Project:

[GitHub] [kafka] showuon commented on a change in pull request #10843: MINOR: Log formatting for exceptions during configuration related operations

showuon commented on a change in pull request #10843: URL: https://github.com/apache/kafka/pull/10843#discussion_r651354743 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java ## @@ -174,11 +174,15 @@ public int hashCode() { return

[GitHub] [kafka] showuon commented on a change in pull request #10843: MINOR: Log formatting for exceptions during configuration related operations

showuon commented on a change in pull request #10843: URL: https://github.com/apache/kafka/pull/10843#discussion_r651354059 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -469,7 +469,7 @@ class DynamicBrokerConfig(private val kafkaConfig:

[GitHub] [kafka] ijuma commented on pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

ijuma commented on pull request #10584: URL: https://github.com/apache/kafka/pull/10584#issuecomment-861064040 Yeah, that unintentional while using the GitHub editor. Will add it back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] jolshan commented on pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

jolshan commented on pull request #10584: URL: https://github.com/apache/kafka/pull/10584#issuecomment-861062736 Ah I see I didn't need that extra declaration but you also removed the comment. Not a huge deal though. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] jolshan commented on a change in pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

jolshan commented on a change in pull request #10584: URL: https://github.com/apache/kafka/pull/10584#discussion_r651337637 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java ## @@ -117,13 +128,21 @@ public MetadataRequestData data() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651336157 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -119,18 +120,50 @@ public static FetchResponse

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651335666 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -71,6 +76,12 @@ public FetchResponseData data() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651335255 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -283,14 +290,18 @@ public void onSuccess(ClientResponse

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651335121 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -283,14 +290,18 @@ public void onSuccess(ClientResponse

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651334106 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651333015 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -213,9 +335,22 @@ public FetchRequestData build() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10786: KAFKA-12787: Integrate controller snapshoting with raft client

hachikuji commented on a change in pull request #10786: URL: https://github.com/apache/kafka/pull/10786#discussion_r651330764 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -85,6 +85,20 @@ public OffsetAndEpoch snapshotId() {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651332908 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -186,23 +268,63 @@ public String toString() { *

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651332118 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -186,23 +268,63 @@ public String toString() { *

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651331636 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -412,6 +412,12 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651331247 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -216,12 +217,21 @@ class ReplicaFetcherThread(name: String, try {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651329577 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -945,10 +945,12 @@ private boolean hasValidClusterId(String

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651323500 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651323170 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -186,6 +192,10 @@

[GitHub] [kafka] hachikuji commented on a change in pull request #10863: KAFKA-12890; Consumer group stuck in `CompletingRebalance`

hachikuji commented on a change in pull request #10863: URL: https://github.com/apache/kafka/pull/10863#discussion_r651224002 ## File path: core/src/main/scala/kafka/coordinator/group/DelayedSync.scala ## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r649585182 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -817,20 +839,26 @@ class KafkaApis(val requestChannel: RequestChannel, def

[GitHub] [kafka] cmccabe commented on pull request #10804: KAFKA-12877: Make flexibleVersions mandatory

cmccabe commented on pull request #10804: URL: https://github.com/apache/kafka/pull/10804#issuecomment-861030811 Seems like there was a Jenkins infra issue on the last test run. ``` [2021-06-14T20:15:25.946Z] Execution failed for task ':streams:streams-scala:compileScala'.

[GitHub] [kafka] cmccabe commented on pull request #10867: KAFKA-12931: KIP-746: Revise KRaft Metadata Records

cmccabe commented on pull request #10867: URL: https://github.com/apache/kafka/pull/10867#issuecomment-861030196 Test failure is `org.apache.kafka.streams.integration.TaskMetadataIntegrationTest`, which is not related -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r65129 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public

[GitHub] [kafka] ijuma commented on a change in pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

ijuma commented on a change in pull request #10584: URL: https://github.com/apache/kafka/pull/10584#discussion_r651308552 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java ## @@ -117,13 +128,21 @@ public MetadataRequestData data() {

[GitHub] [kafka] ijuma commented on a change in pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

ijuma commented on a change in pull request #10584: URL: https://github.com/apache/kafka/pull/10584#discussion_r651308210 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java ## @@ -117,13 +128,21 @@ public MetadataRequestData data() {

[jira] [Updated] (KAFKA-12379) KIP-716: Allow configuring the location of the offsetsync topic with MirrorMaker2

[ https://issues.apache.org/jira/browse/KAFKA-12379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12379: --- Fix Version/s: 3.0.0 > KIP-716: Allow configuring the location of the

[jira] [Updated] (KAFKA-12379) KIP-716: Allow configuring the location of the offsetsync topic with MirrorMaker2

[ https://issues.apache.org/jira/browse/KAFKA-12379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12379: --- Labels: needs-kip (was: ) > KIP-716: Allow configuring the location of the

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651300080 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java ## @@ -255,12 +257,29 @@ public

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651293447 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public

[jira] [Commented] (KAFKA-12948) NetworkClient.close(node) with node in connecting state makes NetworkClient unusable

[ https://issues.apache.org/jira/browse/KAFKA-12948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363227#comment-17363227 ] Ismael Juma commented on KAFKA-12948: - Good catch. So, this regressed in 2.7.0? >

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651298044 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -186,6 +192,10 @@

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r65129 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r65129 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651293447 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651292365 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -357,6 +367,62 @@ public void

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651291878 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651291754 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651291606 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/MonitorableSourceConnector.java ## @@ -58,6 +58,9 @@ public void

[GitHub] [kafka] kpatelatwork commented on pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kpatelatwork commented on pull request #10841: URL: https://github.com/apache/kafka/pull/10841#issuecomment-860983059 @rhauch I have resolved all the review comments. Could you please check to see if it looks good now? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kpatelatwork commented on a change in pull request #10841: URL: https://github.com/apache/kafka/pull/10841#discussion_r651267237 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTest.java ## @@ -56,6 +57,39 @@ "set

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kpatelatwork commented on a change in pull request #10841: URL: https://github.com/apache/kafka/pull/10841#discussion_r651267091 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTest.java ## @@ -56,6 +57,39 @@ "set

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kpatelatwork commented on a change in pull request #10841: URL: https://github.com/apache/kafka/pull/10841#discussion_r651266585 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTest.java ## @@ -56,6 +57,39 @@ "set

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kpatelatwork commented on a change in pull request #10841: URL: https://github.com/apache/kafka/pull/10841#discussion_r651266416 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTest.java ## @@ -56,6 +57,39 @@ "set

[jira] [Commented] (KAFKA-12946) __consumer_offsets topic with very big partitions

[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363203#comment-17363203 ] Emi commented on KAFKA-12946: - [~rndgstn] What do you mean for "has a significantly smaller size than the

[GitHub] [kafka] rajinisivaram opened a new pull request #10882: KAFKA-12948: Remove node from ClusterConnectionStates.connectingNodes when node is removed

rajinisivaram opened a new pull request #10882: URL: https://github.com/apache/kafka/pull/10882 NetworkClient.poll() throws IllegalStateException when checking `isConnectionSetupTimeout` if all nodes in `ClusterConnectionStates.connectingNodes` aren't present in

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kpatelatwork commented on a change in pull request #10841: URL: https://github.com/apache/kafka/pull/10841#discussion_r651266225 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -497,6 +476,37 @@ static void

[GitHub] [kafka] erdody commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

erdody commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r649771532 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -357,6 +367,62 @@ public void

[GitHub] [kafka] jsancio commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-860980428 > Or may be we can make a seperate PR to handle the validation for onSnapshotFrozen? I am okay with fixing this in a future PR. Do you want to go ahead and file an

[jira] [Created] (KAFKA-12948) NetworkClient.close(node) with node in connecting state makes NetworkClient unusable

Rajini Sivaram created KAFKA-12948: -- Summary: NetworkClient.close(node) with node in connecting state makes NetworkClient unusable Key: KAFKA-12948 URL: https://issues.apache.org/jira/browse/KAFKA-12948

[GitHub] [kafka] rhauch commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

rhauch commented on a change in pull request #10841: URL: https://github.com/apache/kafka/pull/10841#discussion_r651200941 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -497,6 +476,37 @@ static void

[jira] [Commented] (KAFKA-12946) __consumer_offsets topic with very big partitions

[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363155#comment-17363155 ] Ron Dagostino commented on KAFKA-12946: --- If the partition isn't being cleaned then you can try

[GitHub] [kafka] dajac commented on pull request #10863: KAFKA-12890; Consumer group stuck in `CompletingRebalance`

dajac commented on pull request #10863: URL: https://github.com/apache/kafka/pull/10863#issuecomment-860921205 @hachikuji Thanks for the clarification. Yes, that makes sense to me as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] kowshik edited a comment on pull request #10280: KAFKA-12554: Refactor Log layer

kowshik edited a comment on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-860537313 @junrao Thanks for the review! I ran the system tests. 1. [System test run #4560](https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4560/) on top of

[GitHub] [kafka] hachikuji commented on pull request #10863: KAFKA-12890; Consumer group stuck in `CompletingRebalance`

hachikuji commented on pull request #10863: URL: https://github.com/apache/kafka/pull/10863#issuecomment-860914096 @dajac Given the background from KAFKA-10134, the rebalance timeout seems like the right one in my mind. We're basically allowing for a delay between the JoinGroup and

[GitHub] [kafka] dajac commented on pull request #10843: MINOR: Log formatting for exceptions during configuration related operations

dajac commented on pull request #10843: URL: https://github.com/apache/kafka/pull/10843#issuecomment-860910847 @YiDing-Duke Thanks for the update. @showuon Does the PR look good to you now? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jsancio commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-860908546 > I assume a KIP is needed. We don't need a KIP. All of these API are internal APIs that are not accessible/publish to projects external to Apache Kafka. -- This is an

[GitHub] [kafka] cmccabe commented on pull request #10804: KAFKA-12877: Make flexibleVersions mandatory

cmccabe commented on pull request #10804: URL: https://github.com/apache/kafka/pull/10804#issuecomment-860882713 OK, I reconsidered this a bit. I think we DON'T want to make incompatible changes if we can avoid it... such as changing the default from NONE to ALL. There are a few

[GitHub] [kafka] hachikuji commented on pull request #10880: KAFKA-12870; Flush in progress not cleared after transaction completion

hachikuji commented on pull request #10880: URL: https://github.com/apache/kafka/pull/10880#issuecomment-860877998 Note I have a few additional tests which I will post shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] wycccccc opened a new pull request #10881: KAFKA-12947 Replace EasyMock and PowerMock with Mockito for StreamsMe…

wycc opened a new pull request #10881: URL: https://github.com/apache/kafka/pull/10881 Development of EasyMock and PowerMock has stagnated while Mockito continues to be actively developed. With the new Java cadence, it's a problem to depend on libraries that do bytecode generation and

[jira] [Updated] (KAFKA-12944) KIP-724: Always write record batches with message format v2

[ https://issues.apache.org/jira/browse/KAFKA-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12944: Description: If IBP is 3.0 or higher. > KIP-724: Always write record batches with message format

[jira] [Created] (KAFKA-12947) Replace EasyMock and PowerMock with Mockito for StreamsMetricsImplTest ...

YI-CHEN WANG created KAFKA-12947: Summary: Replace EasyMock and PowerMock with Mockito for StreamsMetricsImplTest ... Key: KAFKA-12947 URL: https://issues.apache.org/jira/browse/KAFKA-12947 Project:

[GitHub] [kafka] hachikuji opened a new pull request #10880: KAFKA-12870; Flush in progress not cleared after transaction completion

hachikuji opened a new pull request #10880: URL: https://github.com/apache/kafka/pull/10880 We had been using `RecordAccumulator.beginFlush` in order to force the `RecordAccumulator` to flush pending batches when a transaction was being completed. Internally, `RecordAccumulator` has a

[GitHub] [kafka] dajac commented on pull request #10878: KAFKA-12898; Owned partitions in the subscription must be sorted

dajac commented on pull request #10878: URL: https://github.com/apache/kafka/pull/10878#issuecomment-860843508 I forgot to update few tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac opened a new pull request #10879: MINOR: Fix unsafe access to `AbstractCoordinator.state`

dajac opened a new pull request #10879: URL: https://github.com/apache/kafka/pull/10879 We access the `state` from the `HeartbeatResponseHandler#handle` without synchronizing it. This seems unsafe to me as the `state` is not `volatile`. ### Committer Checklist (excluded from commit

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #10843: MINOR: Log formatting for exceptions during configuration related operations

YiDing-Duke commented on a change in pull request #10843: URL: https://github.com/apache/kafka/pull/10843#discussion_r651094578 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -469,7 +469,7 @@ class DynamicBrokerConfig(private val kafkaConfig:

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #10843: MINOR: Log formatting for exceptions during configuration related operations

YiDing-Duke commented on a change in pull request #10843: URL: https://github.com/apache/kafka/pull/10843#discussion_r651094578 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -469,7 +469,7 @@ class DynamicBrokerConfig(private val kafkaConfig:

[GitHub] [kafka] guozhangwang commented on a change in pull request #10869: KAFKA-10546: Deprecate old PAPI

guozhangwang commented on a change in pull request #10869: URL: https://github.com/apache/kafka/pull/10869#discussion_r651095121 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -4615,7 +4732,110 @@ void to(final TopicNameExtractor

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #10843: MINOR: Log formatting for exceptions during configuration related operations

YiDing-Duke commented on a change in pull request #10843: URL: https://github.com/apache/kafka/pull/10843#discussion_r651094904 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java ## @@ -174,11 +174,15 @@ public int hashCode() { return

  1   2   3   >