[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-15 Thread GitBox
satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r670947570 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,484 @@ +/*

[GitHub] [kafka] satishd commented on a change in pull request #11058: KAFKA-12802 Added a file based cache for consumed remote log metadata for each partition to avoid consuming again incase of broke

2021-07-15 Thread GitBox
satishd commented on a change in pull request #11058: URL: https://github.com/apache/kafka/pull/11058#discussion_r670940501 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/CommittedOffsetsFile.java ## @@ -0,0 +1,86 @@ +/* + * Licensed

[GitHub] [kafka] satishd commented on pull request #11058: KAFKA-12802 Added a file based cache for consumed remote log metadata for each partition to avoid consuming again incase of broker restarts.

2021-07-15 Thread GitBox
satishd commented on pull request #11058: URL: https://github.com/apache/kafka/pull/11058#issuecomment-881150696 This is built on top of https://github.com/apache/kafka/pull/10579. We can review and merge once #10579 is merged. -- This is an automated message from the Apache Git

[GitHub] [kafka] satishd commented on pull request #11060: MINOR Refactored the existing CheckpointFile in core module, moved to server-common module and introduced it as SnapshotFile.

2021-07-15 Thread GitBox
satishd commented on pull request #11060: URL: https://github.com/apache/kafka/pull/11060#issuecomment-881150117 @junrao This is a minor refactoring. `SnapshotFile` can be reused by default RLMM for storing committed offsets for remote log metadata topic. -- This is an automated

[GitHub] [kafka] dengziming commented on pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

2021-07-15 Thread GitBox
dengziming commented on pull request #9577: URL: https://github.com/apache/kafka/pull/9577#issuecomment-881129535 ping @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dengziming removed a comment on pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

2021-07-15 Thread GitBox
dengziming removed a comment on pull request #9577: URL: https://github.com/apache/kafka/pull/9577#issuecomment-851110147 ping @mumrah @cmccabe , this PR is similar to KIP-497, I wish this can be finished before KAFKA 3.0.0. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] showuon commented on a change in pull request #11026: KAFKA-13064: refactor ListConsumerGroupOffsetsHandler and tests

2021-07-15 Thread GitBox
showuon commented on a change in pull request #11026: URL: https://github.com/apache/kafka/pull/11026#discussion_r670917051 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ## @@ -82,14 +93,17 @@ public String

[GitHub] [kafka] showuon commented on a change in pull request #11026: KAFKA-13064: refactor ListConsumerGroupOffsetsHandler and tests

2021-07-15 Thread GitBox
showuon commented on a change in pull request #11026: URL: https://github.com/apache/kafka/pull/11026#discussion_r670917051 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ## @@ -82,14 +93,17 @@ public String

[GitHub] [kafka] ableegoldman commented on pull request #10921: KAFKA-13096: Ensure queryable store providers is up to date after adding stream thread

2021-07-15 Thread GitBox
ableegoldman commented on pull request #10921: URL: https://github.com/apache/kafka/pull/10921#issuecomment-881110915 By the way, I filed a ticket for this. I think it's actually a pretty serious bug so we should have a JIRA for it. I'm also going to propose it as a blocker for the 3.0

[jira] [Created] (KAFKA-13096) QueryableStoreProvider is not updated when threads are added/removed/replaced rendering IQ impossible

2021-07-15 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13096: -- Summary: QueryableStoreProvider is not updated when threads are added/removed/replaced rendering IQ impossible Key: KAFKA-13096 URL:

[GitHub] [kafka] cmccabe commented on pull request #11067: MINOR: log static broker configs in KRaft mode

2021-07-15 Thread GitBox
cmccabe commented on pull request #11067: URL: https://github.com/apache/kafka/pull/11067#issuecomment-881088751 In the ZK-based broker code in `KafkaServer.scala`, the configs are logged from here: ``` at

[jira] [Resolved] (KAFKA-13092) Perf regression in LISR requests

2021-07-15 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-13092. - Fix Version/s: 3.0.0 Resolution: Fixed merged the PR to 3.0 and trunk. > Perf regression in

[GitHub] [kafka] junrao merged pull request #11065: KAFKA-13092: Perf regression in LISR requests

2021-07-15 Thread GitBox
junrao merged pull request #11065: URL: https://github.com/apache/kafka/pull/11065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe opened a new pull request #11067: MINOR: log static broker configs in KRaft mode

2021-07-15 Thread GitBox
cmccabe opened a new pull request #11067: URL: https://github.com/apache/kafka/pull/11067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hachikuji merged pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
hachikuji merged pull request #10952: URL: https://github.com/apache/kafka/pull/10952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rondagostino commented on pull request #11066: MINOR: Test ReplicaManager Metric Names

2021-07-15 Thread GitBox
rondagostino commented on pull request #11066: URL: https://github.com/apache/kafka/pull/11066#issuecomment-881063696 Maybe rename `ReplicaManagerMetricNamesTest` to `ClusterMetricNamesTest` so that it isn't specific to `ReplicaManager`? We could define it like this: ```

[GitHub] [kafka] rondagostino commented on pull request #11066: MINOR: Test ReplicaManager Metric Names

2021-07-15 Thread GitBox
rondagostino commented on pull request #11066: URL: https://github.com/apache/kafka/pull/11066#issuecomment-881062140 > Can we do the integration test approach, but have it be part of RaftClusterTest.scala? I think we would only be testing for the KRaft case if we did that, and I

[GitHub] [kafka] ijuma commented on pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-15 Thread GitBox
ijuma commented on pull request #11036: URL: https://github.com/apache/kafka/pull/11036#issuecomment-881058902 JDK 16 build had a bit of flakiness, but the rest looked good. I kicked off another build just in case. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] cmccabe commented on pull request #11066: MINOR: Test ReplicaManager Metric Names

2021-07-15 Thread GitBox
cmccabe commented on pull request #11066: URL: https://github.com/apache/kafka/pull/11066#issuecomment-881054973 Can we do the integration test approach, but have it be part of `RaftClusterTest.scala`? It seems weird to have a new test file just for this one test. We could also

[GitHub] [kafka] ijuma commented on pull request #11059: KAFKA-12930,KAFKA-12929: Deprecate Java 8 and Scala 2.12

2021-07-15 Thread GitBox
ijuma commented on pull request #11059: URL: https://github.com/apache/kafka/pull/11059#issuecomment-881052050 Cherry-picking to 3.0 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma merged pull request #11059: KAFKA-12930,KAFKA-12929: Deprecate Java 8 and Scala 2.12

2021-07-15 Thread GitBox
ijuma merged pull request #11059: URL: https://github.com/apache/kafka/pull/11059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] junrao commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-15 Thread GitBox
junrao commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r670820515 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java ## @@ -0,0 +1,197

[GitHub] [kafka] rondagostino commented on pull request #11066: MINOR: Test ReplicaManager Metric Names

2021-07-15 Thread GitBox
rondagostino commented on pull request #11066: URL: https://github.com/apache/kafka/pull/11066#issuecomment-881031042 I've implemented the test in 2 separate ways, and we should choose which one to keep. 1. A standard unit test, in `ReplicaManagerTest` 2. A parameterized test

[GitHub] [kafka] rondagostino opened a new pull request #11066: MINOR: Test ReplicaManager Metric Names

2021-07-15 Thread GitBox
rondagostino opened a new pull request #11066: URL: https://github.com/apache/kafka/pull/11066 This patch closes a test gap where we do not check ReplicaManager metrics remain as expected. There was a bug in 2.8 where the metrics moved under a different class name for the KRaft case.

[GitHub] [kafka] jolshan opened a new pull request #11065: KAFKA-13092: Perf regression in LISR requests

2021-07-15 Thread GitBox
jolshan opened a new pull request #11065: URL: https://github.com/apache/kafka/pull/11065 cherry-pick of 584213ed20d679b11206b67c5a65035347632f07 Only conflicts were in Log.scala where the new flush code was near some log refactor changes in trunk. I kept the code the same and only

[GitHub] [kafka] junrao commented on pull request #11056: KAFKA-13092: Perf regression in LISR requests

2021-07-15 Thread GitBox
junrao commented on pull request #11056: URL: https://github.com/apache/kafka/pull/11056#issuecomment-881012624 @jolshan : The PR doesn't apply cleanly to 3.0. Could you provide a separate PR for 3.0? Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] junrao merged pull request #11056: KAFKA-13092: Perf regression in LISR requests

2021-07-15 Thread GitBox
junrao merged pull request #11056: URL: https://github.com/apache/kafka/pull/11056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on a change in pull request #11063: Add test to verify behavior of grace API

2021-07-15 Thread GitBox
mjsax commented on a change in pull request #11063: URL: https://github.com/apache/kafka/pull/11063#discussion_r670792151 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/WindowedChangelogRetentionIntegrationTest.java ## @@ -0,0 +1,365 @@ +/* + *

[GitHub] [kafka] dajac commented on a change in pull request #11026: KAFKA-13064: refactor ListConsumerGroupOffsetsHandler and tests

2021-07-15 Thread GitBox
dajac commented on a change in pull request #11026: URL: https://github.com/apache/kafka/pull/11026#discussion_r670798256 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ## @@ -110,40 +124,96 @@ public String

[GitHub] [kafka] cmccabe opened a new pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

2021-07-15 Thread GitBox
cmccabe opened a new pull request #11064: URL: https://github.com/apache/kafka/pull/11064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna commented on pull request #11063: Add test to verify behavior of grace API

2021-07-15 Thread GitBox
cadonna commented on pull request #11063: URL: https://github.com/apache/kafka/pull/11063#issuecomment-880982426 It is expected that the tests fail since #10953 is not merged yet. Once #10953 is merged and this PR is rebased on trunk the test should not fail anymore. -- This is an

[GitHub] [kafka] cadonna opened a new pull request #11063: Add test to verify behavior of grace API

2021-07-15 Thread GitBox
cadonna opened a new pull request #11063: URL: https://github.com/apache/kafka/pull/11063 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670769638 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] hachikuji commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
hachikuji commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670748649 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] dajac commented on a change in pull request #11026: KAFKA-13064: refactor ListConsumerGroupOffsetsHandler and tests

2021-07-15 Thread GitBox
dajac commented on a change in pull request #11026: URL: https://github.com/apache/kafka/pull/11026#discussion_r670737002 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ## @@ -82,14 +93,17 @@ public String

[GitHub] [kafka] cmccabe merged pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

2021-07-15 Thread GitBox
cmccabe merged pull request #10753: URL: https://github.com/apache/kafka/pull/10753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] tang7526 commented on pull request #11062: KAFKA-13094: Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-15 Thread GitBox
tang7526 commented on pull request #11062: URL: https://github.com/apache/kafka/pull/11062#issuecomment-880920746 @cadonna Could you help to review this PR? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] tang7526 opened a new pull request #11062: KAFKA-13094: Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-15 Thread GitBox
tang7526 opened a new pull request #11062: URL: https://github.com/apache/kafka/pull/11062 https://issues.apache.org/jira/browse/KAFKA-13094 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

[jira] [Assigned] (KAFKA-13094) Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-15 Thread Chun-Hao Tang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chun-Hao Tang reassigned KAFKA-13094: - Assignee: Chun-Hao Tang > Session windows do not consider user-specified grace when

[GitHub] [kafka] vvcephei commented on pull request #9616: KAFKA-10091: KIP-695: Deterministic semantics for task idling

2021-07-15 Thread GitBox
vvcephei commented on pull request #9616: URL: https://github.com/apache/kafka/pull/9616#issuecomment-880914082 Implemented in: a92b986c855592d630fbabf49d1e9a160ad5b230 4d28391480fd8c547a63af119bba67fceb5d2ede fdcf8fbf72bee9e672d0790cdbe5539846f7dc8e

[GitHub] [kafka] vvcephei closed pull request #9616: KAFKA-10091: KIP-695: Deterministic semantics for task idling

2021-07-15 Thread GitBox
vvcephei closed pull request #9616: URL: https://github.com/apache/kafka/pull/9616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (KAFKA-13095) TransactionsTest is failing in kraft mode

2021-07-15 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-13095: Assignee: David Arthur > TransactionsTest is failing in kraft mode >

[jira] [Updated] (KAFKA-13095) TransactionsTest is failing in kraft mode

2021-07-15 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13095: Fix Version/s: 3.0.0 > TransactionsTest is failing in kraft mode >

[GitHub] [kafka] guozhangwang commented on pull request #10941: KAFKA-10847: Remove internal config for enabling the fix

2021-07-15 Thread GitBox
guozhangwang commented on pull request #10941: URL: https://github.com/apache/kafka/pull/10941#issuecomment-880901349 Merged to trunk; cherry-picked to 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] guozhangwang merged pull request #10941: KAFKA-10847: Remove internal config for enabling the fix

2021-07-15 Thread GitBox
guozhangwang merged pull request #10941: URL: https://github.com/apache/kafka/pull/10941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-13095) TransactionsTest is failing in kraft mode

2021-07-15 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13095: Summary: TransactionsTest is failing in kraft mode Key: KAFKA-13095 URL: https://issues.apache.org/jira/browse/KAFKA-13095 Project: Kafka Issue Type: Bug

[GitHub] [kafka] mjsax commented on a change in pull request #10941: KAFKA-10847: Remove internal config for enabling the fix

2021-07-15 Thread GitBox
mjsax commented on a change in pull request #10941: URL: https://github.com/apache/kafka/pull/10941#discussion_r670688025 ## File path: docs/streams/upgrade-guide.html ## @@ -117,6 +117,21 @@ Streams API We removed the default implementation of

[GitHub] [kafka] cadonna opened a new pull request #11061: MINOR: Add test for verifying retention on changelog topics

2021-07-15 Thread GitBox
cadonna opened a new pull request #11061: URL: https://github.com/apache/kafka/pull/11061 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670658031 ## File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java ## @@ -845,6 +887,7 @@ protected boolean retainTopic(String topic, boolean

[GitHub] [kafka] cmccabe commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

2021-07-15 Thread GitBox
cmccabe commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r670654509 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentRevert.java ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] junrao commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

2021-07-15 Thread GitBox
junrao commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r670647614 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670630904 ## File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java ## @@ -371,6 +372,43 @@ public void testUpdateLastEpoch() {

[GitHub] [kafka] junrao commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

2021-07-15 Thread GitBox
junrao commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r670609446 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentRevert.java ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] satishd opened a new pull request #11060: MAJOR Refactored the existing CheckpointFile in core module and moved to server common module and introduced it as SnapshotFile.

2021-07-15 Thread GitBox
satishd opened a new pull request #11060: URL: https://github.com/apache/kafka/pull/11060 MAJOR Refactored the existing CheckpointFile in core module and moved to server common module and introduced it as SnapshotFile. - Refactored CheckpointFile to server/common module as a Java class

[GitHub] [kafka] dajac commented on pull request #11035: KAFKA-13072: Make RemoveMembersFromConsumerGroupHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac commented on pull request #11035: URL: https://github.com/apache/kafka/pull/11035#issuecomment-880820784 Merged to trunk and 3.0. cc @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] dajac merged pull request #11035: KAFKA-13072: Make RemoveMembersFromConsumerGroupHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac merged pull request #11035: URL: https://github.com/apache/kafka/pull/11035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on a change in pull request #11054: KAFKA-13090: Improve kraft snapshot integration test

2021-07-15 Thread GitBox
jsancio commented on a change in pull request #11054: URL: https://github.com/apache/kafka/pull/11054#discussion_r670583303 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java ## @@ -280,11 +280,19 @@ default long truncateToEndOffset(OffsetAndEpoch

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670562472 ## File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java ## @@ -874,18 +921,69 @@ protected boolean retainTopic(String topic,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670560488 ## File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java ## @@ -845,6 +887,7 @@ protected boolean retainTopic(String topic, boolean

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670559157 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670558097 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -130,13 +150,36 @@ MetadataCache mergeWith(String newClusterId,

[GitHub] [kafka] ijuma commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-15 Thread GitBox
ijuma commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r670557926 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -253,9 +259,10 @@ class LogManager(logDirs: Seq[File],

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670557719 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -69,13 +73,20 @@ private MetadataCache(String clusterId,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670557519 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] ijuma commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-15 Thread GitBox
ijuma commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r670555452 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -253,9 +259,10 @@ class LogManager(logDirs: Seq[File],

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670553966 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -316,20 +325,29 @@ private MetadataCache

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670554176 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -216,6 +217,14 @@ public synchronized boolean updateRequested() {

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670553369 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] mumrah commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-15 Thread GitBox
mumrah commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r670506521 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -479,4 +501,31 @@ object LogConfig { logProps.put(MessageDownConversionEnableProp,

[GitHub] [kafka] dajac commented on pull request #11035: KAFKA-13072: Make RemoveMembersFromConsumerGroupHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac commented on pull request #11035: URL: https://github.com/apache/kafka/pull/11035#issuecomment-880762486 Failures are not related: ``` Build / JDK 16 and Scala 2.13 / testCloseDuringRebalance() – kafka.api.ConsumerBounceTest 4s Build / JDK 16 and Scala 2.13 /

[GitHub] [kafka] ijuma opened a new pull request #11059: KAFKA-12930,KAFKA-12929: Deprecate Java 8 and Scala 2.12

2021-07-15 Thread GitBox
ijuma opened a new pull request #11059: URL: https://github.com/apache/kafka/pull/11059 Update the readme to note the deprecation. We will also mention the deprecation in the downloads page when the release is done. ### Committer Checklist (excluded from commit message) - [ ]

[GitHub] [kafka] showuon commented on a change in pull request #11026: KAFKA-13064: refactor ListConsumerGroupOffsetsHandler and tests

2021-07-15 Thread GitBox
showuon commented on a change in pull request #11026: URL: https://github.com/apache/kafka/pull/11026#discussion_r670488214 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ## @@ -110,40 +124,96 @@ public String

[GitHub] [kafka] showuon commented on a change in pull request #11026: KAFKA-13064: refactor ListConsumerGroupOffsetsHandler and tests

2021-07-15 Thread GitBox
showuon commented on a change in pull request #11026: URL: https://github.com/apache/kafka/pull/11026#discussion_r670487440 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ## @@ -110,41 +112,97 @@ public String

[GitHub] [kafka] cadonna edited a comment on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-15 Thread GitBox
cadonna edited a comment on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-880699127 Filed the following tickets for the session window bug: https://issues.apache.org/jira/browse/KAFKA-13094 -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] cadonna commented on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-15 Thread GitBox
cadonna commented on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-880699127 Opened the following PR for the session window bug: https://issues.apache.org/jira/browse/KAFKA-13094 -- This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (KAFKA-13094) Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-15 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13094: -- Description: Session windows use internally method {{maintainMs()}} to compute the retention

[jira] [Updated] (KAFKA-13094) Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-15 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13094: -- Description: Session windows use internally method {{maintainMs()}} to compute the retention

[jira] [Updated] (KAFKA-13094) Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-15 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13094: -- Description: Session windows use internally method {{maintainMs()}} to compute the retention

[jira] [Created] (KAFKA-13094) Session windows do not consider user-specified grace when computing retention time for changelog

2021-07-15 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-13094: - Summary: Session windows do not consider user-specified grace when computing retention time for changelog Key: KAFKA-13094 URL:

[jira] [Commented] (KAFKA-12655) CVE-2021-28165 - Upgrade jetty to 9.4.39

2021-07-15 Thread amit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381342#comment-17381342 ] amit commented on KAFKA-12655: -- Seems like this was not back-ported to 2.7.1. Can someone confirm?  >

[jira] [Created] (KAFKA-13093) KIP-724: Log compaction should write new segments with record version v2

2021-07-15 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-13093: --- Summary: KIP-724: Log compaction should write new segments with record version v2 Key: KAFKA-13093 URL: https://issues.apache.org/jira/browse/KAFKA-13093 Project:

[jira] [Updated] (KAFKA-12944) KIP-724: Assume message format version is 3.0 when IBP is 3.0 or higher

2021-07-15 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12944: Description: (was: If IBP is 3.0 or higher.) > KIP-724: Assume message format version is 3.0

[jira] [Updated] (KAFKA-12944) KIP-724: Assume message format version is 3.0 when IBP is 3.0 or higher

2021-07-15 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12944: Summary: KIP-724: Assume message format version is 3.0 when IBP is 3.0 or higher (was: KIP-724:

[GitHub] [kafka] dajac commented on a change in pull request #11026: KAFKA-13064: refactor ListConsumerGroupOffsetsHandler and tests

2021-07-15 Thread GitBox
dajac commented on a change in pull request #11026: URL: https://github.com/apache/kafka/pull/11026#discussion_r670436565 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ## @@ -110,41 +112,97 @@ public String

[GitHub] [kafka] showuon commented on pull request #11035: KAFKA-13072: Make RemoveMembersFromConsumerGroupHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
showuon commented on pull request #11035: URL: https://github.com/apache/kafka/pull/11035#issuecomment-880662479 Thank you. it have been running for whole day. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] cadonna commented on a change in pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-15 Thread GitBox
cadonna commented on a change in pull request #10953: URL: https://github.com/apache/kafka/pull/10953#discussion_r670424875 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/SessionWindowsTest.java ## @@ -57,6 +57,13 @@ public void

[GitHub] [kafka] cadonna commented on a change in pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-15 Thread GitBox
cadonna commented on a change in pull request #10953: URL: https://github.com/apache/kafka/pull/10953#discussion_r670424591 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java ## @@ -117,6 +118,13 @@ public void

[GitHub] [kafka] dajac commented on pull request #11021: KAFKA-13062: Make DeleteConsumerGroupsHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac commented on pull request #11021: URL: https://github.com/apache/kafka/pull/11021#issuecomment-880661583 Merged to trunk and to 3.0. cc @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dajac merged pull request #11021: KAFKA-13062: Make DeleteConsumerGroupsHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac merged pull request #11021: URL: https://github.com/apache/kafka/pull/11021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #11021: KAFKA-13062: Make DeleteConsumerGroupsHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac commented on pull request #11021: URL: https://github.com/apache/kafka/pull/11021#issuecomment-880660679 Failures are not related: ``` Build / JDK 16 and Scala 2.13 / shouldBeAbleToQueryFilterState – org.apache.kafka.streams.integration.QueryableStateIntegrationTest 43s

[GitHub] [kafka] dajac commented on pull request #11035: KAFKA-13072: Make RemoveMembersFromConsumerGroupHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac commented on pull request #11035: URL: https://github.com/apache/kafka/pull/11035#issuecomment-880657706 I've re-triggered Jenkins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cadonna commented on a change in pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-15 Thread GitBox
cadonna commented on a change in pull request #10953: URL: https://github.com/apache/kafka/pull/10953#discussion_r670414694 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java ## @@ -117,6 +118,13 @@ public void

[GitHub] [kafka] dajac commented on pull request #11022: KAFKA-13063: Make DescribeConsumerGroupsHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac commented on pull request #11022: URL: https://github.com/apache/kafka/pull/11022#issuecomment-880652697 Merged to trunk and to 3.0. cc @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dajac merged pull request #11022: KAFKA-13063: Make DescribeConsumerGroupsHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac merged pull request #11022: URL: https://github.com/apache/kafka/pull/11022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #11022: KAFKA-13063: Make DescribeConsumerGroupsHandler unmap for COORDINATOR_NOT_AVAILABLE error

2021-07-15 Thread GitBox
dajac commented on pull request #11022: URL: https://github.com/apache/kafka/pull/11022#issuecomment-880650309 Failures are not related: ``` Build / JDK 8 and Scala 2.12 / testUnauthorizedDeleteTopicsWithDescribe() – kafka.api.AuthorizerIntegrationTest 1m 7s Build / JDK 8 and

[GitHub] [kafka] dajac commented on pull request #11019: KAFKA-13059: Make DeleteConsumerGroupOffsetsHandler unmap for COORDINATOR_NOT_AVAILABLE error and fix issue

2021-07-15 Thread GitBox
dajac commented on pull request #11019: URL: https://github.com/apache/kafka/pull/11019#issuecomment-880648532 Merged to trunk and to 3.0. cc @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dajac merged pull request #11019: KAFKA-13059: Make DeleteConsumerGroupOffsetsHandler unmap for COORDINATOR_NOT_AVAILABLE error and fix issue

2021-07-15 Thread GitBox
dajac merged pull request #11019: URL: https://github.com/apache/kafka/pull/11019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #11019: KAFKA-13059: Make DeleteConsumerGroupOffsetsHandler unmap for COORDINATOR_NOT_AVAILABLE error and fix issue

2021-07-15 Thread GitBox
dajac commented on pull request #11019: URL: https://github.com/apache/kafka/pull/11019#issuecomment-880645547 Failures are not related: ``` Build / JDK 11 and Scala 2.13 / testCommitTransactionTimeout() – kafka.api.TransactionsTest 12s Build / JDK 11 and Scala 2.13 /

[GitHub] [kafka] tombentley commented on pull request #10945: KAFKA-13017: Remove excessive logging for sink task deserialization errors

2021-07-15 Thread GitBox
tombentley commented on pull request #10945: URL: https://github.com/apache/kafka/pull/10945#issuecomment-880614825 @rhauch / @kkonstantine do you want to take a look too? If not I'll go ahead and merge. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] cadonna commented on a change in pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-15 Thread GitBox
cadonna commented on a change in pull request #10953: URL: https://github.com/apache/kafka/pull/10953#discussion_r670352776 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java ## @@ -117,6 +118,13 @@ public void

  1   2   >