[GitHub] [kafka] JoeCqupt opened a new pull request #11088: MINOR: remove unnecessary judgment in method: assignReplicasToBrokersRackAware

2021-07-19 Thread GitBox
JoeCqupt opened a new pull request #11088: URL: https://github.com/apache/kafka/pull/11088 remove unnecessary judgment in method AdminUtils::assignReplicasToBrokersRackAware because replicationFactor <= numBrokers , so the judgment is not unnecessary -- This is an automated

[GitHub] [kafka] ZuevKirill95 opened a new pull request #11087: MINOR: Add port in error message

2021-07-19 Thread GitBox
ZuevKirill95 opened a new pull request #11087: URL: https://github.com/apache/kafka/pull/11087 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] satishd commented on pull request #11033: KAFKA-12988 Asynchronous API support for RemoteLogMetadataManager add/update methods.

2021-07-19 Thread GitBox
satishd commented on pull request #11033: URL: https://github.com/apache/kafka/pull/11033#issuecomment-883064875 @junrao This PR is rebased with trunk, please review and let me know your comments. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma commented on a change in pull request #11080: fix NPE when record==null in append

2021-07-19 Thread GitBox
ijuma commented on a change in pull request #11080: URL: https://github.com/apache/kafka/pull/11080#discussion_r672784612 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java ## @@ -293,7 +293,9 @@ public static DefaultRecord

[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

2021-07-19 Thread GitBox
showuon commented on pull request #11086: URL: https://github.com/apache/kafka/pull/11086#issuecomment-883022752 @dajac @rajinisivaram , please take a look. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] showuon commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

2021-07-19 Thread GitBox
showuon commented on a change in pull request #11086: URL: https://github.com/apache/kafka/pull/11086#discussion_r672778548 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3184,8 +3197,111 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

2021-07-19 Thread GitBox
showuon commented on a change in pull request #11086: URL: https://github.com/apache/kafka/pull/11086#discussion_r672778548 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3184,8 +3197,111 @@ public void

[GitHub] [kafka] showuon opened a new pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

2021-07-19 Thread GitBox
showuon opened a new pull request #11086: URL: https://github.com/apache/kafka/pull/11086 Add `REBALANCE_IN_PROGRESS` error as retriable error for all group API handlers in KIP-699, and tests for it. 1. AlterConsumerGroupOffsetsHandler 2. DeleteConsumerGroupOffsetsHandler 3.

[GitHub] [kafka] ableegoldman commented on a change in pull request #10921: KAFKA-13096: Ensure queryable store providers is up to date after adding stream thread

2021-07-19 Thread GitBox
ableegoldman commented on a change in pull request #10921: URL: https://github.com/apache/kafka/pull/10921#discussion_r672765942 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1081,6 +1079,7 @@ private int getNumStreamThreads(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #10921: KAFKA-13096: Ensure queryable store providers is up to date after adding stream thread

2021-07-19 Thread GitBox
ableegoldman commented on a change in pull request #10921: URL: https://github.com/apache/kafka/pull/10921#discussion_r672764087 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1081,6 +1079,7 @@ private int getNumStreamThreads(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #11083: KAFKA-13010: Retry getting tasks incase of rebalance for TaskMetadata tests

2021-07-19 Thread GitBox
ableegoldman commented on a change in pull request #11083: URL: https://github.com/apache/kafka/pull/11083#discussion_r672762836 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -158,9 +158,13 @@ public void

[GitHub] [kafka] ableegoldman commented on pull request #11085: MINOR: reduce debug log spam and busy loop during shutdown

2021-07-19 Thread GitBox
ableegoldman commented on pull request #11085: URL: https://github.com/apache/kafka/pull/11085#issuecomment-883003472 call for review @wcarlson5 @lct45 @guozhangwang @vvcephei @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ableegoldman commented on a change in pull request #11085: MINOR: reduce debug log spam and busy loop during shutdown

2021-07-19 Thread GitBox
ableegoldman commented on a change in pull request #11085: URL: https://github.com/apache/kafka/pull/11085#discussion_r672761316 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -885,8 +885,8 @@ private long pollPhase()

[GitHub] [kafka] ableegoldman commented on a change in pull request #11085: MINOR: reduce debug log spam and busy loop during shutdown

2021-07-19 Thread GitBox
ableegoldman commented on a change in pull request #11085: URL: https://github.com/apache/kafka/pull/11085#discussion_r672760705 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -719,10 +719,10 @@ void runOnce() {

[GitHub] [kafka] ccding commented on a change in pull request #11080: fix NPE when record==null in append

2021-07-19 Thread GitBox
ccding commented on a change in pull request #11080: URL: https://github.com/apache/kafka/pull/11080#discussion_r672758944 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java ## @@ -293,7 +293,9 @@ public static DefaultRecord

[jira] [Commented] (KAFKA-13103) Should group admin handlers consider REBALANCE_IN_PROGRESS and GROUP_AUTHORIZATION_FAILED as retryable errors?

2021-07-19 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383700#comment-17383700 ] Luke Chen commented on KAFKA-13103: --- I'll get the PR ready today (my time) in case this improvement

[GitHub] [kafka] ableegoldman opened a new pull request #11085: MINOR: reduce debug log spam and busy loop during shutdown

2021-07-19 Thread GitBox
ableegoldman opened a new pull request #11085: URL: https://github.com/apache/kafka/pull/11085 While investigating some system test failures I found the Streams logs often got up to several GB in size, with much of it being due to these three lines being logged on repeat many times per

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

2021-07-19 Thread GitBox
showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-882996715 @ijuma , thanks for the update. It looks better now! Also, thank you and @rondagostino for your patiently review! For your question: > it looks to me that we don't

[jira] [Resolved] (KAFKA-12588) Remove deprecated --zookeeper in shell commands

2021-07-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-12588. - Resolution: Fixed > Remove deprecated --zookeeper in shell commands >

[GitHub] [kafka] ijuma commented on pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

2021-07-19 Thread GitBox
ijuma commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-882989575 Merged to master and cherry-picking to 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] ijuma merged pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

2021-07-19 Thread GitBox
ijuma merged pull request #10811: URL: https://github.com/apache/kafka/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

2021-07-19 Thread GitBox
ijuma commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-882984058 Failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cmccabe commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

2021-07-19 Thread GitBox
cmccabe commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672716954 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -651,20 +661,21 @@ public void handleCommit(BatchReader

[GitHub] [kafka] cmccabe commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

2021-07-19 Thread GitBox
cmccabe commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672716671 ## File path: metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java ## @@ -178,14 +178,18 @@ public Snapshot getSnapshot(long epoch) {

[GitHub] [kafka] jsancio commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

2021-07-19 Thread GitBox
jsancio commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672716678 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -302,17 +302,13 @@ private void onUpdateLeaderHighWatermark( }

[GitHub] [kafka] cmccabe commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

2021-07-19 Thread GitBox
cmccabe commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672715848 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -755,11 +766,22 @@ public void

[GitHub] [kafka] jsancio opened a new pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

2021-07-19 Thread GitBox
jsancio opened a new pull request #11084: URL: https://github.com/apache/kafka/pull/11084 This commit includes a few changes: 1. The leader assumes that there is always an in-memory snapshot at the last committed offset. This means that the controller needs to generate an

[GitHub] [kafka] dielhennr commented on a change in pull request #10463: KAFKA-12670: support unclean.leader.election.enable in KRaft mode

2021-07-19 Thread GitBox
dielhennr commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r672693205 ## File path: metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java ## @@ -42,23 +42,38 @@ import java.util.Map.Entry;

[GitHub] [kafka] wcarlson5 commented on pull request #11083: KAFKA-13010: retry for tasks

2021-07-19 Thread GitBox
wcarlson5 commented on pull request #11083: URL: https://github.com/apache/kafka/pull/11083#issuecomment-882919484 @ableegoldman @jlprat @cadonna Can I get a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] wcarlson5 opened a new pull request #11083: KAFKA-13010: retry for tasks

2021-07-19 Thread GitBox
wcarlson5 opened a new pull request #11083: URL: https://github.com/apache/kafka/pull/11083 If there is a cooperative the tasks might not be assigned to a thread so retrying should work in a very short timeframe ### Committer Checklist (excluded from commit message) - [ ] Verify

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383653#comment-17383653 ] Walker Carlson commented on KAFKA-13010: It looks like the issue only shows up between

[jira] [Commented] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383652#comment-17383652 ] Konstantine Karantasis commented on KAFKA-12994: Downgraded the priority to Major since

[jira] [Updated] (KAFKA-13021) Improve Javadocs for API Changes from KIP-633

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13021: --- Priority: Major (was: Blocker) > Improve Javadocs for API Changes from

[jira] [Updated] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12994: --- Priority: Major (was: Blocker) > Migrate all Tests to New API and Remove

[jira] [Commented] (KAFKA-12644) Add Missing Class-Level Javadoc to Descendants of org.apache.kafka.common.errors.ApiException

2021-07-19 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383650#comment-17383650 ] Jason Gustafson commented on KAFKA-12644: - Downgrading priority since this is not a blocker. We

[jira] [Updated] (KAFKA-12644) Add Missing Class-Level Javadoc to Descendants of org.apache.kafka.common.errors.ApiException

2021-07-19 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12644: Priority: Major (was: Blocker) > Add Missing Class-Level Javadoc to Descendants of >

[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns

2021-07-19 Thread GitBox
dielhennr commented on a change in pull request #11082: URL: https://github.com/apache/kafka/pull/11082#discussion_r672657134 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -284,6 +284,7 @@ private Throwable

[jira] [Updated] (KAFKA-12622) Automate LICENSE file validation

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12622: --- Fix Version/s: (was: 3.0.0) 3.0.1 > Automate LICENSE

[jira] [Comment Edited] (KAFKA-12291) Fix Ignored Upgrade Tests in streams_upgrade_test.py: test_upgrade_downgrade_brokers

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383642#comment-17383642 ] Konstantine Karantasis edited comment on KAFKA-12291 at 7/19/21, 10:35 PM:

[jira] [Commented] (KAFKA-12291) Fix Ignored Upgrade Tests in streams_upgrade_test.py: test_upgrade_downgrade_brokers

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383642#comment-17383642 ] Konstantine Karantasis commented on KAFKA-12291: [~cadonna] we are now past code freeze

[jira] [Commented] (KAFKA-13021) Improve Javadocs for API Changes from KIP-633

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383636#comment-17383636 ] Konstantine Karantasis commented on KAFKA-13021: I don't see a PR linked for this issue.

[jira] [Commented] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383632#comment-17383632 ] Konstantine Karantasis commented on KAFKA-12994: Hi [~iekpo]. You mentioned on the dev

[jira] [Comment Edited] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383620#comment-17383620 ] Walker Carlson edited comment on KAFKA-13010 at 7/19/21, 10:15 PM: --- I

[jira] [Comment Edited] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383620#comment-17383620 ] Walker Carlson edited comment on KAFKA-13010 at 7/19/21, 10:08 PM: --- I

[jira] [Comment Edited] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383620#comment-17383620 ] Walker Carlson edited comment on KAFKA-13010 at 7/19/21, 10:07 PM: --- I

[jira] [Comment Edited] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383620#comment-17383620 ] Walker Carlson edited comment on KAFKA-13010 at 7/19/21, 10:05 PM: --- I

[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns

2021-07-19 Thread GitBox
dielhennr commented on a change in pull request #11082: URL: https://github.com/apache/kafka/pull/11082#discussion_r672662886 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -284,6 +284,7 @@ private Throwable

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383620#comment-17383620 ] Walker Carlson commented on KAFKA-13010: I ran it for the commit before KIP-744 and it did fail.

[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns

2021-07-19 Thread GitBox
dielhennr commented on a change in pull request #11082: URL: https://github.com/apache/kafka/pull/11082#discussion_r672657134 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -284,6 +284,7 @@ private Throwable

[jira] [Updated] (KAFKA-7330) Kakfa 0.10.2.1 producer close method issue

2021-07-19 Thread Arikathota, Durga (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arikathota, Durga updated KAFKA-7330: - Attachment: disclaim.txt image001.png Any update on this issue please ?

[GitHub] [kafka] jsancio commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns

2021-07-19 Thread GitBox
jsancio commented on a change in pull request #11082: URL: https://github.com/apache/kafka/pull/11082#discussion_r672645909 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -284,6 +284,7 @@ private Throwable

[jira] [Updated] (KAFKA-12487) Sink connectors do not work with the cooperative consumer rebalance protocol

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12487: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Sink connectors

[jira] [Commented] (KAFKA-12487) Sink connectors do not work with the cooperative consumer rebalance protocol

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383609#comment-17383609 ] Konstantine Karantasis commented on KAFKA-12487: Changing the default consumer protocol

[jira] [Commented] (KAFKA-13069) Add magic number to DefaultKafkaPrincipalBuilder.KafkaPrincipalSerde

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383604#comment-17383604 ] Konstantine Karantasis commented on KAFKA-13069: Postponing to the subsequent release

[jira] [Updated] (KAFKA-13069) Add magic number to DefaultKafkaPrincipalBuilder.KafkaPrincipalSerde

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13069: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Add magic number

[jira] [Updated] (KAFKA-12712) KRaft: Missing controller.quorom.voters config not properly handled

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12712: --- Fix Version/s: (was: 3.0.0) 3.1.0 > KRaft: Missing

[GitHub] [kafka] dielhennr opened a new pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns

2021-07-19 Thread GitBox
dielhennr opened a new pull request #11082: URL: https://github.com/apache/kafka/pull/11082 When the active controller encounters an event exception it attempts to renounce leadership. Unfortunately, this doesn't tell the RaftClient that it should attempt to give up leadership. This will

[jira] [Commented] (KAFKA-12712) KRaft: Missing controller.quorom.voters config not properly handled

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383602#comment-17383602 ] Konstantine Karantasis commented on KAFKA-12712: Postponing to the subsequent release

[jira] [Commented] (KAFKA-12882) Add RegisteredBrokerCount and UnfencedBrokerCount metrics to the QuorumController

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383600#comment-17383600 ] Konstantine Karantasis commented on KAFKA-12882: The KIP has been published but it's

[jira] [Updated] (KAFKA-12882) Add RegisteredBrokerCount and UnfencedBrokerCount metrics to the QuorumController

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12882: --- Fix Version/s: (was: 3.0.0) > Add RegisteredBrokerCount and

[GitHub] [kafka] dielhennr closed pull request #11081: MINOR: Typo in RaftClient Javadoc

2021-07-19 Thread GitBox
dielhennr closed pull request #11081: URL: https://github.com/apache/kafka/pull/11081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12699: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Streams no

[jira] [Comment Edited] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383586#comment-17383586 ] Konstantine Karantasis edited comment on KAFKA-12699 at 7/19/21, 9:08 PM:

[jira] [Commented] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383586#comment-17383586 ] Konstantine Karantasis commented on KAFKA-12699: Postponing to the subsequent release

[jira] [Updated] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12774: --- Fix Version/s: 3.0.1 > kafka-streams 2.8: logging in

[jira] [Updated] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12774: --- Fix Version/s: (was: 3.0.0) 3.1.0 > kafka-streams

[jira] [Updated] (KAFKA-10641) ACL Command hangs with SSL as not existing with proper error code

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10641: --- Fix Version/s: (was: 3.0.0) > ACL Command hangs with SSL as not

[jira] [Commented] (KAFKA-10641) ACL Command hangs with SSL as not existing with proper error code

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383584#comment-17383584 ] Konstantine Karantasis commented on KAFKA-10641: Resetting the fix version of this

[jira] [Commented] (KAFKA-10642) Expose the real stack trace if any exception occurred during SSL Client Trust Verification in extension

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383582#comment-17383582 ] Konstantine Karantasis commented on KAFKA-10642: Postponing to the subsequent release

[jira] [Updated] (KAFKA-10642) Expose the real stack trace if any exception occurred during SSL Client Trust Verification in extension

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10642: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Expose the real

[jira] [Comment Edited] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383564#comment-17383564 ] Josep Prat edited comment on KAFKA-13010 at 7/19/21, 9:02 PM: -- I only

[jira] [Updated] (KAFKA-12899) Support --bootstrap-server in ReplicaVerificationTool

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12899: --- Fix Version/s: (was: 3.0.0) > Support --bootstrap-server in

[jira] [Commented] (KAFKA-12899) Support --bootstrap-server in ReplicaVerificationTool

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383577#comment-17383577 ] Konstantine Karantasis commented on KAFKA-12899: KIP freeze has past a while ago and the

[jira] [Updated] (KAFKA-9803) Allow producers to recover gracefully from transaction timeouts

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9803: -- Fix Version/s: (was: 3.0.0) 3.1.0 > Allow producers to

[jira] [Commented] (KAFKA-9803) Allow producers to recover gracefully from transaction timeouts

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383576#comment-17383576 ] Konstantine Karantasis commented on KAFKA-9803: --- Postponing to the subsequent release given

[jira] [Commented] (KAFKA-12842) Failing test: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383575#comment-17383575 ] Konstantine Karantasis commented on KAFKA-12842: This is an infrequent failure on a

[jira] [Assigned] (KAFKA-12842) Failing test: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis reassigned KAFKA-12842: -- Assignee: (was: Konstantine Karantasis) > Failing test: >

[jira] [Updated] (KAFKA-12842) Failing test: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12842: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Failing test: >

[jira] [Assigned] (KAFKA-12842) Failing test: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis reassigned KAFKA-12842: -- Assignee: Konstantine Karantasis > Failing test: >

[jira] [Commented] (KAFKA-9910) Implement new transaction timed out error

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383573#comment-17383573 ] Konstantine Karantasis commented on KAFKA-9910: --- Postponing to the subsequent release given

[jira] [Updated] (KAFKA-9910) Implement new transaction timed out error

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9910: -- Fix Version/s: (was: 3.0.0) 3.1.0 > Implement new

[jira] [Resolved] (KAFKA-12803) Support reassigning partitions when in KRaft mode

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-12803. Resolution: Fixed Resolving as Fixed given that the PR got merged and

[jira] [Resolved] (KAFKA-13090) Improve cluster snapshot integration test

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-13090. Resolution: Fixed Resolving given that the PR got merged and

[GitHub] [kafka] dielhennr opened a new pull request #11081: MINOR: Typo in RaftClient Javadoc

2021-07-19 Thread GitBox
dielhennr opened a new pull request #11081: URL: https://github.com/apache/kafka/pull/11081 Small typo in RaftClient javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383564#comment-17383564 ] Josep Prat commented on KAFKA-13010: I only mentioned because it seems to be the only other change

[GitHub] [kafka] ijuma commented on a change in pull request #11080: fix NPE when record==null in append

2021-07-19 Thread GitBox
ijuma commented on a change in pull request #11080: URL: https://github.com/apache/kafka/pull/11080#discussion_r672610426 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java ## @@ -293,7 +293,9 @@ public static DefaultRecord

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383560#comment-17383560 ] Walker Carlson commented on KAFKA-13010: This doesn't use the StreamsMetadata so I don't think

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383557#comment-17383557 ] Josep Prat commented on KAFKA-13010: The only other difference left now is in StreamsMetadataImpl

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383553#comment-17383553 ] Walker Carlson commented on KAFKA-13010: it took about 126 runs but it still failed > Flaky

[jira] [Commented] (KAFKA-13105) Expose a method in KafkaConfig to write the configs to a logger

2021-07-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383550#comment-17383550 ] Ismael Juma commented on KAFKA-13105: - I think we should make this Jira about including dynamic

[jira] [Comment Edited] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383537#comment-17383537 ] Josep Prat edited comment on KAFKA-13010 at 7/19/21, 7:40 PM: -- If this is

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383537#comment-17383537 ] Josep Prat commented on KAFKA-13010: If this is the reason why we are seeing this bug, by replacing

[jira] [Updated] (KAFKA-13105) Expose a method in KafkaConfig to write the configs to a logger

2021-07-19 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13105: - Issue Type: Improvement (was: Bug) > Expose a method in KafkaConfig to write the configs to a

[GitHub] [kafka] cmccabe merged pull request #11067: MINOR: log broker configs in KRaft mode

2021-07-19 Thread GitBox
cmccabe merged pull request #11067: URL: https://github.com/apache/kafka/pull/11067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

2021-07-19 Thread GitBox
cmccabe commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672574835 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy

[jira] [Created] (KAFKA-13105) Expose a method in KafkaConfig to write the configs to a logger

2021-07-19 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13105: Summary: Expose a method in KafkaConfig to write the configs to a logger Key: KAFKA-13105 URL: https://issues.apache.org/jira/browse/KAFKA-13105 Project: Kafka

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383533#comment-17383533 ] Walker Carlson commented on KAFKA-13010: That sounds likely as the ThreadMetadata is retrieved

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383531#comment-17383531 ] Josep Prat commented on KAFKA-13010: One thing that was modified under that PR that might cause some

[GitHub] [kafka] ccding commented on pull request #11080: fix NPE when record==null in append

2021-07-19 Thread GitBox
ccding commented on pull request #11080: URL: https://github.com/apache/kafka/pull/11080#issuecomment-882800476 This PR is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383516#comment-17383516 ] Walker Carlson commented on KAFKA-13010: That does seem to be the case. I think somehow those

  1   2   >