showuon commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r800141904
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -488,7 +492,7 @@ public boolean
showuon commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r800141904
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -488,7 +492,7 @@ public boolean
showuon commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r800141737
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##
@@ -192,6 +192,9 @@
private final String
showuon commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r800141507
##
File path:
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala
##
@@ -1037,7 +1037,8 @@ class AuthorizerIntegrationTest extends
showuon commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r800141430
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##
@@ -2641,14 +2565,16 @@ private FetchResponse
showuon commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r800141328
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##
@@ -660,15 +645,12 @@ public void
jasonk000 commented on pull request #11721:
URL: https://github.com/apache/kafka/pull/11721#issuecomment-1030737954
I had misread spotbugs output and used the CI spotbugs steps, fixed it now =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
chia7712 merged pull request #11469:
URL: https://github.com/apache/kafka/pull/11469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on pull request #11469:
URL: https://github.com/apache/kafka/pull/11469#issuecomment-1030685984
```
Build / JDK 11 and Scala 2.13 /
kafka.api.PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords()
```
```
Build / JDK 8 and
hachikuji merged pull request #11734:
URL: https://github.com/apache/kafka/pull/11734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hachikuji merged pull request #11691:
URL: https://github.com/apache/kafka/pull/11691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hachikuji commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1030677045
The updates LGTM. Merging to trunk, 3.1, and 3.0. Thanks @showuon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487519#comment-17487519
]
Mohammad Yousuf Minhaj Zia edited comment on KAFKA-13641 at 2/5/22, 6:36 PM:
[
https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487519#comment-17487519
]
Mohammad Yousuf Minhaj Zia commented on KAFKA-13641:
I see. Just wondering what the
dajac commented on a change in pull request #11586:
URL: https://github.com/apache/kafka/pull/11586#discussion_r800075216
##
File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java
##
@@ -945,6 +947,8 @@ private void close(KafkaChannel channel, CloseMode
splett2 commented on a change in pull request #11586:
URL: https://github.com/apache/kafka/pull/11586#discussion_r800073769
##
File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java
##
@@ -945,6 +947,8 @@ private void close(KafkaChannel channel,
splett2 commented on a change in pull request #11586:
URL: https://github.com/apache/kafka/pull/11586#discussion_r800073769
##
File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java
##
@@ -945,6 +947,8 @@ private void close(KafkaChannel channel,
showuon commented on pull request #11681:
URL: https://github.com/apache/kafka/pull/11681#issuecomment-1030619107
@dajac , thanks for the comment.
> We could perhaps apply the suggestion that I've made to fix the flaky
tests
Sure. I'll update the PR later.
> file a
showuon commented on pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#issuecomment-1030618945
@mjsax @guozhangwang , this PR is ready for review. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chia7712 commented on pull request #11469:
URL: https://github.com/apache/kafka/pull/11469#issuecomment-1030612949
> Any reason why this wasn't merged?
will merge it if QA pass :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dajac commented on pull request #11681:
URL: https://github.com/apache/kafka/pull/11681#issuecomment-1030592956
@showuon Thanks for the PR. I left a suggestion. Overall, I wonder if the
real issue is in the admin client. If we have all the brokers in the bootstrap
list, it should be able
dajac commented on a change in pull request #11681:
URL: https://github.com/apache/kafka/pull/11681#discussion_r800041619
##
File path: core/src/test/scala/unit/kafka/admin/LeaderElectionCommandTest.scala
##
@@ -55,9 +54,18 @@ final class LeaderElectionCommandTest(cluster:
dajac commented on pull request #11586:
URL: https://github.com/apache/kafka/pull/11586#issuecomment-1030581570
@dongjinleekr Could we also add a unit test which verifies that connection
metrics are closed?
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487433#comment-17487433
]
Matthias J. Sax commented on KAFKA-13641:
-
I don't have a good intuition atm what a good way
[
https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487431#comment-17487431
]
Kvicii.Yu commented on KAFKA-13641:
---
[~yzia2000]
I don't think it's a good idea to modify the method
25 matches
Mail list logo
