[jira] [Commented] (KAFKA-4212) Add a key-value store that is a TTL persistent cache

2022-02-23 Thread Zhongda Zhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497236#comment-17497236 ] Zhongda Zhao commented on KAFKA-4212: - We thought we could have used {{Materialized.withRetention}}

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-23 Thread GitBox
RivenSun2 commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r813609339 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2849,6 +2850,20 @@ public void testUnusedConfigs()

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-23 Thread GitBox
RivenSun2 commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r813618411 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -377,10 +383,21 @@ private void logAll() { }

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-23 Thread GitBox
RivenSun2 commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r813610827 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2849,6 +2850,20 @@ public void testUnusedConfigs()

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-23 Thread GitBox
RivenSun2 commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r813609339 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2849,6 +2850,20 @@ public void testUnusedConfigs()

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-23 Thread GitBox
RivenSun2 commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r813607110 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -813,6 +813,7 @@ public KafkaConsumer(Map configs,

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-23 Thread GitBox
RivenSun2 commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r813606372 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -377,10 +383,21 @@ private void logAll() { }

[GitHub] [kafka] showuon commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-23 Thread GitBox
showuon commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r813598311 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -377,10 +383,21 @@ private void logAll() { }

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2022-02-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497214#comment-17497214 ] Matthias J. Sax commented on KAFKA-10635: - Is this fixed via

[jira] [Commented] (KAFKA-13681) Sink event duplicates for partition-stuck stream application

2022-02-23 Thread Mikhail Dubrovin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497211#comment-17497211 ] Mikhail Dubrovin commented on KAFKA-13681: -- [~guozhang] thank you for the reply. What's the

[jira] [Commented] (KAFKA-12446) Define KGroupedTable#aggregate subtractor + adder order of execution

2022-02-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497210#comment-17497210 ] Matthias J. Sax commented on KAFKA-12446: - Just discovering the ticket. – I don't think it makes

[jira] [Resolved] (KAFKA-12640) AbstractCoordinator ignores backoff timeout when joining the consumer group

2022-02-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-12640. - Resolution: Duplicate > AbstractCoordinator ignores backoff timeout when joining the

[jira] [Commented] (KAFKA-13501) Avoid state restore via rebalance if standbys are enabled

2022-02-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497201#comment-17497201 ] Matthias J. Sax commented on KAFKA-13501: - There is also

[jira] [Commented] (KAFKA-13501) Avoid state restore via rebalance if standbys are enabled

2022-02-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497196#comment-17497196 ] Matthias J. Sax commented on KAFKA-13501: - I just discovered

[jira] [Updated] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-02-23 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Troiano updated KAFKA-13687: --- Fix Version/s: (was: 2.8.1) > Limit number of batches when using kafka-dump-log.sh >

[jira] [Updated] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-02-23 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Troiano updated KAFKA-13687: --- Fix Version/s: 2.8.1 > Limit number of batches when using kafka-dump-log.sh >

[jira] [Updated] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-02-23 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Troiano updated KAFKA-13687: --- Affects Version/s: 2.8.1 > Limit number of batches when using kafka-dump-log.sh >

[GitHub] [kafka] vamossagar12 commented on pull request #11796: Kip 770

2022-02-23 Thread GitBox
vamossagar12 commented on pull request #11796: URL: https://github.com/apache/kafka/pull/11796#issuecomment-1049465748 @guozhangwang , this PR is showing a failure in streams:compileTestJava.. It seems to be working on my local. -- This is an automated message from the Apache Git

[GitHub] [kafka] RivenSun2 commented on pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-23 Thread GitBox
RivenSun2 commented on pull request #11800: URL: https://github.com/apache/kafka/pull/11800#issuecomment-1049437682 Hi @showuon @guozhangwang Please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] RivenSun2 opened a new pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-23 Thread GitBox
RivenSun2 opened a new pull request #11800: URL: https://github.com/apache/kafka/pull/11800 Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-23 Thread GitBox
showuon commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r813497899 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -233,6 +233,19 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-23 Thread GitBox
showuon commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r813497832 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -361,6 +369,20 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-23 Thread GitBox
showuon commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r813495690 ## File path: docs/upgrade.html ## @@ -21,7 +21,7 @@ Notable changes in 3.2.0 -Idempotence for the producer is enabled by default. In

[GitHub] [kafka] hongyiz6639 commented on pull request #11793: MINOR: Skip fsync on parent directory to start Kafka on ZOS

2022-02-23 Thread GitBox
hongyiz6639 commented on pull request #11793: URL: https://github.com/apache/kafka/pull/11793#issuecomment-1049431604 > @hongyiz6639 : Thanks for the PR. LGTM. Are the test failures related to this PR? @junrao Thanks for your reply. All test failures are not related with this PR.

[GitHub] [kafka] showuon commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-23 Thread GitBox
showuon commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r813491031 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,55 @@ private void

[GitHub] [kafka] showuon commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-23 Thread GitBox
showuon commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r813489168 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -276,8 +276,8 @@

[jira] [Assigned] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun reassigned KAFKA-13689: Assignee: RivenSun (was: Luke Chen) > AbstractConfig log print information is incorrect >

[jira] [Commented] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497090#comment-17497090 ] RivenSun commented on KAFKA-13689: -- [~showuon]  [~guozhang]  Thanks for your advices. I will create a

[GitHub] [kafka] showuon commented on pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

2022-02-23 Thread GitBox
showuon commented on pull request #11760: URL: https://github.com/apache/kafka/pull/11760#issuecomment-1049350759 @tim-patterson @cadonna , yes, we are aware of the failed system tests because someone reported last week: https://github.com/apache/kafka/pull/11769. And yes, we have a PR

[jira] [Updated] (KAFKA-13685) Seems to get empty event time in some messages.

2022-02-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13685: Component/s: streams (was: consumer) (was:

[jira] [Updated] (KAFKA-13678) 2nd punctuation using STREAM_TIME does not respect scheduled interval

2022-02-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13678: Issue Type: Improvement (was: Bug) > 2nd punctuation using STREAM_TIME does not respect

[jira] [Commented] (KAFKA-13678) 2nd punctuation using STREAM_TIME does not respect scheduled interval

2022-02-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497056#comment-17497056 ] Matthias J. Sax commented on KAFKA-13678: - What [~guozhang] says is right – we align stream-time

[GitHub] [kafka] jsancio commented on a change in pull request #11790: MINOR: Cleanup admin creation logic in integration tests

2022-02-23 Thread GitBox
jsancio commented on a change in pull request #11790: URL: https://github.com/apache/kafka/pull/11790#discussion_r813357222 ## File path: core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala ## @@ -168,18 +198,41 @@ abstract class KafkaServerTestHarness

[jira] [Updated] (KAFKA-13677) version 3.0.0 Processor implementation uses parameter record (restricted identifier)

2022-02-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13677: Component/s: streams (was: clients) > version 3.0.0 Processor

[GitHub] [kafka] chb2ab opened a new pull request #11799: KAFKA-13688: Fix a couple incorrect metrics in KafkaController

2022-02-23 Thread GitBox
chb2ab opened a new pull request #11799: URL: https://github.com/apache/kafka/pull/11799 KAFKA-13688: This change removes unnecessary and incorrect set creations over the topics to be deleted during update metrics, computing both replicasToDeleteCount and

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-23 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r812722151 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,303

[GitHub] [kafka] tim-patterson commented on pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

2022-02-23 Thread GitBox
tim-patterson commented on pull request #11760: URL: https://github.com/apache/kafka/pull/11760#issuecomment-1049175838 I wonder if this is the fix https://issues.apache.org/jira/browse/KAFKA-13673 (Not sure what tests in particular it's trying to fix) -- This is an automated message

[GitHub] [kafka] tim-patterson edited a comment on pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

2022-02-23 Thread GitBox
tim-patterson edited a comment on pull request #11760: URL: https://github.com/apache/kafka/pull/11760#issuecomment-1049161045 > The most recent [system test run on

[GitHub] [kafka] tim-patterson commented on pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

2022-02-23 Thread GitBox
tim-patterson commented on pull request #11760: URL: https://github.com/apache/kafka/pull/11760#issuecomment-1049161045 > The most recent [system test run on

[GitHub] [kafka] guozhangwang commented on a change in pull request #11705: KAFKA-9847: add config to set default store type

2022-02-23 Thread GitBox
guozhangwang commented on a change in pull request #11705: URL: https://github.com/apache/kafka/pull/11705#discussion_r813252418 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -81,14 +81,19 @@ public StreamsBuilder() {

[jira] [Updated] (KAFKA-13676) When processing in ALOS, when one task encounters a task-specific exception we could still commit progress made by other tasks

2022-02-23 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-13676: --- Fix Version/s: 3.2.0 > When processing in ALOS, when one task encounters a task-specific

[jira] [Updated] (KAFKA-13676) When processing in ALOS, when one task encounters a task-specific exception we could still commit progress made by other tasks

2022-02-23 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-13676: --- Description: When processing in ALOS, we might as well commit progress made by other tasks

[jira] [Commented] (KAFKA-13678) 2nd punctuation using STREAM_TIME does not respect scheduled interval

2022-02-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497010#comment-17497010 ] Guozhang Wang commented on KAFKA-13678: --- Hello [~lorenzocagnatel] thanks for reporting. There's

[jira] [Commented] (KAFKA-13681) Sink event duplicates for partition-stuck stream application

2022-02-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497004#comment-17497004 ] Guozhang Wang commented on KAFKA-13681: --- Thanks for reporting [~DrozD_0], I think this is indeed a

[jira] [Commented] (KAFKA-13683) Transactional Producer - Transaction with key xyz went wrong with exception: Timeout expired after 60000milliseconds while awaiting InitProducerId

2022-02-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497002#comment-17497002 ] Guozhang Wang commented on KAFKA-13683: --- Hello, I checked your uploaded files and cannot find any

[GitHub] [kafka] hachikuji commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-23 Thread GitBox
hachikuji commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813188764 ## File path: core/src/test/scala/unit/kafka/cluster/PartitionTest.scala ## @@ -1077,6 +1078,58 @@ class PartitionTest extends AbstractPartitionTest {

[jira] [Updated] (KAFKA-13683) Transactional Producer - Transaction with key xyz went wrong with exception: Timeout expired after 60000milliseconds while awaiting InitProducerId

2022-02-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13683: -- Labels: new-txn-protocol-should-fix (was: ) > Transactional Producer - Transaction with key

[jira] [Commented] (KAFKA-13684) KStream rebalance can lead to JVM process crash when network issues occure

2022-02-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496995#comment-17496995 ] Guozhang Wang commented on KAFKA-13684: --- Thanks [~petercipov] for reporting this, we will look

[jira] [Updated] (KAFKA-13684) KStream rebalance can lead to JVM process crash when network issues occure

2022-02-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13684: -- Priority: Critical (was: Major) > KStream rebalance can lead to JVM process crash when

[jira] [Commented] (KAFKA-13680) Kafka Streams application remains in RUNNING state although all stream threads shut down

2022-02-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496989#comment-17496989 ] Guozhang Wang commented on KAFKA-13680: --- Thanks for reporting this Denis. I think we still need

[jira] [Commented] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496981#comment-17496981 ] Guozhang Wang commented on KAFKA-13689: --- Thanks [~RivenSun] for reporting this. I think logging

[GitHub] [kafka] guozhangwang commented on pull request #11499: KAFKA-10199: Add interface for state updater

2022-02-23 Thread GitBox
guozhangwang commented on pull request #11499: URL: https://github.com/apache/kafka/pull/11499#issuecomment-1049069755 Thanks @cadonna , merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] guozhangwang merged pull request #11499: KAFKA-10199: Add interface for state updater

2022-02-23 Thread GitBox
guozhangwang merged pull request #11499: URL: https://github.com/apache/kafka/pull/11499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hachikuji commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-23 Thread GitBox
hachikuji commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813163349 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -110,6 +110,14 @@

[GitHub] [kafka] hachikuji commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-23 Thread GitBox
hachikuji commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813161823 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -250,23 +260,35 @@ class DefaultAlterIsrManager( val

[GitHub] [kafka] junrao commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-23 Thread GitBox
junrao commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r813156759 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ChildFirstClassLoader.java ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vamossagar12 edited a comment on pull request #11796: Kip 770

2022-02-23 Thread GitBox
vamossagar12 edited a comment on pull request #11796: URL: https://github.com/apache/kafka/pull/11796#issuecomment-1049024510 @ableegoldman , @guozhangwang , @mjsax this is the new PR for KIP-770(follow up from https://github.com/apache/kafka/pull/11424/ last 3-4 commits hold the

[GitHub] [kafka] vamossagar12 commented on pull request #11796: Kip 770

2022-02-23 Thread GitBox
vamossagar12 commented on pull request #11796: URL: https://github.com/apache/kafka/pull/11796#issuecomment-1049024510 @ableegoldman , @guozhangwang , @mjsax this is the new PR for KIP-770(follow up from https://github.com/apache/kafka/pull/11424/ last 3-4 commits hold the new set

[jira] [Commented] (KAFKA-10902) IllegalMonitorStateException in KafkaProducer.waitOnMetadata

2022-02-23 Thread Antoine DESSAIGNE (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496913#comment-17496913 ] Antoine DESSAIGNE commented on KAFKA-10902: --- Yes, you're right. Unfortunately, we can't yet

[jira] [Commented] (KAFKA-10902) IllegalMonitorStateException in KafkaProducer.waitOnMetadata

2022-02-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496912#comment-17496912 ] Ismael Juma commented on KAFKA-10902: - The most helpful thing would be to test with JDK 17. If the

[jira] [Commented] (KAFKA-10902) IllegalMonitorStateException in KafkaProducer.waitOnMetadata

2022-02-23 Thread Antoine DESSAIGNE (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496883#comment-17496883 ] Antoine DESSAIGNE commented on KAFKA-10902: --- We also encounter this bug which looks more and

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-23 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r812992120 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -461,27 +464,56 @@ private void

[GitHub] [kafka] ijuma commented on a change in pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-23 Thread GitBox
ijuma commented on a change in pull request #11788: URL: https://github.com/apache/kafka/pull/11788#discussion_r812999106 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -361,6 +369,20 @@ public void

[GitHub] [kafka] ccding commented on pull request #11793: MINOR: Skip fsync on parent directory to start Kafka on ZOS

2022-02-23 Thread GitBox
ccding commented on pull request #11793: URL: https://github.com/apache/kafka/pull/11793#issuecomment-1048896072 @zshuo can you help to have a look at this since you worked on https://github.com/apache/kafka/commit/62b2eac4e1a97e6d77bc57f9100bf22a2f364178? -- This is an automated

[GitHub] [kafka] madhusyath5620 opened a new pull request #11798: yes added

2022-02-23 Thread GitBox
madhusyath5620 opened a new pull request #11798: URL: https://github.com/apache/kafka/pull/11798 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] C0urante commented on pull request #11772: KAFKA-10000: Add new metrics for source task transactions (KIP-618)

2022-02-23 Thread GitBox
C0urante commented on pull request #11772: URL: https://github.com/apache/kafka/pull/11772#issuecomment-1048803516 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] C0urante commented on pull request #11774: KAFKA-10000: Widely-used utility methods (KIP-618)

2022-02-23 Thread GitBox
C0urante commented on pull request #11774: URL: https://github.com/apache/kafka/pull/11774#issuecomment-1048803328 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mimaison merged pull request #11774: KAFKA-10000: Widely-used utility methods (KIP-618)

2022-02-23 Thread GitBox
mimaison merged pull request #11774: URL: https://github.com/apache/kafka/pull/11774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison merged pull request #11772: KAFKA-10000: Add new metrics for source task transactions (KIP-618)

2022-02-23 Thread GitBox
mimaison merged pull request #11772: URL: https://github.com/apache/kafka/pull/11772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-23 Thread GitBox
showuon commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r812884587 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -252,10 +253,53

[jira] [Commented] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496735#comment-17496735 ] Luke Chen commented on KAFKA-13689: --- OK, sounds good to me. See if there are other opinions. Thanks.

[jira] [Resolved] (KAFKA-13685) Seems to get empty event time in some messages.

2022-02-23 Thread Alex (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex resolved KAFKA-13685. -- Resolution: Auto Closed > Seems to get empty event time in some messages. >

[GitHub] [kafka] mimaison commented on pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-02-23 Thread GitBox
mimaison commented on pull request #11572: URL: https://github.com/apache/kafka/pull/11572#issuecomment-1048687705 @tombentley @vvcephei @C0urante As you voted on the KIP, can you take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mimaison commented on a change in pull request #10244: KAFKA-12399: Deprecate Log4J Appender

2022-02-23 Thread GitBox
mimaison commented on a change in pull request #10244: URL: https://github.com/apache/kafka/pull/10244#discussion_r812791855 ## File path: log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java ## @@ -333,6 +333,7 @@ public void activateOptions()

[GitHub] [kafka] cadonna edited a comment on pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

2022-02-23 Thread GitBox
cadonna edited a comment on pull request #11760: URL: https://github.com/apache/kafka/pull/11760#issuecomment-1048659159 The most recent [system test run on

[GitHub] [kafka] cadonna commented on pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

2022-02-23 Thread GitBox
cadonna commented on pull request #11760: URL: https://github.com/apache/kafka/pull/11760#issuecomment-1048659159 The most recent system test run on trunk I could find on Jenkins was one on February 9th. This run does not contain the system test failures I mentioned above

[GitHub] [kafka] mimaison closed pull request #11769: Use default non-zero value for retries in producer

2022-02-23 Thread GitBox
mimaison closed pull request #11769: URL: https://github.com/apache/kafka/pull/11769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on pull request #11769: Use default non-zero value for retries in producer

2022-02-23 Thread GitBox
mimaison commented on pull request #11769: URL: https://github.com/apache/kafka/pull/11769#issuecomment-1048641952 https://github.com/apache/kafka/pull/11788 should address this issue, closing -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-02-23 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Troiano updated KAFKA-13687: --- Description: Currently the kafka-dump-log.sh reads the whole files(s) and dumps the results

[jira] [Updated] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-02-23 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Troiano updated KAFKA-13687: --- Description: Currently the kafka-dump-log.sh reads the whole files(s) and dumps the results

[jira] [Commented] (KAFKA-13680) Kafka Streams application remains in RUNNING state although all stream threads shut down

2022-02-23 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496626#comment-17496626 ] Bruno Cadonna commented on KAFKA-13680: --- BTW, we probably missed to ensure to keep exactly the

[GitHub] [kafka] dengziming commented on a change in pull request #11784: KAFKA-13228; Ensure ApiVersionRequest is properly handled KRaft co-resident mode

2022-02-23 Thread GitBox
dengziming commented on a change in pull request #11784: URL: https://github.com/apache/kafka/pull/11784#discussion_r812650014 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -209,6 +211,11 @@ class BrokerServer( val controllerNodes =

[GitHub] [kafka] lkokhreidze commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-23 Thread GitBox
lkokhreidze commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-1048612254 Hi @cadonna @showuon I've addressed your comments. Please have a look. Thank you! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-23 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r812722151 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,303

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-23 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r812720897 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,303

[jira] [Comment Edited] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496594#comment-17496594 ] RivenSun edited comment on KAFKA-13689 at 2/23/22, 9:31 AM: Hi [~showuon]

[jira] [Comment Edited] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496594#comment-17496594 ] RivenSun edited comment on KAFKA-13689 at 2/23/22, 9:11 AM: Hi [~showuon]

[jira] [Commented] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496594#comment-17496594 ] RivenSun commented on KAFKA-13689: -- Hi [~showuon] Thanks for your reply. I recommend printing the logs

[jira] [Commented] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496587#comment-17496587 ] Luke Chen commented on KAFKA-13689: --- [~RivenSun] , thanks for the report. Maybe we just modify the log

[jira] [Commented] (KAFKA-1194) The kafka broker cannot delete the old log files after the configured time

2022-02-23 Thread Martin Pelak (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496586#comment-17496586 ] Martin Pelak commented on KAFKA-1194: - Hi [~mzinal], thank you for the fix. I have been testing Kafka

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-02-23 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496564#comment-17496564 ] RivenSun commented on KAFKA-13422: -- Hi [~rsivaram]  [~ijuma] could you give any suggestions? Thanks.  

[jira] [Commented] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496563#comment-17496563 ] RivenSun commented on KAFKA-13689: -- Hi [~showuon]  , [~guozhang]  Could you give any suggestions?

[GitHub] [kafka] dengziming commented on a change in pull request #11784: KAFKA-13228; Ensure ApiVersionRequest is properly handled KRaft co-resident mode

2022-02-23 Thread GitBox
dengziming commented on a change in pull request #11784: URL: https://github.com/apache/kafka/pull/11784#discussion_r812650014 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -209,6 +211,11 @@ class BrokerServer( val controllerNodes =

[jira] [Updated] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun updated KAFKA-13689: - Description: h1. 1.Example KafkaClient version is 3.1.0, KafkaProducer init properties:   {code:java}

[jira] [Created] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-02-23 Thread RivenSun (Jira)
RivenSun created KAFKA-13689: Summary: AbstractConfig log print information is incorrect Key: KAFKA-13689 URL: https://issues.apache.org/jira/browse/KAFKA-13689 Project: Kafka Issue Type: Bug

[GitHub] [kafka] dengziming commented on a change in pull request #11784: KAFKA-13228; Ensure ApiVersionRequest is properly handled KRaft co-resident mode

2022-02-23 Thread GitBox
dengziming commented on a change in pull request #11784: URL: https://github.com/apache/kafka/pull/11784#discussion_r812644858 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -68,28 +67,14 @@ object AlterIsrManager { * Factory to AlterIsr based