[GitHub] [kafka] dengziming commented on pull request #12170: KAFKA-13875 Adjusted the output the topic describe output to include TopicID & se…

2022-05-16 Thread GitBox
dengziming commented on PR #12170: URL: https://github.com/apache/kafka/pull/12170#issuecomment-1128442992 It's OK to add topicId in the docs, the segment.bytes property is not intended to be printed, this seems to be a small bug: KAFKA-13718 -- This is an automated message from the

[GitHub] [kafka] dengziming commented on pull request #12109: KAFKA-13863: Prevent null config value when create topic in KRaft mode

2022-05-16 Thread GitBox
dengziming commented on PR #12109: URL: https://github.com/apache/kafka/pull/12109#issuecomment-1128357555 Resolve conflicts, and I also changed `ZkAdminManager.createTopics` to throw `ConfigException` on null config values. -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (KAFKA-13907) Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable

2022-05-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13907: -- Labels: newbie (was: ) > Fix hanging

[GitHub] [kafka] dengziming commented on pull request #12165: KAFKA-13905: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
dengziming commented on PR #12165: URL: https://github.com/apache/kafka/pull/12165#issuecomment-1128348174 Thank you @showuon @hachikuji, I changed the assertion and disabled `testCleanShutdownWithKRaftControllerUnavailable ` and created KAFKA-13907 for this bug. For

[jira] [Created] (KAFKA-13907) Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable

2022-05-16 Thread dengziming (Jira)
dengziming created KAFKA-13907: -- Summary: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable Key: KAFKA-13907 URL: https://issues.apache.org/jira/browse/KAFKA-13907 Project:

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-05-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537882#comment-17537882 ] Luke Chen commented on KAFKA-12495: --- No problem, [~mcabrera] ! > Unbalanced connectors/tasks

[GitHub] [kafka] bozhao12 commented on a diff in pull request #12158: MINOR:A few code cleanUps in KafkaController

2022-05-16 Thread GitBox
bozhao12 commented on code in PR #12158: URL: https://github.com/apache/kafka/pull/12158#discussion_r874295581 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -468,14 +468,6 @@ class KafkaController(val config: KafkaConfig, // shutdown leader

[GitHub] [kafka] showuon commented on pull request #12165: KAFKA-13905: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
showuon commented on PR #12165: URL: https://github.com/apache/kafka/pull/12165#issuecomment-1128325494 @dengziming , I'd suggest we follow @hachikuji 's advice to add an `assertCause` to fix the failed tests. I can create another JIRA to address our thoughts in this comment:

[GitHub] [kafka] hachikuji opened a new pull request, #12171: MINOR: Convert admin integration tests

2022-05-16 Thread GitBox
hachikuji opened a new pull request, #12171: URL: https://github.com/apache/kafka/pull/12171 This patch enables KRaft support in `PlaintextAdminIntegrationTest`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[jira] [Comment Edited] (KAFKA-13867) Improve JavaDoc for MetadataVersion.java

2022-05-16 Thread Kvicii.Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537864#comment-17537864 ] Kvicii.Yu edited comment on KAFKA-13867 at 5/17/22 1:24 AM: [~cmccabe] hi,

[jira] [Commented] (KAFKA-13867) Improve JavaDoc for MetadataVersion.java

2022-05-16 Thread Kvicii.Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537864#comment-17537864 ] Kvicii.Yu commented on KAFKA-13867: --- [~cmccabe] hi, My understanding is to just modify the method name

[GitHub] [kafka] mjsax commented on pull request #12137: MINOR: Consolidate StreamsException and TaskCorruptedException

2022-05-16 Thread GitBox
mjsax commented on PR #12137: URL: https://github.com/apache/kafka/pull/12137#issuecomment-1128295416 > Avoiding the public API change seems quite hacky to me I leave it up to you -- it's only a small KIP so if you want to do it, just go for it -- personally, I don't see much benefit

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2022-05-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537860#comment-17537860 ] Matthias J. Sax commented on KAFKA-6520: It's still an open item – and it's complex (for details,

[GitHub] [kafka] hachikuji commented on pull request #12162: KAFKA-13899: Use INVALID_CONFIG error code consistently in AlterConfig APIs

2022-05-16 Thread GitBox
hachikuji commented on PR #12162: URL: https://github.com/apache/kafka/pull/12162#issuecomment-1128281035 @dengziming By the way, KAFKA-13609 seems to apply to broker configurations. Similarly, I do not think we need a KIP since INVALID_CONFIG is already used by these APIs. -- This is

[jira] [Resolved] (KAFKA-13899) Inconsistent error codes returned from AlterConfig APIs

2022-05-16 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13899. - Fix Version/s: 3.2.1 Resolution: Fixed > Inconsistent error codes returned from

[GitHub] [kafka] hachikuji merged pull request #12162: KAFKA-13899: Use INVALID_CONFIG error code consistently in AlterConfig APIs

2022-05-16 Thread GitBox
hachikuji merged PR #12162: URL: https://github.com/apache/kafka/pull/12162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-16 Thread GitBox
cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r874258218 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -108,7 +108,8 @@ class KafkaRaftManager[T]( time: Time, metrics: Metrics, threadNamePrefixOpt:

[jira] [Comment Edited] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2022-05-16 Thread Karthik Raman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537647#comment-17537647 ] Karthik Raman edited comment on KAFKA-6520 at 5/17/22 12:26 AM: [~mjsax]

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-16 Thread GitBox
cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r874257133 ## clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java: ## @@ -91,19 +95,11 @@ public static NodeApiVersions create(short apiKey, short minVersion,

[GitHub] [kafka] Moovlin commented on pull request #12170: KAFKA-13875 Adjusted the output the topic describe output to include TopicID & se…

2022-05-16 Thread GitBox
Moovlin commented on PR #12170: URL: https://github.com/apache/kafka/pull/12170#issuecomment-1128249740 There are no code changes in this PR. It's an update to the quickstart.html file so I think these tests failures can be ignored. This is only my second PR so please let me know if I have

[GitHub] [kafka] hachikuji commented on a diff in pull request #12138: MINOR: Followers should not have any remote replica states left over from previous leadership

2022-05-16 Thread GitBox
hachikuji commented on code in PR #12138: URL: https://github.com/apache/kafka/pull/12138#discussion_r874209109 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -578,7 +579,8 @@ class Partition(val topicPartition: TopicPartition, // Updating the assignment and

[GitHub] [kafka] hachikuji commented on a diff in pull request #12165: KAFKA-13905: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
hachikuji commented on code in PR #12165: URL: https://github.com/apache/kafka/pull/12165#discussion_r874198037 ## core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala: ## @@ -195,8 +195,9 @@ class ServerShutdownTest extends KafkaServerTestHarness { // identify

[GitHub] [kafka] rittikaadhikari commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-16 Thread GitBox
rittikaadhikari commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r874121554 ## core/src/main/scala/kafka/server/ReplicaFetcherBlockingSend.scala: ## @@ -124,4 +124,8 @@ class ReplicaFetcherBlockingSend(sourceBroker: BrokerEndPoint,

[GitHub] [kafka] rittikaadhikari commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-16 Thread GitBox
rittikaadhikari commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r874120703 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] rittikaadhikari commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-16 Thread GitBox
rittikaadhikari commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r874118991 ## checkstyle/suppressions.xml: ## @@ -309,7 +309,7 @@ files="(RemoteLogManagerConfig).java"/> -

[GitHub] [kafka] kowshik commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-05-16 Thread GitBox
kowshik commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r874090550 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] Moovlin opened a new pull request, #12170: KAFKA-13875 Adjusted the output the topic describe output to include TopicID & se…

2022-05-16 Thread GitBox
Moovlin opened a new pull request, #12170: URL: https://github.com/apache/kafka/pull/12170 …gment.bytes *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: Fix stuck SSL tests in case of authentication failure

2022-05-16 Thread GitBox
fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r874001986 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -449,9 +450,9 @@ public void close() { @Test public void

[GitHub] [kafka] mjsax opened a new pull request, #12169: MINOR: improve description of `commit.interval.ms` config

2022-05-16 Thread GitBox
mjsax opened a new pull request, #12169: URL: https://github.com/apache/kafka/pull/12169 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] hachikuji commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2022-05-16 Thread GitBox
hachikuji commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r874042264 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1292,8 +1292,10 @@ public void handleResponse(AbstractResponse

[GitHub] [kafka] mumrah opened a new pull request, #12168: Minor: Remove extraneous code in LocalLogManager

2022-05-16 Thread GitBox
mumrah opened a new pull request, #12168: URL: https://github.com/apache/kafka/pull/12168 Looks like this was some left over test code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: Fix stuck SSL tests in case of authentication failure

2022-05-16 Thread GitBox
fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r874001986 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -449,9 +450,9 @@ public void close() { @Test public void

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: Fix stuck SSL tests in case of authentication failure

2022-05-16 Thread GitBox
fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r874001986 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -449,9 +450,9 @@ public void close() { @Test public void

[GitHub] [kafka] hachikuji commented on a diff in pull request #12158: MINOR:A few code cleanUps in KafkaController

2022-05-16 Thread GitBox
hachikuji commented on code in PR #12158: URL: https://github.com/apache/kafka/pull/12158#discussion_r873958800 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -468,14 +468,6 @@ class KafkaController(val config: KafkaConfig, // shutdown leader

[jira] [Comment Edited] (KAFKA-13716) add tests for `DeleteRecordsCommand` class

2022-05-16 Thread Richard Joerger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537654#comment-17537654 ] Richard Joerger edited comment on KAFKA-13716 at 5/16/22 4:53 PM: --

[jira] [Commented] (KAFKA-13716) add tests for `DeleteRecordsCommand` class

2022-05-16 Thread Richard Joerger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537654#comment-17537654 ] Richard Joerger commented on KAFKA-13716: - Since we hadn't heard from Shivanjal, I went ahead

[jira] [Comment Edited] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2022-05-16 Thread Karthik Raman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537647#comment-17537647 ] Karthik Raman edited comment on KAFKA-6520 at 5/16/22 4:46 PM: --- [~mjsax] /

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2022-05-16 Thread Karthik Raman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537647#comment-17537647 ] Karthik Raman commented on KAFKA-6520: -- [~mjsax] / [~Yohan123] : Just wondering if there is any

[GitHub] [kafka] hachikuji merged pull request #12153: MINOR: Clarify impact of num.replica.fetchers

2022-05-16 Thread GitBox
hachikuji merged PR #12153: URL: https://github.com/apache/kafka/pull/12153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hachikuji commented on pull request #12162: KAFKA-13899: Use INVALID_CONFIG error code consistently in AlterConfig APIs

2022-05-16 Thread GitBox
hachikuji commented on PR #12162: URL: https://github.com/apache/kafka/pull/12162#issuecomment-1127889552 @dengziming I am thinking not. We already raise INVALID_CONFIG in some cases and it was documented explicitly in at least the IncrementalAlterConfig KIP. -- This is an automated

[GitHub] [kafka] Moovlin opened a new pull request, #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…

2022-05-16 Thread GitBox
Moovlin opened a new pull request, #12167: URL: https://github.com/apache/kafka/pull/12167 …eleteRecordsCommand. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-05-16 Thread Manuel Garcia Cabrera (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537612#comment-17537612 ] Manuel Garcia Cabrera commented on KAFKA-12495: --- [~showuon] I'm short on time right now,

[GitHub] [kafka] mimaison commented on pull request #10644: [KAFKA-12635] auto sync consumer offset 0 when translated offset larger than partition end offset

2022-05-16 Thread GitBox
mimaison commented on PR #10644: URL: https://github.com/apache/kafka/pull/10644#issuecomment-1127837181 Closing, this issue has been fixed in https://github.com/apache/kafka/pull/11748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mimaison closed pull request #10644: [KAFKA-12635] auto sync consumer offset 0 when translated offset larger than partition end offset

2022-05-16 Thread GitBox
mimaison closed pull request #10644: [KAFKA-12635] auto sync consumer offset 0 when translated offset larger than partition end offset URL: https://github.com/apache/kafka/pull/10644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

2022-05-16 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-12635. Fix Version/s: 3.3.0 Assignee: Mickael Maison (was: Ning Zhang)

[GitHub] [kafka] mimaison merged pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-16 Thread GitBox
mimaison merged PR #11748: URL: https://github.com/apache/kafka/pull/11748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-16 Thread GitBox
mimaison commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r873878544 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -169,6 +172,7 @@ public String version() { return

[GitHub] [kafka] qingwei91 commented on a diff in pull request #12166: KAFKA-13817 Always sync nextTimeToEmit with wall clock

2022-05-16 Thread GitBox
qingwei91 commented on code in PR #12166: URL: https://github.com/apache/kafka/pull/12166#discussion_r873762061 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -226,9 +226,10 @@ private void emitNonJoinedOuterRecords(

[GitHub] [kafka] qingwei91 opened a new pull request, #12166: KAFKA-13817 Always sync nextTimeToEmit with wall clock

2022-05-16 Thread GitBox
qingwei91 opened a new pull request, #12166: URL: https://github.com/apache/kafka/pull/12166 We should sync nextTimeToEmit with wall clock on each method call to ensure throttling works correctly in case of clock drift. If we dont, then in the event of significant clock drift, throttling

[GitHub] [kafka] showuon commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-16 Thread GitBox
showuon commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r873739814 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -319,27 +319,21 @@ public void

[jira] [Updated] (KAFKA-13906) Invalid replica state transition

2022-05-16 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-13906: Labels: BUG controller replication reproducible-bug (was: BUG controller) > Invalid replica

[jira] [Updated] (KAFKA-13906) Invalid replica state transition

2022-05-16 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-13906: Labels: BUG controller (was: reproducible-bug) > Invalid replica state transition >

[jira] [Updated] (KAFKA-8366) partitions of topics being deleted show up in the offline partitions metric

2022-05-16 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-8366: --- Component/s: controller core metrics > partitions of topics being

[jira] [Updated] (KAFKA-8366) partitions of topics being deleted show up in the offline partitions metric

2022-05-16 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-8366: --- Issue Type: Bug (was: Improvement) > partitions of topics being deleted show up in the offline

[jira] [Updated] (KAFKA-8366) partitions of topics being deleted show up in the offline partitions metric

2022-05-16 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-8366: --- Labels: BUG controller metrics reproducible-bug (was: BUG controller metrics) > partitions of

[jira] [Created] (KAFKA-13906) Invalid replica state transition

2022-05-16 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-13906: --- Summary: Invalid replica state transition Key: KAFKA-13906 URL: https://issues.apache.org/jira/browse/KAFKA-13906 Project: Kafka Issue Type: Bug

[GitHub] [kafka] mimaison commented on pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

2022-05-16 Thread GitBox
mimaison commented on PR #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-1127619143 Thanks, that makes sense. I've started reviewing #11780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] mimaison commented on pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-16 Thread GitBox
mimaison commented on PR #11748: URL: https://github.com/apache/kafka/pull/11748#issuecomment-1127616971 Thanks for the review @showuon. I've replied to your questions and pushed an update. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mimaison commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-16 Thread GitBox
mimaison commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r873670168 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -526,6 +520,65 @@ public void

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12159: Fix stuck SSL tests in case of authentication failure

2022-05-16 Thread GitBox
divijvaidya commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r873646603 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -449,9 +450,9 @@ public void close() { @Test public void

[GitHub] [kafka] franz1981 commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

2022-05-16 Thread GitBox
franz1981 commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r873652472 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -30,6 +33,18 @@ */ public final class Checksums { +private static final

[jira] [Updated] (KAFKA-8366) partitions of topics being deleted show up in the offline partitions metric

2022-05-16 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-8366: --- Affects Version/s: 3.1.1 3.0.1 3.0.0

[jira] [Commented] (KAFKA-8366) partitions of topics being deleted show up in the offline partitions metric

2022-05-16 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537501#comment-17537501 ] Igor Soarez commented on KAFKA-8366: I also ran into this issue. I managed to replicate this bug with

[GitHub] [kafka] franz1981 commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

2022-05-16 Thread GitBox
franz1981 commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r873640450 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -40,11 +55,41 @@ public static void update(Checksum checksum, ByteBuffer buffer, int

[GitHub] [kafka] franz1981 commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

2022-05-16 Thread GitBox
franz1981 commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r873638337 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -40,11 +55,41 @@ public static void update(Checksum checksum, ByteBuffer buffer, int

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

2022-05-16 Thread GitBox
divijvaidya commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r873603513 ## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ## @@ -40,11 +55,41 @@ public static void update(Checksum checksum, ByteBuffer buffer, int

[GitHub] [kafka] cadonna merged pull request #12164: Update upgrade.html

2022-05-16 Thread GitBox
cadonna merged PR #12164: URL: https://github.com/apache/kafka/pull/12164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-16 Thread GitBox
mimaison commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r873606546 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -319,27 +319,21 @@ public void

[GitHub] [kafka] mimaison commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-16 Thread GitBox
mimaison commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r873586510 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -319,27 +319,21 @@ public void

[GitHub] [kafka] mimaison commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-16 Thread GitBox
mimaison commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r873584393 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -319,27 +319,21 @@ public void

[GitHub] [kafka] mimaison commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-05-16 Thread GitBox
mimaison commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r873584393 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -319,27 +319,21 @@ public void

[GitHub] [kafka] dengziming commented on a diff in pull request #12165: KAFKA-13905: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
dengziming commented on code in PR #12165: URL: https://github.com/apache/kafka/pull/12165#discussion_r873557577 ## core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala: ## @@ -195,8 +195,9 @@ class ServerShutdownTest extends KafkaServerTestHarness { //

[GitHub] [kafka] showuon commented on a diff in pull request #12165: KAFKA-13905: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
showuon commented on code in PR #12165: URL: https://github.com/apache/kafka/pull/12165#discussion_r873525802 ## core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala: ## @@ -195,8 +195,9 @@ class ServerShutdownTest extends KafkaServerTestHarness { // identify

[GitHub] [kafka] dengziming commented on a diff in pull request #12165: KAFKA-13905: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
dengziming commented on code in PR #12165: URL: https://github.com/apache/kafka/pull/12165#discussion_r873512570 ## core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala: ## @@ -195,8 +195,9 @@ class ServerShutdownTest extends KafkaServerTestHarness { //

[GitHub] [kafka] dengziming commented on a diff in pull request #12165: MINOR: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
dengziming commented on code in PR #12165: URL: https://github.com/apache/kafka/pull/12165#discussion_r873512570 ## core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala: ## @@ -195,8 +195,9 @@ class ServerShutdownTest extends KafkaServerTestHarness { //

[GitHub] [kafka] dengziming commented on a diff in pull request #12165: MINOR: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
dengziming commented on code in PR #12165: URL: https://github.com/apache/kafka/pull/12165#discussion_r873512570 ## core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala: ## @@ -195,8 +195,9 @@ class ServerShutdownTest extends KafkaServerTestHarness { //

[jira] [Created] (KAFKA-13905) Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13905: - Summary: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs Key: KAFKA-13905 URL: https://issues.apache.org/jira/browse/KAFKA-13905

[GitHub] [kafka] showuon commented on pull request #12165: MINOR: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
showuon commented on PR #12165: URL: https://github.com/apache/kafka/pull/12165#issuecomment-1127413805 Also, I've created [KAFKA-13905](https://issues.apache.org/jira/browse/KAFKA-13905) for this issue. Please link the PR to that issue, in case there are also other people try to fix it

[GitHub] [kafka] showuon commented on a diff in pull request #12165: MINOR: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
showuon commented on code in PR #12165: URL: https://github.com/apache/kafka/pull/12165#discussion_r873488369 ## core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala: ## @@ -195,8 +195,9 @@ class ServerShutdownTest extends KafkaServerTestHarness { // identify

[GitHub] [kafka] dengziming commented on pull request #12165: MINOR: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
dengziming commented on PR #12165: URL: https://github.com/apache/kafka/pull/12165#issuecomment-1127393942 Hello @cmccabe, PTAL at this solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] dengziming opened a new pull request, #12165: MINOR: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

2022-05-16 Thread GitBox
dengziming opened a new pull request, #12165: URL: https://github.com/apache/kafka/pull/12165 *More detailed description of your change* Before #11969, We will throw an `ExecutionException(KafkaStorageException)` in `BrokerServer.startup`, and the outside ExecutionException is removed in

[GitHub] [kafka] showuon merged pull request #12087: KAFKA-13851: Add integration tests for DeleteRecords API

2022-05-16 Thread GitBox
showuon merged PR #12087: URL: https://github.com/apache/kafka/pull/12087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #12087: KAFKA-13851: Add integration tests for DeleteRecords API

2022-05-16 Thread GitBox
showuon commented on PR #12087: URL: https://github.com/apache/kafka/pull/12087#issuecomment-1127340235 All tests passed. Merge into trunk. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] showuon commented on a diff in pull request #12140: KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS

2022-05-16 Thread GitBox
showuon commented on code in PR #12140: URL: https://github.com/apache/kafka/pull/12140#discussion_r873420698 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java: ## @@ -488,6 +489,54 @@ public void

[jira] [Resolved] (KAFKA-12703) Allow unencrypted private keys when using PEM files

2022-05-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-12703. - Fix Version/s: 3.3.0 Resolution: Fixed > Allow unencrypted private keys when using PEM

[jira] [Updated] (KAFKA-12703) Allow unencrypted private keys when using PEM files

2022-05-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-12703: Summary: Allow unencrypted private keys when using PEM files (was: Unencrypted PEM files can't

[GitHub] [kafka] dajac merged pull request #11916: KAFKA-12703; Allow unencrypted private keys when using PEM files

2022-05-16 Thread GitBox
dajac merged PR #11916: URL: https://github.com/apache/kafka/pull/11916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (KAFKA-7955) Provide a BOM for EmbeddedConnectCluster and EmbeddedCluster

2022-05-16 Thread Richard Fussenegger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537373#comment-17537373 ] Richard Fussenegger edited comment on KAFKA-7955 at 5/16/22 7:15 AM: -

[jira] [Commented] (KAFKA-9060) Publish BOMs for Kafka

2022-05-16 Thread Richard Fussenegger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537374#comment-17537374 ] Richard Fussenegger commented on KAFKA-9060: In

[jira] [Commented] (KAFKA-7955) Provide a BOM for EmbeddedConnectCluster and EmbeddedCluster

2022-05-16 Thread Richard Fussenegger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537373#comment-17537373 ] Richard Fussenegger commented on KAFKA-7955: https://issues.apache.org/jira/browse/KAFKA-9060