[
https://issues.apache.org/jira/browse/KAFKA-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-13880.
---
Fix Version/s: 3.3.0
Assignee: Guozhang Wang
Resolution: Fixed
>
guozhangwang merged PR #12304:
URL: https://github.com/apache/kafka/pull/12304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jnh5y commented on PR #12298:
URL: https://github.com/apache/kafka/pull/12298#issuecomment-1159323680
> @jnh5y Have you been able to come up with a unit test?
I have not yet; I'm traveling a little bit. Don't let me hold up progress;
I'll make an effort to get to it next week.
--
[
https://issues.apache.org/jira/browse/KAFKA-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555781#comment-17555781
]
Matthias J. Sax commented on KAFKA-13531:
-
Could be. We usually also report if we say more
[
https://issues.apache.org/jira/browse/KAFKA-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-13531.
-
Resolution: Cannot Reproduce
> Flaky test NamedTopologyIntegrationTest
>
[
https://issues.apache.org/jira/browse/KAFKA-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14007:
--
Summary: Connect header converters are never closed (was: Connect header
converters never
C0urante commented on code in PR #11781:
URL: https://github.com/apache/kafka/pull/11781#discussion_r900544587
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -16,56 +16,325 @@
*/
package
philipnee commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r900530199
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1292,8 +1296,12 @@ public void handleResponse(AbstractResponse
hachikuji commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r900524288
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1292,8 +1296,12 @@ public void handleResponse(AbstractResponse
C0urante commented on PR #11781:
URL: https://github.com/apache/kafka/pull/11781#issuecomment-1159226471
I've completed the remaining follow-up tasks.
### Audit of resource allocation and cleanup:
- Documented ownership expectations more clearly with the `KafkaBasedLog`
and
Chris Egerton created KAFKA-14007:
-
Summary: Connect header converters never closed
Key: KAFKA-14007
URL: https://issues.apache.org/jira/browse/KAFKA-14007
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555698#comment-17555698
]
Kyle R Stehbens edited comment on KAFKA-13840 at 6/17/22 8:08 PM:
--
andymg3 opened a new pull request, #12305:
URL: https://github.com/apache/kafka/pull/12305
### Details
- Adds the new KRaft `__cluster_metadata` topic to `INTERNAL_TOPICS` which
tracks internal topics
### Committer Checklist (excluded from commit message)
- [ ] Verify design
franz1981 commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900375199
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555698#comment-17555698
]
Kyle R Stehbens commented on KAFKA-13840:
-
Sure, looks like the same kind of of co-coordinator
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555698#comment-17555698
]
Kyle R Stehbens edited comment on KAFKA-13840 at 6/17/22 4:42 PM:
--
guozhangwang commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r900315653
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -286,6 +308,7 @@ public void
guozhangwang commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r900314537
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -290,6 +295,34 @@ private void addTaskToRestoredTasks(final
guozhangwang commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r900314064
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -69,15 +77,27 @@ class DefaultStateUpdaterTest {
guozhangwang commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r900313777
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -69,15 +77,27 @@ class DefaultStateUpdaterTest {
guozhangwang commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r900312281
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -290,6 +295,34 @@ private void addTaskToRestoredTasks(final
dajac commented on PR #12298:
URL: https://github.com/apache/kafka/pull/12298#issuecomment-1159032033
@jnh5y Have you been able to come up with a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
divijvaidya commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r900281799
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -162,79 +163,82 @@ private static FilterResult filterTo(TopicPartition
partition,
divijvaidya commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r900273507
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java:
##
@@ -567,12 +577,12 @@ private boolean flushNetOutBuffer()
divijvaidya commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r900273174
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -809,6 +810,13 @@ private void maybeCloseOldestConnection(long
currentTimeNanos) {
ijuma commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900196059
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
[
https://issues.apache.org/jira/browse/KAFKA-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-13890.
Fix Version/s: 3.3.0
Assignee: RivenSun
Resolution: Fixed
> Improve
mimaison merged PR #12226:
URL: https://github.com/apache/kafka/pull/12226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
franz1981 commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900173675
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
franz1981 commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900173675
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
franz1981 commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900172822
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
franz1981 commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900172822
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
ijuma commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900170120
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
franz1981 commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900167550
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
ijuma commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r900167678
##
clients/src/main/java/org/apache/kafka/common/protocol/types/CompactArrayOf.java:
##
@@ -119,7 +119,7 @@ public Object[] validate(Object item) {
ijuma commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r900166671
##
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java:
##
@@ -308,7 +308,7 @@ protected Record readNext(long baseOffset, long
baseTimestamp,
ijuma commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r900165661
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java:
##
@@ -326,7 +326,7 @@ static String formatRequestBody(String
franz1981 commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900164891
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
ijuma commented on code in PR #12230:
URL: https://github.com/apache/kafka/pull/12230#discussion_r900163290
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -463,8 +463,7 @@ public static T newParameterizedInstance(String
className, Object... params)
ijuma commented on PR #12194:
URL: https://github.com/apache/kafka/pull/12194#issuecomment-1158913451
I would also change the processor log to move the "Processor 0" part into
the prefix. The log message would be "Listening to new connection from...".
--
This is an automated message from
ijuma commented on PR #12194:
URL: https://github.com/apache/kafka/pull/12194#issuecomment-1158911152
Thanks for the PR. The log context is meant to encapsulate properties. If we
want to include `SocketServer` there, it would ideally follow the key=value
convention.
--
This is an
ijuma commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900153506
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+private static final Logger
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-13736:
-
Labels: flakey flaky-test (was: flakey)
> Flaky
divijvaidya commented on code in PR #12272:
URL: https://github.com/apache/kafka/pull/12272#discussion_r899967565
##
examples/README:
##
@@ -9,4 +9,4 @@ To run the demo:
this means we are starting 3 EOS instances with 6 topic partitions and
5 pre-populated records.
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1158708791
> Yes, kafka is unaffacted by it now, but it could be affected in the
future.
The fix for this has already been merged into Scala and it will be included
in the 2.12.17
mdedetrich commented on PR #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-1158695092
@showuon @tombentley @mimaison Since KIP-797 has the necessary amount of
binding votes this PR is now ready to be reviewed.
--
This is an automated message from the Apache Git
pjmagee commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1158681036
Would I be correct with the following example too?
```
{
"transforms" : "TransformSchema",
"transforms.TransformSchema.type" :
pjmagee commented on code in PR #11442:
URL: https://github.com/apache/kafka/pull/11442#discussion_r899937599
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java:
##
@@ -35,29 +37,34 @@
private static final Logger log =
[
https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew de Detrich updated KAFKA-6527:
--
Labels: flakey (was: )
> Transient failure in
[
https://issues.apache.org/jira/browse/KAFKA-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew de Detrich updated KAFKA-13897:
---
Labels: flakey (was: )
> Add 3.1.1 to system tests and streams upgrade tests
>
[
https://issues.apache.org/jira/browse/KAFKA-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew de Detrich updated KAFKA-13897:
---
Labels: (was: flakey)
> Add 3.1.1 to system tests and streams upgrade tests
>
[
https://issues.apache.org/jira/browse/KAFKA-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew de Detrich updated KAFKA-8280:
--
Labels: flakey (was: )
> Flaky Test
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew de Detrich updated KAFKA-13736:
---
Labels: flakey (was: )
> Flaky
[
https://issues.apache.org/jira/browse/KAFKA-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555483#comment-17555483
]
Marten Richert edited comment on KAFKA-7205 at 6/17/22 8:58 AM:
Here is
[
https://issues.apache.org/jira/browse/KAFKA-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555483#comment-17555483
]
Marten Richert edited comment on KAFKA-7205 at 6/17/22 8:57 AM:
Here is a
[
https://issues.apache.org/jira/browse/KAFKA-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555483#comment-17555483
]
Marten Richert commented on KAFKA-7205:
---
Here is a patch against todays trunk:
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899850723
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -286,6 +308,7 @@ public void
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899854007
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -290,6 +295,34 @@ private void addTaskToRestoredTasks(final
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899850723
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -286,6 +308,7 @@ public void
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899841232
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -69,15 +77,27 @@ class DefaultStateUpdaterTest {
private
RivenSun2 commented on PR #12226:
URL: https://github.com/apache/kafka/pull/12226#issuecomment-1158580834
Hi @mimaison could we merge this PR?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899842750
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -290,6 +295,34 @@ private void addTaskToRestoredTasks(final
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899842750
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -290,6 +295,34 @@ private void addTaskToRestoredTasks(final
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899841693
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -69,15 +77,27 @@ class DefaultStateUpdaterTest {
private
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899841693
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -69,15 +77,27 @@ class DefaultStateUpdaterTest {
private
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899841232
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -69,15 +77,27 @@ class DefaultStateUpdaterTest {
private
[
https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555390#comment-17555390
]
Shawn Wang edited comment on KAFKA-13419 at 6/17/22 6:12 AM:
-
Hi [~showuon]
[
https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555390#comment-17555390
]
Shawn Wang edited comment on KAFKA-13419 at 6/17/22 6:12 AM:
-
Hi [~showuon]
[
https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555390#comment-17555390
]
Shawn Wang commented on KAFKA-13419:
Hi [~showuon]
After i applied this fix and my previous change
[
https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555390#comment-17555390
]
Shawn Wang edited comment on KAFKA-13419 at 6/17/22 6:11 AM:
-
Hi [~showuon]
70 matches
Mail list logo
