philipnee opened a new pull request, #12580:
URL: https://github.com/apache/kafka/pull/12580
We are observing flakiness in the OffsetValidationTest, and I believe
(evidently) it is due to not handling the uncommitted offset during the
rebalancing. Here the fix is very simple, commit the of
showuon commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1233663013
Thank you @jsancio ! As long as the system test passed, I'm good to merge
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
[
https://issues.apache.org/jira/browse/KAFKA-13990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming resolved KAFKA-13990.
Resolution: Fixed
> Update features will fail in KRaft mode
>
cmccabe commented on code in PR #12578:
URL: https://github.com/apache/kafka/pull/12578#discussion_r960059546
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -248,33 +249,44 @@ private void
incrementalAlterConfigResource(ConfigResou
[
https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598637#comment-17598637
]
Jose Armando Garcia Sancio commented on KAFKA-12622:
Thanks for the
jsancio commented on PR #12579:
URL: https://github.com/apache/kafka/pull/12579#issuecomment-1233424449
@mimaison @vvcephei are you able to take a look at this PR? Much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
jsancio opened a new pull request, #12579:
URL: https://github.com/apache/kafka/pull/12579
The following commands don't show any missings licenses
```
$ ./gradlewAll clean releaseTarGz
$ tar xzf core/build/distributions/kafka_2.13-3.3.0-SNAPSHOT.tgz
$ cd kafka_2.13-3.3.0-SNAPSHOT/
rondagostino opened a new pull request, #12578:
URL: https://github.com/apache/kafka/pull/12578
https://github.com/apache/kafka/pull/12374 adjusted the invocation of the
alter configs policy check in KRaft to match the behavior in ZooKeeper, which
is to only provide the configs that were ex
C0urante merged PR #12576:
URL: https://github.com/apache/kafka/pull/12576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jsancio commented on PR #12039:
URL: https://github.com/apache/kafka/pull/12039#issuecomment-1233386184
Let's see if @omkreddy or @rajinisivaram are interested in reviewing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
agavra commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r959892207
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {
cadonna merged PR #12569:
URL: https://github.com/apache/kafka/pull/12569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #12569:
URL: https://github.com/apache/kafka/pull/12569#issuecomment-1233290152
@guozhangwang As discussed yesterday, I will merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
cadonna commented on code in PR #12569:
URL: https://github.com/apache/kafka/pull/12569#discussion_r959907923
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1180,6 +1182,68 @@ void shutdown(final boolean clean) {
}
}
cadonna commented on PR #12569:
URL: https://github.com/apache/kafka/pull/12569#issuecomment-1233289415
Build failures are unrelated:
```
Build / JDK 11 and Scala 2.13 /
kafka.api.TransactionsExpirationTest.testTransactionAfterProducerIdExpires(String).quorum=zk
Build / JDK 8 and Sc
cmccabe commented on PR #12294:
URL: https://github.com/apache/kafka/pull/12294#issuecomment-1233288601
So, the reason we didn't notice this bug earlier is that it doesn't affect
single-node clusters. And in the multi-node ducktape test that I wrote, the
upgrade command was failing but we d
cmccabe merged PR #12294:
URL: https://github.com/apache/kafka/pull/12294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
C0urante commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r959706989
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -307,9 +309,31 @@ ClusterAssignment performTask
jsancio closed pull request #12212: Kafka 13888 new fields
URL: https://github.com/apache/kafka/pull/12212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
jsancio commented on PR #12212:
URL: https://github.com/apache/kafka/pull/12212#issuecomment-1233257452
@lqjack I am closing the PR. It looks like this issue was fixed by
https://github.com/apache/kafka/pull/12206 and
https://github.com/apache/kafka/pull/12508
--
This is an automated mes
jsancio commented on PR #12414:
URL: https://github.com/apache/kafka/pull/12414#issuecomment-1233255286
> Hi @jsancio, I have reverted the changes made to `RaftClient` and kept the
logging withing `BrokerMetadataSnapshotter` and `QuorumController`
>
> I have two questions, would reall
guozhangwang commented on code in PR #12519:
URL: https://github.com/apache/kafka/pull/12519#discussion_r959853208
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TasksRegistry.java:
##
@@ -57,10 +57,10 @@ public interface TasksRegistry {
void addNew
jsancio commented on code in PR #12414:
URL: https://github.com/apache/kafka/pull/12414#discussion_r959867602
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -119,16 +120,29 @@ class BrokerMetadataListener(
}
_bytesSinceLastSnapsh
[
https://issues.apache.org/jira/browse/KAFKA-13990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13990:
-
Priority: Blocker (was: Major)
> Update features will fail in KRaft mode
>
niket-goel commented on PR #12212:
URL: https://github.com/apache/kafka/pull/12212#issuecomment-1233227011
The following PR https://github.com/apache/kafka/pull/12508 implements this
functionality. This PR can be closed.
--
This is an automated message from the Apache Git Service.
To resp
guozhangwang commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r959844687
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMe
guozhangwang commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r959834484
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +362,95 @@ private void mergeDuplicateSourceNodes() {
[
https://issues.apache.org/jira/browse/KAFKA-14193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14193:
---
Affects Version/s: 3.3.0
> Connect system test ConnectRestApiTest is
[
https://issues.apache.org/jira/browse/KAFKA-14193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14193:
---
Fix Version/s: 3.3.0
> Connect system test ConnectRestApiTest is fai
jsancio commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1233200113
> @jsancio We can't access the Jenkins URL you shared (`This page is only
accessible by Confluent employees on corporate VPN.`). It would be great to get
this into 3.3 if you can, having
[
https://issues.apache.org/jira/browse/KAFKA-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14143:
---
Affects Version/s: 3.3.0
> Exactly-once source system tests
> --
[
https://issues.apache.org/jira/browse/KAFKA-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14143:
---
Fix Version/s: 3.3.0
> Exactly-once source system tests
> --
cmccabe commented on PR #12294:
URL: https://github.com/apache/kafka/pull/12294#issuecomment-1233178487
Thanks for finding this, @dengziming . It is a great find and definitely a
3.3 blocker.
Two comments:
* ZK brokers should not expose metadata.version (they should have a
sup
mimaison commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1233174679
@jsancio We can't access the Jenkins URL you shared (`This page is only
accessible by Confluent employees on corporate VPN.`). It would be great to get
this into 3.3 if you can, having s
jsancio commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1233133033
@showuon and @C0urante here is the system test job
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5109/ not
sure if you are authorized to see the job.
@yashmayya
jsancio commented on PR #11775:
URL: https://github.com/apache/kafka/pull/11775#issuecomment-1233132205
@showuon and @C0urante here is the system test job
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5109/ not
sure if you are authorized to see the job.
@yashmayya
[
https://issues.apache.org/jira/browse/KAFKA-13990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13990:
---
Affects Version/s: 3.3.0
> Update features will fail in KRaft mode
>
[
https://issues.apache.org/jira/browse/KAFKA-13990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13990:
---
Fix Version/s: 3.3.0
> Update features will fail in KRaft mode
> ---
jsancio commented on code in PR #12294:
URL: https://github.com/apache/kafka/pull/12294#discussion_r959749618
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -832,4 +833,31 @@ class KRaftClusterTest {
}
}
+
+ @Test
+ def testUpdateMetada
[
https://issues.apache.org/jira/browse/KAFKA-13401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598405#comment-17598405
]
Omnia Ibrahim commented on KAFKA-13401:
---
PR is here
[https://github.com/apache/ka
[
https://issues.apache.org/jira/browse/KAFKA-13401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim updated KAFKA-13401:
--
Fix Version/s: 3.4.0
> Introduce a new Interface to manage Kafka resources in MM2
> --
OmniaGM opened a new pull request, #12577:
URL: https://github.com/apache/kafka/pull/12577
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
C0urante commented on code in PR #12543:
URL: https://github.com/apache/kafka/pull/12543#discussion_r959610302
##
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala:
##
@@ -490,6 +490,58 @@ class ControllerIntegrationTest extends QuorumTestHarness {
C0urante commented on code in PR #12543:
URL: https://github.com/apache/kafka/pull/12543#discussion_r959610302
##
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala:
##
@@ -490,6 +490,58 @@ class ControllerIntegrationTest extends QuorumTestHarness {
C0urante commented on PR #12575:
URL: https://github.com/apache/kafka/pull/12575#issuecomment-1232935220
This is already addressed in https://github.com/apache/kafka/pull/11783. I'm
not sure we can backport that to the 3.3 release branch but I'd like to try
given that it has a few other low
vamossagar12 commented on PR #12512:
URL: https://github.com/apache/kafka/pull/12512#issuecomment-1232887757
@guozhangwang let me know when the KIP changes are done and this could be
re-worked upon..
--
This is an automated message from the Apache Git Service.
To respond to the message, p
[
https://issues.apache.org/jira/browse/KAFKA-14153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao reassigned KAFKA-14153:
-
Assignee: Sagar Rao
> UnknownTopicOrPartitionException should include the topic/partition in th
vamossagar12 commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1232878652
Also, I have made the changes to use the existing delay/scheduledRebalance
mechanism to delay the revocation. cc @showuon , @C0urante
--
This is an automated message from the Apac
vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r959527478
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -307,9 +307,31 @@ ClusterAssignment perform
vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r959526920
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -285,18 +292,11 @@ ClusterAssignment perfor
songnon commented on PR #12543:
URL: https://github.com/apache/kafka/pull/12543#issuecomment-1232861959
> Should we also add a test case for when the leader election takes place on
the same topic as the one undergoing reassignment?
@C0urante Added a new test case. Could you have a loo
[
https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598338#comment-17598338
]
Ivan Yurchenko commented on KAFKA-13077:
[~mrMigles] could you check the timesta
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r959392484
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +362,95 @@ private void mergeDuplicateSourceNodes() {
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r959328394
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMetada
[
https://issues.apache.org/jira/browse/KAFKA-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov reassigned KAFKA-12878:
---
Assignee: Nikolay Izhikov (was: Neil Buesing)
> Support --bootstrap-server kafka-s
[
https://issues.apache.org/jira/browse/KAFKA-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov reassigned KAFKA-12899:
---
Assignee: Dongjin Lee (was: Nikolay Izhikov)
> Support --bootstrap-server in Repli
[
https://issues.apache.org/jira/browse/KAFKA-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov reassigned KAFKA-12899:
---
Assignee: Nikolay Izhikov (was: Dongjin Lee)
> Support --bootstrap-server in Repli
yashmayya commented on PR #12576:
URL: https://github.com/apache/kafka/pull/12576#issuecomment-1232639522
@C0urante since you also reviewed
https://github.com/apache/kafka/pull/12450, could you please review this system
test fix whenever possible?
--
This is an automated message from the
yashmayya commented on PR #12575:
URL: https://github.com/apache/kafka/pull/12575#issuecomment-1232638498
@C0urante @jsancio could you please take a look at this whenever possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
yashmayya opened a new pull request, #12575:
URL: https://github.com/apache/kafka/pull/12575
-
[ConnectRestApiTest](https://github.com/apache/kafka/blob/trunk/tests/kafkatest/tests/connect/connect_rest_test.py)
is currently failing on `trunk` and `3.3` with the following assertion error:
yashmayya opened a new pull request, #12576:
URL: https://github.com/apache/kafka/pull/12576
-
[ConnectRestApiTest](https://github.com/apache/kafka/blob/trunk/tests/kafkatest/tests/connect/connect_rest_test.py)
is currently failing on `trunk` and `3.3` with the following assertion error:
cadonna commented on code in PR #12519:
URL: https://github.com/apache/kafka/pull/12519#discussion_r959304723
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -872,14 +872,92 @@ public void shouldHandleMultipleRestoredTasks() {
Yash Mayya created KAFKA-14193:
--
Summary: Connect system test ConnectRestApiTest is failing
Key: KAFKA-14193
URL: https://issues.apache.org/jira/browse/KAFKA-14193
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-13908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598233#comment-17598233
]
Nikolay Izhikov commented on KAFKA-13908:
-
Hello, [~showuon].
I open PR for thi
nizhikov opened a new pull request, #12574:
URL: https://github.com/apache/kafka/pull/12574
Rethrow `ExecutionException` instead of wrapping it in `RuntimeException`.
It will preserve original cause in method-wide catch block:
```
} catch {
case e: Throwable =>
[
https://issues.apache.org/jira/browse/KAFKA-13908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov reassigned KAFKA-13908:
---
Assignee: Nikolay Izhikov (was: Richard Joerger)
> RuntimeException will be thrown
Bruno Cadonna created KAFKA-14192:
-
Summary: Move registering and unregistering changelogs to state
updater
Key: KAFKA-14192
URL: https://issues.apache.org/jira/browse/KAFKA-14192
Project: Kafka
cadonna commented on PR #12573:
URL: https://github.com/apache/kafka/pull/12573#issuecomment-1232554297
Call for review: @wcarlson5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cadonna opened a new pull request, #12573:
URL: https://github.com/apache/kafka/pull/12573
Changelogs are already unregistered when tasks are closed.
There is no need to also unregister them in the state
updater.
In future, when we will only have the state updater without
the
[
https://issues.apache.org/jira/browse/KAFKA-14182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598215#comment-17598215
]
Luke Chen commented on KAFKA-14182:
---
Good to know! Thanks.
> KRaft and ACL + GSSAPI
>
showuon commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1232549663
Still working on it. Hope we can get the results this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
[
https://issues.apache.org/jira/browse/KAFKA-14182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598214#comment-17598214
]
Svyatoslav commented on KAFKA-14182:
[~showuon] but when i had changed back to 3.2 v
showuon merged PR #12059:
URL: https://github.com/apache/kafka/pull/12059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #12059:
URL: https://github.com/apache/kafka/pull/12059#issuecomment-1232544863
Failed test is unrelated.
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testConnectorBoundary
```
--
This is an auto
[
https://issues.apache.org/jira/browse/KAFKA-14182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598209#comment-17598209
]
Luke Chen commented on KAFKA-14182:
---
[~rykovsi] , yes, the AuthorizerNotReadyException
75 matches
Mail list logo
