[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

2022-09-14 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17605087#comment-17605087 ] Christo Lolov commented on KAFKA-14132: --- Hello [~ChrisEgerton]! I have followed the colour-coding

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

2022-09-14 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14132: -- Description: {color:#de350b}Some of the tests below use EasyMock as well. For those migrate

[jira] [Resolved] (KAFKA-14156) Built-in partitioner may create suboptimal batches with large linger.ms

2022-09-14 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-14156. - Assignee: Artem Livshits Resolution: Fixed Merged the PR to 3.3 and trunk. > Built-in

[GitHub] [kafka] junrao merged pull request #12570: KAFKA-14156: Built-in partitioner may create suboptimal batches

2022-09-14 Thread GitBox
junrao merged PR #12570: URL: https://github.com/apache/kafka/pull/12570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14234) /admin/delete_topics is not in the list of zookeeper watchers

2022-09-14 Thread Yan Xue (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Xue updated KAFKA-14234: Description: I deployed the Kafka cluster on Kuberentes and am trying to figure out how topic deletion

[jira] [Created] (KAFKA-14234) /admin/delete_topics is not in the list of zookeeper watchers

2022-09-14 Thread Yan Xue (Jira)
Yan Xue created KAFKA-14234: --- Summary: /admin/delete_topics is not in the list of zookeeper watchers Key: KAFKA-14234 URL: https://issues.apache.org/jira/browse/KAFKA-14234 Project: Kafka Issue

[GitHub] [kafka] lihaosky commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
lihaosky commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r971383169 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRegister.java: ## @@ -31,6 +33,8 @@ public interface ChangelogRegister { */

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971319874 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -138,6 +139,15 @@ public List authorize( return results; }

[GitHub] [kafka] mumrah commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
mumrah commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971306933 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -138,6 +139,15 @@ public List authorize( return results; }

[GitHub] [kafka] artemlivshits commented on pull request #12570: KAFKA-14156: Built-in partitioner may create suboptimal batches

2022-09-14 Thread GitBox
artemlivshits commented on PR #12570: URL: https://github.com/apache/kafka/pull/12570#issuecomment-1247321505 Looked through the failed tests -- seem unrelated (also ran locally - pass). -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971280735 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -182,59 +174,58 @@ StandardAuthorizerData copyWithNewConfig(int

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971280346 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -182,59 +174,58 @@ StandardAuthorizerData copyWithNewConfig(int

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971279173 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -138,6 +139,15 @@ public List authorize( return results; }

[jira] [Commented] (KAFKA-6221) ReplicaFetcherThread throws UnknownTopicOrPartitionException on topic creation

2022-09-14 Thread Idrissi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604951#comment-17604951 ] Idrissi commented on KAFKA-6221: Hello , i am facing the same problem with the following message : *

[jira] [Comment Edited] (KAFKA-6221) ReplicaFetcherThread throws UnknownTopicOrPartitionException on topic creation

2022-09-14 Thread Idrissi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604951#comment-17604951 ] Idrissi edited comment on KAFKA-6221 at 9/14/22 8:18 PM: - Hello , i am facing the

[jira] [Comment Edited] (KAFKA-6221) ReplicaFetcherThread throws UnknownTopicOrPartitionException on topic creation

2022-09-14 Thread Idrissi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604951#comment-17604951 ] Idrissi edited comment on KAFKA-6221 at 9/14/22 8:18 PM: - Hello , i am facing the

[GitHub] [kafka] jolshan opened a new pull request, #12643: KAFKA-14097: make producer ID expiration a dynamic config

2022-09-14 Thread GitBox
jolshan opened a new pull request, #12643: URL: https://github.com/apache/kafka/pull/12643 Changed the integer value for producer ID expiration to a dynamically configurable value. Tested that the configuration can be changed dynamically and works as expected. I considered

[GitHub] [kafka] cmccabe commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r971205378 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] cmccabe commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r971204480 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] cmccabe commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r971203656 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] cmccabe commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r971203144 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] cmccabe commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r971201992 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] cmccabe commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r971201651 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] jsancio opened a new pull request, #12642: KAFKA-14207; KRaft Operations documentation

2022-09-14 Thread GitBox
jsancio opened a new pull request, #12642: URL: https://github.com/apache/kafka/pull/12642 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] abbccdda closed pull request #10156: KAFKA-10345: File watch store reloading

2022-09-14 Thread GitBox
abbccdda closed pull request #10156: KAFKA-10345: File watch store reloading URL: https://github.com/apache/kafka/pull/10156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] gitlw commented on pull request #12634: KAFKA-14225: Fix deadlock caused by lazy val exemptSensor

2022-09-14 Thread GitBox
gitlw commented on PR #12634: URL: https://github.com/apache/kafka/pull/12634#issuecomment-1247113089 rerun tests please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-14 Thread GitBox
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1247109394 I've checked tests failure. Looks like they are not related to the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mumrah commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
mumrah commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971116340 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -182,59 +174,58 @@ StandardAuthorizerData copyWithNewConfig(int nodeId,

[GitHub] [kafka] mumrah commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
mumrah commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971108745 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -96,18 +97,16 @@ public void completeInitialLoad(Exception e) { }

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
akhileshchg commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971088491 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -109,14 +110,9 @@ public class StandardAuthorizerData {

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12570: KAFKA-14156: Built-in partitioner may create suboptimal batches

2022-09-14 Thread GitBox
artemlivshits commented on code in PR #12570: URL: https://github.com/apache/kafka/pull/12570#discussion_r971097010 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -1129,31 +1129,34 @@ public void

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971095900 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -182,59 +173,58 @@ StandardAuthorizerData copyWithNewConfig(int

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2022-09-14 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604862#comment-17604862 ] Nicholas Telford commented on KAFKA-10635: -- Hi [~guozhang], I've managed to pull some logs

[jira] [Updated] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2022-09-14 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated KAFKA-10635: - Attachment: logs.csv > Streams application fails with OutOfOrderSequenceException after

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971094152 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -96,18 +97,16 @@ public void completeInitialLoad(Exception e) { }

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971092861 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -109,14 +110,9 @@ public class StandardAuthorizerData { private

[GitHub] [kafka] cmccabe commented on pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
cmccabe commented on PR #12636: URL: https://github.com/apache/kafka/pull/12636#issuecomment-1247070076 Jenkins went down again. :( ``` java.nio.file.FileSystemException: /home/jenkins/workspace/Kafka_kafka-pr_PR-12636: No space left on device ``` -- This is an automated

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971091182 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -96,18 +97,16 @@ public void completeInitialLoad(Exception e) { }

[GitHub] [kafka] vpapavas opened a new pull request, #12641: KAFKA-14209 : Change Topology optimization to accept list of rules 1/3

2022-09-14 Thread GitBox
vpapavas opened a new pull request, #12641: URL: https://github.com/apache/kafka/pull/12641 This PR is part of a series implementing the self-join rewriting. As part of it, we decided to clean up the `TOPOLOGY_OPTIMIZATION_CONFIG` and make it a list of optimization rules. Acceptable

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
guozhangwang commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r971076310 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -575,8 +584,10 @@ public void close() throws

[GitHub] [kafka] divijvaidya commented on pull request #12639: KAFKA-14233: do not init managers twice to avoid resource leak

2022-09-14 Thread GitBox
divijvaidya commented on PR #12639: URL: https://github.com/apache/kafka/pull/12639#issuecomment-1247027848 Wow! Great deep dive to find the root cause here @showuon  I am curious, how did you narrow down that `Gradle Test Executor 128` is related to

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2022-09-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604838#comment-17604838 ] Guozhang Wang commented on KAFKA-10635: --- Hmm okay I think we'd need to reproduce this which can

[GitHub] [kafka] junrao commented on a diff in pull request #12570: KAFKA-14156: Built-in partitioner may create suboptimal batches

2022-09-14 Thread GitBox
junrao commented on code in PR #12570: URL: https://github.com/apache/kafka/pull/12570#discussion_r971047147 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -1129,31 +1129,34 @@ public void onCompletion(RecordMetadata

[GitHub] [kafka] jolshan commented on a diff in pull request #12392: KAFKA-14053: Transactional producer should bump the epoch and skip ab…

2022-09-14 Thread GitBox
jolshan commented on code in PR #12392: URL: https://github.com/apache/kafka/pull/12392#discussion_r971022152 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -2594,27 +2596,20 @@ public void testDropCommitOnBatchExpiry()

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-09-14 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r971010379 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamSelfJoin.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jsancio merged pull request #12640: MINOR; Add missing li end tag

2022-09-14 Thread GitBox
jsancio merged PR #12640: URL: https://github.com/apache/kafka/pull/12640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
mumrah commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r970977191 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -397,18 +387,34 @@ private MatchingAclRule findAclRule( return

[GitHub] [kafka] jsancio opened a new pull request, #12640: MINOR; Add missing li end tag

2022-09-14 Thread GitBox
jsancio opened a new pull request, #12640: URL: https://github.com/apache/kafka/pull/12640 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] jsancio merged pull request #12635: MINOR: Mention that kraft is production ready in upgrade notes

2022-09-14 Thread GitBox
jsancio merged PR #12635: URL: https://github.com/apache/kafka/pull/12635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-14 Thread GitBox
guozhangwang commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r970973727 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,95 @@ private void

[GitHub] [kafka] philipnee commented on pull request #12633: [Consumer Refactor] Background thread skeleton

2022-09-14 Thread GitBox
philipnee commented on PR #12633: URL: https://github.com/apache/kafka/pull/12633#issuecomment-1246909476 cc @dajac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

2022-09-14 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604794#comment-17604794 ] Chris Egerton commented on KAFKA-14132: --- [~christo_lolov] Any preference on how we should indicate

[jira] [Comment Edited] (KAFKA-10802) Spurious log message when starting consumers

2022-09-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604757#comment-17604757 ] François Rosière edited comment on KAFKA-10802 at 9/14/22 3:02 PM: ---

[GitHub] [kafka] C0urante merged pull request #12615: KAFKA-14132: Migrate some Connect tests from EasyMock/PowerMock to Mockito

2022-09-14 Thread GitBox
C0urante merged PR #12615: URL: https://github.com/apache/kafka/pull/12615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (KAFKA-10802) Spurious log message when starting consumers

2022-09-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604757#comment-17604757 ] François Rosière edited comment on KAFKA-10802 at 9/14/22 2:33 PM: ---

[jira] [Commented] (KAFKA-10802) Spurious log message when starting consumers

2022-09-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604757#comment-17604757 ] François Rosière commented on KAFKA-10802: -- Issue is still present when using Kafka 3.2.1.

[GitHub] [kafka] C0urante commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-09-14 Thread GitBox
C0urante commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1246858578 Hi @dplavcic, are you still working on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-14220) "partition-count" not getting updated after revocation of partitions in case of Incremental Co-operative rebalancing.

2022-09-14 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604716#comment-17604716 ] Chris Egerton commented on KAFKA-14220: --- [~kumarpritam863] this seemed like a legitimate issue; is

[GitHub] [kafka] vpapavas commented on a diff in pull request #12555: Optimize self-join

2022-09-14 Thread GitBox
vpapavas commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r970800187 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamSelfJoin.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vpapavas commented on a diff in pull request #12555: Optimize self-join

2022-09-14 Thread GitBox
vpapavas commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r970805661 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamSelfJoin.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] showuon commented on pull request #12639: KAFKA-14233: do not init managers twice to avoid resource leak

2022-09-14 Thread GitBox
showuon commented on PR #12639: URL: https://github.com/apache/kafka/pull/12639#issuecomment-1246762358 @hachikuji @jsancio , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] showuon opened a new pull request, #12639: KAFKA-14233: do not init managers twice to avoid resource leak

2022-09-14 Thread GitBox
showuon opened a new pull request, #12639: URL: https://github.com/apache/kafka/pull/12639 Recently, we got a lot of build failed (and terminated) with core:unitTest failure. The failed messages look like this: ``` FAILURE: Build failed with an exception. [2022-09-14T09:51:52.190Z]

[GitHub] [kafka] vpapavas commented on a diff in pull request #12555: Optimize self-join

2022-09-14 Thread GitBox
vpapavas commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r970800187 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamSelfJoin.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vpapavas commented on a diff in pull request #12555: Optimize self-join

2022-09-14 Thread GitBox
vpapavas commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r970792491 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamSelfJoin.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-14233) Jenkins build failed with task ':core:unitTest' exit value 1

2022-09-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14233: -- Description: Recently, we got a lot of build failed (and terminated) with core:unitTest failure. The

[jira] [Updated] (KAFKA-14233) Jenkins build failed with task ':core:unitTest' exit value 1

2022-09-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14233: -- Description: Recently, we got a lot of build failed (and terminated) with Failed messages look like

[jira] [Created] (KAFKA-14233) Jenkins build failed with task ':core:unitTest' exit value 1

2022-09-14 Thread Luke Chen (Jira)
Luke Chen created KAFKA-14233: - Summary: Jenkins build failed with task ':core:unitTest' exit value 1 Key: KAFKA-14233 URL: https://issues.apache.org/jira/browse/KAFKA-14233 Project: Kafka

[jira] [Updated] (KAFKA-7109) KafkaConsumer should close its incremental fetch sessions on close

2022-09-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-7109: - Fix Version/s: 3.3.1 > KafkaConsumer should close its incremental fetch sessions on close >

[GitHub] [kafka] showuon merged pull request #11516: MINOR: Use MessageDigest equals when comparing signature

2022-09-14 Thread GitBox
showuon merged PR #11516: URL: https://github.com/apache/kafka/pull/11516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #11516: MINOR: Use MessageDigest equals when comparing signature

2022-09-14 Thread GitBox
showuon commented on PR #11516: URL: https://github.com/apache/kafka/pull/11516#issuecomment-1246713341 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / integration.kafka.server.FetchRequestBetweenDifferentIbpTest.testControllerNewToOldIBP() Build / JDK 17 and

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-14 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r970668525 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,95 @@ private void classifyTasksWithoutStateUpdater(final

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2022-09-14 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604021#comment-17604021 ] Nicholas Telford commented on KAFKA-10635: -- [~guozhang] both my Kafka brokers and all clients

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-14 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r970637424 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -103,42 +101,75 @@ public void addPendingStandbyTasksToCreate(final Map

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r970637017 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -169,7 +169,7 @@ public void addPendingActiveTaskToSuspend(final TaskId taskId)

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r970631567 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRegister.java: ## @@ -31,6 +33,8 @@ public interface ChangelogRegister { */

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r970630607 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -536,7 +543,9 @@ public void flushCache() { public void

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r970630206 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -209,7 +212,9 @@ void registerStateStores(final List allStores,

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r970629341 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -575,8 +584,10 @@ public void close() throws

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r970627977 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -406,17 +412,21 @@ private void maybeCheckpointUpdatingTasks(final

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r970626576 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -262,19 +263,19 @@ private List getTasksAndActions() {

[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna commented on code in PR #12638: URL: https://github.com/apache/kafka/pull/12638#discussion_r970625278 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -98,7 +99,7 @@ public void run() { while

[GitHub] [kafka] cadonna commented on pull request #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna commented on PR #12638: URL: https://github.com/apache/kafka/pull/12638#issuecomment-1246558345 Call for review: @wcarlson5 @lihaosky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cadonna opened a new pull request, #12638: Register and unregister changelog topics in state updater

2022-09-14 Thread GitBox
cadonna opened a new pull request, #12638: URL: https://github.com/apache/kafka/pull/12638 Registering and unregistering the changelog topics in the changelog reader outside of the state updater leads to race conditions between the stream thread and the state updater thread. Thus, this PR

[GitHub] [kafka] naanagon commented on pull request #11516: MINOR: Use MessageDigest equals when comparing signature

2022-09-14 Thread GitBox
naanagon commented on PR #11516: URL: https://github.com/apache/kafka/pull/11516#issuecomment-1246533634 @divijvaidya Thank you for your suggestion. Noted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (KAFKA-14220) "partition-count" not getting updated after revocation of partitions in case of Incremental Co-operative rebalancing.

2022-09-14 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kumar updated KAFKA-14220: - Description: (was: Issue: 
In case of the revocation of partitions, the updation of

[jira] [Resolved] (KAFKA-14220) "partition-count" not getting updated after revocation of partitions in case of Incremental Co-operative rebalancing.

2022-09-14 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kumar resolved KAFKA-14220. -- Reviewer: (was: Chris Egerton) Resolution: Abandoned > "partition-count" not getting

[jira] [Closed] (KAFKA-14220) "partition-count" not getting updated after revocation of partitions in case of Incremental Co-operative rebalancing.

2022-09-14 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kumar closed KAFKA-14220. > "partition-count" not getting updated after revocation of partitions in case > of Incremental

[jira] [Updated] (KAFKA-14220) "partition-count" not getting updated after revocation of partitions in case of Incremental Co-operative rebalancing.

2022-09-14 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kumar updated KAFKA-14220: - Flags: (was: Patch,Important) > "partition-count" not getting updated after revocation of

[jira] [Updated] (KAFKA-14220) "partition-count" not getting updated after revocation of partitions in case of Incremental Co-operative rebalancing.

2022-09-14 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kumar updated KAFKA-14220: - Labels: (was: pull-request-available) > "partition-count" not getting updated after

[jira] (KAFKA-14220) "partition-count" not getting updated after revocation of partitions in case of Incremental Co-operative rebalancing.

2022-09-14 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14220 ] Pritam Kumar deleted comment on KAFKA-14220: -- was (Author: JIRAUSER295638): The following is the patch made and verified: *https://github.com/apache/kafka/pull/12622* > "partition-count"

[jira] (KAFKA-14220) "partition-count" not getting updated after revocation of partitions in case of Incremental Co-operative rebalancing.

2022-09-14 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14220 ] Pritam Kumar deleted comment on KAFKA-14220: -- was (Author: JIRAUSER295638): https://github.com/apache/kafka/pull/12622 > "partition-count" not getting updated after revocation of

[jira] [Updated] (KAFKA-14220) "partition-count" not getting updated after revocation of partitions in case of Incremental Co-operative rebalancing.

2022-09-14 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kumar updated KAFKA-14220: - Component/s: (was: KafkaConnect) > "partition-count" not getting updated after revocation

[GitHub] [kafka] kumarpritam863 closed pull request #12622: Update WorkerSinkTask.java

2022-09-14 Thread GitBox
kumarpritam863 closed pull request #12622: Update WorkerSinkTask.java URL: https://github.com/apache/kafka/pull/12622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-14 Thread GitBox
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1246427376 @C0urante Thanks for the review. Fixed all your comments. > Should we also update the system test I doubt it. a. We have compatibility tests (which not use streams

[GitHub] [kafka] nizhikov commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-14 Thread GitBox
nizhikov commented on code in PR #12632: URL: https://github.com/apache/kafka/pull/12632#discussion_r970460345 ## docs/streams/developer-guide/app-reset-tool.html: ## @@ -84,9 +84,11 @@ Step 1: Run the application reset

[GitHub] [kafka] nizhikov commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-14 Thread GitBox
nizhikov commented on code in PR #12632: URL: https://github.com/apache/kafka/pull/12632#discussion_r970457373 ## core/src/main/scala/kafka/tools/StreamsResetter.java: ## @@ -213,8 +217,12 @@ private void parseArguments(final String[] args) { .ofType(String.class)

[GitHub] [kafka] cadonna merged pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-14 Thread GitBox
cadonna merged PR #12600: URL: https://github.com/apache/kafka/pull/12600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna commented on pull request #12600: KAFKA-10199: Suspend tasks in the state updater on revocation

2022-09-14 Thread GitBox
cadonna commented on PR #12600: URL: https://github.com/apache/kafka/pull/12600#issuecomment-1246332926 Build failures are unrelated: ``` Build / JDK 8 and Scala 2.12 / kafka.test.ClusterTestExtensionsTest.[1] Type=ZK, Name=Generated Test, MetadataVersion=3.3-IV3, Security=PLAINTEXT

[jira] [Comment Edited] (KAFKA-8115) Flaky Test CoordinatorTest#testTaskRequestWithOldStartMsGetsUpdated

2022-09-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603914#comment-17603914 ] Bruno Cadonna edited comment on KAFKA-8115 at 9/14/22 7:01 AM: --- Failed

[jira] [Commented] (KAFKA-8115) Flaky Test CoordinatorTest#testTaskRequestWithOldStartMsGetsUpdated

2022-09-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603914#comment-17603914 ] Bruno Cadonna commented on KAFKA-8115: -- Failed again on JDK17:

  1   2   >