dengziming commented on code in PR #12669:
URL: https://github.com/apache/kafka/pull/12669#discussion_r981887516
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -159,22 +158,6 @@ class PlaintextAdminIntegrationTest extends
dengziming commented on code in PR #12669:
URL: https://github.com/apache/kafka/pull/12669#discussion_r981881965
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -159,22 +158,6 @@ class PlaintextAdminIntegrationTest extends
Philip Nee created KAFKA-14264:
--
Summary: Create a coordinator class for the new implementation
Key: KAFKA-14264
URL: https://issues.apache.org/jira/browse/KAFKA-14264
Project: Kafka
Issue
philipnee commented on code in PR #12672:
URL: https://github.com/apache/kafka/pull/12672#discussion_r981877223
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerBackgroundThread.java:
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software
showuon commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1260300450
I'm going to merge this PR this week if there's no more comments. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
philipnee commented on code in PR #12672:
URL: https://github.com/apache/kafka/pull/12672#discussion_r981876990
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation
guozhangwang commented on code in PR #12644:
URL: https://github.com/apache/kafka/pull/12644#discussion_r981688919
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java:
##
@@ -92,17 +96,38 @@ public void writeToTopology(final
guozhangwang commented on code in PR #12644:
URL: https://github.com/apache/kafka/pull/12644#discussion_r981685201
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamSelfJoinTest.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software
hachikuji commented on code in PR #12634:
URL: https://github.com/apache/kafka/pull/12634#discussion_r981556802
##
core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala:
##
@@ -30,6 +30,9 @@ import scala.jdk.CollectionConverters._
object ClientRequestQuotaManager {
hachikuji merged PR #12691:
URL: https://github.com/apache/kafka/pull/12691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
David Arthur created KAFKA-14263:
Summary: Investigate flaky upgrade_test.py (missing messages)
Key: KAFKA-14263
URL: https://issues.apache.org/jira/browse/KAFKA-14263
Project: Kafka
Issue
mumrah commented on PR #12693:
URL: https://github.com/apache/kafka/pull/12693#issuecomment-1259885018
I applied this change to the 3.3 branch as part of the release validation,
here is the system test output
mumrah opened a new pull request, #12693:
URL: https://github.com/apache/kafka/pull/12693
KIP-373 added a "token requester" field to the output of
`kafka-delegation-tokens.sh`. The system test was failing since it was not
expecting this new field. This patch adds support for this field and
guozhangwang commented on PR #12659:
URL: https://github.com/apache/kafka/pull/12659#issuecomment-1259877050
After discussed with @cadonna offline, we decide to first try with the
simpler approach which let the state updater thread periodically check the
source-of-truth topology metadata
see-quick opened a new pull request, #12692:
URL: https://github.com/apache/kafka/pull/12692
This PR adds a few test cases to the Raft module (i.e., VotedStateTest,
ValidOffsetAndEpochTest, UnattachedStateTest, ResignedStateTest). I have also
removed an un-used method (i.e.,
hachikuji commented on code in PR #12669:
URL: https://github.com/apache/kafka/pull/12669#discussion_r981539256
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -169,8 +168,7 @@ class PlaintextAdminIntegrationTest extends
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1259755885
Rebased with the latest `trunk` to resolve merge conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
divijvaidya commented on PR #12590:
URL: https://github.com/apache/kafka/pull/12590#issuecomment-1259748550
@dajac this is ready for your review, whenever you get a chance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
divijvaidya commented on PR #12465:
URL: https://github.com/apache/kafka/pull/12465#issuecomment-1259747104
@cadonna this is ready for your review whenever you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
hachikuji commented on code in PR #12682:
URL: https://github.com/apache/kafka/pull/12682#discussion_r981453929
##
docs/security.html:
##
@@ -36,7 +36,136 @@ 7.2 Encryption and Authentication using SSL
+7.2 Listener
Configuration
+
+In order to secure a Kafka cluster,
[
https://issues.apache.org/jira/browse/KAFKA-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610141#comment-17610141
]
Chris Egerton commented on KAFKA-14250:
---
[~viktorsomogyi] can you confirm which version the
C0urante commented on PR #12671:
URL: https://github.com/apache/kafka/pull/12671#issuecomment-1259704922
This kind of failure shouldn't propagate beyond rebalances; we don't take
task status (running vs. failed vs. unassigned) into account after rebalances
when starting/restarting tasks.
viktorsomogyi commented on PR #12671:
URL: https://github.com/apache/kafka/pull/12671#issuecomment-1259701968
@C0urante this problem arises when `stop` is called really fast, right after
calling `start` when that is still running. I've attached a log sample to the
case but the exception
vpapavas commented on code in PR #12644:
URL: https://github.com/apache/kafka/pull/12644#discussion_r981415910
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java:
##
@@ -92,17 +96,38 @@ public void writeToTopology(final
[
https://issues.apache.org/jira/browse/KAFKA-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-14250:
Attachment: mm2.log
> Exception during normal operation in MirrorSourceTask
mimaison merged PR #12689:
URL: https://github.com/apache/kafka/pull/12689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-13187:
-
Assignee: Matthew de Detrich (was: Chris Egerton)
> Replace EasyMock and PowerMock
C0urante commented on PR #11792:
URL: https://github.com/apache/kafka/pull/11792#issuecomment-1259559178
@mdedetrich Great, thanks! I've assigned
[KAFKA-13187](https://issues.apache.org/jira/browse/KAFKA-13187) to you to let
others know that the ticket is being worked on. If you need to
[
https://issues.apache.org/jira/browse/KAFKA-13187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-13187:
-
Assignee: Chris Egerton (was: Dalibor Plavcic)
> Replace EasyMock and PowerMock with
C0urante commented on PR #11792:
URL: https://github.com/apache/kafka/pull/11792#issuecomment-1259557319
@divijvaidya I've also used the `OngoingStubbing` class to set up multiple
expectations for a mock at once. I'm not sure if it's applicable to your case,
but I found that it wasn't too
[
https://issues.apache.org/jira/browse/KAFKA-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610078#comment-17610078
]
Manikumar commented on KAFKA-14063:
---
There wont be official PR. Yes, you can pickup the commit from
ijuma commented on PR #12674:
URL: https://github.com/apache/kafka/pull/12674#issuecomment-1259463709
We could document that fetch from follower must first be enabled on the
cluster before it's enabled on the client _if_ KIP-320 is not supported by the
client.
--
This is an automated
zigarn commented on PR #12175:
URL: https://github.com/apache/kafka/pull/12175#issuecomment-1259448130
@dajac: thanks for your review, I did most of the proposed fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
urbandan commented on PR #12392:
URL: https://github.com/apache/kafka/pull/12392#issuecomment-1259383078
@dajac @hachikuji Any chance you can take a look at this? This is a painful
issue in transactional producers, with some serious consequences (partition
corruption).
--
This is an
dajac commented on PR #12674:
URL: https://github.com/apache/kafka/pull/12674#issuecomment-1259370231
@hachikuji Yeah, that's right. If a client already specifies the rack id
before the cluster sets up a replica selector, the client won't be able to
fetch until all the brokers have the
blcksrx commented on PR #12400:
URL: https://github.com/apache/kafka/pull/12400#issuecomment-1259349410
Just checking what is the status of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mdedetrich commented on PR #11792:
URL: https://github.com/apache/kafka/pull/11792#issuecomment-1259331955
I will start looking into it to see how I can help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
see-quick commented on code in PR #12689:
URL: https://github.com/apache/kafka/pull/12689#discussion_r981009538
##
core/src/test/scala/kafka/api/LeaderAndIsrTest.scala:
##
@@ -31,4 +31,56 @@ final class LeaderAndIsrTest {
assertEquals(List(3), recoveringLeaderAndIsr.isr)
Mickael Maison created KAFKA-14262:
--
Summary: Delete MirrorMaker v1
Key: KAFKA-14262
URL: https://issues.apache.org/jira/browse/KAFKA-14262
Project: Kafka
Issue Type: Task
divijvaidya commented on PR #12684:
URL: https://github.com/apache/kafka/pull/12684#issuecomment-1259199080
1. (Calling this out for completeness sake) `Instant.ofEpochMilli` is slower
than existing solution but it is worth making this change for the sake of
readability of logs. It will
divijvaidya commented on code in PR #12689:
URL: https://github.com/apache/kafka/pull/12689#discussion_r980910425
##
core/src/test/scala/kafka/api/LeaderAndIsrTest.scala:
##
@@ -31,4 +31,56 @@ final class LeaderAndIsrTest {
assertEquals(List(3), recoveringLeaderAndIsr.isr)
divijvaidya commented on PR #12669:
URL: https://github.com/apache/kafka/pull/12669#issuecomment-1259136260
@hachikuji this is ready for your review. The test failures are unrelated:
```
Build / JDK 8 and Scala 2.12 /
testTransactionAfterProducerIdExpires(String).quorum=zk –
42 matches
Mail list logo
