[
https://issues.apache.org/jira/browse/KAFKA-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715227#comment-17715227
]
Justine Olshan commented on KAFKA-14920:
I originally considered this, but we can't do it
dajac commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1518511048
> Does this PR need a KIP process? Anyone take a look?
Metrics are part of the public api. Changing or adding metrics require a KIP.
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/KAFKA-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715224#comment-17715224
]
Artem Livshits commented on KAFKA-14920:
I wonder if we could just add producer state before
artemlivshits commented on code in PR #13267:
URL: https://github.com/apache/kafka/pull/13267#discussion_r1174283192
##
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala:
##
@@ -123,73 +129,94 @@ class ZkProducerIdManager(brokerId: Int,
}
}
-
[
https://issues.apache.org/jira/browse/KAFKA-14925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715205#comment-17715205
]
ASF GitHub Bot commented on KAFKA-14925:
atu-sharm commented on PR #506:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-14925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715204#comment-17715204
]
ASF GitHub Bot commented on KAFKA-14925:
atu-sharm opened a new pull request, #506:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-14892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715193#comment-17715193
]
Jun Rao commented on KAFKA-14892:
-
Sounds good to me. Including storage in the package name probably
bmscomp opened a new pull request, #13625:
URL: https://github.com/apache/kafka/pull/13625
Upgrade Gradle wrapper to the latest stable version 8.1.1 and update the
value of property name `distributionSha256Sum`
### Committer Checklist (excluded from commit message)
- [x] Verify
[
https://issues.apache.org/jira/browse/KAFKA-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715177#comment-17715177
]
Greg Harris commented on KAFKA-8115:
We merged an attempted fix for this, but it appears that
gharris1727 commented on PR #13557:
URL: https://github.com/apache/kafka/pull/13557#issuecomment-1518351859
Looks like this might have caused some flaky failures on trunk:
https://issues.apache.org/jira/browse/KAFKA-14929
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-14929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14929:
Labels: flaky-test (was: )
> Flaky
[
https://issues.apache.org/jira/browse/KAFKA-14929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14929:
Description:
This test recently started flaky-failing with the following stack trace:
{noformat}
philipnee commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1174174040
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -250,6 +257,7 @@ public void commitAsync(OffsetCommitCallback
Greg Harris created KAFKA-14929:
---
Summary: Flaky
KafkaStatusBackingStoreFormatTest#putTopicStateRetriableFailure
Key: KAFKA-14929
URL: https://issues.apache.org/jira/browse/KAFKA-14929
Project: Kafka
hachikuji commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1169316955
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -250,6 +257,7 @@ public void commitAsync(OffsetCommitCallback
[
https://issues.apache.org/jira/browse/KAFKA-14905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat updated KAFKA-14905:
---
Fix Version/s: 3.4.1
3.6.0
> Failing tests in MM2 ForwardingAdmin test since
hachikuji commented on PR #13551:
URL: https://github.com/apache/kafka/pull/13551#issuecomment-1518292028
@cmccabe I think that case is already covered here:
https://github.com/apache/kafka/blob/trunk/generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java#L425.
The case
jlprat merged PR #13575:
URL: https://github.com/apache/kafka/pull/13575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jlprat commented on PR #13575:
URL: https://github.com/apache/kafka/pull/13575#issuecomment-1518270904
Yes, I was looking at the `rat` as well, one but I fail to see how they
would be caused in any way by the changes you made.
I seee
mjsax commented on PR #13577:
URL: https://github.com/apache/kafka/pull/13577#issuecomment-1518267444
Merged to `trunk` and cherry-picked to `3.5`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-14876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715158#comment-17715158
]
Greg Harris commented on KAFKA-14876:
-
I think the stop API is relevant to document, even without
mjsax merged PR #13577:
URL: https://github.com/apache/kafka/pull/13577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715157#comment-17715157
]
Matthias J. Sax commented on KAFKA-14722:
-
I did a PR:
gharris1727 commented on PR #13575:
URL: https://github.com/apache/kafka/pull/13575#issuecomment-1518264915
hmm some build failures from `rat` like in #13315 but I don't think this PR
is related. And the JDK17 build failed due to streams upgrade tests.
--
This is an automated message
jlprat commented on code in PR #13575:
URL: https://github.com/apache/kafka/pull/13575#discussion_r1174097520
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeForwardingAdminWithLocalMetadata.java:
##
@@ -38,16 +38,13 @@
import
szalapski commented on PR #5876:
URL: https://github.com/apache/kafka/pull/5876#issuecomment-1518174551
@rhauch Any idea how to move this along?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gharris1727 commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1173998391
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -139,10 +171,103 @@ public void close() {
protected void
gharris1727 commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1173998391
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -139,10 +171,103 @@ public void close() {
protected void
gharris1727 commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1173998391
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -139,10 +171,103 @@ public void close() {
protected void
gharris1727 commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1173998391
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -139,10 +171,103 @@ public void close() {
protected void
[
https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14666:
Fix Version/s: 3.5.0
> MM2 should translate consumer group offsets behind replication flow
>
[
https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14666:
Affects Version/s: (was: 3.5.0)
> MM2 should translate consumer group offsets behind
gharris1727 commented on code in PR #13575:
URL: https://github.com/apache/kafka/pull/13575#discussion_r1173979163
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeForwardingAdminWithLocalMetadata.java:
##
@@ -38,16 +38,13 @@
import
dajac commented on PR #13602:
URL: https://github.com/apache/kafka/pull/13602#issuecomment-1518070622
@jeffkbkim Could you please rebase this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac merged PR #13598:
URL: https://github.com/apache/kafka/pull/13598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on PR #13598:
URL: https://github.com/apache/kafka/pull/13598#issuecomment-1518069951
I could not get a successful build because there is always an `Timeout
waiting to lock zinc-1.3.5_2.12.15_8 compiler cache` error. However, two builds
combines give us a good signal:
*
[
https://issues.apache.org/jira/browse/KAFKA-14720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Federico Valeri updated KAFKA-14720:
Fix Version/s: 3.5.0
> KIP-906: Tools migration guidelines
>
[
https://issues.apache.org/jira/browse/KAFKA-14633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14633:
-
Attachment: flamegraph-pr-heapalloc-after.html
ruslankrivoshein commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1518054816
Yes, since it's WIP and I have questions, I left original files.
Well, I'll take a look at `ClusterTestExtensions` and will try to figure out
more about testing there.
--
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715053#comment-17715053
]
ASF GitHub Bot commented on KAFKA-10883:
machi1990 commented on PR #504:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715054#comment-17715054
]
ASF GitHub Bot commented on KAFKA-10883:
machi1990 closed pull request #504: KAFKA-10883: link
rvansa commented on PR #13619:
URL: https://github.com/apache/kafka/pull/13619#issuecomment-1517992031
@Hangleton You're right, this process should be repeated; for example in the
JDK itself we flush DNS caches before checkpoint. I was hoping that the code in
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manyanda Chitimbo updated KAFKA-10883:
--
Description:
The get-started page: [https://kafka.apache.org/get-started] currently
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manyanda Chitimbo updated KAFKA-10883:
--
Description:
The get-started page: [https://kafka.apache.org/get-started] currently
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manyanda Chitimbo updated KAFKA-10883:
--
Description:
The get-started page: [https://kafka.apache.org/get-started] currently
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manyanda Chitimbo updated KAFKA-10883:
--
Summary: Properly finish the "get-started.html" page and link in in the top
dajac commented on PR #13603:
URL: https://github.com/apache/kafka/pull/13603#issuecomment-1517975471
@jeffkbkim Could you please rebase this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-12826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715047#comment-17715047
]
Josep Prat commented on KAFKA-12826:
Unfortunately, this task can't be taken just yet. It can only
dajac merged PR #13599:
URL: https://github.com/apache/kafka/pull/13599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-12826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715044#comment-17715044
]
shiqin.lan commented on KAFKA-12826:
Class org.apache.kafka.streams.scala.Serdes was deprecated in
[
https://issues.apache.org/jira/browse/KAFKA-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715041#comment-17715041
]
Alexandre Dupriez edited comment on KAFKA-14928 at 4/21/23 2:55 PM:
[
https://issues.apache.org/jira/browse/KAFKA-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715041#comment-17715041
]
Alexandre Dupriez commented on KAFKA-14928:
---
Hi Divij, thanks for reporting this. Would you
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715040#comment-17715040
]
ASF GitHub Bot commented on KAFKA-10883:
mimaison commented on PR #504:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-14652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban updated KAFKA-14652:
-
Summary: Improve MM2 logging by adding the flow information to the context
(KIP-916) (was:
machi1990 commented on code in PR #13623:
URL: https://github.com/apache/kafka/pull/13623#discussion_r1173855980
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig,
*/
def shutdown(): Unit = {
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715035#comment-17715035
]
ASF GitHub Bot commented on KAFKA-10883:
machi1990 commented on PR #504:
URL:
Divij Vaidya created KAFKA-14928:
Summary: Metrics collection contends on lock with log cleaning
Key: KAFKA-14928
URL: https://issues.apache.org/jira/browse/KAFKA-14928
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Daines updated KAFKA-14927:
--
Description:
Using {{kafka-configs}} should validate dynamic configurations before applying.
Justin Daines created KAFKA-14927:
-
Summary: Dynamic configs not validated when using kafka-configs
and --add-config-file
Key: KAFKA-14927
URL: https://issues.apache.org/jira/browse/KAFKA-14927
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715010#comment-17715010
]
Mickael Maison commented on KAFKA-14722:
Have the docs updates been merged? Or is anyone working
jlprat commented on code in PR #13575:
URL: https://github.com/apache/kafka/pull/13575#discussion_r1173773831
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeForwardingAdminWithLocalMetadata.java:
##
@@ -38,16 +38,13 @@
import
machi1990 commented on PR #13624:
URL: https://github.com/apache/kafka/pull/13624#issuecomment-1517844646
Hi @guozhangwang @ableegoldman would you mind giving this a look when you've
some time? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715008#comment-17715008
]
ASF GitHub Bot commented on KAFKA-10883:
mimaison commented on PR #504:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715005#comment-17715005
]
Manyanda Chitimbo commented on KAFKA-10883:
---
I've opened a PR
machi1990 commented on PR #13612:
URL: https://github.com/apache/kafka/pull/13612#issuecomment-1517827939
Thanks for the review @jlprat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
machi1990 opened a new pull request, #13624:
URL: https://github.com/apache/kafka/pull/13624
The field is not used so can be removed.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
[
https://issues.apache.org/jira/browse/KAFKA-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714998#comment-17714998
]
ASF GitHub Bot commented on KAFKA-10883:
machi1990 opened a new pull request, #504:
URL:
urbandan commented on code in PR #13475:
URL: https://github.com/apache/kafka/pull/13475#discussion_r1173744877
##
config/connect-mirror-maker.properties:
##
@@ -57,3 +57,6 @@ config.storage.replication.factor=1
# replication.policy.separator = _
# sync.topic.acls.enabled =
[
https://issues.apache.org/jira/browse/KAFKA-14926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14926:
-
Issue Type: Improvement (was: Bug)
> Remove metrics on Log Cleaner shutdown
>
jlprat merged PR #13612:
URL: https://github.com/apache/kafka/pull/13612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya opened a new pull request, #13623:
URL: https://github.com/apache/kafka/pull/13623
# Motivation
When Log cleaning is shutdown, it doesn't remove metrics that were
registered to `KafkaYammerMetrics.defaultRegistry()` which has one instance per
server. Log cleaner's lifecycle
viktorsomogyi commented on code in PR #13475:
URL: https://github.com/apache/kafka/pull/13475#discussion_r1173739241
##
config/connect-mirror-maker.properties:
##
@@ -57,3 +57,6 @@ config.storage.replication.factor=1
# replication.policy.separator = _
#
Divij Vaidya created KAFKA-14926:
Summary: Remove metrics on Log Cleaner shutdown
Key: KAFKA-14926
URL: https://issues.apache.org/jira/browse/KAFKA-14926
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-12826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shiqin.lan reassigned KAFKA-12826:
--
Assignee: shiqin.lan
> Remove Deprecated Class Serdes (Streams)
>
[
https://issues.apache.org/jira/browse/KAFKA-12826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shiqin.lan reassigned KAFKA-12826:
--
Assignee: (was: shiqin.lan)
> Remove Deprecated Class Serdes (Streams)
>
dajac merged PR #13604:
URL: https://github.com/apache/kafka/pull/13604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on PR #13601:
URL: https://github.com/apache/kafka/pull/13601#issuecomment-1517708744
@jeffkbkim Could you please rebase this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac commented on PR #13600:
URL: https://github.com/apache/kafka/pull/13600#issuecomment-1517708617
@jeffkbkim Could you please rebase this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac merged PR #13597:
URL: https://github.com/apache/kafka/pull/13597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac merged PR #13596:
URL: https://github.com/apache/kafka/pull/13596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1517696428
Thanks @yashmayya . I just tried to include only the ones which have a
similar pattern. I think `SourceTaskOffsetCommitter` is something which can
also be modified but I missed
dajac commented on code in PR #13538:
URL: https://github.com/apache/kafka/pull/13538#discussion_r1173669055
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java:
##
@@ -0,0 +1,613 @@
+/*
+ * Licensed to the Apache Software
Hangleton commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1173645096
##
metadata/src/main/java/org/apache/kafka/metadata/authorizer/AclCache.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Hangleton commented on PR #13619:
URL: https://github.com/apache/kafka/pull/13619#issuecomment-1517679958
Hi, Radim,
Thank you for the follow-up and clarifying, I missed the fact that the
targeted components are the Kafka clients.
Some of the previous statements regarding
Hangleton commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1173645096
##
metadata/src/main/java/org/apache/kafka/metadata/authorizer/AclCache.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/KAFKA-14925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714923#comment-17714923
]
Mickael Maison commented on KAFKA-14925:
Done
> The website shouldn't load external resources
>
[
https://issues.apache.org/jira/browse/KAFKA-14925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-14925:
--
Assignee: Atul Sharma
> The website shouldn't load external resources
>
[
https://issues.apache.org/jira/browse/KAFKA-14925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714920#comment-17714920
]
Atul Sharma commented on KAFKA-14925:
-
Want to work on this, can someone assign to me?
> The
dajac merged PR #13537:
URL: https://github.com/apache/kafka/pull/13537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac merged PR #13555:
URL: https://github.com/apache/kafka/pull/13555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on code in PR #13514:
URL: https://github.com/apache/kafka/pull/13514#discussion_r1173486311
##
examples/src/main/java/kafka/examples/Consumer.java:
##
@@ -21,97 +21,120 @@
import org.apache.kafka.clients.consumer.ConsumerRecord;
import
omkreddy merged PR #13437:
URL: https://github.com/apache/kafka/pull/13437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
omkreddy commented on PR #13437:
URL: https://github.com/apache/kafka/pull/13437#issuecomment-1517476396
Test failures are known connect/mirror failures:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13437/12/tests
--
This is an automated message from
clolov commented on PR #13621:
URL: https://github.com/apache/kafka/pull/13621#issuecomment-1517474714
I believe the related test failures are due to the same problem as
https://github.com/apache/kafka/pull/13529#discussion_r1168432918. Once that PR
is merged and this one is rebased those
[
https://issues.apache.org/jira/browse/KAFKA-14807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714861#comment-17714861
]
Zhaoli commented on KAFKA-14807:
[~durban] Thanks, but we use dedicated mode.
> MirrorMaker2 config
showuon commented on code in PR #13459:
URL: https://github.com/apache/kafka/pull/13459#discussion_r1173462823
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
urbandan commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1173450470
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -139,10 +171,103 @@ public void close() {
protected void
urbandan commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1173450470
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -139,10 +171,103 @@ public void close() {
protected void
urbandan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1173405147
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -968,13 +968,31 @@ private void transitionTo(State target) {
emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1173353923
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -68,7 +68,7 @@ public void
100 matches
Mail list logo
