satishd merged PR #14330:
URL: https://github.com/apache/kafka/pull/14330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #14330:
URL: https://github.com/apache/kafka/pull/14330#issuecomment-1710357878
There are a few test failures unrelated to this change. Merging it to trunk
and 3.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
nizhikov commented on PR #14217:
URL: https://github.com/apache/kafka/pull/14217#issuecomment-1710353468
Hello @gharris1727
Is there anything I can do to get this PR merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
satishd merged PR #14352:
URL: https://github.com/apache/kafka/pull/14352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #14352:
URL: https://github.com/apache/kafka/pull/14352#issuecomment-1710350430
There are a few test failures unrelated to this change. Merging it to trunk
and 3.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
divijvaidya commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1315541873
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -110,12 +111,12 @@ public class RemoteIndexCache implements Closeable {
jeffkbkim commented on code in PR #14147:
URL: https://github.com/apache/kafka/pull/14147#discussion_r1318764218
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2930,72 +2930,86 @@ public CoordinatorResult genericGroupLeave
zhaohaidao commented on PR #14271:
URL: https://github.com/apache/kafka/pull/14271#issuecomment-1710321306
> @zhaohaidao There is a bunch of conflicts with `trunk`. Could you please
fix them?
@dajac hi, I have resolved conflicts with trunk and address your comments.
could you pls con
[
https://issues.apache.org/jira/browse/KAFKA-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14273:
---
Affects Version/s: 3.5.1
3.4.1
> Kafka doesn'
[
https://issues.apache.org/jira/browse/KAFKA-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14273:
---
Affects Version/s: (was: 3.4.1)
(was:
dajac merged PR #14124:
URL: https://github.com/apache/kafka/pull/14124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
zhaohaidao commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1318751801
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -420,6 +422,23 @@ public Group group(String groupId, long comm
C0urante commented on code in PR #14314:
URL: https://github.com/apache/kafka/pull/14314#discussion_r1318748685
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -5634,16 +5637,31 @@ public void testListOffsetsMetadataNonRetriableErrors()
jsancio commented on code in PR #12763:
URL: https://github.com/apache/kafka/pull/12763#discussion_r1318749537
##
raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java:
##
@@ -149,6 +149,7 @@ private void writeElectionStateToFile(final File stateFile,
QuorumStateDat
zhaohaidao commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1318745164
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -428,9 +432,51 @@ public CompletableFuture
listGroups(
C0urante commented on code in PR #14314:
URL: https://github.com/apache/kafka/pull/14314#discussion_r1318720780
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategy.java:
##
@@ -72,6 +79,12 @@ private void handleTopicError(
) {
[
https://issues.apache.org/jira/browse/KAFKA-15352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762768#comment-17762768
]
Divij Vaidya commented on KAFKA-15352:
--
PR:
[https://github.com/apache/kafka/pull/
[
https://issues.apache.org/jira/browse/KAFKA-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15351:
-
Labels: KIP-405 (was: )
> Update log-start-offset after leader election for topics enabled with
C0urante commented on PR #14314:
URL: https://github.com/apache/kafka/pull/14314#issuecomment-1710273707
No worries about the delay, thanks for continuing to work on this @jolshan!
> Given that we moved the retries to TopicAdmin::retryEndOffsets does this
mean there is not any known w
[
https://issues.apache.org/jira/browse/KAFKA-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762766#comment-17762766
]
Divij Vaidya commented on KAFKA-15351:
--
Case 1 is fixed by [https://github.com/apac
dajac commented on code in PR #14353:
URL: https://github.com/apache/kafka/pull/14353#discussion_r1318715231
##
core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala:
##
@@ -14,233 +14,532 @@
* See the License for the specific language governing permissions and
dajac commented on code in PR #14353:
URL: https://github.com/apache/kafka/pull/14353#discussion_r1318712684
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1494,6 +1494,8 @@ class KafkaApis(val requestChannel: RequestChannel,
requestContext,
new Offset
dajac opened a new pull request, #14353:
URL: https://github.com/apache/kafka/pull/14353
This patch adds integration tests for the OffsetCommit API and the
OffsetFetch API. The tests runs against the old and the new group coordinator
and with the new and the old consumer rebalance protocol.
divijvaidya merged PR #14340:
URL: https://github.com/apache/kafka/pull/14340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
C0urante commented on PR #14313:
URL: https://github.com/apache/kafka/pull/14313#issuecomment-1710250787
@philipnee I'm curious about the other tests as well. From what I could
tell, the distinguishing factor is the use of a `MockTime` instance that has a
non-zero auto-tick, in conjunction
divijvaidya commented on PR #14340:
URL: https://github.com/apache/kafka/pull/14340#issuecomment-1710245344
Unrelated test failures:
```
[Build / JDK 17 and Scala 2.13 /
kafka.server.DescribeClusterRequestTest.testDescribeClusterRequestIncludingClusterAuthorizedOperations(String).quoru
C0urante commented on code in PR #14313:
URL: https://github.com/apache/kafka/pull/14313#discussion_r1318694288
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java:
##
@@ -286,11 +286,16 @@ public static NewTopicBuilder defineTopic(String
topicName) {
[
https://issues.apache.org/jira/browse/KAFKA-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762760#comment-17762760
]
Divij Vaidya commented on KAFKA-15351:
--
[~ckamal] adding to case 1
step 5, one of
viktorsomogyi commented on PR #13975:
URL: https://github.com/apache/kafka/pull/13975#issuecomment-1710236138
@cmccabe would you please take a look when you have some time or could you
please suggest a reviewer?
--
This is an automated message from the Apache Git Service.
To respond to th
lianetm commented on code in PR #14323:
URL: https://github.com/apache/kafka/pull/14323#discussion_r1318665973
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation
lianetm commented on code in PR #14323:
URL: https://github.com/apache/kafka/pull/14323#discussion_r1318655049
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762750#comment-17762750
]
David Arthur commented on KAFKA-15411:
--
This could be related to the recent Metadat
lianetm commented on code in PR #14323:
URL: https://github.com/apache/kafka/pull/14323#discussion_r1318645607
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
lianetm commented on code in PR #14323:
URL: https://github.com/apache/kafka/pull/14323#discussion_r1318635008
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
ruslankrivoshein commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1710177527
> update the description to list your changes
@dengziming or @fvaleri, could you clarify it to me, please?
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762735#comment-17762735
]
Atul Jain commented on KAFKA-14597:
---
Hi [~talestonini] , [~cadonna],
Please ignore my
clolov commented on PR #14255:
URL: https://github.com/apache/kafka/pull/14255#issuecomment-1710110932
Polite ping @olalamichelle - I will wait until mid next week and then I will
start opening new pull requests targeting these files as I would like to
double-down on the effort to finish th
[
https://issues.apache.org/jira/browse/KAFKA-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana reassigned KAFKA-14993:
--
Assignee: Abhijeet Kumar (was: Kamal Chandraprakash)
> Improve TransactionIndex inst
clolov commented on code in PR #14305:
URL: https://github.com/apache/kafka/pull/14305#discussion_r1318543584
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -639,9 +639,9 @@ private void maybeOverrideClientId(Map
configs) {
}
showuon commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318551914
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegment
[
https://issues.apache.org/jira/browse/KAFKA-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-14993:
--
Description:
RSM should throw a ResourceNotFoundException if it does not have
TransactionIndex. Curre
satishd commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318539662
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegment
divijvaidya commented on code in PR #14349:
URL: https://github.com/apache/kafka/pull/14349#discussion_r1318506043
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -818,56 +818,51 @@ public
RemoteLogRetentionHandler(Optional retentionSizeData,
yashmayya commented on code in PR #14279:
URL: https://github.com/apache/kafka/pull/14279#discussion_r1318447034
##
connect/file/src/test/java/org/apache/kafka/connect/file/integration/FileStreamSinkConnectorIntegrationTest.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apac
showuon commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318426217
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegment
showuon commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318426217
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegment
showuon commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318425718
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegment
kamalcph commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318418335
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegmen
kamalcph commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318413354
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegmen
satishd commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318410493
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegment
[
https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762676#comment-17762676
]
Victor van den Hoven edited comment on KAFKA-15417 at 9/7/23 9:46 AM:
[
https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762676#comment-17762676
]
Victor van den Hoven commented on KAFKA-15417:
--
Yes, I think it was incorre
[
https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762673#comment-17762673
]
Luke Chen commented on KAFKA-15402:
---
Maybe this issue can be workaround in your test e
[
https://issues.apache.org/jira/browse/KAFKA-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana reassigned KAFKA-15442:
--
Assignee: Abhijeet Kumar
> add document to introduce tiered storage feature and the u
showuon commented on PR #14352:
URL: https://github.com/apache/kafka/pull/14352#issuecomment-1709782685
@kamalcph @satishd , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-15442:
---
Labels: KIP-405 (was: )
> add document to introduce tiered storage feature and the usage
>
showuon commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318319429
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegment
showuon commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318317947
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegment
showuon commented on code in PR #14352:
URL: https://github.com/apache/kafka/pull/14352#discussion_r1318317138
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -121,14 +121,17 @@ InputStream fetchLogSegment(RemoteLogSegment
showuon opened a new pull request, #14352:
URL: https://github.com/apache/kafka/pull/14352
Update the javadoc in `RemoteStorageManager#fetchIndex` to guide the
providers how to implement it.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementati
yashmayya commented on code in PR #14304:
URL: https://github.com/apache/kafka/pull/14304#discussion_r1318291411
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1090,6 +1090,23 @@ public interface UncheckedCloseable extends
AutoCloseable {
voi
Luke Chen created KAFKA-15442:
-
Summary: add document to introduce tiered storage feature and the
usage
Key: KAFKA-15442
URL: https://issues.apache.org/jira/browse/KAFKA-15442
Project: Kafka
Iss
[
https://issues.apache.org/jira/browse/KAFKA-15440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15440:
-
Fix Version/s: (was: 3.6.0)
> Update minor dependencies in preparation for 3.6.0
> -
[
https://issues.apache.org/jira/browse/KAFKA-15440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762616#comment-17762616
]
Divij Vaidya commented on KAFKA-15440:
--
ok, sounds good.
> Update minor dependenci
ashwinpankaj commented on code in PR #14279:
URL: https://github.com/apache/kafka/pull/14279#discussion_r1318186912
##
connect/file/src/test/java/org/apache/kafka/connect/file/integration/FileStreamSinkConnectorIntegrationTest.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/KAFKA-15440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762588#comment-17762588
]
Satish Duggana commented on KAFKA-15440:
Thanks [~divijvaidya] for filing the JI
101 - 166 of 166 matches
Mail list logo